From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 03 23:17:22 2019 Received: (at submit) by debbugs.gnu.org; 4 Sep 2019 03:17:22 +0000 Received: from localhost ([127.0.0.1]:60735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i5LnO-0003oI-8u for submit@debbugs.gnu.org; Tue, 03 Sep 2019 23:17:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:33351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i5LnL-0003oA-Op for submit@debbugs.gnu.org; Tue, 03 Sep 2019 23:17:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48046) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5LnK-0000LM-EY for bug-guix@gnu.org; Tue, 03 Sep 2019 23:17:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, SPOOFED_FREEMAIL autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5LnJ-0001Q6-C4 for bug-guix@gnu.org; Tue, 03 Sep 2019 23:17:18 -0400 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]:38966) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i5LnJ-0001Pm-4T for bug-guix@gnu.org; Tue, 03 Sep 2019 23:17:17 -0400 Received: by mail-pg1-x534.google.com with SMTP id u17so10388684pgi.6 for ; Tue, 03 Sep 2019 20:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=8d+iQzVjdBZ5jVwJSYRMREGX4RlVjyq89U/f/mKPlSI=; b=B0csNU7xgjjFv5MhBX7koK/5+1OZju8lafD3TQaRWa/LYWR4mPG031Bsfy4Pw9lf1V HoulThLH7ILrrqYrb13cZDFnUGABrzlsgQhGFiQdL3iaHhi6mAmeyEXHDEsJmQgwVO5H NBQ9jhn1HxJSgpIszm3SD5WoX32hfUuZYO8DmfiiFdKIjflhLgQv0OYDBw28nNfY5vXt AoJeNDMswmsTjW/dcDf+xI/aAuiq8Q+6a8WEso6ah8xTf4fzBRNYZo4fPm7siCp10gJv FFCupnCzfxvS/i40TE1bY4pVfuQxMmfmSWtpz8Ah/YUNABU6dVHXd/EELHWmwl+1ggN6 6afg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=8d+iQzVjdBZ5jVwJSYRMREGX4RlVjyq89U/f/mKPlSI=; b=ZrLNB4VhP2wtyB+xRyW3f1ILHOLe1RYVNvWR9DrZ5Q//WAusnq9hIOYvKcrTDTg//+ IA5yDtxPBGGLm2qCTzDXM5GCwGJl2lB1OhiwnZn3HisOwL6+w5MECW/z+FMNMeKDH8Z4 1JWlSexL9UVM5rER9jYSzS/aDYfzfxnRBt9qvKCEhx9UyslBPavgBGL9dGZtRs7YXxdx sBQFJkeUUrfaXhJBX1W8l45qkvmBQw702BLw8HW0Zj9R7BSuQR0GVDGCcseFjAwIY4Dg +qfI/zxo5Vx/JUbgZ5Ii5azDUboAylXZlt7jWFIRwx8nE56Uk3RhHop52Duv3XbPqLWc yJYA== X-Gm-Message-State: APjAAAVTXGsX/HNgIkzKwj7lFp2N2u/i29l8SnePe2ZsWr2ClST/M/50 yJem1x5mT2b8GpONZlINsrpVZ783 X-Google-Smtp-Source: APXvYqyFoxV82kCGgy4H3k7dlZ2d56iVmHcvm0GFf1hbwu4j6Zge7saUeEFzjsVs07Jk4GVPR36TpQ== X-Received: by 2002:aa7:9117:: with SMTP id 23mr20696649pfh.94.1567567034836; Tue, 03 Sep 2019 20:17:14 -0700 (PDT) Received: from x200 ([240f:c7:38e9:1:314b:485c:9ba4:72c6]) by smtp.gmail.com with ESMTPSA id y14sm15934511pge.7.2019.09.03.20.17.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 20:17:13 -0700 (PDT) From: Maxim Cournoyer To: bug-guix Subject: Imported packages' indentation doesn't respect Guix conventions Date: Wed, 04 Sep 2019 12:17:10 +0900 Message-ID: <87woeoycll.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::534 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The package definitions imported by Guix importers do not respect Guix conventions regarding indentation. Consider: guix pypi import transaction (package (name "python-transaction") (version "2.4.0") (source (origin (method url-fetch) (uri (pypi-uri "transaction" version)) (sha256 (base32 "17wz1y524ca07vr03yddy8dv0gbscs06dbdywmllxv5rc725jq3j")))) (build-system python-build-system) (propagated-inputs `(("python-zope.interface" ,python-zope.interface))) (native-inputs `(("python-coverage" ,python-coverage) ("python-mock" ,python-mock) ("python-nose" ,python-nose))) (home-page "https://github.com/zopefoundation/transaction") (synopsis "Transaction management for Python") (description "Transaction management for Python") (license #f)) Re-identing this in Emacs with the Guix .dir-local.el indentation customizations yields: (define-public python-transaction (package (name "python-transaction") (version "2.4.0") (source (origin (method url-fetch) (uri (pypi-uri "transaction" version)) (sha256 (base32 "17wz1y524ca07vr03yddy8dv0gbscs06dbdywmllxv5rc725jq3j")))) (build-system python-build-system) (propagated-inputs `(("python-zope.interface" ,python-zope.interface))) (native-inputs `(("python-coverage" ,python-coverage) ("python-mock" ,python-mock) ("python-nose" ,python-nose))) (home-page "https://github.com/zopefoundation/transaction") (synopsis "Transaction management for Python") (description "Transaction management for Python") (license #f))) Multiple record fields indentation offset is set to 1 instead of the regular 2. This is produced by the function pretty-print from ice-9. Maybe there's a way to configure the indentation rules used by pretty-print? From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 09:23:36 2023 Received: (at 37300-done) by debbugs.gnu.org; 20 Jul 2023 13:23:36 +0000 Received: from localhost ([127.0.0.1]:58018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMTd2-0001a7-Fy for submit@debbugs.gnu.org; Thu, 20 Jul 2023 09:23:36 -0400 Received: from mail-qv1-xf2f.google.com ([2607:f8b0:4864:20::f2f]:61873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMTd1-0001Zq-EO for 37300-done@debbugs.gnu.org; Thu, 20 Jul 2023 09:23:35 -0400 Received: by mail-qv1-xf2f.google.com with SMTP id 6a1803df08f44-635eb5b0320so5939766d6.3 for <37300-done@debbugs.gnu.org>; Thu, 20 Jul 2023 06:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689859410; x=1690464210; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=iCoxhWABu+eSBOE87woXY8+67Z8C4ZTRiStYvPWovwI=; b=FZy3yp7RGBeIkuvgT7sQMWuxW8vCOcvd1MMdQI8g/oROFFsJdXmI2yshSS4ozoSA2M nFbLnK4n01i898qoxOml9smwG1FODs2yrKC+B7ko0AAei1wm48DEOojC++hPe1U+h18l KgWhDu8Rb645I41sos7Se4Q20NJQKGcXHsa8W2VY9nbuj8XUAbOse1HT4sjSe37c6zrG HnEq3IP9Jr3jsbIy1wf29jwCPb/4qGcUsfiW+m6OIyECi5M+c8uRerNhCaWN3HK1GKc3 jQf3+Ztym5R4wO9NpZfeZ0ZPiBz31bpPT6YfJwLWW+1XA4c/Pb/XE5upvTYOWRTMG0pA MXzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689859410; x=1690464210; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iCoxhWABu+eSBOE87woXY8+67Z8C4ZTRiStYvPWovwI=; b=UPjJaIPmO5nwN2oeapoMPlGBe4t1u4wKwf1oDwPJbYBFr/sUGB8KkvMGejcdq0w9E1 qh2z6lua4GJ7X9SxVki8pMbjOp22P+EEI5JlH4k+Do9AwOhRhBqEz6NaIZNx3LVeay2A 7s70r6uEbu7oV4XVapv/6CizNEu76SusjHYyIWJFAj9oSaAt9GXe200AbmxEweTa1Z2c McMZkn+rgn99J5L/wFNx2OJx3ufrs9Byujqw8IMk+YZv8zOFoUZIqb65qeANPvwokD8v 1QG8HvAbJi1alkNHNxRJS53xFF36XoAontqXWrEFgKyKVBIlXuYfiV9JP/IohZJx4W8o NHSA== X-Gm-Message-State: ABy/qLaQaqT83gEBEJOWF+52BCrp6UFxjbmtQM3sqexl8kD/+gh98j0D ioDoufk/8zPfDiqdw+eM7hUixxla0oM= X-Google-Smtp-Source: APBJJlEayqpnRzaxtH7G5l8+xYsylVTb4BILi4/IUGHSe7IjWOoUCUQSg4Bh2zqCA3t+rhasS0wPvQ== X-Received: by 2002:ad4:4301:0:b0:635:df49:719c with SMTP id c1-20020ad44301000000b00635df49719cmr20228602qvs.22.1689859409726; Thu, 20 Jul 2023 06:23:29 -0700 (PDT) Received: from hurd (dsl-159-145.b2b2c.ca. [66.158.159.145]) by smtp.gmail.com with ESMTPSA id j16-20020a0ce010000000b0062ff179a538sm323200qvk.123.2023.07.20.06.23.28 for <37300-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jul 2023 06:23:29 -0700 (PDT) From: Maxim Cournoyer To: 37300-done@debbugs.gnu.org Subject: Re: bug#37300: Imported packages' indentation doesn't respect Guix conventions References: <87woeoycll.fsf@gmail.com> Date: Thu, 20 Jul 2023 09:23:28 -0400 In-Reply-To: <87woeoycll.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 04 Sep 2019 12:17:10 +0900") Message-ID: <87pm4mlnsf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 37300-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Maxim Cournoyer writes: > The package definitions imported by Guix importers do not respect Guix > conventions regarding indentation. > > Consider: > > guix pypi import transaction > > (package > (name "python-transaction") > (version "2.4.0") > (source > (origin > (method url-fetch) > (uri (pypi-uri "transaction" version)) > (sha256 > (base32 > "17wz1y524ca07vr03yddy8dv0gbscs06dbdywmllxv5rc725jq3j")))) > (build-system python-build-system) > (propagated-inputs > `(("python-zope.interface" ,python-zope.interface))) > (native-inputs > `(("python-coverage" ,python-coverage) > ("python-mock" ,python-mock) > ("python-nose" ,python-nose))) > (home-page > "https://github.com/zopefoundation/transaction") > (synopsis "Transaction management for Python") > (description "Transaction management for Python") > (license #f)) > > Re-identing this in Emacs with the Guix .dir-local.el indentation > customizations yields: > > (define-public python-transaction > (package > (name "python-transaction") > (version "2.4.0") > (source > (origin > (method url-fetch) > (uri (pypi-uri "transaction" version)) > (sha256 > (base32 > "17wz1y524ca07vr03yddy8dv0gbscs06dbdywmllxv5rc725jq3j")))) > (build-system python-build-system) > (propagated-inputs > `(("python-zope.interface" ,python-zope.interface))) > (native-inputs > `(("python-coverage" ,python-coverage) > ("python-mock" ,python-mock) > ("python-nose" ,python-nose))) > (home-page > "https://github.com/zopefoundation/transaction") > (synopsis "Transaction management for Python") > (description "Transaction management for Python") > (license #f))) That's been taken care of by applying 'guix style' to the importer-generated definitions; it now looks like: (define-public python-transaction (package (name "python-transaction") (version "3.1.0") (source (origin (method url-fetch) (uri (pypi-uri "transaction" version)) (sha256 (base32 "191gj6pzvgw0726dsywy8pbj7shxnkc6pyrpnbiw9ryvjbmb3l35")))) (build-system pyproject-build-system) (propagated-inputs (list python-zope.interface)) (native-inputs (list python-coverage python-mock python-nose)) (home-page "https://github.com/zopefoundation/transaction") (synopsis "Transaction management for Python") (description "Transaction management for Python") (license #f))) which is correct. Closing. -- Thanks, Maxim From unknown Thu Aug 14 22:21:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 18 Aug 2023 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator