GNU bug report logs - #37284
[PATCH] added gnu/packages/fmit.scm (Free Musical Instrument Tuner)

Previous Next

Package: guix-patches;

Reported by: raingloom <raingloom <at> protonmail.com>

Date: Mon, 2 Sep 2019 16:24:01 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

Full log


Message #25 received at 37284-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: raingloom <raingloom <at> protonmail.com>
Cc: 37284-done <at> debbugs.gnu.org
Subject: Re: [bug#37284] [PATCH] added gnu/packages/fmit.scm (Free Musical
 Instrument Tuner)
Date: Sun, 08 Sep 2019 11:17:36 +0200
Hello,

raingloom <raingloom <at> protonmail.com> writes:

> Updated again. Is sending it as an attachment fine?

Well, oddly, it seems that your update addressed only one of my
suggestions. So, I applied your patch with the following changes:

- fixed the commit message,
- added a copyright line,
- added the (file-name ...) line,
- split the (sha256 ...) line,
- re-ordered the inputs,
- changed case in synopsis,
- fixed typographic mistakes in the description and the licenses
  comments.

Let me know if something is wrong, in particular the copyright line,
which I add to guess.

Thank you for your contribution!

Regards,

-- 
Nicolas Goaziou




This bug report was last modified 5 years and 256 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.