From unknown Wed Jun 18 23:13:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#37284 <37284@debbugs.gnu.org> To: bug#37284 <37284@debbugs.gnu.org> Subject: Status: [PATCH] added gnu/packages/fmit.scm (Free Musical Instrument Tuner) Reply-To: bug#37284 <37284@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:13:21 +0000 retitle 37284 [PATCH] added gnu/packages/fmit.scm (Free Musical Instrument = Tuner) reassign 37284 guix-patches submitter 37284 raingloom severity 37284 normal tag 37284 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 02 12:23:26 2019 Received: (at submit) by debbugs.gnu.org; 2 Sep 2019 16:23:27 +0000 Received: from localhost ([127.0.0.1]:58902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4p70-0001cN-FS for submit@debbugs.gnu.org; Mon, 02 Sep 2019 12:23:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:54287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4p0N-0001Qw-KB for submit@debbugs.gnu.org; Mon, 02 Sep 2019 12:16:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49016) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4p0L-0002W5-Qk for guix-patches@gnu.org; Mon, 02 Sep 2019 12:16:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i4p0K-0002ua-8W for guix-patches@gnu.org; Mon, 02 Sep 2019 12:16:33 -0400 Received: from mail-40133.protonmail.ch ([185.70.40.133]:58074) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i4p0J-0002qm-Mc for guix-patches@gnu.org; Mon, 02 Sep 2019 12:16:32 -0400 Date: Mon, 02 Sep 2019 16:16:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1567440984; bh=YisdcVgCitlxV5yHrLm5y2me++/+dibOj/0kos7O3J4=; h=Date:To:From:Reply-To:Subject:Feedback-ID:From; b=vFMF2Bkew9EMJAPiNZrRdTDDO1odj29vfF7+LFNlFIOGUR1NK0Sbs+pNBoOo7iptF iU75kirlGurZL7x0NOfL0j7Tg71fuTu1mUUK71Ut+hox0wAPe+Jp7MKCqhYT2wYeiq oKULU3TpgdEz9UXxXWWedHJ8jNPGlfmDpGX2EWgs= To: "guix-patches@gnu.org" From: raingloom Subject: [PATCH] added gnu/packages/fmit.scm (Free Musical Instrument Tuner) Message-ID: Feedback-ID: JWBSa_o7n7kLWsdufRbO3OsPMprCgbsbX2_Lsfl4hHyN7ygZaS2d20pmOMgj-PiYsBCsSZjZFG7H0-B1fw10NQ==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 185.70.40.133 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 02 Sep 2019 12:23:25 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raingloom Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/fmit.scm: created --- gnu/packages/fmit.scm | 64 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 64 insertions(+) create mode 100644 gnu/packages/fmit.scm diff --git a/gnu/packages/fmit.scm b/gnu/packages/fmit.scm new file mode 100644 index 0000000000..2db5b1ca25 --- /dev/null +++ b/gnu/packages/fmit.scm @@ -0,0 +1,64 @@ +(define-module (gnu packages fmit) + #:use-module (guix packages) + #:use-module (guix git-download) + #:use-module (guix build-system gnu) + #:use-module (guix licenses) + #:use-module (gnu packages qt) + #:use-module (gnu packages gnome) + #:use-module (gnu packages algebra) + #:use-module (gnu packages audio) + #:use-module (gnu packages glib) + #:use-module (gnu packages linux) + #:use-module (gnu packages gettext)) + +(define-public fmit + (package + (name "fmit") + (version "1.2.6") + (source (origin +=09 (method git-fetch) +=09 (uri (git-reference +=09=09 (url "https://github.com/gillesdegottex/fmit/") +=09=09 (commit (string-append "v" version)))) +=09 (sha256 (base32 "03nzkig5mw2rqwhwmg0qvc5cnk9bwh2wp13jh0mdrr935w05= 87mz")))) + (build-system gnu-build-system) + (arguments + '(#:make-flags (let ((out (assoc-ref %outputs "out"))) (list (string-= append "PREFIX=3D" out) (string-append "PREFIXSHORTCUT=3D" out))) + #:phases + (modify-phases %standard-phases +=09 (delete 'configure) +=09 (add-before 'build 'qmake +=09 (lambda _ +=09 (let ((out (assoc-ref %outputs "out"))) (invoke "qmake" "fmit.pro"= (string-append "PREFIX=3D" out) (string-append "PREFIXSHORTCUT=3D" out) "C= ONFIG+=3Dacs_qt acs_alsa acs_jack acs_portaudio")))) + (add-after 'install 'wrap-executable + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (wrap-program (string-append out "/bin/fmit") + `("QT_PLUGIN_PATH" ":" prefix + ,(map (lambda (label) + (string-append (assoc-ref inputs label) + "/lib/qt5/plugins")) + '("qtbase" "qtmultimedia" "qtsvg"))) + `("QML2_IMPORT_PATH" ":" prefix + ,(map (lambda (label) + (string-append (assoc-ref inputs label) + "/lib/qt5/qml")) + '("qtmultimedia")))) + #t)))))) + (inputs + `(("fftw" ,fftw) + ("portaudio" ,portaudio) + ("qtmultimedia" ,qtmultimedia) + ("qtsvg" ,qtsvg) + ("alsa-lib" ,alsa-lib) + ("jack" ,jack-1) + ("qtbase" ,qtbase))) + (native-inputs + `(("itstool" ,itstool) + ("qttools" ,qttools) + ("hicolor-icon-theme" ,hicolor-icon-theme) + ("gettext" ,gnu-gettext))) + (synopsis "Free Musical Instrument Tuner") + (description "FMIT is a graphical utility for tuning musical instrumen= ts, with error and volume history, and advanced features") + (home-page "http://gillesdegottex.github.io/fmit/") + (license gpl3+))) -- 2.23.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 02 13:29:46 2019 Received: (at submit) by debbugs.gnu.org; 2 Sep 2019 17:29:46 +0000 Received: from localhost ([127.0.0.1]:58927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4q9C-0003dW-AX for submit@debbugs.gnu.org; Mon, 02 Sep 2019 13:29:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:51745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4q99-0003dL-Ok for submit@debbugs.gnu.org; Mon, 02 Sep 2019 13:29:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60022) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4q98-0003Lk-CX for guix-patches@gnu.org; Mon, 02 Sep 2019 13:29:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i4q97-0006zg-04 for guix-patches@gnu.org; Mon, 02 Sep 2019 13:29:42 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:47299) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i4q96-0006vu-Qp for guix-patches@gnu.org; Mon, 02 Sep 2019 13:29:40 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 18E6C24000D; Mon, 2 Sep 2019 17:29:35 +0000 (UTC) From: Nicolas Goaziou To: raingloom via Guix-patches via Subject: Re: [bug#37284] [PATCH] added gnu/packages/fmit.scm (Free Musical Instrument Tuner) References: Date: Mon, 02 Sep 2019 19:29:34 +0200 In-Reply-To: (raingloom via Guix-patches via's message of "Mon, 02 Sep 2019 16:16:19 +0000") Message-ID: <87ef0yr4ht.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.70.183.193 X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 37284@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, raingloom via Guix-patches via writes: > * gnu/packages/fmit.scm: created Thank you! > --- > gnu/packages/fmit.scm | 64 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 gnu/packages/fmit.scm > > diff --git a/gnu/packages/fmit.scm b/gnu/packages/fmit.scm Is there any reason to create a new module instead of putting the package into "music.scm"? > + (arguments > + '(#:make-flags (let ((out (assoc-ref %outputs "out"))) (list (string-append "PREFIX=" out) (string-append "PREFIXSHORTCUT=" out))) This line is too long. Moreover, I think "PREFIX=" is not necessary, as Guix adds it automatically. I'm not sure about "PREFIXSHORTCUT=", tho. It seems PREFIX and PREFIXSHORTCUT are used in qmake, not in make, so it may be possible to remove the whole #:make-flags altogether. WDYT? > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) Indentation looks wrong. Could you take care about it? > + (add-before 'build 'qmake > + (lambda _ > + (let ((out (assoc-ref %outputs "out"))) (invoke "qmake" "fmit.pro" > (string-append "PREFIX=" out) (string-append "PREFIXSHORTCUT=" out) > "CONFIG+=acs_qt acs_alsa acs_jack acs_portaudio")))) The line is too long. I suggest: (let ((out (assoc-ref %outputs "out"))) (invoke "qmake" "fmit.pro" (string-append "PREFIX=" out) (string-append "PREFIXSHORTCUT=" out) "CONFIG+=acs_qt acs_alsa acs_jack acs_portaudio")) > + (inputs > + `(("fftw" ,fftw) > + ("portaudio" ,portaudio) > + ("qtmultimedia" ,qtmultimedia) > + ("qtsvg" ,qtsvg) > + ("alsa-lib" ,alsa-lib) > + ("jack" ,jack-1) > + ("qtbase" ,qtbase))) > + (native-inputs > + `(("itstool" ,itstool) > + ("qttools" ,qttools) > + ("hicolor-icon-theme" ,hicolor-icon-theme) > + ("gettext" ,gnu-gettext))) Could you re-order (native-)inputs alphabetically? > + (synopsis "Free Musical Instrument Tuner") I understand Free is the F from FMIT, but, as a synopsis, I don't think it brings much value. Maybe "Musical instrument tuner" is enough? > + (description "FMIT is a graphical utility for tuning musical instruments, with error and volume history, and advanced features") > + (home-page "http://gillesdegottex.github.io/fmit/") Prefer https:// here. > + (license gpl3+))) If you move it to music.scm, I believe it should be prefixed with license: Also, the license seems wrong, it should be (list license:gpl2+ license:lgpl2.1) with a comment explaining that most of the code is under GPL2+, but some abstract or helper classes are under LGPL2.1. Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 02 21:53:44 2019 Received: (at 37284) by debbugs.gnu.org; 3 Sep 2019 01:53:44 +0000 Received: from localhost ([127.0.0.1]:59121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4y0t-0007yN-EU for submit@debbugs.gnu.org; Mon, 02 Sep 2019 21:53:44 -0400 Received: from mail-40136.protonmail.ch ([185.70.40.136]:53414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i4xOd-0006uK-0l for 37284@debbugs.gnu.org; Mon, 02 Sep 2019 21:14:12 -0400 Date: Tue, 03 Sep 2019 01:13:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1567473243; bh=IhRlj8qBjM1SoOLLGA2up4+XOojnX53gCzkFtbhT9w0=; h=Date:To:From:Cc:Reply-To:Subject:Feedback-ID:From; b=NaEgnJcY9pCULkAf1z5EThc7UZcZjwibkY7VEe1ly5/uTB+sUmjLHS/7ajBicvyeA kRSZ721/TCM+90XNSIOa90Go+heJ4ZUYcomN6107Trj9FR1ZZ/E0rGNOKVMhz8fdod PCIrADd34fz4vxUYibyjhLpGqu3ISK59GXpJGJHw= To: "mail@nicolasgoaziou.fr" From: raingloom Subject: Re: [bug#37284] [PATCH] added gnu/packages/fmit.scm (Free Musical Instrument Tuner) Message-ID: Feedback-ID: JWBSa_o7n7kLWsdufRbO3OsPMprCgbsbX2_Lsfl4hHyN7ygZaS2d20pmOMgj-PiYsBCsSZjZFG7H0-B1fw10NQ==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37284 X-Mailman-Approved-At: Mon, 02 Sep 2019 21:53:41 -0400 Cc: "37284@debbugs.gnu.org" <37284@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raingloom Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thanks for the suggestions! How about this attempt? Also, is this how i reply to an issue? I didn't see your email in my inbox = (yet?), only on the web interface. Do I also have to subscribe to the guix-= patches mailing list? --- gnu/packages/music.scm | 59 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index d4aaecc1e2..a9770f4f16 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -4483,3 +4483,62 @@ discard bad quality ones. controller.") (home-page "https://github.com/charlesfleche/lpd8editor") (license license:expat))) + +(define-public fmit + (package + (name "fmit") + (version "1.2.6") + (source (origin +=09 (method git-fetch) +=09 (uri (git-reference +=09=09 (url "https://github.com/gillesdegottex/fmit/") +=09=09 (commit (string-append "v" version)))) +=09 (sha256 (base32 "03nzkig5mw2rqwhwmg0qvc5cnk9bwh2wp13jh0mdrr935w05= 87mz")))) + (build-system gnu-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases +=09 (delete 'configure) +=09 (add-before 'build 'qmake +=09 (lambda _ +=09 (let ((out (assoc-ref %outputs "out"))) + (invoke "qmake" + "fmit.pro" + (string-append "PREFIX=3D" out) + (string-append "PREFIXSHORTCUT=3D" out) + "CONFIG+=3Dacs_qt acs_alsa acs_jack acs_portaudio")= ))) + (add-after 'install 'wrap-executable + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (wrap-program (string-append out "/bin/fmit") + `("QT_PLUGIN_PATH" ":" prefix + ,(map (lambda (label) + (string-append (assoc-ref inputs label) + "/lib/qt5/plugins")) + '("qtbase" "qtmultimedia" "qtsvg"))) + `("QML2_IMPORT_PATH" ":" prefix + ,(map (lambda (label) + (string-append (assoc-ref inputs label) + "/lib/qt5/qml")) + '("qtmultimedia")))) + #t)))))) + (inputs + `(("fftw" ,fftw) + ("portaudio" ,portaudio) + ("qtmultimedia" ,qtmultimedia) + ("qtsvg" ,qtsvg) + ("alsa-lib" ,alsa-lib) + ("jack" ,jack-1) + ("qtbase" ,qtbase))) + (native-inputs + `(("gettext" ,gnu-gettext) + ("hicolor-icon-theme" ,hicolor-icon-theme) + ("itstool" ,itstool) + ("qttools" ,qttools))) + (synopsis "Musical Instrument Tuner") + (description + "FMIT is a graphical utility for tuning musical instruments, +with error and volume history, and advanced features") + (home-page "https://gillesdegottex.github.io/fmit/") + ;; most of the code is under GPL2+, but some abstract or helper classe= s are under LGPL2.1 + (license (list license:gpl2+ license:lgpl2.1)))) -- 2.23.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 04 12:01:58 2019 Received: (at 37284) by debbugs.gnu.org; 4 Sep 2019 16:01:59 +0000 Received: from localhost ([127.0.0.1]:34197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i5XjK-000640-IX for submit@debbugs.gnu.org; Wed, 04 Sep 2019 12:01:58 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:33909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i5XjH-00063o-Mq for 37284@debbugs.gnu.org; Wed, 04 Sep 2019 12:01:57 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 1E4F4200004; Wed, 4 Sep 2019 16:01:51 +0000 (UTC) From: Nicolas Goaziou To: raingloom Subject: Re: [bug#37284] [PATCH] added gnu/packages/fmit.scm (Free Musical Instrument Tuner) References: Date: Wed, 04 Sep 2019 18:01:50 +0200 In-Reply-To: (raingloom@protonmail.com's message of "Tue, 03 Sep 2019 01:13:57 +0000") Message-ID: <87ef0woxsh.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37284 Cc: "37284@debbugs.gnu.org" <37284@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, raingloom writes: > Thanks for the suggestions! > How about this attempt? Better, indeed. I have a couple more comments, if you don't mind. I think I will be able to commit it at next iteration. > Also, is this how i reply to an issue? Like you did. > Do I also have to subscribe to the guix-patches mailing list? I don't think so. > --- > gnu/packages/music.scm | 59 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > > diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm > index d4aaecc1e2..a9770f4f16 100644 > --- a/gnu/packages/music.scm > +++ b/gnu/packages/music.scm > @@ -4483,3 +4483,62 @@ discard bad quality ones. > controller.") > (home-page "https://github.com/charlesfleche/lpd8editor") > (license license:expat))) Could you add a proper commit message to the patch ? It would look like: * gnu/packages/music.scm (fmit): New variable. Also, could you add yourself to the copyright line at the top of the "music.scm" file? > +(define-public fmit > + (package > + (name "fmit") > + (version "1.2.6") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/gillesdegottex/fmit/") > + (commit (string-append "v" version)))) You need to add the following line here: (file-name (git-file-name name version)) > + (sha256 (base32 "03nzkig5mw2rqwhwmg0qvc5cnk9bwh2wp13jh0mdrr935w0587mz")))) This line is too long, you ought to use (sha256 (base32 "...")) > + (inputs > + `(("fftw" ,fftw) > + ("portaudio" ,portaudio) > + ("qtmultimedia" ,qtmultimedia) > + ("qtsvg" ,qtsvg) > + ("alsa-lib" ,alsa-lib) > + ("jack" ,jack-1) > + ("qtbase" ,qtbase))) > + (native-inputs > + `(("gettext" ,gnu-gettext) > + ("hicolor-icon-theme" ,hicolor-icon-theme) > + ("itstool" ,itstool) > + ("qttools" ,qttools))) You forgot to re-order inputs alphabetically. > + (synopsis "Musical Instrument Tuner") I don't think title case is warranted here. "Musical instrument tuner" is enough, IMO. > + (description > + "FMIT is a graphical utility for tuning musical instruments, > +with error and volume history, and advanced features") Please move the string so that it starts on the same line as "(description ". Also, it is missing a final dot. > + (home-page "https://gillesdegottex.github.io/fmit/") > + ;; most of the code is under GPL2+, but some abstract or helper > classes are under LGPL2.1 ;; Most of ... under LGPL2.1. i.e., missing capital and the final full stop. Could you send an updated patch? Thank you! Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 07 18:13:10 2019 Received: (at 37284) by debbugs.gnu.org; 7 Sep 2019 22:13:10 +0000 Received: from localhost ([127.0.0.1]:38217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6ixC-0007Uc-2X for submit@debbugs.gnu.org; Sat, 07 Sep 2019 18:13:10 -0400 Received: from mail-40136.protonmail.ch ([185.70.40.136]:56563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6ix9-0007U5-DX for 37284@debbugs.gnu.org; Sat, 07 Sep 2019 18:13:08 -0400 Date: Sat, 07 Sep 2019 22:12:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1567894379; bh=Vd1K29vGuABiIke1nXO/ygNjChoVurp8EoxY5zqSUAc=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References: Feedback-ID:From; b=FJPfm1H+o5IBlSYsH0acv+mFHQS0hYpZzrjKAxrzmfwOz0fgsnzcCrSekLWG8tjf1 CkEieP9CXDbkYqBRpwEz279JDJJTJ8X5Zf1val5gMEwE2rt0ZX+yCQ+DZPZOihWb1O Jn41iQdjNLClGSpexzfRFt4gAviJhqMYe1VasbKY= To: Nicolas Goaziou From: raingloom Subject: Re: [bug#37284] [PATCH] added gnu/packages/fmit.scm (Free Musical Instrument Tuner) Message-ID: <6N2dsbDEMS8qfeyHPubfhcX_yqjbdQPCIY4d8TY_4eMJCBfWNMxNzOjiwR-6QhOyPw4s9s1uCGUNppmnaSuEbtR2HpQ3WX49EN1u7iVK2Ok=@protonmail.com> In-Reply-To: <87ef0woxsh.fsf@nicolasgoaziou.fr> References: <87ef0woxsh.fsf@nicolasgoaziou.fr> Feedback-ID: JWBSa_o7n7kLWsdufRbO3OsPMprCgbsbX2_Lsfl4hHyN7ygZaS2d20pmOMgj-PiYsBCsSZjZFG7H0-B1fw10NQ==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_76f503eb3c96f583d922b0ca08329f45" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37284 Cc: "37284\\@debbugs.gnu.org" <37284@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raingloom Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --b1_76f503eb3c96f583d922b0ca08329f45 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hey! Updated again. Is sending it as an attachment fine? =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Wednesday, September 4, 2019 4:01 PM, Nicolas Goaziou wrote: > Hello, > > raingloom raingloom@protonmail.com writes: > > > Thanks for the suggestions! > > How about this attempt? > > Better, indeed. I have a couple more comments, if you don't mind. > I think I will be able to commit it at next iteration. > > > Also, is this how i reply to an issue? > > Like you did. > > > Do I also have to subscribe to the guix-patches mailing list? > > I don't think so. > > > gnu/packages/music.scm | 59 ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 59 insertions(+) > > diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm > > index d4aaecc1e2..a9770f4f16 100644 > > --- a/gnu/packages/music.scm > > +++ b/gnu/packages/music.scm > > @@ -4483,3 +4483,62 @@ discard bad quality ones. > > controller.") > > (home-page "https://github.com/charlesfleche/lpd8editor") > > (license license:expat))) > > Could you add a proper commit message to the patch ? It would look like: > > - gnu/packages/music.scm (fmit): New variable. > > Also, could you add yourself to the copyright line at the top of the > "music.scm" file? > > > > +(define-public fmit > > > > - (package > > - (name "fmit") > > - (version "1.2.6") > > - (source (origin > > - (method git-fetch) > > > > > > - (uri (git-reference > > > > > > - (url "https://github.com/gillesdegottex/fmit/") > > > > > > - (commit (string-append "v" version)))) > > > > > > You need to add the following line here: > > (file-name (git-file-name name version)) > > > - (sha256 (base32 "03nzkig5mw2rqwhwmg0qvc5cnk9bwh2wp13jh0mdrr93= 5w0587mz")))) > > > > > > This line is too long, you ought to use > > (sha256 > (base32 > "...")) > > > - (inputs > > - `(("fftw" ,fftw) > > > > > > - ("portaudio" ,portaudio) > > > > > > - ("qtmultimedia" ,qtmultimedia) > > > > > > - ("qtsvg" ,qtsvg) > > > > > > - ("alsa-lib" ,alsa-lib) > > > > > > - ("jack" ,jack-1) > > > > > > - ("qtbase" ,qtbase))) > > > > > > - (native-inputs > > - `(("gettext" ,gnu-gettext) > > > > > > - ("hicolor-icon-theme" ,hicolor-icon-theme) > > > > > > - ("itstool" ,itstool) > > > > > > - ("qttools" ,qttools))) > > > > > > You forgot to re-order inputs alphabetically. > > > - (synopsis "Musical Instrument Tuner") > > I don't think title case is warranted here. "Musical instrument tuner" > is enough, IMO. > > > - (description > > - "FMIT is a graphical utility for tuning musical instruments, > > > > > > > > +with error and volume history, and advanced features") > > Please move the string so that it starts on the same line as > "(description ". Also, it is missing a final dot. > > > - (home-page "https://gillesdegottex.github.io/fmit/") > > - ;; most of the code is under GPL2+, but some abstract or helper > > classes are under LGPL2.1 > > > > ;; Most of ... under LGPL2.1. > > i.e., missing capital and the final full stop. > > Could you send an updated patch? Thank you! > > Regards, > > -------------------------------------------------------------------------= -------------------------------------------------------------- > > Nicolas Goaziou --b1_76f503eb3c96f583d922b0ca08329f45 Content-Type: text/x-patch; name="0001-gnu-packages-music.scm-fmit-New-variable.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-packages-music.scm-fmit-New-variable.patch RnJvbSAzZGRjOWM2YjYyZjYxOTkzZjRjNDdjMDcxYTRjMjExOTk3MzY2ZWIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiByYWluZ2xvb20gPHJhaW5nbG9vbUBwcm90b25tYWlsLmNvbT4K RGF0ZTogTW9uLCAyIFNlcCAyMDE5IDE1OjQ0OjE1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gKiBn bnUvcGFja2FnZXMvbXVzaWMuc2NtIChmbWl0KTogTmV3IHZhcmlhYmxlLgoKLS0tCiBnbnUvcGFj a2FnZXMvbXVzaWMuc2NtIHwgNTkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNTkgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2du dS9wYWNrYWdlcy9tdXNpYy5zY20gYi9nbnUvcGFja2FnZXMvbXVzaWMuc2NtCmluZGV4IGQ0YWFl Y2MxZTIuLmE5NzcwZjRmMTYgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9tdXNpYy5zY20KKysr IGIvZ251L3BhY2thZ2VzL211c2ljLnNjbQpAQCAtNDQ4MywzICs0NDgzLDYyIEBAIGRpc2NhcmQg YmFkIHF1YWxpdHkgb25lcy4KIGNvbnRyb2xsZXIuIikKICAgICAoaG9tZS1wYWdlICJodHRwczov L2dpdGh1Yi5jb20vY2hhcmxlc2ZsZWNoZS9scGQ4ZWRpdG9yIikKICAgICAobGljZW5zZSBsaWNl bnNlOmV4cGF0KSkpCisKKyhkZWZpbmUtcHVibGljIGZtaXQKKyAgKHBhY2thZ2UKKyAgICAobmFt ZSAiZm1pdCIpCisgICAgKHZlcnNpb24gIjEuMi42IikKKyAgICAoc291cmNlIChvcmlnaW4KKwkg ICAgICAobWV0aG9kIGdpdC1mZXRjaCkKKwkgICAgICAodXJpIChnaXQtcmVmZXJlbmNlCisJCSAg ICAodXJsICJodHRwczovL2dpdGh1Yi5jb20vZ2lsbGVzZGVnb3R0ZXgvZm1pdC8iKQorCQkgICAg KGNvbW1pdCAoc3RyaW5nLWFwcGVuZCAidiIgdmVyc2lvbikpKSkKKwkgICAgICAoc2hhMjU2IChi YXNlMzIgIjAzbnpraWc1bXcycnF3aHdtZzBxdmM1Y25rOWJ3aDJ3cDEzamgwbWRycjkzNXcwNTg3 bXoiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1l bnRzCisgICAgICcoIzpwaGFzZXMKKyAgICAgICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhh c2VzCisJIChkZWxldGUgJ2NvbmZpZ3VyZSkKKwkgKGFkZC1iZWZvcmUgJ2J1aWxkICdxbWFrZQor CSAgIChsYW1iZGEgXworCSAgICAgKGxldCAoKG91dCAoYXNzb2MtcmVmICVvdXRwdXRzICJvdXQi KSkpCisgICAgICAgICAgICAgICAoaW52b2tlICJxbWFrZSIKKyAgICAgICAgICAgICAgICAgICAg ICAgImZtaXQucHJvIgorICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCAiUFJF RklYPSIgb3V0KQorICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCAiUFJFRklY U0hPUlRDVVQ9IiBvdXQpCisgICAgICAgICAgICAgICAgICAgICAgICJDT05GSUcrPWFjc19xdCBh Y3NfYWxzYSBhY3NfamFjayBhY3NfcG9ydGF1ZGlvIikpKSkKKyAgICAgICAgIChhZGQtYWZ0ZXIg J2luc3RhbGwgJ3dyYXAtZXhlY3V0YWJsZQorICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgaW5w dXRzIG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAgICAgICAgIChsZXQgKChvdXQg KGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSkpCisgICAgICAgICAgICAgICAod3JhcC1wcm9ncmFt IChzdHJpbmctYXBwZW5kIG91dCAiL2Jpbi9mbWl0IikKKyAgICAgICAgICAgICAgICAgYCgiUVRf UExVR0lOX1BBVEgiICI6IiBwcmVmaXgKKyAgICAgICAgICAgICAgICAgICAsKG1hcCAobGFtYmRh IChsYWJlbCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmctYXBwZW5kIChhc3Nv Yy1yZWYgaW5wdXRzIGxhYmVsKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIi9saWIvcXQ1L3BsdWdpbnMiKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAnKCJx dGJhc2UiICJxdG11bHRpbWVkaWEiICJxdHN2ZyIpKSkKKyAgICAgICAgICAgICAgICAgYCgiUU1M Ml9JTVBPUlRfUEFUSCIgIjoiIHByZWZpeAorICAgICAgICAgICAgICAgICAgICwobWFwIChsYW1i ZGEgKGxhYmVsKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgKGFz c29jLXJlZiBpbnB1dHMgbGFiZWwpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAiL2xpYi9xdDUvcW1sIikpCisgICAgICAgICAgICAgICAgICAgICAgICAgJygicXRt dWx0aW1lZGlhIikpKSkKKyAgICAgICAgICAgICAgICN0KSkpKSkpCisgICAgKGlucHV0cworICAg ICBgKCgiZmZ0dyIgLGZmdHcpCisgICAgICAgKCJwb3J0YXVkaW8iICxwb3J0YXVkaW8pCisgICAg ICAgKCJxdG11bHRpbWVkaWEiICxxdG11bHRpbWVkaWEpCisgICAgICAgKCJxdHN2ZyIgLHF0c3Zn KQorICAgICAgICgiYWxzYS1saWIiICxhbHNhLWxpYikKKyAgICAgICAoImphY2siICxqYWNrLTEp CisgICAgICAgKCJxdGJhc2UiICxxdGJhc2UpKSkKKyAgICAobmF0aXZlLWlucHV0cworICAgICBg KCgiZ2V0dGV4dCIgLGdudS1nZXR0ZXh0KQorICAgICAgICgiaGljb2xvci1pY29uLXRoZW1lIiAs aGljb2xvci1pY29uLXRoZW1lKQorICAgICAgICgiaXRzdG9vbCIgLGl0c3Rvb2wpCisgICAgICAg KCJxdHRvb2xzIiAscXR0b29scykpKQorICAgIChzeW5vcHNpcyAiTXVzaWNhbCBJbnN0cnVtZW50 IFR1bmVyIikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAgIkZNSVQgaXMgYSBncmFwaGljYWwgdXRp bGl0eSBmb3IgdHVuaW5nIG11c2ljYWwgaW5zdHJ1bWVudHMsCit3aXRoIGVycm9yIGFuZCB2b2x1 bWUgaGlzdG9yeSwgYW5kIGFkdmFuY2VkIGZlYXR1cmVzIikKKyAgICAoaG9tZS1wYWdlICJodHRw czovL2dpbGxlc2RlZ290dGV4LmdpdGh1Yi5pby9mbWl0LyIpCisgICAgOzsgbW9zdCBvZiB0aGUg Y29kZSBpcyB1bmRlciBHUEwyKywgYnV0IHNvbWUgYWJzdHJhY3Qgb3IgaGVscGVyIGNsYXNzZXMg YXJlIHVuZGVyIExHUEwyLjEKKyAgICAobGljZW5zZSAobGlzdCBsaWNlbnNlOmdwbDIrIGxpY2Vu c2U6bGdwbDIuMSkpKSkKLS0gCjIuMjMuMAoK --b1_76f503eb3c96f583d922b0ca08329f45-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 08 05:17:43 2019 Received: (at 37284-done) by debbugs.gnu.org; 8 Sep 2019 09:17:43 +0000 Received: from localhost ([127.0.0.1]:38358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6tKI-00032M-Sn for submit@debbugs.gnu.org; Sun, 08 Sep 2019 05:17:43 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:52125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6tKG-00032C-Qh for 37284-done@debbugs.gnu.org; Sun, 08 Sep 2019 05:17:41 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 58BD5C0003; Sun, 8 Sep 2019 09:17:37 +0000 (UTC) From: Nicolas Goaziou To: raingloom Subject: Re: [bug#37284] [PATCH] added gnu/packages/fmit.scm (Free Musical Instrument Tuner) References: <87ef0woxsh.fsf@nicolasgoaziou.fr> <6N2dsbDEMS8qfeyHPubfhcX_yqjbdQPCIY4d8TY_4eMJCBfWNMxNzOjiwR-6QhOyPw4s9s1uCGUNppmnaSuEbtR2HpQ3WX49EN1u7iVK2Ok=@protonmail.com> Date: Sun, 08 Sep 2019 11:17:36 +0200 In-Reply-To: <6N2dsbDEMS8qfeyHPubfhcX_yqjbdQPCIY4d8TY_4eMJCBfWNMxNzOjiwR-6QhOyPw4s9s1uCGUNppmnaSuEbtR2HpQ3WX49EN1u7iVK2Ok=@protonmail.com> (raingloom@protonmail.com's message of "Sat, 07 Sep 2019 22:12:51 +0000") Message-ID: <871rwrm9jj.fsf_-_@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37284-done Cc: 37284-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, raingloom writes: > Updated again. Is sending it as an attachment fine? Well, oddly, it seems that your update addressed only one of my suggestions. So, I applied your patch with the following changes: - fixed the commit message, - added a copyright line, - added the (file-name ...) line, - split the (sha256 ...) line, - re-ordered the inputs, - changed case in synopsis, - fixed typographic mistakes in the description and the licenses comments. Let me know if something is wrong, in particular the copyright line, which I add to guess. Thank you for your contribution! Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 08 05:22:51 2019 Received: (at 37284) by debbugs.gnu.org; 8 Sep 2019 09:22:51 +0000 Received: from localhost ([127.0.0.1]:38365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6tPH-0003A4-Hv for submit@debbugs.gnu.org; Sun, 08 Sep 2019 05:22:51 -0400 Received: from mail-40136.protonmail.ch ([185.70.40.136]:49394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6tPE-00039p-Lf for 37284@debbugs.gnu.org; Sun, 08 Sep 2019 05:22:49 -0400 Date: Sun, 08 Sep 2019 09:22:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1567934559; bh=daUNPAJwgk8tr1UEqxBT76UcToFlYMkIwOptXaRA6H8=; h=Date:To:From:Reply-To:Subject:In-Reply-To:References:Feedback-ID: From; b=ii8vh3Sz8j2o53bdYZUCgDZ8FHLnfGwrsdZ0+nAoMoDYb/Sn7fQnY14Ydv8ysdDVf AdrhtdBjK6vgJ43Gq30rkIjneBpT7uia0XDWTNvJoRKHnV/34swSlix7bT7VYwp8Hr CwCwGjQ7Ce7j8R4VU64PNZw43OUyBQ8ZfSaTGcUw= To: "37284@debbugs.gnu.org" <37284@debbugs.gnu.org> From: raingloom Subject: Re: bug#37284: closed (Re: [bug#37284] [PATCH] added gnu/packages/fmit.scm (Free Musical Instrument Tuner)) Message-ID: In-Reply-To: References: <871rwrm9jj.fsf_-_@nicolasgoaziou.fr> Feedback-ID: JWBSa_o7n7kLWsdufRbO3OsPMprCgbsbX2_Lsfl4hHyN7ygZaS2d20pmOMgj-PiYsBCsSZjZFG7H0-B1fw10NQ==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37284 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raingloom Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > 37284: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D37284 > GNU Bug Tracking System > Contact help-debbugs@gnu.org with problems > Hello, > > raingloom raingloom@protonmail.com writes: > > > Updated again. Is sending it as an attachment fine? > > Well, oddly, it seems that your update addressed only one of my > suggestions. That's be weird indeed, I'm pretty sure I went through all of them.... ah. = Ahh heck. Forgot to commit. >_> Git is confusing. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 08 05:25:57 2019 Received: (at 37284-done) by debbugs.gnu.org; 8 Sep 2019 09:25:57 +0000 Received: from localhost ([127.0.0.1]:38369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6tSD-0003Ef-2e for submit@debbugs.gnu.org; Sun, 08 Sep 2019 05:25:57 -0400 Received: from mail-40130.protonmail.ch ([185.70.40.130]:41692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6tSA-0003ES-EP for 37284-done@debbugs.gnu.org; Sun, 08 Sep 2019 05:25:51 -0400 Date: Sun, 08 Sep 2019 09:25:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1567934738; bh=FRXpIf/Ap1emcPkQ2E+twHep2HwwNflWwsirHRwv/5s=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References: Feedback-ID:From; b=FV9AxKNKwnEt/QmZPppJo1IUL5syuLF9zJvWQUfE+oucLRXAtmOnibAS37vcFr9YA Ce0mi+TyC0mZfmm3Cv9pkGwsGR5VZdsWtvAtrQGeQVmHsXl1Agulb5+QFCD5UGRvee fxNkWSCS/nvt9aGbptN3DKbTUY64YZjS6a5EsNmo= To: Nicolas Goaziou From: raingloom Subject: Re: [bug#37284] [PATCH] added gnu/packages/fmit.scm (Free Musical Instrument Tuner) Message-ID: In-Reply-To: <871rwrm9jj.fsf_-_@nicolasgoaziou.fr> References: <87ef0woxsh.fsf@nicolasgoaziou.fr> <6N2dsbDEMS8qfeyHPubfhcX_yqjbdQPCIY4d8TY_4eMJCBfWNMxNzOjiwR-6QhOyPw4s9s1uCGUNppmnaSuEbtR2HpQ3WX49EN1u7iVK2Ok=@protonmail.com> <871rwrm9jj.fsf_-_@nicolasgoaziou.fr> Feedback-ID: JWBSa_o7n7kLWsdufRbO3OsPMprCgbsbX2_Lsfl4hHyN7ygZaS2d20pmOMgj-PiYsBCsSZjZFG7H0-B1fw10NQ==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_c55e327fbe87b97f51488f4b7cda25e5" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37284-done Cc: "37284-done@debbugs.gnu.org" <37284-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raingloom Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_c55e327fbe87b97f51488f4b7cda25e5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Yep, looks like I _thought_ I used `git commit -a --amend` but I forgot the= -a. *facepalm* Here is what I actually wanted to send. =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Sunday, September 8, 2019 9:17 AM, Nicolas Goaziou wrote: > Hello, > > raingloom raingloom@protonmail.com writes: > > > Updated again. Is sending it as an attachment fine? > > Well, oddly, it seems that your update addressed only one of my > suggestions. So, I applied your patch with the following changes: > > - fixed the commit message, > - added a copyright line, > - added the (file-name ...) line, > - split the (sha256 ...) line, > - re-ordered the inputs, > - changed case in synopsis, > - fixed typographic mistakes in the description and the licenses > comments. > > Let me know if something is wrong, in particular the copyright line, > which I add to guess. > > Thank you for your contribution! > > Regards, > > -- > Nicolas Goaziou > --b1_c55e327fbe87b97f51488f4b7cda25e5 Content-Type: text/x-patch; name="0001-gnu-packages-music.scm-fmit-New-variable.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-packages-music.scm-fmit-New-variable.patch RnJvbSAwYmJlMTlhMWQzN2M5ODFmNjk5ZDQ2ODFlMjM3YWFkYzYxMDg5YzkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiByYWluZ2xvb20gPHJhaW5nbG9vbUBwcm90b25tYWlsLmNvbT4K RGF0ZTogTW9uLCAyIFNlcCAyMDE5IDE1OjQ0OjE1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gKiBn bnUvcGFja2FnZXMvbXVzaWMuc2NtIChmbWl0KTogTmV3IHZhcmlhYmxlLgoKLS0tCiBnbnUvcGFj a2FnZXMvbXVzaWMuc2NtIHwgNjIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNjIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2du dS9wYWNrYWdlcy9tdXNpYy5zY20gYi9nbnUvcGFja2FnZXMvbXVzaWMuc2NtCmluZGV4IGQ0YWFl Y2MxZTIuLjBlMGVhZDUyMjkgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9tdXNpYy5zY20KKysr IGIvZ251L3BhY2thZ2VzL211c2ljLnNjbQpAQCAtMjIsNiArMjIsNyBAQAogOzs7IENvcHlyaWdo dCDCqSAyMDE5IEdhYnJpZWwgSG9uZGV0IDxnYWJyaWVsaG9uZGV0QGdtYWlsLmNvbT4KIDs7OyBD b3B5cmlnaHQgwqkgMjAxOSBUaW1vdGVqIExhemFyIDx0aW1vdGVqLmxhemFyQGFyYW5lby5zaT4K IDs7OyBDb3B5cmlnaHQgwqkgMjAxOSBKYWtvYiBMLiBLcmV1emUgPHplcm9kYXlzZm9yZGF5c0Bz ZGYubG9uZXN0YXIub3JnPgorOzs7IENvcHlyaWdodCDCqSAyMDE5IHJhaW5nbG9vbSA8cmFpbmds b29tQHByb3Rvbm1haWwuY29tPgogOzs7CiA7OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1 aXguCiA7OzsKQEAgLTQ0ODMsMyArNDQ4NCw2NCBAQCBkaXNjYXJkIGJhZCBxdWFsaXR5IG9uZXMu CiBjb250cm9sbGVyLiIpCiAgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9naXRodWIuY29tL2NoYXJs ZXNmbGVjaGUvbHBkOGVkaXRvciIpCiAgICAgKGxpY2Vuc2UgbGljZW5zZTpleHBhdCkpKQorCiso ZGVmaW5lLXB1YmxpYyBmbWl0CisgIChwYWNrYWdlCisgICAgKG5hbWUgImZtaXQiKQorICAgICh2 ZXJzaW9uICIxLjIuNiIpCisgICAgKHNvdXJjZSAob3JpZ2luCisJICAgICAgKG1ldGhvZCBnaXQt ZmV0Y2gpCisJICAgICAgKHVyaSAoZ2l0LXJlZmVyZW5jZQorCQkgICAgKHVybCAiaHR0cHM6Ly9n aXRodWIuY29tL2dpbGxlc2RlZ290dGV4L2ZtaXQvIikKKwkJICAgIChjb21taXQgKHN0cmluZy1h cHBlbmQgInYiIHZlcnNpb24pKSkpCisgICAgICAgICAgICAgIChmaWxlLW5hbWUgKGdpdC1maWxl LW5hbWUgbmFtZSB2ZXJzaW9uKSkKKwkgICAgICAoc2hhMjU2CisgICAgICAgICAgICAgICAoYmFz ZTMyCisgICAgICAgICAgICAgICAgIjAzbnpraWc1bXcycnF3aHdtZzBxdmM1Y25rOWJ3aDJ3cDEz amgwbWRycjkzNXcwNTg3bXoiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3Rl bSkKKyAgICAoYXJndW1lbnRzCisgICAgICcoIzpwaGFzZXMKKyAgICAgICAobW9kaWZ5LXBoYXNl cyAlc3RhbmRhcmQtcGhhc2VzCisJIChkZWxldGUgJ2NvbmZpZ3VyZSkKKwkgKGFkZC1iZWZvcmUg J2J1aWxkICdxbWFrZQorCSAgIChsYW1iZGEgXworCSAgICAgKGxldCAoKG91dCAoYXNzb2MtcmVm ICVvdXRwdXRzICJvdXQiKSkpCisgICAgICAgICAgICAgICAoaW52b2tlICJxbWFrZSIKKyAgICAg ICAgICAgICAgICAgICAgICAgImZtaXQucHJvIgorICAgICAgICAgICAgICAgICAgICAgICAoc3Ry aW5nLWFwcGVuZCAiUFJFRklYPSIgb3V0KQorICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5n LWFwcGVuZCAiUFJFRklYU0hPUlRDVVQ9IiBvdXQpCisgICAgICAgICAgICAgICAgICAgICAgICJD T05GSUcrPWFjc19xdCBhY3NfYWxzYSBhY3NfamFjayBhY3NfcG9ydGF1ZGlvIikpKSkKKyAgICAg ICAgIChhZGQtYWZ0ZXIgJ2luc3RhbGwgJ3dyYXAtZXhlY3V0YWJsZQorICAgICAgICAgICAobGFt YmRhKiAoIzprZXkgaW5wdXRzIG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAgICAg ICAgIChsZXQgKChvdXQgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSkpCisgICAgICAgICAgICAg ICAod3JhcC1wcm9ncmFtIChzdHJpbmctYXBwZW5kIG91dCAiL2Jpbi9mbWl0IikKKyAgICAgICAg ICAgICAgICAgYCgiUVRfUExVR0lOX1BBVEgiICI6IiBwcmVmaXgKKyAgICAgICAgICAgICAgICAg ICAsKG1hcCAobGFtYmRhIChsYWJlbCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJp bmctYXBwZW5kIChhc3NvYy1yZWYgaW5wdXRzIGxhYmVsKQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIi9saWIvcXQ1L3BsdWdpbnMiKSkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAnKCJxdGJhc2UiICJxdG11bHRpbWVkaWEiICJxdHN2ZyIpKSkKKyAgICAgICAg ICAgICAgICAgYCgiUU1MMl9JTVBPUlRfUEFUSCIgIjoiIHByZWZpeAorICAgICAgICAgICAgICAg ICAgICwobWFwIChsYW1iZGEgKGxhYmVsKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0 cmluZy1hcHBlbmQgKGFzc29jLXJlZiBpbnB1dHMgbGFiZWwpCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiL2xpYi9xdDUvcW1sIikpCisgICAgICAgICAgICAgICAg ICAgICAgICAgJygicXRtdWx0aW1lZGlhIikpKSkKKyAgICAgICAgICAgICAgICN0KSkpKSkpCisg ICAgKGlucHV0cworICAgICBgKCgiYWxzYS1saWIiICxhbHNhLWxpYikKKyAgICAgICAoImZmdHci ICxmZnR3KQorICAgICAgICgiamFjayIgLGphY2stMSkKKyAgICAgICAoInBvcnRhdWRpbyIgLHBv cnRhdWRpbykKKyAgICAgICAoInF0YmFzZSIgLHF0YmFzZSkKKyAgICAgICAoInF0bXVsdGltZWRp YSIgLHF0bXVsdGltZWRpYSkKKyAgICAgICAoInF0c3ZnIiAscXRzdmcpKSkKKyAgICAobmF0aXZl LWlucHV0cworICAgICBgKCgiZ2V0dGV4dCIgLGdudS1nZXR0ZXh0KQorICAgICAgICgiaGljb2xv ci1pY29uLXRoZW1lIiAsaGljb2xvci1pY29uLXRoZW1lKQorICAgICAgICgiaXRzdG9vbCIgLGl0 c3Rvb2wpCisgICAgICAgKCJxdHRvb2xzIiAscXR0b29scykpKQorICAgIChzeW5vcHNpcyAiTXVz aWNhbCBpbnN0cnVtZW50IHR1bmVyIikKKyAgICAoZGVzY3JpcHRpb24gIkZNSVQgaXMgYSBncmFw aGljYWwgdXRpbGl0eSBmb3IgdHVuaW5nIG11c2ljYWwgaW5zdHJ1bWVudHMsCit3aXRoIGVycm9y IGFuZCB2b2x1bWUgaGlzdG9yeSwgYW5kIGFkdmFuY2VkIGZlYXR1cmVzLiIpCisgICAgKGhvbWUt cGFnZSAiaHR0cHM6Ly9naWxsZXNkZWdvdHRleC5naXRodWIuaW8vZm1pdC8iKQorICAgIDs7IE1v c3Qgb2YgdGhlIGNvZGUgaXMgdW5kZXIgR1BMMissIGJ1dCBzb21lIGFic3RyYWN0IG9yIGhlbHBl ciBjbGFzc2VzIGFyZSB1bmRlciBMR1BMMi4xLgorICAgIChsaWNlbnNlIChsaXN0IGxpY2Vuc2U6 Z3BsMisgbGljZW5zZTpsZ3BsMi4xKSkpKQotLSAKMi4yMy4wCgo= --b1_c55e327fbe87b97f51488f4b7cda25e5-- From unknown Wed Jun 18 23:13:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 06 Oct 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator