GNU bug report logs - #37273
[PATCH 07/19] gnu: xfconf: Fix tests.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: L  p R n  d n <guix <at> lprndn.info>
Subject: bug#37273: closed (Re: [bug#37273] [PATCH 07/19] gnu: xfconf: Fix
 tests.)
Date: Fri, 06 Sep 2019 22:25:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#37273: [PATCH 07/19] gnu: xfconf: Fix tests.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 37273 <at> debbugs.gnu.org.

-- 
37273: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37273
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: L p R n d n <guix <at> lprndn.info>
Cc: 37273-done <at> debbugs.gnu.org
Subject: Re: [bug#37273] [PATCH 07/19] gnu: xfconf: Fix tests.
Date: Sat, 07 Sep 2019 00:24:22 +0200

L  p R n  d n <guix <at> lprndn.info> skribis:

> * gnu/packages/xfce.scm (xfconf)[arguments]: Rename check phase to
>   custom-check.
>   [native-inputs]: Add dbus.

Good catch.  Applied, thanks!

[Message part 3 (message/rfc822, inline)]

From: L  p R n  d n <guix <at> lprndn.info>
To: guix-patches <at> gnu.org
Subject: [PATCH 07/19] gnu: xfconf: Fix tests.
Date: Mon,  2 Sep 2019 16:04:52 +0200

* gnu/packages/xfce.scm (xfconf)[arguments]: Rename check phase to
  custom-check.
  [native-inputs]: Add dbus.
---
 gnu/packages/xfce.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index eb14157780..31a1209167 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -127,7 +127,7 @@ Xfce Desktop Environment.")
      '(#:phases
        ;; Run check after install phase to test dbus activation.
        (modify-phases %standard-phases
-         (add-after 'install 'check
+         (add-after 'install 'custom-check
            (lambda _
              (setenv "HOME" (getenv "TMPDIR")) ; xfconfd requires a writable HOME
              ;; Run test-suite under a dbus session.
@@ -142,7 +142,8 @@ Xfce Desktop Environment.")
        ("intltool" ,intltool)
        ("glib:bin" ,glib "bin") ;; for gdbus-codegen
        ("gobject-introspection" ,gobject-introspection)
-       ("vala" ,vala)))
+       ("vala" ,vala)
+       ("dbus" ,dbus)))
     (propagated-inputs
      ;; libxfconf-0.pc refers to all these.
      `(("glib" ,glib)))
-- 
2.22.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.