GNU bug report logs - #37259
[PATCH] Update emacs-org-ql to 0.2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37259 in the body.
You can then email your comments to 37259 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update emacs-org-ql to 0.2.
Date: Sun, 1 Sep 2019 19:55:52 +0200

[Message part 1 (text/plain, inline)]

See attached.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-emacs-ts.patch (text/x-patch, attachment)]

[0002-gnu-emacs-org-sidebar-Update-to-0.1-1.ed951d1.patch (text/x-patch, attachment)]

[0003-gnu-emacs-org-ql-Update-to-0.2.patch (text/x-patch, attachment)]

Message #8 received at 37259 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: 37259 <at> debbugs.gnu.org
Subject: [PATCH] Update emacs-org-ql to 0.2.
Date: Sun, 1 Sep 2019 20:09:39 +0200

[Message part 1 (text/plain, inline)]

I changed the commit message on the last patch.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-emacs-ts.patch (text/x-patch, attachment)]

[0003-gnu-emacs-org-ql-Update-to-0.2.patch (text/x-patch, attachment)]

[0002-gnu-emacs-org-sidebar-Update-to-0.1-1.ed951d1.patch (text/x-patch, attachment)]

Message #11 received at 37259 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pyhalov <go.wigust <at> gmail.com>
To: Brian Leung <bkleung89 <at> gmail.com>
Cc: 37259 <at> debbugs.gnu.org
Subject: Re: [bug#37259] [PATCH] Update emacs-org-ql to 0.2.
Date: Sun, 01 Sep 2019 22:29:52 +0300

[Message part 1 (text/plain, inline)]

Hello Brian,

Brian Leung <bkleung89 <at> gmail.com> writes:

> I changed the commit message on the last patch.
> From 4f75a46c67e840eccc01f21cfd62768fc8e5ffdf Mon Sep 17 00:00:00 2001
> From: Brian Leung <bkleung89 <at> gmail.com>
> Date: Sun, 1 Sep 2019 19:46:27 +0200
> Subject: [PATCH 1/3] gnu: Add emacs-ts.
>
> * gnu/packages/emacs-xyz.scm (emacs-ts): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)

Could you take a look on enabling test suite, please?

Everything else LGTM.

[…]

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 37259 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: Oleg Pyhalov <go.wigust <at> gmail.com>
Cc: 37259 <at> debbugs.gnu.org
Subject: Re: [bug#37259] [PATCH] Update emacs-org-ql to 0.2.
Date: Mon, 2 Sep 2019 02:40:19 +0200

[Message part 1 (text/plain, inline)]

Hi Oleg,

I've modified the patches. Three tests from ts.el are failing right now; I
don't think it's a serious problem though (see the patch for the
explanation).

On Sun, Sep 1, 2019 at 9:30 PM Oleg Pyhalov <go.wigust <at> gmail.com> wrote:

> Hello Brian,
>
> Brian Leung <bkleung89 <at> gmail.com> writes:
>
> > I changed the commit message on the last patch.
> > From 4f75a46c67e840eccc01f21cfd62768fc8e5ffdf Mon Sep 17 00:00:00 2001
> > From: Brian Leung <bkleung89 <at> gmail.com>
> > Date: Sun, 1 Sep 2019 19:46:27 +0200
> > Subject: [PATCH 1/3] gnu: Add emacs-ts.
> >
> > * gnu/packages/emacs-xyz.scm (emacs-ts): New variable.
> > ---
> >  gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
>
> Could you take a look on enabling test suite, please?
>
> Everything else LGTM.
>
> […]
>
> Thanks,
> Oleg.
>

[Message part 2 (text/html, inline)]

[0001-gnu-Add-emacs-ts.patch (text/x-patch, attachment)]

[0002-gnu-emacs-org-sidebar-Update-to-0.1-1.ed951d1.patch (text/x-patch, attachment)]

[0003-gnu-emacs-org-ql-Update-to-0.2.patch (text/x-patch, attachment)]

Message #17 received at 37259 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pyhalov <go.wigust <at> gmail.com>
To: Brian Leung <bkleung89 <at> gmail.com>
Cc: 37259 <at> debbugs.gnu.org
Subject: Re: [bug#37259] [PATCH] Update emacs-org-ql to 0.2.
Date: Mon, 02 Sep 2019 20:31:20 +0300

[Message part 1 (text/plain, inline)]

Hi Brian,

Brian Leung <bkleung89 <at> gmail.com> writes:

> I've modified the patches. Three tests from ts.el are failing right now; I
> don't think it's a serious problem though (see the patch for the
> explanation).

OK.  Thank you.  Hope it works as intended.  Still we could have 35/38
succeeded tests.  Could you report upstream about tests failure, delete
failed from the package recipe, and enable tests?  You could take
emacs-json-reformat recipe as an example.

[…]

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 37259 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: Oleg Pyhalov <go.wigust <at> gmail.com>
Cc: 37259 <at> debbugs.gnu.org
Subject: Re: [bug#37259] [PATCH] Update emacs-org-ql to 0.2.
Date: Mon, 2 Sep 2019 21:10:41 +0200

[Message part 1 (text/plain, inline)]

OK, I've enabled the tests and removed the three failing tests in this set
of patches.

On Mon, Sep 2, 2019 at 7:31 PM Oleg Pyhalov <go.wigust <at> gmail.com> wrote:

> Hi Brian,
>
> Brian Leung <bkleung89 <at> gmail.com> writes:
>
> > I've modified the patches. Three tests from ts.el are failing right now;
> I
> > don't think it's a serious problem though (see the patch for the
> > explanation).
>
> OK.  Thank you.  Hope it works as intended.  Still we could have 35/38
> succeeded tests.  Could you report upstream about tests failure, delete
> failed from the package recipe, and enable tests?  You could take
> emacs-json-reformat recipe as an example.
>
> […]
>
> Oleg.
>

[Message part 2 (text/html, inline)]

[0001-gnu-Add-emacs-ts.patch (text/x-patch, attachment)]

[0002-gnu-emacs-org-sidebar-Update-to-0.1-1.ed951d1.patch (text/x-patch, attachment)]

[0003-gnu-emacs-org-ql-Update-to-0.2.patch (text/x-patch, attachment)]

Message #23 received at 37259 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pyhalov <go.wigust <at> gmail.com>
To: Brian Leung <bkleung89 <at> gmail.com>
Cc: 37259 <at> debbugs.gnu.org, 37259-done <at> debbugs.gnu.org
Subject: Re: [bug#37259] [PATCH] Update emacs-org-ql to 0.2.
Date: Tue, 03 Sep 2019 10:00:21 +0300

[Message part 1 (text/plain, inline)]

Hi Brian,

Brian Leung <bkleung89 <at> gmail.com> writes:

> OK, I've enabled the tests and removed the three failing tests in this
> set of patches.

Great.  Pushed to master.

[…]

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.