GNU bug report logs - #37222
[PATCH] gnu: services: Add dkimproxy-out.

Previous Next

To reply to this bug, email your comments to 37222 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: services: Add dkimproxy-out.
Date: Thu, 29 Aug 2019 21:52:26 +0200

[Message part 1 (text/plain, inline)]

Hi guix, the attached patch adds the dkimproxy-out service that I use
for signing my emails (including this one, although it's probably not
valid because it went through a mailing list).

Thanks!

[0001-gnu-services-Add-dkimproxy-out.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: guix-patches <at> gnu.org
Cc: 37222 <at> debbugs.gnu.org
Subject: Re: [bug#37222] [PATCH] gnu: services: Add dkimproxy-out.
Date: Thu, 29 Aug 2019 22:04:05 +0200

[Message part 1 (text/plain, inline)]

Julien,

Julien Lepiller 写道：
> Hi guix, the attached patch adds the dkimproxy-out service that 
> I use
> for signing my emails (including this one, although it's 
> probably not
> valid because it went through a mailing list).

Interesting; I wasn't expecting that.  I thought GNU'd finally 
fixed their mailman to not break signatures, but you're right:

 Received: from a.mx.tobias.gr (localhost [127.0.0.1])
	by DKIM-proxy (OpenSMTPD) with ESMTP id a7e379af
	for <me <at> tobias.gr>;
	Thu, 29 Aug 2019 19:53:20 +0000 (UTC)
 Authentication-Results: tobias.gr; dkim=fail (message has been 
 altered) header.i=@lepiller.eu; domainkeys=fail (message has 
 been altered) header.from=julien <at> lepiller.eu
 X-DKIM-Authentication-Results: fail (message has been altered)
 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	by a.mx.tobias.gr (OpenSMTPD) with ESMTPS id eb36763a 
	(TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO)
	for <me <at> tobias.gr>;
	Thu, 29 Aug 2019 19:53:20 +0000 (UTC)

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 37222 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 37222 <at> debbugs.gnu.org
Subject: Re: [bug#37222] [PATCH] gnu: services: Add dkimproxy-out.
Date: Wed, 04 Sep 2019 14:16:12 +0200

Hi!

Julien Lepiller <julien <at> lepiller.eu> skribis:

>>From 114067a7134ceb49dc5bbcef820edc49d62c8d0f Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien <at> lepiller.eu>
> Date: Thu, 29 Aug 2019 21:48:25 +0200
> Subject: [PATCH] gnu: services: Add dkimproxy-out.
                   ^
No need for “gnu:”, which is only for (gnu packages …).  (Confusingly…)
>
> * gnu/services/mail.scm (dkimproxy-out-service-type): New variable.
> * doc/guix.texi (Mail Services): Document it.
> +@subsubheading Dkimproxy Outbound Service
> +@cindex Dkimproxy Outbound Service
> +

Could you add an introductory paragraph, for instance mentioning what
DKIM is about, linking to the Wikipedia page or something?

> +@deffn {Scheme Variable} dkimproxy-out-service-type
> +This is the type of the @uref{http://dkimproxy.sourceforge.net/, dkimproxy
> +outbound daemon}, whose value should be a @code{dkimproxy-out-configuration}
> +object as in this example:
> +
> +@example
> +(service dkimproxy-out-service-type
> +         (dkimproxy-out-configuration
> +	   (listen "127.0.0.1:10027")
   ^
No tabs please.  :-)

> +            %default-imap4d-config-file
> +	    
> +	    dkimproxy-out-service-type

Ditto (several occurrences in this file.)

> +(define (generate-map-file config filename)
> +  (apply plain-file filename
> +         (map (lambda (config)
> +                (match config
> +                  ((selector (config ...))
> +                   (string-append
> +                     selector " "
> +                     (string-join
> +                       (map generate-dkimproxy-out-signature-configuration config)
> +                       "\n")))
> +                  ((selector config)
> +                   (string-append
> +                     selector " "
> +                     (generate-dkimproxy-out-signature-configuration config)))))
> +              config)))

This is incorrect since ‘plain-file’ takes exactly two arguments.
Should it be something like:

  (plain-file file-name (string-join (map … config)))

?

> +                               (domains
> +                                 (apply append
> +                                   (map

Use ‘append-map’ instead.

> +(define dkimproxy-out-service-type
> +  (service-type
> +    (name 'dkimproxy-out)
> +    (extensions
> +      (list (service-extension account-service-type
> +                               (const %dkimproxy-accounts))
> +            (service-extension shepherd-root-service-type
> +                               dkimproxy-out-shepherd-service)))))

Please add a ‘description’ field.

It would be nice to have a system test too, which I guess could at least
ensure that the generated config is valid and that the daemon happily
starts?

Thanks,
Ludo’.

Message #17 received at 37222 <at> debbugs.gnu.org (full text, mbox):

From: Alexey Abramov <levenson <at> mmer.org>
To: julien <at> lepiller.eu
Cc: 37222 <at> debbugs.gnu.org
Subject: dkimproxy-out status
Date: Thu, 04 Feb 2021 12:19:46 +0100

Hi Julien,

I copy&pasted your great dkimproxy service, and it works like a charm. Thank you! I was wondering when are you going to address those changes that Ludo has suggested?

If you don't have time for some reason, I am willing to help with it to let it merge. What do you think?

-- 
Alexey

Message #20 received at 37222 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Alexey Abramov <levenson <at> mmer.org>
Cc: 37222 <at> debbugs.gnu.org
Subject: Re: dkimproxy-out status
Date: Thu, 04 Feb 2021 06:37:35 -0500

[Message part 1 (text/plain, inline)]

Oh, I totally forgot about it! With FOSDEM and everything, I don't think I'll be able to take care of this before next week. I appreciate any help you can provide!

Le 4 février 2021 06:19:46 GMT-05:00, Alexey Abramov <levenson <at> mmer.org> a écrit :
>Hi Julien,
>
>I copy&pasted your great dkimproxy service, and it works like a charm.
>Thank you! I was wondering when are you going to address those changes
>that Ludo has suggested?
>
>If you don't have time for some reason, I am willing to help with it to
>let it merge. What do you think?
>
>-- 
>Alexey

[Message part 2 (text/html, inline)]

Message #23 received at 37222 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: 37222 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: services: Add dkimproxy-out.
Date: Thu, 15 Jun 2023 18:08:02 +0200

Dear guix,

I myself have a similar service for DKIM signing. I would be glad to
trash it and use this one. This patch series seems to be forgotten,
could we reconsider it?

Best regards,

Vivien

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.