GNU bug report logs - #37216
[PATCH] vc-svn-ignore sets incorrect properties for relative filenames

Previous Next

Full log

Message #8 received at 37216 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>
Cc: 37216 <at> debbugs.gnu.org
Subject: Re: bug#37216: [PATCH] vc-svn-ignore sets incorrect properties for
 relative filenames
Date: Sun, 15 Sep 2019 15:07:46 +0200

Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de> writes:

> If a relative filename has at least one level of parent
> directories, `vc-svn-ignore' fails to add the ignore spec to the
> correct subdirectory.
>
> The attached patch fixes that error.

[...]

> +FILE is a wildcard specification, either relative to
> +DIRECTORY or absolute."
> +  (let* ((path (directory-file-name (expand-file-name file directory)))
> +         (directory (file-name-directory path))
> +         (file (file-name-nondirectory path))
> +         (ignores (vc-svn-ignore-completion-table directory))
>           (ignores (if remove
>                        (delete file ignores)
>                      (push file ignores))))
>      (vc-svn-command nil 0 nil nil "propset" "svn:ignore"
>                      (mapconcat #'identity ignores "\n")
> -                    (expand-file-name directory))))
> +                    directory)))

I don't have any svn trees to test with, but if I understand the code
here, then this seems correct.

Does anybody else have an opinion?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.