GNU bug report logs - #37215
[PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37215: closed ([PATCH] vc-cvs-ignore writes absolute
 filenames and duplicate strings)
Date: Sat, 22 Feb 2020 09:01:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 22 Feb 2020 10:59:49 +0200
with message-id <83tv3jhu9m.fsf <at> gnu.org>
and subject line Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings
has caused the debbugs.gnu.org bug report #37215,
regarding [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37215: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37215
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings
Date: Thu, 29 Aug 2019 00:32:22 +0200

[Message part 3 (text/plain, inline)]

When called with an absolute filename (which is the default
case), `vc-cvs-ignore' writes the entire path into the .cvsignore
file.

`vc-cvs-ignore' also writes duplicate strings into .cvsignore.

The attached patch fixes these errors.

[0001-Do-not-write-absolute-filenames-and-duplicate-string.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>
Cc: larsi <at> gnus.org, 37215-done <at> debbugs.gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and
 duplicate strings
Date: Sat, 22 Feb 2020 10:59:49 +0200

> Cc: larsi <at> gnus.org, 37215 <at> debbugs.gnu.org, dgutov <at> yandex.ru
> From: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>
> Date: Fri, 21 Feb 2020 21:32:03 +0100
> 
> > Please quote 'like this' in log messages, and try to avoid non-ASCII
> > characters there (they are generally only necessary in people's
> > names).
> OK
> >> +Patterns follow glob(7) syntax.  Special characters \"?*[\\\" are
> >> +escaped with a backslash."
> > I'd say "should be escaped" here, since this is a requirement for the
> > argument passed to this function.
> Here is that amgbuity again ;-). It is only required, if the user
> wants a special character to match literally. It's perfectly fine to
> specify  *.pyc  as a pattern. I have phrased it like that.
> > Also, I'd mention that FILE can be a pattern, otherwise the reference
> > to patterns might come as a surprise to the reader.
> I emphasized more, that the basename of the FILE argument (not the
> entire FILE) is in fact a CVS ignore pattern.
> >> +to hear about anymore.  If SORT is non-nil, sort the ines of the
> >> +ignore file."                                        ^^^^
> > Typo: should be "lines".
> Right.
> >> +    (goto-char (point-min))
> >> +    (save-match-data
> >> +      (unless (re-search-forward (concat "^" (regexp-quote str) "$") nil t)
> >> +        (goto-char (point-max))
> > You could use non-nil, non-t 3rd argument of re-search-forward, in
> > which case the following goto-char would be redundant, right?
> Right, I just left the  goto-char  in there, because it makes it
> obvious what is going on. Switching to the side-effect optimization ...

Thanks, pushed to the release branch.

Please note that I need to make minor copyedits in the log message;
please try following this style in the future.

With this, I'm closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.