GNU bug report logs - #37215
[PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>
Cc: 37215 <at> debbugs.gnu.org
Subject: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings
Date: Sun, 15 Sep 2019 15:12:05 +0200

Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de> writes:

> * lisp/vc/vc-cvs.el: (vc-cvs-ignore) Expand filename correctly
> and pass on basename only.
> (vc-cvs-append-to-ignore) Do not write duplicate strings to
> .cvsignore.

This looks correct to me, but:

[...]

> +        ;; FIXME this is a pcvs variable.
> +        (if (bound-and-true-p cvs-sort-ignore-file)
> +            (sort-lines nil (point-min) (point-max)))

Does it make sense to heed a pcvs variable here?  I think it would be
surprising that vc-cvs behaves differently depending on whether you've
loaded pcvs or not.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.