From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 28 18:32:33 2019 Received: (at submit) by debbugs.gnu.org; 28 Aug 2019 22:32:33 +0000 Received: from localhost ([127.0.0.1]:51365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i36US-0006nE-MQ for submit@debbugs.gnu.org; Wed, 28 Aug 2019 18:32:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:51376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i36UR-0006n6-1B for submit@debbugs.gnu.org; Wed, 28 Aug 2019 18:32:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45277) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i36UP-0001uv-NG for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2019 18:32:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i36UO-0002T8-Jg for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2019 18:32:29 -0400 Received: from mout.gmx.net ([212.227.15.15]:49893) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i36UO-0002S3-2D for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2019 18:32:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1567031544; bh=jb0cMdUAvfUBqaW6ZYQf2dbhAx9JkXoEpIKk/W335Z0=; h=X-UI-Sender-Class:To:From:Subject:Date; b=AbxWHfyv4Er5gT54/3bqQ+tOUGqwBQrp9jzvcovY/OwiW215xoljEas/fL1jaWHJM PG/dhmGzWb7FYKa6Dtxc2HPfLm9yNWNBReVTQRkvW252rdZdPhQRmaLU6JE08bkkJP lmi+YcAwXqrYBrx4SUW2bvfWQl5YNZoPxy3T/m/4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.144.41.174]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MIMbO-1hxexg1Key-00EMwo for ; Thu, 29 Aug 2019 00:32:24 +0200 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id BA98D1942AFF for ; Thu, 29 Aug 2019 00:32:22 +0200 (CEST) To: Emacs Bugs From: Wolfgang Scherer Subject: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: Date: Thu, 29 Aug 2019 00:32:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------3FBEAFDFBD64FCA29D5F1499" Content-Language: de-DE X-Provags-ID: V03:K1:xtpW0fyEJnjEMV5rsdCkerYx2caLbb74XxdoiJdW25NJ/5b0wR1 7QjUlRO4KuNBp4SLJu5UflIAQMeWvtDL5yboNQeFCjDAefNnFBHUU5ZumfheVwUng5NJZ5k bZMR6FF6IylybUzWayYiJbmfgmB+eRp7+IGtGyqd7rmktWllSLBw5ZbzdoCmL9yqMalF0V8 DR+TDwxn+34orUtP5zDvg== X-UI-Out-Filterresults: notjunk:1;V03:K0:buwnXpotcl4=:DySNbGH6yQv0wHO2nOTSW7 K2VkgNDuU/gxVlTVVqMJzIhj/xq+h7oG7d8mQqdJXCVSMJIIVoBhRUQMxTDFzVX+ojCXRgRpy TU+OZMpnTPvtYhKgj/lu9QpIQCtpECAeN5csJb3el7ZRMCjt1dau3qvRgqciaOhorL3UcfA++ n+z0YmFok/vLg8l/tmi9j1r9sSmyvFOBhRbxHvJJ8UeVZbiC2sD+7PRNk5UAD46LvM1NyNyUC 657Tcok0Ds3sooSzDCds5gN2aIl/plrEfDMqR3zUhUwS1J7d3D/K4qoDQzTjNHk5H5BMVRqpD sC3FVk+XAAxqTeWDwZluLK4nT6hEPMNrcJYl4iqYtt5YdgNmCbUyD1diqb4I7OGES3vFZwSco 5CgAOtgRc8q5OBrQ/5KbKKmdghfPDR44fVdJcg8v7QxLKN+1XTvEl+1mI61Im0v9sYMj7lbHI ZEjlbZAmv7sIjrW7Ya3AcF4XND88NAaMg3gRzncKubjRyQheSq1TdwIj6TW2pVUgQhd8tLeC9 Vtq2GpVNtXwBeYxFt8/WGdCgBnECWI2GE1V721Ki8X9w/I6NyjZp2uH1ygxI4odACdOo6M0mC yP5sA2bxvOOXn+KTlSuc1D3iX+fo5dktSidiHUr1+CEdI7EViM0aV7KQ3Jv6BGomL5g9NKpLF qG5DRpxiRQNRYllK35gDSTaEzv/Ke2b0ESGI8Re0DaprP8WeKl9qYmj4AUUaAizaYFc1nk2Ro shHUv58WiQed5Qmy2dOk9ZmKZxGtFJI2yKT2js5K+w4tUgE9lSv2Iu6Bc19SEclJNnPE65FlD dhQtCkn5xwvdvuPtyStW0ib+mxvBnzLLblPua+Q90oi/UTObyQNcJsnZ6kJMwD7ihszJJqrMl HLcWys6i8+EAIolomhygRoJkhykR2pxey5n7YNZdFeYeMiwSbrVZPUUu/MSXVxoxasgCS/eX4 dCE18EYFiuB0jMFJN2OFxAnmPl4VYGFGvJtLR56hrqWWMzSaD7WvD5/fTxThynbMkrrAGBw9X 1kzgUEBisz2aBu3UpsGI6r8gozz/IWQL/r/YRm5VIHZaDq0aaZVyko2KmulCjcgKGbacJZMwj U7s2fDBP2Xc5wnDpYF1Jx0DSUjrWZieTmu61OOqy6vzMCdZIm9GLjpVqw== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.15 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This is a multi-part message in MIME format. --------------3FBEAFDFBD64FCA29D5F1499 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit When called with an absolute filename (which is the default case), `vc-cvs-ignore' writes the entire path into the .cvsignore file. `vc-cvs-ignore' also writes duplicate strings into .cvsignore. The attached patch fixes these errors. --------------3FBEAFDFBD64FCA29D5F1499 Content-Type: text/x-patch; name="0001-Do-not-write-absolute-filenames-and-duplicate-string.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-Do-not-write-absolute-filenames-and-duplicate-string.pa"; filename*1="tch" =46rom 2b7b90b94a426754a99c965bf708bf5854008b76 Mon Sep 17 00:00:00 2001 From: Wolfgang Scherer Date: Thu, 29 Aug 2019 00:29:31 +0200 Subject: [PATCH] Do not write absolute filenames and duplicate strings int= o .cvsignore * lisp/vc/vc-cvs.el: (vc-cvs-ignore) Expand filename correctly and pass on basename only. (vc-cvs-append-to-ignore) Do not write duplicate strings to .cvsignore. =2D-- lisp/vc/vc-cvs.el | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/lisp/vc/vc-cvs.el b/lisp/vc/vc-cvs.el index d84700f..1d0387b 100644 =2D-- a/lisp/vc/vc-cvs.el +++ b/lisp/vc/vc-cvs.el @@ -1220,9 +1220,11 @@ is non-nil." "Return the administrative directory of FILE." (vc-find-root file "CVS")) -(defun vc-cvs-ignore (file &optional _directory _remove) - "Ignore FILE under CVS." - (vc-cvs-append-to-ignore (file-name-directory file) file)) +(defun vc-cvs-ignore (file &optional directory _remove) + "Ignore FILE under CVS. +FILE is either absolute or relative to DIRECTORY." + (setq file (directory-file-name (expand-file-name file directory))) + (vc-cvs-append-to-ignore (file-name-directory file) (file-name-nondirec= tory file))) (defun vc-cvs-append-to-ignore (dir str &optional old-dir) "In DIR, add STR to the .cvsignore file. @@ -1236,13 +1238,16 @@ to hear about anymore." (not (vc-editable-p buffer-file-name)))) ;; CVSREAD=3Don special case (vc-checkout buffer-file-name t)) - (goto-char (point-max)) - (unless (bolp) (insert "\n")) - (insert str (if old-dir "/\n" "\n")) - ;; FIXME this is a pcvs variable. - (if (bound-and-true-p cvs-sort-ignore-file) - (sort-lines nil (point-min) (point-max))) - (save-buffer))) + (goto-char (point-min)) + (save-match-data + (unless (re-search-forward (concat "^" (regexp-quote str) "$") nil = t) + (goto-char (point-max)) + (unless (bolp) (insert "\n")) + (insert str (if old-dir "/\n" "\n")) + ;; FIXME this is a pcvs variable. + (if (bound-and-true-p cvs-sort-ignore-file) + (sort-lines nil (point-min) (point-max))) + (save-buffer))))) (provide 'vc-cvs) =2D- 2.7.4 --------------3FBEAFDFBD64FCA29D5F1499-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 15 09:12:14 2019 Received: (at 37215) by debbugs.gnu.org; 15 Sep 2019 13:12:14 +0000 Received: from localhost ([127.0.0.1]:47507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9UK3-0004jB-Bi for submit@debbugs.gnu.org; Sun, 15 Sep 2019 09:12:11 -0400 Received: from quimby.gnus.org ([80.91.231.51]:33358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9UK1-0004j4-Lr for 37215@debbugs.gnu.org; Sun, 15 Sep 2019 09:12:10 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9UJy-0000Q8-9b; Sun, 15 Sep 2019 15:12:08 +0200 From: Lars Ingebrigtsen To: Wolfgang Scherer Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings References: Date: Sun, 15 Sep 2019 15:12:05 +0200 In-Reply-To: (Wolfgang Scherer's message of "Thu, 29 Aug 2019 00:32:22 +0200") Message-ID: <87imptwvoa.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Wolfgang Scherer writes: > * lisp/vc/vc-cvs.el: (vc-cvs-ignore) Expand filename correctly > and pass on basename only. > (vc-cvs-append-to-ignore) Do not write duplicate strings to > .cvsignore. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Wolfgang Scherer writes: > * lisp/vc/vc-cvs.el: (vc-cvs-ignore) Expand filename correctly > and pass on basename only. > (vc-cvs-append-to-ignore) Do not write duplicate strings to > .cvsignore. This looks correct to me, but: [...] > + ;; FIXME this is a pcvs variable. > + (if (bound-and-true-p cvs-sort-ignore-file) > + (sort-lines nil (point-min) (point-max))) Does it make sense to heed a pcvs variable here? I think it would be surprising that vc-cvs behaves differently depending on whether you've loaded pcvs or not. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 23:00:06 2020 Received: (at 37215) by debbugs.gnu.org; 5 Jan 2020 04:00:06 +0000 Received: from localhost ([127.0.0.1]:43582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inx5B-0002t1-Vp for submit@debbugs.gnu.org; Sat, 04 Jan 2020 23:00:06 -0500 Received: from mout.gmx.net ([212.227.17.21]:59011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inx5B-0002s3-0M for 37215@debbugs.gnu.org; Sat, 04 Jan 2020 23:00:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1578196798; bh=l5uBPUVNYSQk9HsoR4p1i4VzAgCBxpdUuK1udyR5N30=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=liIzXM7PUX/yHJZ0iiXR5F8R0sKZesNysZfPg+/clxsSEbGg+UXIBxd1SdnuCIwj1 9Uh/B8xGl+Naf2jbrtEjk5+1QEAocvg0sloNKfVDrc0pXtf6ojiyDBhCeR/wIqcJac aAV51XjwYIDgQRBvRPWnPT103yxMyNO2hrRhCN7k= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MEm6F-1iupcb2qtf-00GGsD; Sun, 05 Jan 2020 04:59:58 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id 07FCC1940579; Sun, 5 Jan 2020 04:59:57 +0100 (CET) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Lars Ingebrigtsen References: <87imptwvoa.fsf@gnus.org> From: Wolfgang Scherer Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: Date: Sun, 5 Jan 2020 04:59:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <87imptwvoa.fsf@gnus.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: de-DE X-Provags-ID: V03:K1:bpx+SYRUKwDPP3ThPAWgqZ+IictgTE3T70fxT4b72dw+XetY6Jf sIxNMbXeotTu/8ybecQw2ohupG8tf7Q3ShzTDjJgEd86m0Fs4IcuytM7wHX1C7I2nO+2L3K d3KOH7/E/Qxg+OVS/Bd2V8NDUuDZBi26qQkLMF8mxlMrn5kuGhiUA5kAsuGC7G4t/ZngUxH 5hLN2mHPPtDGyGiGMOqPw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:1aeDdpJfUPE=:FN4uP4Vjz7g/D3lAd9iICh nQhispmQMMM6vYF2ntBUUV5XUmfbO3tHujnSItrNINCon+3YNZMBYXR+ovs4KZdUyzOhZPBTJ y5yfw6WPUWEI2Rxhl2hWkqDLRmDhhouUVIGN3hPlJ6MkVfcMY5x3Ro3jxQJbKAvGnglH1J7eq q3oi1HBpcn9sVidetAJBJwq0qLT+U8hHgyq0h8/+PuahmqndoLwRIrttcavFay7TiW9KTAI+8 /GHXx5Ljx7sl9ASpqK88MNSbOkEwwdzkHU9q8VrxkdwN89TO5266wyt8Pb4Awq6tpJ7RR3vro sxeGpFeHuQ4D90bs67JTakpaHepGz3BV5S/FsYXXDTMWtnBkDkjlM9b5Qwk9CGJGJLW0uVIPw X6kQvYskzm1SpRPgNEJnpI8wNyr8DMFQfaDBFX1o6SyBQiPXXJwfyj8EsIP4kLzhM9nFHBeuK HzeQlm/Rj1bCs7eH+QCi+meNtfGJryep6A5l/na3vQd6zDi8YjpsRvXAoZ1lYtnXlsZBv+8nw QO1hECIISo3oauJov/TJcX0eaAOvRZTrdCAidSmCiT5GuDyw6ZPEp3Zl9Wr/0Dh5wznz/w3Mv WBK8I/dLzXP09A5rNYQ0UIvukrzG7C/K9Q0AY2XYf0+X3KeEN+k4U8plWrY2kpJumklpJAy/P ibDhJ4wXqGwRUFPQe6diknc2nyp56Xup+Uj0eTd/eDft6+pj3knVW/OPwYfc7jeSO2ecdRDe4 zDamBJlhFndhm0QSAC4dXi+FOF8En3X1f8XI3umXO0oT8fjF5uvEkIYlOZuuQ8BOBYt2kLFy3 NcWnjNNvXT9CCxO7nTVttzhfJNYeO22TfpyRqBlWwK/5UbTR3eiLi/LyoRZro1SPXMLvJNeoc 6rOq0S+/gquKv4LZMv5v4T65QJeYMB07MY+5fo/0u9/UwN4nxUnTNA29xPrb3fEscWvD1gJsD kMOtA2s0tTt135woW10+rrsZT6cOX9ZfP2tKeTftVqKha8EY3vLN9XKVNahN5jTSKqOmrDoIW XUbH0WivY4Zn4Fv/ezRSM3Tt7u6iQw6rXdKAhhLEeE4zMTgtIzuxqlsMsQ8NgIuF6N65CY53F jx20pZs4kz6MqE5G8fjmYgbrVcTEdKUhy754U0Yj4win9rsfAoKprpFqePvADClVqBRYLu4hD hqmcRj6I3pwK5MFYfs+U7cxwkgMzE9jAWvhSBXykC7S+IUDoiHnKEOI/DiAQTajm7fx5KuHGn SchLvvXVLMupWqOCVTvNo392nyjDpVa61nM+egNEh3/jA1QpUJhqDZAhzIF0= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Am 15.09.19 um 15:12 schrieb Lars Ingebrigtsen: > Wolfgang Scherer writes: > >> + ;; FIXME this is a pcvs variable. >> + (if (bound-and-true-p cvs-sort-ignore-file) >> + (sort-lines nil (point-min) (point-max))) > Does it make sense to heed a pcvs variable here? I think it would be > surprising that vc-cvs behaves differently depending on whether you've > loaded pcvs or not. Just to clarifiy: my patch does not introduce this FIXME. Only the indentation is changed. This question should be handled in a separate bug report. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 22 07:43:25 2020 Received: (at 37215) by debbugs.gnu.org; 22 Jan 2020 12:43:25 +0000 Received: from localhost ([127.0.0.1]:49134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuFLx-0001vW-Dv for submit@debbugs.gnu.org; Wed, 22 Jan 2020 07:43:25 -0500 Received: from quimby.gnus.org ([95.216.78.240]:59372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuFLw-0001vJ-5y for 37215@debbugs.gnu.org; Wed, 22 Jan 2020 07:43:24 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iuFLn-0002v5-Ng; Wed, 22 Jan 2020 13:43:18 +0100 From: Lars Ingebrigtsen To: Wolfgang Scherer Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings References: <87imptwvoa.fsf@gnus.org> Date: Wed, 22 Jan 2020 13:43:15 +0100 In-Reply-To: (Wolfgang Scherer's message of "Sun, 5 Jan 2020 04:59:57 +0100") Message-ID: <87k15jy84c.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Wolfgang Scherer writes: > Am 15.09.19 um 15:12 schrieb Lars Ingebrigtsen: >> Wolfgang Scherer writes: >> >>> + ; ; FIXME this is a pcvs variable. >>> + (if (bound-and-true-p cvs-sort-ignore-file) >>> [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gmx.de] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Wolfgang Scherer writes: > Am 15.09.19 um 15:12 schrieb Lars Ingebrigtsen: >> Wolfgang Scherer writes: >> >>> + ;; FIXME this is a pcvs variable. >>> + (if (bound-and-true-p cvs-sort-ignore-file) >>> + (sort-lines nil (point-min) (point-max))) >> Does it make sense to heed a pcvs variable here? I think it would be >> surprising that vc-cvs behaves differently depending on whether you've >> loaded pcvs or not. > > Just to clarifiy: my patch does not introduce this FIXME. Only the > indentation is changed. This question should be handled in a separate > bug report. Right; sorry. Looking at the patch again, I don't quite get the logic here: > -(defun vc-cvs-ignore (file &optional _directory _remove) > - "Ignore FILE under CVS." > - (vc-cvs-append-to-ignore (file-name-directory file) file)) > +(defun vc-cvs-ignore (file &optional directory _remove) > + "Ignore FILE under CVS. > +FILE is either absolute or relative to DIRECTORY." > + (setq file (directory-file-name (expand-file-name file directory))) > + (vc-cvs-append-to-ignore (file-name-directory file) (file-name-nondirectory file))) This is basically (file-name-nondirectory (directory-file-name (expand-file-name "foo" directory))) isn't it? In what circumstances does that evaluate to something other than "foo"? That is, what DIRECTORY is doesn't seem to matter, if I'm reading this right? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 14:44:10 2020 Received: (at 37215) by debbugs.gnu.org; 30 Jan 2020 19:44:10 +0000 Received: from localhost ([127.0.0.1]:36265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixFjW-0006x2-Hw for submit@debbugs.gnu.org; Thu, 30 Jan 2020 14:44:10 -0500 Received: from mout.gmx.net ([212.227.17.21]:35207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixFjU-0006wn-Ny for 37215@debbugs.gnu.org; Thu, 30 Jan 2020 14:44:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1580413442; bh=96NcCPd7QEOiLCGo7I2q+OCYqk0QzpLt3ucjajVCVRk=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=FeWuubnjc3Xmfo39K9eeJ43zD3GH2ztuKanhQ8gt7nveu/U/opYyO+owJWeX2JYqx EgDtJSpAf7z87JCXHMllLosAVIbJFN88HGegCE10iP5HJ9IH+cYtW3XnKfRcNxuNRr c40l9r2GJjeBbX0J0QLuOXTp/+21V5R15eE5QJqo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MTzfG-1j5XDk1m6s-00Qx08; Thu, 30 Jan 2020 20:44:02 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id E0D02194310B; Thu, 30 Jan 2020 20:44:00 +0100 (CET) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Lars Ingebrigtsen References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> From: Wolfgang Scherer Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> Date: Thu, 30 Jan 2020 20:44:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <87k15jy84c.fsf@gnus.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: de-DE X-Provags-ID: V03:K1:H667lownjgiqOGOi7G1JkOZlTBzLgQtS+NoR+vRw1CS1pUH99LH atjXeDjrZawCxR3MjeaaKODF7MfmGMMBuAwfcpkFF9mO9PKTO6qdChrrlmkM7tHxhrCEXYY eoQGpzib569Lxg4f3GAN1VPMnxinOsKmuKArvtDZuQ0QzzMOtbuG3XP1/LipleALvp9/5Iy 1edCXP/WRFXkbCeir+VkQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:3MsczQjQOlU=:bxax7XGsx5SuN0PPWse06p c59RhoIMMh7Us36SuS50JHdwvUmkeN4cV/ALXvjmA+9OU/CiZ+ShCcKa4mHiuQh03n1wZtwDd gmybD9dyX6mfxrMir0hqO9H0814OLeLpjrmOcVXPP1r6ZLUZRc6rzZtLJ8HVSAlHNVCEcJqcG 29mQ9vEczkz47xZTWFZr6EqDWJA22KufnCtiHIQy7Y0PiF16eBvvbpVR1JmSU4Bifqa8jtV7a ZWduEVMMJ50XV2I/OX+5WQlbh1pFbd3TFli0q6f9YNCJSDQAM1ZU/at5S7geutdWD+BEPXg2m Ug7cm5VXsVJYPJd9z7wkmT9p/NDlxj3wBs0IcQ8sgETphf4Rs98x4/rUiT9MRpIKaQ7qAAQNV 7Ov3cE2k+n1f//zyKRG+62nKIq0i9w4FkbI+DsoBDqjI+eyI5A6ML7VnsvJg2UvqcGO/l0Rr7 IMYX/Sql+jVl/YsAUTPYojrxykbxN3BOm9BJymoNw2Z5SGD0TCpTqpZqXHZTQxWVwOBQzlZuE pb46AxuPrThB+7cuH5ic4Go1r0LhNZ9NKuclkY4wqKhopzSVyID6/n0xfV//ZeRbNno3oE/jR kvX/aLsWXoJ0mwK0XgxJ8fg7ZGnEyxwkiWqzKtqoIWEvRxq8NY6kRg5JDSxo7kzdmYMUJfZuO Pg6NgZBwn/rEUUwyi+P6f7EXfpzJXTLZSx80VZRC2q3HTXXCkoyy0ai34M88Fl59wvLtA1/4t RgbaS9xpcUNwbpuQsswCqxXj13KG6WqnbR8SMqiWGFNYYWhJ1YnMpX9uOfGpA9BNFskkFD4Wn jdW9wxxXhh54zlQ8aohkxV6jHK9Nmxgv2ujYu8d2OSdkh0f8fHhZw9ukaCC5BkQSq19YDLqNv M0IkkS82JD1+js0xYFiNAcbf2t8nbopsn9sChkGiFi/3USm51w/Lq5pQOANFoBBp02V7ZKi1q tzReAvSqrB3LcwcT7s6cPKIJkjLFg6WgdK5C+QKmccKpaWnD1ttmuoeohbzzFHTRAgV8XylEu mqUqI6b+dNmNYQr7W028e7uqObtTfkDryKwoaGEiBSPFs4Xrojb66sltK3EWgGVudkbsT1Jhh VDg+D00A8rLeVyEsTCXheOor/76diSrxYADJ9K9ADoAXNMngMgXLz/urRViV+K4ckVb/pZsrE 1SPnLprzIzYDqF024SyGVj+jaloMh2RYO0jEnCqIeYbaJkEauRBn9PI/o+GFvooxGhCLUiLsF wxjU6Ii8dsCz5D9OE X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Am 22.01.20 um 13:43 schrieb Lars Ingebrigtsen: > Wolfgang Scherer writes: > >> Just to clarifiy: my patch does not introduce this FIXME. Only the >> indentation is changed. This question should be handled in a separate >> bug report. > Right; sorry. Looking at the patch again, I don't quite get the logic h= ere: > >> -(defun vc-cvs-ignore (file &optional _directory _remove) >> - "Ignore FILE under CVS." >> - (vc-cvs-append-to-ignore (file-name-directory file) file)) >> +(defun vc-cvs-ignore (file &optional directory _remove) >> + "Ignore FILE under CVS. >> +FILE is either absolute or relative to DIRECTORY." >> + (setq file (directory-file-name (expand-file-name file directory))) >> + (vc-cvs-append-to-ignore (file-name-directory file) (file-name-nondi= rectory file))) > This is basically > > (file-name-nondirectory (directory-file-name (expand-file-name "foo" dir= ectory))) > > isn't it? It is for `file` equal to "foo" (a simple basename). > In what circumstances does that evaluate to something other > than "foo"? If "foo" is something other than a simple basename (see below). > That is, what DIRECTORY is doesn't seem to matter, if I'm > reading this right? Your assumption, that `file` is always a simple basename is wrong. (defun xx-vc-cvs-ignore (file &optional directory _remove) =C2=A0 "Ignore FILE under CVS. FILE is either absolute or relative to DIRECTORY." =C2=A0 (let* ((norm-path (directory-file-name (expand-file-name file direc= tory))) =C2=A0=C2=A0=C2=A0 =C2=A0(norm-dir (file-name-directory norm-path)) =C2=A0=C2=A0=C2=A0 =C2=A0(norm-file (file-name-nondirectory norm-path))) =C2=A0 (format "'%S\n'%S" =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (list :equal: (if (= equal norm-file file) "yes" "no ") =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 :file: norm-file :orig: file) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (list :equal: (if (= equal norm-dir directory) "yes" "no ") =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 :dir_: norm-dir :orig: directory)))) Default directory is "/home/ws/tmp/", home directory is also "/home/ws/". ;; (insert (format "\n;; 1)\n%s" (xx-vc-cvs-ignore "x-vc-repair.el" nil))) ;; 1) '(:equal: "yes" :file: "x-vc-repair.el" :orig: "x-vc-repair.el") '(:equal: "no " :dir_: "/home/ws/tmp/" :orig: nil) ;; (insert (format "\n;; 2)\n%s" (xx-vc-cvs-ignore "x-vc-repair.el" "/root= /emacs-init/.emacs.def/"))) ;; 2) '(:equal: "yes" :file: "x-vc-repair.el" :orig: "x-vc-repair.el") '(:equal: "yes" :dir_: "/root/emacs-init/.emacs.def/" :orig: "/root/emacs-= init/.emacs.def/") ;; (insert (format "\n;; 3)\n%s" (xx-vc-cvs-ignore "~/x-vc-repair.el" "/ro= ot/other-dir/"))) ;; 3) '(:equal: "no " :file: "x-vc-repair.el" :orig: "~/x-vc-repair.el") '(:equal: "no " :dir_: "/home/ws/" :orig: "/root/other-dir/") ;; (insert (format "\n;; 4)\n%s" (xx-vc-cvs-ignore "/root/emacs-init/.emac= s.def/x-vc-repair.el" "/root/other-dir/"))) ;; 4) '(:equal: "no " :file: "x-vc-repair.el" :orig: "/root/emacs-init/.emacs.de= f/x-vc-repair.el") '(:equal: "no " :dir_: "/root/emacs-init/.emacs.def/" :orig: "/root/other-= dir/") ;; (insert (format "\n;; 5)\n%s" (xx-vc-cvs-ignore ".emacs.def/x-vc-repair= .el" "/root/emacs-init/"))) ;; 5) '(:equal: "no " :file: "x-vc-repair.el" :orig: ".emacs.def/x-vc-repair.el"= ) '(:equal: "no " :dir_: "/root/emacs-init/.emacs.def/" :orig: "/root/emacs-= init/") =C2=8D From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 13 14:36:35 2020 Received: (at 37215) by debbugs.gnu.org; 13 Feb 2020 19:36:35 +0000 Received: from localhost ([127.0.0.1]:60499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2KHq-0007ki-Vm for submit@debbugs.gnu.org; Thu, 13 Feb 2020 14:36:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2KHp-0007kV-70 for 37215@debbugs.gnu.org; Thu, 13 Feb 2020 14:36:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2KHk-0004xl-0b; Thu, 13 Feb 2020 14:36:28 -0500 Received: from [176.228.60.248] (port=1327 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j2KHj-0003dw-86; Thu, 13 Feb 2020 14:36:27 -0500 Date: Thu, 13 Feb 2020 21:36:29 +0200 Message-Id: <831rqyqnya.fsf@gnu.org> From: Eli Zaretskii To: Wolfgang Scherer In-reply-to: <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> (message from Wolfgang Scherer on Thu, 30 Jan 2020 20:44:00 +0100) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Wolfgang Scherer > Date: Thu, 30 Jan 2020 20:44:00 +0100 > Cc: 37215@debbugs.gnu.org > > >> -(defun vc-cvs-ignore (file &optional _directory _remove) > >> - "Ignore FILE under CVS." > >> - (vc-cvs-append-to-ignore (file-name-directory file) file)) > >> +(defun vc-cvs-ignore (file &optional directory _remove) > >> + "Ignore FILE under CVS. > >> +FILE is either absolute or relative to DIRECTORY." > >> + (setq file (directory-file-name (expand-file-name file directory))) > >> + (vc-cvs-append-to-ignore (file-name-directory file) (file-name-nondirectory file))) > > This is basically > > > > (file-name-nondirectory (directory-file-name (expand-file-name "foo" directory))) > > > > isn't it? > It is for `file` equal to "foo" (a simple basename). > > In what circumstances does that evaluate to something other > > than "foo"? > If "foo" is something other than a simple basename (see below). > > That is, what DIRECTORY is doesn't seem to matter, if I'm > > reading this right? > > Your assumption, that `file` is always a simple basename is wrong. Yes, but when does it make sense to have FILE not absolute and not just a basename (i.e. with leading directories)? Do we have such use cases? Because if that happens, the file's name will be added to .cvsignore not in DIRECTORY but in one of its subdirectories. Would that be surprising? And if so, perhaps we should warn about that or even error out? From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 13 20:24:24 2020 Received: (at 37215) by debbugs.gnu.org; 14 Feb 2020 01:24:24 +0000 Received: from localhost ([127.0.0.1]:60710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2PiR-00059u-Mo for submit@debbugs.gnu.org; Thu, 13 Feb 2020 20:24:24 -0500 Received: from mout.gmx.net ([212.227.17.21]:36505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2PiP-00059e-9s for 37215@debbugs.gnu.org; Thu, 13 Feb 2020 20:24:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1581643454; bh=MMoSHBi1Fmis8Cz7IwVpN7yXF9Zr+4PGzhe5XBpPGrw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Ic5pubPsU+ivwkMqP8OmX3/VYnOOhDNkt+u9VewiVRQlXkVenLnYAGeeIlZTE1DtT R5AUSxuuv+rkEEPTUw5uF8u0T3VhvNFJmX/OsFXZ5bzlj44CcQIdLqNrowoMu4F1OX 9+1Lk/JmC9Fshc7A+x58HyvUCvG3zDVOlZ46Cn9w= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M1Ygt-1j4tcL2kxP-0036bB; Fri, 14 Feb 2020 02:24:14 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id 6382019431BD; Fri, 14 Feb 2020 02:24:12 +0100 (CET) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Eli Zaretskii References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> From: Wolfgang Scherer Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: Date: Fri, 14 Feb 2020 02:24:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <831rqyqnya.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: de-DE X-Provags-ID: V03:K1:5FPeZ+yxJf0TzpHjXStEakptdG6ywCeT0N/IeQO2A/IHoILOE5C 4CbZKd9ubr7E+RNilQvkCzhYM5Fb7H05ZuFsuojoQnGzswCBX0KN779PnShjtO3CCDaKIVh I2gVJQVZzAIdL66gF6k/8uzivVwRjOX9zopLkz+zfcArefEcX4oVYvaObBmdiEAZdJutCC7 zYuh/T6U607At9Wyo8QJw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:rGm9PD5huvI=:hfSlum/Ogu8DeV5oF2Jubn HXfmt8IrrxSu7pilqJUyBCg1qJGBWenDBSR++p/tvPEu+PKfgCI5m80E3doi+2R8KzjoaBxot 1oVU/dE19GxZOGzH6W0E+5ZuXbTrDxkzNczocA9Vn/xaGtc6IsBovOTACUw8Kyw5JenaodkC+ dbH2DpEX7Q+zKwwfZcAeLjnQMSnkDzv2eCtLe7Mcgniw65j4/b2wyQU7GuqYtG6LbE5jGD9u9 d0KwWjcdWjZBnNomY5xdGbGItsnslIm00RDmxIYhP/VCn4KLwuIpjYfVYgych+rBI0BomMTXj beb5mJfgu1TltquZijCyotvxZWgWes0EqYzclCkBQTOJLGvUhHYbHSz/j1jmdSMNQNyl6R3l1 xafeKhHnMlJT9+LNIrOPVlh6szTIiRLLE2EpVBKtVK8RTuhIfIxVs5UauM0/rE8iXSbq3a90U TGMVSXTryVM5F//xvgwA6t0slmgzouAc7mlOs+NGutR3NhgZMLKyzP3XZavA9I1nN0iW2eADd FL/uE7L7jfXZMP7nqcJkSQKleQsdaWrkIpMYTk4f9iuKiBRCrV05zMszVp2FqNsrIMlDXsKjV K2y3NzfOZpmiIrb9B/bpXdL6QYnq9C3ULC/qDIb65I1uOnvW5LQlMwgpuZbSwjZKsOLO4rHp/ +w6F1ICzJ4I/ORhjVD15aZS97wLXUjRhZ2JgvP77JeD5T6uVLQ+hGp6AJrRcInSpzSS0P38EE LvF7vtNj3+X18X3/+m550V0PPHRNYSXg4y9DfScp7ohAlFDBrYJfRV3kbDH5LicMU0jQdByYf 1vOmB8JE1G8MkVDkX7yiLa/OMjEIRqZGb0/n/cf2SHrEYLQwgD44ghsMIsZGnnpC75/rF3aaH uY7RSehlLCKXSDFqWOjgUMhksCOnv4aKOcO8vrE8knwsE6BWoqYd0Z8+a5bOyUzqC6iLa8RAU +EvBkRv1s5eQVmf0LF55SQwO+XLxsZubPzxYACkbMk6F7sZUXLVlvlESc8hQRor2OAqc9uLyK 6ZyA3xUjNQCWqjm7fqSYv72VuT/1BxruLM2ogwG0cAE/YUfMrVHxH12MwCmaraxeYkaFwaRvn XK35kicT08DNih/csBGVZa5Os4nZ/v07gjdmdk3d/PajFwONACEX+wzJdPVcND/v+/EtOr1Nr MdKwFQBr+fGoauG4b5EMFxUQ7bMJUhXlTDNHJrU1wc16Nlipb9bYhI/sUouNmc06MDCOADG3t bjMDjylnne1gGryXU X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Am 13.02.20 um 20:36 schrieb Eli Zaretskii: >> From: Wolfgang Scherer >> Date: Thu, 30 Jan 2020 20:44:00 +0100 >> Cc: 37215@debbugs.gnu.org >> >>>> -(defun vc-cvs-ignore (file &optional _directory _remove) >>>> - "Ignore FILE under CVS." >>>> - (vc-cvs-append-to-ignore (file-name-directory file) file)) >>>> +(defun vc-cvs-ignore (file &optional directory _remove) >>>> + "Ignore FILE under CVS. >>>> +FILE is either absolute or relative to DIRECTORY." >>>> + (setq file (directory-file-name (expand-file-name file directory))= ) >>>> + (vc-cvs-append-to-ignore (file-name-directory file) (file-name-non= directory file))) >>> This is basically >>> >>> (file-name-nondirectory (directory-file-name (expand-file-name "foo" d= irectory))) >>> >>> isn't it? >> It is for `file` equal to "foo" (a simple basename). >>> In what circumstances does that evaluate to something other >>> than "foo"? >> If "foo" is something other than a simple basename (see below). >>> That is, what DIRECTORY is doesn't seem to matter, if I'm >>> reading this right? >> Your assumption, that `file` is always a simple basename is wrong. > Yes, but when does it make sense to have FILE not absolute and not > just a basename (i.e. with leading directories)? Do we have such use > cases? vc-dir-ignore with patch from #37240 > Because if that happens, the file's name will be added to > .cvsignore not in DIRECTORY but in one of its subdirectories. Would > that be surprising? Not for anybody familiar with CVS. (Any other old-timers that can chime in= here?) > And if so, perhaps we should warn about that or > even error out? Certainly not. Here is a long explanation of what is going on: The latest patch to=C2=A0 vc-dir-ignore=C2=A0 (#37240) uses ewoc to get a = list of marked files.=C2=A0 The files in this list are relative file pathes and can also be in subdirectories. e.g.: =C2=A0=C2=A0 VC backend : CVS =C2=A0=C2=A0 Working dir: /re/po =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 ./ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unregistered=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 .cvsignore =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 edited=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 data =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 sub/ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unregistered=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 sub/.cvsignore =C2=A0=C2=A0 *=C2=A0=C2=A0 unregistered=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 sub/sub-file =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 sub/sub/ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unregistered=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 sub/sub/.cvsignore =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 edited=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sub/sub/data Pressing=C2=A0 G=C2=A0 while "sub/sub-file" is marked, initiates the call = chain =C2=A0vc-dir-ignore=C2=A0 =3D>=C2=A0 vc-ignore=C2=A0 =3D>=C2=A0 vc-cvs-ign= ore=C2=A0 with "sub/sub-file" as FILE argument. CVS has per-directory ignore files, which can only handle simple filenames without directory parts. I.e,, it is incorrect to write "sub/sub-file" into "/re/po/.cvsignore". Instead "sub-file" must be written into "/re/po/sub/.cvsignore" to have the desired effect. Therefore, it is necessary to expand the FILE parameter to =C2=A0=C2=A0 (directory-file-name (expand-file-name "sub/sub-file" "/re/po= ")) =C2=A0=C2=A0 =3D> "/re/po/sub/sub-file" And the resulting absolute file path can be used to determine the ignore file, which is located in the directory: =C2=A0=C2=A0 (expand-file-name ".cvsignore" (file-name-directory "/re/po/s= ub/sub-file")) =C2=A0=C2=A0 =3D> "/re/po/sub/.cvsignore" and the string that must be written to it is the basename: =C2=A0=C2=A0 (file-name-nondirectory "/re/po/sub/sub-file") =3D> "sub-file= " So, the algorithm is correct and I assume that anybody familiar with CVS would expect just that behavior. Citing from the CVS texinfo manual: =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CVS has a list of files (or sh(1) file name= patterns) that it should =C2=A0=C2=A0 ignore while running 'update', 'import' and 'release'.=C2=A0 = This list is =C2=A0=C2=A0 constructed in the following way. =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * The list is initialized to include certai= n file name patterns: =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [...] =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * As CVS traverses through your directories= , the contents of any =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 '.cvsignore' will be appended t= o the list.=C2=A0 The patterns found in =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 '.cvsignore' are only valid for= the directory that contains them, =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 not for any sub-directories. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 13 21:50:42 2020 Received: (at 37215) by debbugs.gnu.org; 14 Feb 2020 02:50:42 +0000 Received: from localhost ([127.0.0.1]:60747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2R3y-0007Fv-CR for submit@debbugs.gnu.org; Thu, 13 Feb 2020 21:50:42 -0500 Received: from mout.gmx.net ([212.227.17.20]:39109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2R3x-0007Fg-4c for 37215@debbugs.gnu.org; Thu, 13 Feb 2020 21:50:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1581648634; bh=a2jijP8hSVXmPWUK/2/wKcTAiKPv5/A/A0dzT2+CFK4=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=QbKzEfR/PVOzYCLKUoV/0nWTx/LMJ/mDZHb7Sm0lePJBUjyPU7KHkgfUZH/CoqwoT Y5iokpjrof9aUHShsGW+9Rt5eVJfBJO7A7ZZNIzAR/b/Il4vIlQAttdYJHljXpt/t1 dmwf2DpHxv/VL2Tkot5A7HeA+6stOfqbA8PQqQl0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MtwYu-1jLKr81OA8-00uJ5q; Fri, 14 Feb 2020 03:50:34 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id D423419431D9; Fri, 14 Feb 2020 03:50:32 +0100 (CET) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Eli Zaretskii References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> From: Wolfgang Scherer Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: <6b666912-f0e4-77cc-989a-0518d1742fb5@gmx.de> Date: Fri, 14 Feb 2020 03:50:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <831rqyqnya.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: de-DE X-Provags-ID: V03:K1:DP0qmgKhV98iuf4z0nSA/fwxJgDb9b+agX6IQpnMJ3denaS9Swi PO7tvptPAn22IJukH52JCHBpmDnF9H28/MmE9jIAKzmec98sEUEujOCPYmkHJB818cq2RdI CIQsHol8i31zYbmog3Xph/WaYLMMx4NmqXTBtDROCETCMoD1b5qxLRpuNGqMarwb/Q9uXhF ez/ldWvu6wFSCFviWsF8w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:D4ws1yE5dWw=:Y4Vmu7798LhOTaTBFQU3V1 LpPBpQlz1F7NRryYGiJTdYRElLWu+t7xIKHnGQDrVpGk+RyfLxQ7vuJyoWCdb3pz80LNEygVZ i0uY0TyHfjoNSHfkDz3cQowM3s4tnnScc8OYt45CfTCO5WO6K0hcgV74hu+IhN+bleTg5VZb4 8DYrPsvyYKIGmcaUKn8Me1B61FhApMKoqy7AimhxZgPv710CBXNb7XXkv3scbpEvQBB0hpD7S 0e94x+VDRVSIes+VO9uwrWJCGkr4JVvypZezaPQgSATDqZRKr5vWEVXV2bSbztB/GCsx3Uca2 YQEZFn6z35cpfVa9wMcb+MNPuJdNNySgXBWjuVcINwkZPgOWmVv/DdUdZCWgnquiuVWewP9Dw H/FGTZwdGMHVecSON/tTMW8vFqsKeiQLLUcE/GUYAuIkHv/gi2zESE7URytk7fSj7CrD10hvX OFw9ZjonnuAcRZE4v1h1H0CEI9QPcYYn13S9npGIiRkGeD5ZsCMNOd+LhG+iu4gOdvRkkatKy 2AO0l+Ensjw9pNIx33XRAIK+8Pq5Mh9TQyw+xz6LZQyYQFEKuNX/LNUbg3JfdGSVIruU0sGAE Ql5iaDxu8/wtIJf/xoyOLBd6JYuaVA7ZGVWhv0ys++5ncSGJet8eZw5UNnLPEySNEA7kuaU4G kBH7wkHEZBqSjMuCf9V9ZVPfrIhQYNeX5RaLHmbbm7D++1g9cbnBgg5dkU8MuHjY/pQKMoRJ1 kwmTFV4QFp9ZgMJAGVu58VFXU80gCN3AXr4cgFChZU5tHrvxOnyU0m+RHNMxdAHEcYClC8pmr PVcl3aJRHi+jbD68w6AHZxbx4j+TmAfs3c1GbhW88sfLpQFmAVFr5F29VgoL3ECHNejUMfha6 Lgv1hnysxO6pLX4qlfUKHoGnOy2fgZfeo8sN3HXrf2uH6tAAmwQ2WLibaC2+LLcz77NXfFVUm 3aTLaOi3EXY0b1jE1k2kKOlUx0d5GE0yHHXHEEkr6CNmtUh/UdcKnvHg0ZOquC8qFzYB+5DJM uccN1yqdkkkfug8V2BRlgPI6rdbaV6DgbrB1xLAt8pHOe1FmAaLHKx6jgwbBmvfCAu7bxP5x+ 0RAvDOtaw0vYyMV4hab0ee/T/zPcz2No4Bn5ZH5Tcxi+nABd4zhnp/f3Ck32fOs/p/aLWv+fj 1PS4P8LaFQVcttt5asQ+y9BvwYs36zfbx9/M7JHmEpD8bwAzGQghkOZRjKLroIged9s3stv8h +ISuCIDpjXGTyRdln X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Just FYI, this is the function that writes absolute path names into the .cvsignore file when called with an absolute path name, which happens if there are no marked files in a vc-dir-mode buffer and `G` is pressed. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 03:33:53 2020 Received: (at 37215) by debbugs.gnu.org; 14 Feb 2020 08:33:53 +0000 Received: from localhost ([127.0.0.1]:60810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2WQ5-00078W-9s for submit@debbugs.gnu.org; Fri, 14 Feb 2020 03:33:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2WQ3-00078K-8l for 37215@debbugs.gnu.org; Fri, 14 Feb 2020 03:33:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2WPx-0008Dh-V6; Fri, 14 Feb 2020 03:33:45 -0500 Received: from [176.228.60.248] (port=4789 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j2WPw-0005lS-LN; Fri, 14 Feb 2020 03:33:45 -0500 Date: Fri, 14 Feb 2020 10:33:48 +0200 Message-Id: <83pnehpnyr.fsf@gnu.org> From: Eli Zaretskii To: Wolfgang Scherer In-reply-to: (message from Wolfgang Scherer on Fri, 14 Feb 2020 02:24:12 +0100) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Cc: larsi@gnus.org, 37215@debbugs.gnu.org > From: Wolfgang Scherer > Date: Fri, 14 Feb 2020 02:24:12 +0100 > > >> Your assumption, that `file` is always a simple basename is wrong. > > Yes, but when does it make sense to have FILE not absolute and not > > just a basename (i.e. with leading directories)? Do we have such use > > cases? > vc-dir-ignore with patch from #37240 OK, but then please document this use case and how DIRECTORY is used in this function. The various -ignore functions in vc.el and in backends assign different semantics to their DIRECTORY argument, and I think these (largely undocumented) differences are a source of some confusion and bugs in this area. > > Because if that happens, the file's name will be added to > > .cvsignore not in DIRECTORY but in one of its subdirectories. Would > > that be surprising? > Not for anybody familiar with CVS. This should be documented, IMO. The existing documentation of .cvsignore is minimal, and doesn't mention several important aspects. For example, the fact that only basenames are allowed is only hinted upon, and there's no information whatsoever AFAICT whether characters special to wildcards can be escaped. So I think we should provide this minimal information either in doc strings or at least in comments in the code. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 03:39:25 2020 Received: (at 37215) by debbugs.gnu.org; 14 Feb 2020 08:39:25 +0000 Received: from localhost ([127.0.0.1]:60815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2WVQ-0007G4-VQ for submit@debbugs.gnu.org; Fri, 14 Feb 2020 03:39:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2WVQ-0007Ft-CR for 37215@debbugs.gnu.org; Fri, 14 Feb 2020 03:39:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2WVK-0000Nm-S8; Fri, 14 Feb 2020 03:39:19 -0500 Received: from [176.228.60.248] (port=1153 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j2WVK-00068a-7k; Fri, 14 Feb 2020 03:39:18 -0500 Date: Fri, 14 Feb 2020 10:39:22 +0200 Message-Id: <83mu9lpnph.fsf@gnu.org> From: Eli Zaretskii To: Wolfgang Scherer In-reply-to: <6b666912-f0e4-77cc-989a-0518d1742fb5@gmx.de> (message from Wolfgang Scherer on Fri, 14 Feb 2020 03:50:32 +0100) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <6b666912-f0e4-77cc-989a-0518d1742fb5@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Cc: larsi@gnus.org, 37215@debbugs.gnu.org > From: Wolfgang Scherer > Date: Fri, 14 Feb 2020 03:50:32 +0100 > > Just FYI, this is the function that writes absolute path names > into the .cvsignore file when called with an absolute path name, > which happens if there are no marked files in a > vc-dir-mode buffer and `G` is pressed. That was the reason for the bug report, and the purpose of the changes that were installed, right? So it's quite obvious. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 04:24:54 2020 Received: (at 37215) by debbugs.gnu.org; 14 Feb 2020 09:24:54 +0000 Received: from localhost ([127.0.0.1]:60855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2XDS-0008Jw-9a for submit@debbugs.gnu.org; Fri, 14 Feb 2020 04:24:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2XDQ-0008Jk-NE for 37215@debbugs.gnu.org; Fri, 14 Feb 2020 04:24:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2XDL-0004rh-9C; Fri, 14 Feb 2020 04:24:47 -0500 Received: from [176.228.60.248] (port=3914 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j2XDK-0002NQ-P5; Fri, 14 Feb 2020 04:24:47 -0500 Date: Fri, 14 Feb 2020 11:24:52 +0200 Message-Id: <83eeuxplln.fsf@gnu.org> From: Eli Zaretskii To: Wolfgang.Scherer@gmx.de In-reply-to: <83mu9lpnph.fsf@gnu.org> (message from Eli Zaretskii on Fri, 14 Feb 2020 10:39:22 +0200) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <6b666912-f0e4-77cc-989a-0518d1742fb5@gmx.de> <83mu9lpnph.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Date: Fri, 14 Feb 2020 10:39:22 +0200 > From: Eli Zaretskii > Cc: 37215@debbugs.gnu.org, larsi@gnus.org > > That was the reason for the bug report, and the purpose of the changes > that were installed, right? So it's quite obvious. Sorry, I was wrong about it being installed, it seems. But everything else is correct. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 20:42:41 2020 Received: (at 37215) by debbugs.gnu.org; 15 Feb 2020 01:42:41 +0000 Received: from localhost ([127.0.0.1]:34920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2mTh-0006yV-3f for submit@debbugs.gnu.org; Fri, 14 Feb 2020 20:42:41 -0500 Received: from mout.gmx.net ([212.227.15.18]:41679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2mTd-0006yH-Ts for 37215@debbugs.gnu.org; Fri, 14 Feb 2020 20:42:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1581730951; bh=ppnlpsnrsaUgA205v1E2q/l3FoS2ijMP6rRtdZT4YNQ=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=K5LMpRsfPwrcmc4IWO1nKeY30DtlUKJkGK3YNpfKYNamS547oE1GOQyG64sRtNRNF gC8JbeuvXsEUC6PgVZiDZSKoPNseJ/hALbCGN3lHgTFmdV6H/2FXGqaCKhfn/Dka/y a5h4zdS1B/KmEkILir30xT4qUIPv2YvkW6dGoFq0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MORAa-1iq4Nt159a-00PuiU; Sat, 15 Feb 2020 02:42:31 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id 3B9F519431DD; Sat, 15 Feb 2020 02:42:29 +0100 (CET) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Eli Zaretskii References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> From: Wolfgang Scherer Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> Date: Sat, 15 Feb 2020 02:42:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <83pnehpnyr.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: de-DE X-Provags-ID: V03:K1:DFfqfOx4B1rqn8P72b+CaL4q1goF1pJM5f6u4EFpqjqui0t9qWd yha2PWwWFkuZC7Z5Wg11WpTmvLzrt8Zoe6mF+aMUVPGWmWh9ZbdXubJ7G8mPSkOAe/2FO77 m2gWYchEqQ5q2HtsuDZeXtTg7TAjCKJRwb4L4JLLnW/7Ok7uL4lOarg4/rUPmTQFsBklf72 o04i/cme5O48e8xqwvQeA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:xyOpcw6Y4kg=:BWpMUJb57wIFzg8xe1MHid oBv9MDWDypiBO30UhzM7/1uItHwfJ9qBdoOzoCCx14RfIzwH/IUlPjY+PBSDzZPgWnT1GAiTt cPIymKYejraiJV9upu/fXa+Idn2GelNAgC+JjebFTFlVcExIPf+X3YTUXDeJycBO3rzeOi3Yd 7TrHKKj3sEJqQJiwAFvHKrFBXTjeTtiVP4fVBKcECaz3B98n+B00GLpacD6mtEG3ZGRUcQTXJ Rr66whdvX8sdUSVeBmUdbJyLyDfDgvwQs2Kc5KfHcMMS7O6aVDWudrjDTJaQw8zDM0wOfLfOX Lt2RNpZtJtjSq+kEEY0Veq72SH34iPuRyIZZqjz9zOZvL573Dw+uL//Hc1qdgE9V7sGWWOIOk /3YGW+fp4UJ5yJTBrwC/P2ROQFv50xPgxq1nlIvjDwU3ZmUntIluVmXfcVKtCzLXZmejSND39 Rm48oedkZHQvI3/NgMg9BVH8zAlJhSLZy+oSGECBmpliDWNic0azBM2YXFbR2mthhMCT5hue+ +plMj9bs+yqesFhOnsxdgghr7cwxjhMYb2nd1UkmUL0xc/9v8CErOiePgOwU/CR5FrXvjD+vC Bz+4MUBxnW7zqEpzP+LO6mQhcDteb53Gr2Wk2ZjMvRx6EUkygP8xEmkkPK/qNOxv8UQrH1fiy eFzwNGf7UrxxO2d9XffM07f7iu9si/2sdaQXdslzULBV5bCb4wCG6h5xEq2KcxKhTW9RIfGfS C2t/lM7xWmMMOi2IORnMUsWUUs5nt5SB43dtfLrY6IBivbT7AQGXuKc8jZTHxsRZJVmHl66Cv Jaa/fFa3aRaEgZjEm90QqljvAEfUeq/vnuAw/n5GfdbhAWOqdEdy1y+ThhMprbFpIwY+rhVes GQ69TuYoZRGb3xOU/TFh2cphy2gfxYWoxmg8ToIe3Y61jSVXc5oLmhoUr7pN1KgSvdhh59UU1 nIk/nL+7lW3+ZAits/N9ktqjajYTveS4vmAWMGmgpwEr21yxjIcBLziRiEFjrKAk1CbVCZ6qn IuiAsnLAUDrvDJTWL2kU8A3vHoZrNwS1ZBTl0+xIYEwXgPIXwiTY3udmqxHg7J0HX2DT0fLQm Xan2LyArhRRpKUp8bTvOuoO/Q5fi9OP15EITJImrqpzo2/WkCHB2RvC+PkQBc9Kh+X3LnzJAo Y2oX97fDt2BLX5xu0Skfzd86BuCTT/xs4shMRTBp+MsxmOrLxxeBCoR61sb7ADH4ubcvNOiiT ffPq6iGkTYx8NZPTu X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Am 14.02.20 um 09:33 schrieb Eli Zaretskii: >> Cc: larsi@gnus.org, 37215@debbugs.gnu.org >> From: Wolfgang Scherer >> Date: Fri, 14 Feb 2020 02:24:12 +0100 >> >>>> Your assumption, that `file` is always a simple basename is wrong. >>> Yes, but when does it make sense to have FILE not absolute and not >>> just a basename (i.e. with leading directories)? Do we have such use >>> cases? >> vc-dir-ignore with patch from #37240 > OK, but then please document this use case and how DIRECTORY is used > in this function. The various -ignore functions in vc.el and in > backends assign different semantics to their DIRECTORY argument, and I > think these (largely undocumented) differences are a source of some > confusion and bugs in this area. This is one of the first errors I ran into and I know a lot more now, after doing the research. There is a problem with describing the use case, because *vc-cvs-append-to-ignore* has several of them. So I think it is best, that Dmitry comes up with an overall solution for *vc-ignore* - as he has planned - which would naturally solve this problem, too. Since CVS is a special case, because another package, PCL-CVS, is also involved, therefore increasing the danger that something breaks, I have put my findings at the end for your convenience. > >>> Because if that happens, the file's name will be added to >>> .cvsignore not in DIRECTORY but in one of its subdirectories. Would >>> that be surprising? >> Not for anybody familiar with CVS. > This should be documented, IMO. The existing documentation of > .cvsignore is minimal, and doesn't mention several important aspects. > For example, the fact that only basenames are allowed is only hinted > upon, and there's no information whatsoever AFAICT whether characters > special to wildcards can be escaped. So I think we should provide > this minimal information either in doc strings or at least in comments > in the code. As for the pattern syntax for CVS, it is following POSIX and is fully described in the man page for glob(7) including the escape mechanism with backslash. There is one quirk in the .cvsignore file parser, which breaks patterns not only at lines but also at other whitespace on the same line. It is therefore better to match a filename containing spaces with a `?` for each space character. As for the use cases: Besides **vc** there is also PCL-CVS (**pcvs**), which is also part of GNU Emacs. PCL-CVS handles strictly CVS, nothing else. When the *vc-ignore* feature was introduced, the function *cvs-append-to-ignore* was moved to `vc-cvs.el` and renamed to *vc-cvs-append-to-ignore*: ```elisp (define-obsolete-function-alias 'cvs-append-to-ignore 'vc-cvs-append-to-ig= nore =C2=A0 "24.4") ``` 1.=C2=A0 The sole PCL-CVS use case can be found in *cvs-mode-ignore*: =C2=A0=C2=A0=C2=A0 ```elisp =C2=A0=C2=A0=C2=A0 (defun-cvs-mode cvs-mode-ignore () =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Arrange so that CVS ignores the selected f= iles. =C2=A0=C2=A0=C2=A0 This command ignores files that are not flagged as `Unk= nown'." =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (interactive) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (dolist (fi (cvs-mode-marked 'ignore)) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (vc-cvs-append-to-ignore (cvs-f= ileinfo->dir fi) (cvs-fileinfo->file fi) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (eq (cvs-fileinfo->subtype fi) 'NEW-DIR)) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (setf (cvs-fileinfo->type fi) '= DEAD)) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (cvs-cleanup-collection cvs-cookies nil nil= nil)) =C2=A0=C2=A0=C2=A0 ``` =C2=A0=C2=A0=C2=A0 When *cvs-examine* is called in a CVS repository, PCL-C= VS creates a =C2=A0=C2=A0=C2=A0 buffer `*cvs*`, which looks simiilar to *vc-dir-mode*, = e.g.: =C2=A0=C2=A0=C2=A0 ```text =C2=A0=C2=A0=C2=A0 Repository : /re/po/root-cvs =C2=A0=C2=A0=C2=A0 Module=C2=A0=C2=A0=C2=A0=C2=A0 : check-cvs =C2=A0=C2=A0=C2=A0 Working dir: /re/po/check-cvs/ =C2=A0=C2=A0=C2=A0 In directory .: =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Unknown=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .cvsignore =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Modified=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 data =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 * Unknown=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 test2.xx =C2=A0=C2=A0=C2=A0 In directory sub: =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Unknown=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sub/.cvsignor= e =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Modified=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sub/data =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 * Unknown=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sub/test2.xx =C2=A0=C2=A0=C2=A0 In directory sub/sub: =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Unknown=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sub/sub/.cvsi= gnore =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Modified=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sub/sub/data =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Unknown=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sub/sub/test2= .xx =C2=A0=C2=A0=C2=A0 ``` =C2=A0=C2=A0=C2=A0 With `test2.xx` and `sub/test2.xx` marked, invoking =C2=A0=C2=A0=C2=A0 *cvs-mode-ignore* by pressing `i` to ignore the marked = files =C2=A0=C2=A0=C2=A0 -=C2=A0=C2=A0 writes "test2.xx" into `/re/po/check-cvs/= .cvsignore` =C2=A0=C2=A0=C2=A0 -=C2=A0=C2=A0 and "test2.xx" into `/re/po/check-cvs/sub= /.cvsignore`. =C2=A0=C2=A0=C2=A0 As far as I am concerned, this use case is sufficiently= documented =C2=A0=C2=A0=C2=A0 both in *cvs-mode-ignore* and *vc-cvs-append-to-ignore*= , which were =C2=A0=C2=A0=C2=A0 written to fit together. 2.=C2=A0 When *vc-cvs-append-to-ignore* was imported from **pcvs**, the =C2=A0=C2=A0=C2=A0 function *vc-dir-ignore* - when pressing `G` in *vc-dir= -mode* - =C2=A0=C2=A0=C2=A0 ```elisp =C2=A0=C2=A0=C2=A0 (defun vc-dir-ignore () =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Ignore the current file." =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (interactive) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (vc-ignore (vc-dir-current-file))) =C2=A0=C2=A0=C2=A0 ``` =C2=A0=C2=A0=C2=A0 only used the current file - not all marked files - and= sent the =C2=A0=C2=A0=C2=A0 absolute pathname effectively to *vc-cvs-ignore* =C2=A0=C2=A0=C2=A0 ```elisp =C2=A0=C2=A0=C2=A0 (defun vc-cvs-ignore (file &optional _directory _remove= ) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Ignore FILE under CVS." =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (vc-cvs-append-to-ignore (file-name-directo= ry file) file)) =C2=A0=C2=A0=C2=A0 ``` =C2=A0=C2=A0=C2=A0 As can be seen from *cvs-mode-ignore*, the invocation o= f =C2=A0=C2=A0=C2=A0 *vc-cvs-append-to-ignore* for the case of an absolute p= athname =C2=A0=C2=A0=C2=A0 should have been: =C2=A0=C2=A0=C2=A0 ```elisp =C2=A0=C2=A0=C2=A0 (vc-cvs-append-to-ignore (file-name-directory file) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (file-name-nondirectory file))) =C2=A0=C2=A0=C2=A0 ``` 3.=C2=A0 Pressing `C-x v G` to invoke *vc-ignore* interactively, prompts f= or =C2=A0=C2=A0=C2=A0 an absolute pathname FILE, which is described as: =C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 Normally, FILE is a wildcard specificatio= n that matches the files =C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 to be ignored.. =C2=A0=C2=A0=C2=A0 This actually works with the current implementation, if= FILE does =C2=A0=C2=A0=C2=A0 not contain any directory components. It does not work,= if the =C2=A0=C2=A0=C2=A0 default absolute pathname is sent as is (same use case = as with =C2=A0=C2=A0=C2=A0 *vc-dir-ignore*). So it seems the correct solution for all three use cases requires that *vc-dir-cvsignore* call *vc-ignore* in the same manner as *cvs-mode-ignore* calls *vc-cvs-append-to-ignore*: ```elisp (defun vc-dir-ignore () =C2=A0 "Ignore the current file." =C2=A0 (interactive) =C2=A0 (let ((fi (vc-dir-current-file))) =C2=A0=C2=A0=C2=A0 (vc-ignore (file-name-nondirectory fi) (file-name-direc= tory fi)))) ``` and *vc-cvs-ignore* just passes on both DIRECTORY and FILE: ```elisp (defun vc-cvs-ignore (file &optional directory _remove) =C2=A0 "Ignore FILE under CVS." =C2=A0 (vc-cvs-append-to-ignore directory file)) ``` However, this would mean that all modifications so far (except maybe for SVN) have to be mostly rolled back, which will lead to other problems. For my own needs, which is to cover the range of Emacsen from 22 to 26 and beyond, I have prepared a standalone extension package which is mostly independent from the:current defun:vc-ignore subsystem, It shows, that the problem can be solved and you are welcome to refer to the escape and anchoring mechanisms there [wolfmanx/vc-ign: Emacs VC ignore feature](https://github.com/wolfmanx/vc-ign). From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 15 02:44:24 2020 Received: (at 37215) by debbugs.gnu.org; 15 Feb 2020 07:44:24 +0000 Received: from localhost ([127.0.0.1]:34982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2s7j-0007Ue-MU for submit@debbugs.gnu.org; Sat, 15 Feb 2020 02:44:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2s7i-0007UQ-4P for 37215@debbugs.gnu.org; Sat, 15 Feb 2020 02:44:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2s7c-0000Le-De; Sat, 15 Feb 2020 02:44:16 -0500 Received: from [176.228.60.248] (port=2841 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j2s7b-0007Qs-VM; Sat, 15 Feb 2020 02:44:16 -0500 Date: Sat, 15 Feb 2020 09:44:23 +0200 Message-Id: <83imk8nvl4.fsf@gnu.org> From: Eli Zaretskii To: Wolfgang Scherer In-reply-to: <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> (message from Wolfgang Scherer on Sat, 15 Feb 2020 02:42:28 +0100) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Cc: larsi@gnus.org, 37215@debbugs.gnu.org, Dmitry Gutov > From: Wolfgang Scherer > Date: Sat, 15 Feb 2020 02:42:28 +0100 > > >> vc-dir-ignore with patch from #37240 > > OK, but then please document this use case and how DIRECTORY is used > > in this function. The various -ignore functions in vc.el and in > > backends assign different semantics to their DIRECTORY argument, and I > > think these (largely undocumented) differences are a source of some > > confusion and bugs in this area. > This is one of the first errors I ran into and I know a lot more now, > after doing the research. > > There is a problem with describing the use case, because > *vc-cvs-append-to-ignore* has several of them. So I think it is best, > that Dmitry comes up with an overall solution for *vc-ignore* - as he > has planned - which would naturally solve this problem, too. Since CVS > is a special case, because another package, PCL-CVS, is also involved, > therefore increasing the danger that something breaks, I have put my > findings at the end for your convenience. > > > >>> Because if that happens, the file's name will be added to > >>> .cvsignore not in DIRECTORY but in one of its subdirectories. Would > >>> that be surprising? > >> Not for anybody familiar with CVS. > > This should be documented, IMO. The existing documentation of > > .cvsignore is minimal, and doesn't mention several important aspects. > > For example, the fact that only basenames are allowed is only hinted > > upon, and there's no information whatsoever AFAICT whether characters > > special to wildcards can be escaped. So I think we should provide > > this minimal information either in doc strings or at least in comments > > in the code. > > As for the pattern syntax for CVS, it is following POSIX and is fully > described in the man page for glob(7) including the escape mechanism > with backslash. There is one quirk in the .cvsignore file parser, which > breaks patterns not only at lines but also at other whitespace on the > same line. It is therefore better to match a filename containing spaces > with a `?` for each space character. I'd like to install your patch, and I'd like to do it soon, so it makes it into Emacs 27. Can you please propose a modified patch which adds some minimal information about what's going on to the doc string and/or the comments around the code? IOW, I don't think we need any further discussions of this issue, we need a somewhat improved patch that explains more why its code is correct. Do you think you could provide such an improved patch? I don't think it's wise to make this patch wait for untangling the more general vc-ignore issues. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 15 07:55:21 2020 Received: (at 37215) by debbugs.gnu.org; 15 Feb 2020 12:55:21 +0000 Received: from localhost ([127.0.0.1]:35087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2wyf-0008Oy-Ff for submit@debbugs.gnu.org; Sat, 15 Feb 2020 07:55:21 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:50378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2wyd-0008Ol-Jw for 37215@debbugs.gnu.org; Sat, 15 Feb 2020 07:55:20 -0500 Received: by mail-wm1-f68.google.com with SMTP id a5so12782947wmb.0 for <37215@debbugs.gnu.org>; Sat, 15 Feb 2020 04:55:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CNEfZyy0Ux9N78QZ1/u1S3zwER5vLODxwxddVBkfFiU=; b=OCw7g1CztALfKXEiLKRtdGGg8lvKm1U7p7mqVoaeAu2F0u9DjWwrVvhX+edMyd4SQf biO3q8RhjikE2k+vrVhJRt2KBa+U/UFhjM8+Iaj/ti/h778u+RPlSBdTO7ZdwGMX2i0N llhQMUXRTQR3uf77JCG0fH0W6prctZzHF6Mv7N26pBKQVX2Nn6EEad4WnhPvbVNWuL5r JWLZti8VUDoDiiu9YlwPd/Q/X5KV7cHOLGsBBVgGtbEJ3XQE4aJLIem58aON9GzLbZAV Twe6+kWF83gw20CR5nPZYxXYHaNbEo5cUARc3geDkz0vZW6YEJ7svRXTTrK137tzpDUs EeEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CNEfZyy0Ux9N78QZ1/u1S3zwER5vLODxwxddVBkfFiU=; b=FDUc4f+dndk7AhqkeexKt8rrjl3b2qse/ZZCqm+wAw+II41cSxV0T2PMFWPiaRH+s+ 0oGla4OSVewxDAPACfYSM2AbB1uj0HK7K5OrVAr5TYHoxbrU/Wo+1NrlcIjgH10/H1Va 7ofqIYsuM995fB9FTI8wF6XeSoYqbTM8Ae5DBU300WCJWWHJpn8Cavei3nyHxrsCW88P r0St9LonRTx58kKeW/UugS56eDiUTYKQAq0cGmz3b1bqR8zYEIQxDDXUeJW9pXI7Likc +C0lrQcPOnBjxylHq6kwT8kCLIggEYBtrHNT06fhyxynlNdsZHDuDOkEgb2tY4hrCfYr Bqdw== X-Gm-Message-State: APjAAAXjjY0SCcxzPtNNlwOF8F7vjxzTnTbt37/NR2I/ze51D02c7+Rq xrO1yUfI0MFqYmiyh6FFV/QdtZm/ X-Google-Smtp-Source: APXvYqx1OQgLfoFHhoKWAkwH523nGf4jdh6CPBSCEWLTTSR+aNBJ/TOE2vW88pLNvMG5rgk8vgQvfA== X-Received: by 2002:a7b:cb97:: with SMTP id m23mr10370402wmi.37.1581771313489; Sat, 15 Feb 2020 04:55:13 -0800 (PST) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id z19sm10766757wmi.35.2020.02.15.04.55.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Feb 2020 04:55:12 -0800 (PST) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Eli Zaretskii , Wolfgang Scherer References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> <83imk8nvl4.fsf@gnu.org> From: Dmitry Gutov Message-ID: <5cece2fd-2389-f933-7d40-ac24a668fc50@yandex.ru> Date: Sat, 15 Feb 2020 14:55:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83imk8nvl4.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 15.02.2020 9:44, Eli Zaretskii wrote: > I > don't think it's wise to make this patch wait for untangling the more > general vc-ignore issues. And I'm hoping this patch will fit the current contract of vc-ignore (however imprecise it is), rather than the redesigned one. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 15 19:20:33 2020 Received: (at 37215) by debbugs.gnu.org; 16 Feb 2020 00:20:33 +0000 Received: from localhost ([127.0.0.1]:36605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j37fl-0005FS-8Z for submit@debbugs.gnu.org; Sat, 15 Feb 2020 19:20:33 -0500 Received: from mout.gmx.net ([212.227.17.21]:55995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j37fj-0005FE-Gm for 37215@debbugs.gnu.org; Sat, 15 Feb 2020 19:20:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1581812425; bh=S/bZQPFUD8drWozd/VHe4xCe8+CTH1t321ZUW7dQe2k=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=iNQbFHC1n/KqWSW4cR3Vi6vtxG5OvjZq0q1fUklSpBS+3vqw2uhOusMAI9ES3Ekj8 eWP2mto4A5T0OhKMJ9mSpT+fuIdCrio6p6UXR7TZVyfTLwDJ6/URdkTcWU4Fq11IOh 1rkH9k4UJxOMPDUFrsGB9QikyYl8GMwdR8kU+meM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MvK0X-1jKvbV3jPN-00rHgN; Sun, 16 Feb 2020 01:20:24 +0100 Received: from [192.168.33.54] (p57A0D234.dip0.t-ipconnect.de [87.160.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id DCE5A19431DF; Sun, 16 Feb 2020 01:20:23 +0100 (CET) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Eli Zaretskii References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> <83imk8nvl4.fsf@gnu.org> From: Wolfgang Scherer Autocrypt: addr=wolfgang.scherer@gmx.de; keydata= mQGiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OLQqV29sZmdhbmcg U2NoZXJlciA8V29sZmdhbmcuU2NoZXJlckBnbXguZGU+iGAEExECACAFAkb46IgCGyMGCwkI BwMCBBUCCAMEFgIDAQIeAQIXgAAKCRCFAq9xq9ddlenRAKDSHzk7esbwdo8uGVP8nZtdGA7/ yQCeLoBx4xTFASiFdNE7LQoSFAARRnC5AQ0ERvjoiBAEAIYtMI3MbwOLcnIYNjULsASH/S1/ +Opfu+PkG3sAp2uGvpsP/bOSmKixrWDLrt/ymKvcgXedzmHOy1kyzMbBjiAE0jkEYXQimFtQ Gp7qWKwv2yjVv/ItkBF3OyyHmImiCNE5FXUE1Wca4PZCi0PlX+s9OC237/dbFQpByiPY8YFT AAMFA/9JpA3jdLZZTx/jTo25JKpTo+lDsM8CGIF5gC4bgBBRl1SzNh30VfU7SWtjqBmYroch l2rdyZfUCvTTb3fyeB0mpfd2R1rLT1OGCEXOboSdXnlsCrH05j722VzCjJIfoQQSd/UmZ5sX 6HlM5CtBEDRNqT2Q8owJc9N6jseg9Ax52YhJBBgRAgAJBQJG+OiIAhsMAAoJEIUCr3Gr112V PD8AoLOsuiNuhk4Ud1WwhVhQE/XeYG+jAKDGKQ7JrNCdIjI2hD0OMe3qVAlkew== Message-ID: <1754727a-a31a-5437-c6f3-8e5e525d4da1@gmx.de> Date: Sun, 16 Feb 2020 01:20:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <83imk8nvl4.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Provags-ID: V03:K1:JCxwY0jTH9NGZwYxUwPrsVnbFQARFf7Z/6tIkWJ8eNRxcTlMxYC kUaxoK5R2vBg7uNenTxNJSzSgH+cWn/UnlQwXAiuqYbm2R+Xu379Q4UXSyVoT0olPt0TIrT zw6jwzwwf0BAiFQ+0DSud3pgwFIN3qfcPTgnrfFJaQMjEVjBymSmAJw79CXxu/nyXD9PYdc QbHXrpOy4Rc2RZxNe6tXQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:XvmXaBJrUFY=:z3TapHXqvBBGpi4HCxhzrr JpBSLxT1XrFDI+EwXsyEZMKzDa1GdOqc193uz1O0nC0lEps4uEVK3cchtZNGMC4iQEc++Cnwg Tjm0D9Fi+nlgMkHaexrdWj0AS6uQumEPfYI0sq0QqbBfsx01d0Yhgo02mKcsN4vIbBjl1e4Q/ SOEfY4Znygl58WNt1QUZgvOXdBizy4rkOE48GizwPb0Ejsc//A2tHPCk5pOmwYm2e5DrdYYtj RhWaGRvczIuZ0OpS6KziJp07uZv1zqZoBpbXUFjXi2hKQ0RqzO8S+rXLmjczil3yUbTfiTaIA x6u5xwHB7OsLrfxBpXicF7yjY8bFCwIF2ca73DQ2Dv4ApwA/vuN8+rap0JyWIxv3Uze/XOHkx 8IAajd9d7/TiwtJqZkz+9yEkAM5S0hNieNfgSMZzsTuovqpMxaftlBjnXn1EXUGnQhP8InTVw 5wpRVtUTdKat84S6F7QinWi0vlIb4K3Md0OKlvCWS+YQX10YkTITzJFsjjidA0GiTFmqKFVml rUZbdbX/qsTIWzb3STeeHLsiCyPnr4+dadAIf6+MCqJYPSENIPDQulOIjFTVrCoXroihK/0l1 kwsoC7OrNPHXTiaDiIcCWn3rAIQWAXE8r15XgpWx8+ElUZf79gkY/Mo6g+5CdNznEkKXFcmhP rlB4bBRnIgIQ5VVUfmo8Ndzv7U2zrHTyZhR1C2cWhJ6PiWidJx7fDQPxEOh0EITWRt7/JpHjB d3DpZCJcPUHlhL1vjsBZK211LPsNNQYoh+dUZlFDlBaGMrGjFMS+5FHmZwlQDmeJbUP8BLbOb vt1wqShzuvcp+zIx8RcrVO2KmCqs+XPXOEeQiQPT1TJ00u75VGaEYgNAun4blmtrTz5/x6rNZ +L/voayRVkIG4ShkfIG4wwmJk1RgJFaB9qCRhYo/ibl4YX7Cgkz539PpGP40YL0xwbr2Le9rR ol+9O25nJSMkJZt0ZwMLe22rLaMv4ZkLlZPtqTJnnGp0/i72+y13kYBvXSAE7fVsOrje06yRy ocOBtBVSzXBfJ67omAFy7F4ERTARUgaI7FGk/YZPods920YJDKjAN2/ONw2PfG2plM/VE95aR 5vmaEI6SNWfx/q0hH8EKSQylyYySCAB+kUDmf2ri1WwV01gRSL1MDLxA0nxbbo47EleWCb/nj G8t7DR51WLE3u+Nl52/zF4BPVUMaTmg2bBAD2SvVM7Wimd9R4PQZrZQQzskmNXkHTSt51Egwe 92PA31hW7AI1baqvr X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Am 15.02.20 um 08:44 schrieb Eli Zaretskii: > I'd like to install your patch, and I'd like to do it soon, so it > makes it into Emacs 27. Can you please propose a modified patch which > adds some minimal information about what's going on to the doc string > and/or the comments around the code? Will do, and I will keep it short. > > IOW, I don't think we need any further discussions of this issue, Definitely not. > we > need a somewhat improved patch that explains more why its code is > correct. Although it can't be 100% correct, I will try. > Do you think you could provide such an improved patch? Yes, some time on Sunday. > I > don't think it's wise to make this patch wait for untangling the more > general vc-ignore issues. OK. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 19 18:02:15 2020 Received: (at 37215) by debbugs.gnu.org; 19 Feb 2020 23:02:15 +0000 Received: from localhost ([127.0.0.1]:43575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4YMB-0000QF-Lh for submit@debbugs.gnu.org; Wed, 19 Feb 2020 18:02:15 -0500 Received: from mout.gmx.net ([212.227.17.21]:52321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4YM9-0000Pz-HO for 37215@debbugs.gnu.org; Wed, 19 Feb 2020 18:02:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1582153326; bh=TAFXMjXrDfETqCPFamjP+cvFOfNIJGSN1Z8EjOowpRw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=jMBEJ/EuOU5kc4HzxyzGM25U1wmQ3aNFDXwEuyGLU4IY2nH/nrnIUtCMdsrEXemj+ UF77JQnuxHmMuEvAD8VDaNTafrZhWt0lURAfQSmjhCxfCwAiiiQRjP1L2P/m/DrFIH c78ApfsaNOzM+DreDXaj6sw+dZchJOc6jlDRHrsU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfHEJ-1jg3tt3Gd1-00grEe; Thu, 20 Feb 2020 00:02:06 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id C634E19431E6; Thu, 20 Feb 2020 00:02:05 +0100 (CET) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Dmitry Gutov , Eli Zaretskii References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> <83imk8nvl4.fsf@gnu.org> <5cece2fd-2389-f933-7d40-ac24a668fc50@yandex.ru> From: Wolfgang Scherer Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: <2cf0b547-022d-7127-507a-82d52126e2cd@gmx.de> Date: Thu, 20 Feb 2020 00:02:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <5cece2fd-2389-f933-7d40-ac24a668fc50@yandex.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: de-DE X-Provags-ID: V03:K1:jBWJIHPzOZv+eu36uXbshLbLapaZMXeU44h/4186eoG1zNFjf5+ Hg4z3lEJvI96UIGm3y4Dmmew++8oNfzzsRylmbmP1rB5jwNiBrvOrrADrya6Qy7fBACvbHI UtHQi+eCfGk2jHNyn6RxLLCm3S85Sq/GQmQz3Vrss5QepJwA6437DT7UE3i5PIj4LOPM/jp geOGp01Rnc8gg9MmjNLSw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Jk+4kaVXe6U=:COqws3+qXC/J03QvvUYGNK kUNc87uqiYaaRJZK3dKnPh64vxC7P0hQRQaJyBMQo6ctaqmBrjAlLJJPrbAa7DrNs/Hf5DdtO kvyuXrTAjVP8pNuKIGdMS2C6kkwdtQlZSRwGvocYMSKZoDKtxOTdGfIWIChc958rIqwfUvw0r udAO9buSrxEnEQZrkYS9/ucpHLwyxNC2ufknbZWpCYmcIyfVwm+BK5YGpmQqpvP8zWj7+xtC4 As0Wk3xEn0+DSr28xVjj/K0oFLWjSMfDZ0JkFx8XfE+1MraseDCdKOhM8l14ffCzClChtEPN/ n9r1jj3gOc5xqoi8O1rtu9Rz/J2IPCAtV7jzkhKY7RWI4uCUSMC3/vj9YIuw1NFZZOr45jAbI M+snX+uK26r1VShRGlwso5GwnfCrpVIO8qEaJQTGsySj0SSZfxmlzOdL14dJeUZCt/eTxJEmC 6YOQhWzx4fOiqm/uEVaieV0I3J6JwYhs3Jpqabulqgg0DmHtmQ7eNwuTrIcSAyDSQmxmdwGjF 7k9M42eBLfav1r5QXo4asu8bhAWVrY3Qhkcd0CEOpHiSFP4PFYSQW44cGQLpR8uTpQf3vIsB/ NzVcfACbtyREY3hHuMpbzR9gIc53gSIDlHMLeTX3jKBV97yWYwGoImM9dj6TwWXP9y8ognFwR YQyFnjauKIjojdqxZB6rqGx5ocKeGnC2iUxLpTtQ31/E5R41PTyTNq6kta6iPJ/Zx9BbIf1hF 9Yr5+X61DR21WUlvg0QBPX+gz9dR4dfY9TD6hA8szEPjww2tJHloeUIHHafkxrYMi55M3op6I 17FqHWj/al05CjZnS63DM/FUuSA9WKqBrSUwpY0/6MIQAQv4go6TkmHOgZFK5BjPyc46gz8Hp yT1+thF/poSUtvHKX+x3e39qBUSKXYbVZsKqui9GSFL4me/qGBHdwRtnshVLxCk30pVuZBi7M AJ398t1dewiJWHSz1VVF9/hu26LIoB6yL1TYHND6lJUR6y+BfnETImUmJvleJIwBb/X3oiMDy kQDSxs2k1WunKgS8th5e80XV6cc4aZCFtC4WrfuL16KyhibvITMdEBLJUdlPIEIdb+h036Cr7 n1mc4FrPPNuTPD2Bwh+ybgyA8G1kDbFu8UZLttByLSEwb1mDeSO3T/cqrp41zwnKupC68f9en +LhWJLW6aZGWv/s87nKE8d1TldVuf4xaO/KZ0VwetHfOggzZiLfbvqM5Lgv0dHbi3PHN4AWFF wj0CJYHN/VTahiZZc X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Am 15.02.20 um 13:55 schrieb Dmitry Gutov: > On 15.02.2020 9:44, Eli Zaretskii wrote: >> I >> don't think it's wise to make this patch wait for untangling the more >> general vc-ignore issues. > > And I'm hoping this patch will fit the current contract of vc-ignore (however imprecise it is), rather than the redesigned one. Unfortunately, I have no idea, what that contract is. Could you state it for me? The attached patch fits the use case, where pressing "G" in vc-dir-mode sends a relative or absolute file path to vc-ignore, which passes it along to vc-cvs-ignore. The patch correctly identifies the ignore file and writes the correct filename part (basename). From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 19 18:06:20 2020 Received: (at 37215) by debbugs.gnu.org; 19 Feb 2020 23:06:20 +0000 Received: from localhost ([127.0.0.1]:43583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4YQ8-0000Wr-AK for submit@debbugs.gnu.org; Wed, 19 Feb 2020 18:06:20 -0500 Received: from mout.gmx.net ([212.227.15.15]:53879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4YQ6-0000We-6J for 37215@debbugs.gnu.org; Wed, 19 Feb 2020 18:06:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1582153572; bh=i3FwbI3liPXQntJKEHLzRY3XQl8wKl78hX4wFK0rICY=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=WcOjaBsum0Hfh8PEunQzbKksj50/PY2RilYUWZnt2/9JgT+5Nxh2tBw/BQP4k6gV3 VQURL9tFzs/dr0MYrogrobPq1HtSaofWIaPQj1xiaXO7dEcZp7qa7EHCqrPfuLQuXX d5Yz3G4J2ABxa/MvGoC9MyhH4/Y9JCzDC0l4o2jg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MtOGa-1jJJsr3fLi-00upR9; Thu, 20 Feb 2020 00:06:11 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id 3543A19431E6; Thu, 20 Feb 2020 00:06:11 +0100 (CET) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Eli Zaretskii References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> <83imk8nvl4.fsf@gnu.org> From: Wolfgang Scherer Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: <6aaa5f28-13da-e998-a2b5-3a52a97b9dde@gmx.de> Date: Thu, 20 Feb 2020 00:06:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <83imk8nvl4.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------F124554BCE15942068D249C9" Content-Language: de-DE X-Provags-ID: V03:K1:UNho++Azyg2vbmmeTgpi5gN9pWIrrB3mIoBAjI0emD1DLplRF/t KIwNIyk1IGqXsuSDYwTmpyIi/BLCQIezlYgU6w5VzdY3iO77qh6OFdisgWvi63LHkzeBtGZ T/rFtUlLwbY/Ye7spz4eDsjaEfHEYDJ6IvNelxLJLftE2WemRluMU/bwOK3O1PynwCR0nhF C+Rb3eU6AhlgfTgTSY3Pg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:iwQmGFFqX4s=:T9AG/W7YMer4+ZQKVn3byA TVffhXFSNi6Wn94PY+9wf4sgkj0dX2tw4HV86Iccdp3/NvVH46EwGoAXUz+KfQJfKQVieQPmb Dd74Md52QM7dMod6f/Ng5juj/e2mq2l9SJTW7lKBxg7jSkPGR/jt8Mz9n10OCLgplCQ4yZ7aP 1ERotEwq4bkwHXO2atui/KYHfGw5YGugn0dhNoSk2A2KvjeAhu/KHZMSA7B+3tnmvijoHE44D jUBXeDGIDskN8sr1nv5YR75tqc1CR6nQidIgr3pgLi+tvQSp6R7IdjwiszlRaa2c8vHUAmaDN aV6Dh+sMGfO7lh91zodlfpvvHkhg8LL8htbZEPE5ErTHETAt/5BirL/hZdViyhGY4zTCN+wl4 TJcd/7gxCl6z/ADa8BCK1zaicrApUPsfE1+9J2VVKWdyX+TUnMBYLV3GroGRaNlFZB3+vPsAk yUIe7dlf+4HG7GBahVkLlir55eWd1z/CXqrBJqxTotZtjJ5FwxHYW/Ro/jVFun3NRz+7i5hOZ RHyKFGY+29K0qHXZyAtxtGKLchBTf1QFeuAM9D3aFHJuUQUpFr+CqnbCmBQheNQwAjvZIQ+37 +ZBpfJBeWtTIO2ML+80430cGKCyc0IbhmbNFleirlBwIJwyXyi0BcjxRUvi62htpn/E2+Qz6z eqh9t8u5F8VbgQ3oJbFUi6AobkhIvePAS8csQk9XxnNeTXLbEGKy2NmGEz2tCapGJh0tQe9ou v7NWCmUwIrqMChkCAVhNDZIr4x9Mixe3lWyE+AKiZLJuw4/jGptO5ouvei6zWGu0Sq/cq5eH+ 1BkAIFSFgHmbIeSSnVRgXcb2zh+0fKINeupxf1D4pWKfzzs4B8QvDOuYLh669mligix5495JR YKZPsYI55VW2sWayjm5H6so2UjSquHfTJekb/eBB0iQbERzj3yP1a1OzjHLsbcR2s9FVZaBSk stGGlXzc5Yfl5x90RKxXFGXS666DIjuo+yeosD1Gd8kTPqOu/i7cZ5EW8YNpIpOn6MiET6Fnm P/Du+dkEWfWkSCigoyCy3ayokuq9UmPzgVnN5WUnKNeSAcynoiwDlJJ3j0W/TLn2bCn1Bao1E 5wjG7DcKMUVnSyuNvBgk1H+oIgawdowO6FgwTfc5fURXfW7+Eq+Q/simkvpUqOgZoVWLM8LiW HSQQ1JSz8A0PG+NXgI/oF3RIlUcYEkUT0n3OQKIWbsmE0l3Cw9q9f6bvoXrAOZcHyObEBGLhC LulcCNLiNuIXbtb/Y X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------F124554BCE15942068D249C9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Am 15.02.20 um 08:44 schrieb Eli Zaretskii: > > I'd like to install your patch, and I'd like to do it soon, so it > makes it into Emacs 27. Can you please propose a modified patch which > adds some minimal information about what's going on to the doc string > and/or the comments around the code? Here is the revised patch. I have cleared the FIXME issue mentioned by Lars and added commentary to what is going on. --------------F124554BCE15942068D249C9 Content-Type: text/x-patch; name="0001-Do-not-write-absolute-filenames-and-duplicate-string.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-Do-not-write-absolute-filenames-and-duplicate-string.pa"; filename*1="tch" =46rom 375bdad57a2b56c63722e1d93c1e1de13566e8a2 Mon Sep 17 00:00:00 2001 From: Wolfgang Scherer Date: Wed, 19 Feb 2020 23:53:10 +0100 Subject: [PATCH] Do not write absolute filenames and duplicate strings int= o .cvsignore MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * lisp/vc/vc-cvs.el: (vc-cvs-ignore) Expand filename correctly and pass on basename only. (vc-cvs-append-to-ignore) Do not write duplicate strings to .cvsignore. Addtional optional parameter SORT. (lisp/vc/pcvs.el) Call =E2=80=98vc-cvs-append-to-ignore=E2=80=99 with SORT= argument. =2D-- lisp/vc/pcvs.el | 4 ++-- lisp/vc/vc-cvs.el | 40 +++++++++++++++++++++++++++------------- 2 files changed, 29 insertions(+), 15 deletions(-) diff --git a/lisp/vc/pcvs.el b/lisp/vc/pcvs.el index dcba504..cb0494e 100644 =2D-- a/lisp/vc/pcvs.el +++ b/lisp/vc/pcvs.el @@ -106,7 +106,6 @@ ;; right now, it's killed without further ado. ;; - make `cvs-mode-ignore' allow manually entering a pattern. ;; to which dir should it apply ? -;; - cvs-mode-ignore should try to remove duplicate entries. ;; - maybe poll/check CVS/Entries files to react to external `cvs' comman= ds ? ;; - some kind of `cvs annotate' support ? ;; but vc-annotate can be used instead. @@ -1972,7 +1971,8 @@ This command ignores files that are not flagged as `= Unknown'." (interactive) (dolist (fi (cvs-mode-marked 'ignore)) (vc-cvs-append-to-ignore (cvs-fileinfo->dir fi) (cvs-fileinfo->file f= i) - (eq (cvs-fileinfo->subtype fi) 'NEW-DIR)) + (eq (cvs-fileinfo->subtype fi) 'NEW-DIR) + cvs-sort-ignore-file) (setf (cvs-fileinfo->type fi) 'DEAD)) (cvs-cleanup-collection cvs-cookies nil nil nil)) diff --git a/lisp/vc/vc-cvs.el b/lisp/vc/vc-cvs.el index 16566a8..00459e8 100644 =2D-- a/lisp/vc/vc-cvs.el +++ b/lisp/vc/vc-cvs.el @@ -1220,14 +1220,27 @@ is non-nil." "Return the administrative directory of FILE." (vc-find-root file "CVS")) -(defun vc-cvs-ignore (file &optional _directory _remove) - "Ignore FILE under CVS." - (vc-cvs-append-to-ignore (file-name-directory file) file)) - -(defun vc-cvs-append-to-ignore (dir str &optional old-dir) +(defun vc-cvs-ignore (file &optional directory _remove) + "Ignore FILE under CVS. +FILE is either absolute or relative to DIRECTORY. + +There is a CVS ignore file in each subdirectory. Patterns only +match files in the same directory. Since FILE can be a relative +filename with leading diretories, FILE is expanded against +DIRECTORY to determine the correct absolute filename. This path +is then used to determine the directory and the pattern for the +ignore file. + +Patterns follow glob(7) syntax. Special characters \"?*[\\\" are +escaped with a backslash." + (setq file (directory-file-name (expand-file-name file directory))) + (vc-cvs-append-to-ignore (file-name-directory file) (file-name-nondirec= tory file))) + +(defun vc-cvs-append-to-ignore (dir str &optional old-dir sort) "In DIR, add STR to the .cvsignore file. If OLD-DIR is non-nil, then this is a directory that we don't want -to hear about anymore." +to hear about anymore. If SORT is non-nil, sort the ines of the +ignore file." (with-current-buffer (find-file-noselect (expand-file-name ".cvsignore" dir)) (when (ignore-errors @@ -1236,13 +1249,14 @@ to hear about anymore." (not (vc-editable-p buffer-file-name)))) ;; CVSREAD=3Don special case (vc-checkout buffer-file-name t)) - (goto-char (point-max)) - (unless (bolp) (insert "\n")) - (insert str (if old-dir "/\n" "\n")) - ;; FIXME this is a pcvs variable. - (if (bound-and-true-p cvs-sort-ignore-file) - (sort-lines nil (point-min) (point-max))) - (save-buffer))) + (goto-char (point-min)) + (save-match-data + (unless (re-search-forward (concat "^" (regexp-quote str) "$") nil = t) + (goto-char (point-max)) + (unless (bolp) (insert "\n")) + (insert str (if old-dir "/\n" "\n")) + (if sort (sort-lines nil (point-min) (point-max))) + (save-buffer))))) (provide 'vc-cvs) =2D- 2.7.4 --------------F124554BCE15942068D249C9-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 04:31:23 2020 Received: (at 37215) by debbugs.gnu.org; 21 Feb 2020 09:31:23 +0000 Received: from localhost ([127.0.0.1]:46405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j54eZ-0004uP-DT for submit@debbugs.gnu.org; Fri, 21 Feb 2020 04:31:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j54eX-0004u9-JB for 37215@debbugs.gnu.org; Fri, 21 Feb 2020 04:31:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j54eR-0006YC-Sw; Fri, 21 Feb 2020 04:31:15 -0500 Received: from [176.228.60.248] (port=2743 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j54eQ-0005Tv-NG; Fri, 21 Feb 2020 04:31:15 -0500 Date: Fri, 21 Feb 2020 11:31:03 +0200 Message-Id: <83eeuojnhk.fsf@gnu.org> From: Eli Zaretskii To: Wolfgang Scherer In-reply-to: <6aaa5f28-13da-e998-a2b5-3a52a97b9dde@gmx.de> (message from Wolfgang Scherer on Thu, 20 Feb 2020 00:06:11 +0100) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> <83imk8nvl4.fsf@gnu.org> <6aaa5f28-13da-e998-a2b5-3a52a97b9dde@gmx.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Cc: larsi@gnus.org, 37215@debbugs.gnu.org, dgutov@yandex.ru > From: Wolfgang Scherer > Date: Thu, 20 Feb 2020 00:06:11 +0100 > > > I'd like to install your patch, and I'd like to do it soon, so it > > makes it into Emacs 27. Can you please propose a modified patch which > > adds some minimal information about what's going on to the doc string > > and/or the comments around the code? > > Here is the revised patch. I have cleared the FIXME issue mentioned by Lars and added commentary to what is going on. Thanks, this LGTM. Just a couple of minor nits, and we can install this. > (lisp/vc/pcvs.el) Call ‘vc-cvs-append-to-ignore’ with SORT argument. Please quote 'like this' in log messages, and try to avoid non-ASCII characters there (they are generally only necessary in people's names). > +Patterns follow glob(7) syntax. Special characters \"?*[\\\" are > +escaped with a backslash." I'd say "should be escaped" here, since this is a requirement for the argument passed to this function. Also, I'd mention that FILE can be a pattern, otherwise the reference to patterns might come as a surprise to the reader. > +to hear about anymore. If SORT is non-nil, sort the ines of the > +ignore file." ^^^^ Typo: should be "lines". > + (goto-char (point-min)) > + (save-match-data > + (unless (re-search-forward (concat "^" (regexp-quote str) "$") nil t) > + (goto-char (point-max)) You could use non-nil, non-t 3rd argument of re-search-forward, in which case the following goto-char would be redundant, right? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 05:16:30 2020 Received: (at 37215) by debbugs.gnu.org; 21 Feb 2020 10:16:30 +0000 Received: from localhost ([127.0.0.1]:46424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j55MD-0007zm-TP for submit@debbugs.gnu.org; Fri, 21 Feb 2020 05:16:30 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j55MC-0007zV-3D for 37215@debbugs.gnu.org; Fri, 21 Feb 2020 05:16:28 -0500 Received: by mail-wr1-f66.google.com with SMTP id w12so1363332wrt.2 for <37215@debbugs.gnu.org>; Fri, 21 Feb 2020 02:16:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wECUh1bwHz60ZRYEvVnHu5OC3s+da2ahLhwurgPley8=; b=pTKCew1LKQjdYR4uUPPjKFLVImFH6LF13+Dg4bCIDuIv0zGvbKSZtRjfiXNCWtuRKS Gy08MwMg/OARpyHyAwoWp71gZoGB/QVXJg6nbmW86PoqiV+fCvL7IK2TZof0F8RYd6f8 a2jWfMi0q5B1GGf0EtcrPhdLQ+dMU3sFfWYsVKZN8xZjKnw+o9PWGmcamIJVedRbASrx igc5kon4yXLl/Zn0sjDzQZJoa+KykmF8hYy8K90a516tYM/TXcXdX/g5G349/PxPB9uJ Kh/Gs9peecLu94vQ3Rb2/B1FZW33gvZl41JSfX/dDuQmn2Q7D9DeKOh8xtrKbIUMuYQi S+jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wECUh1bwHz60ZRYEvVnHu5OC3s+da2ahLhwurgPley8=; b=CI2BqEBqSQ2aiYC1bJ6sVXmBxeUKynS3hEBXKsJbg26Pa5SM2SpR7HLGzAsfEJWdSS 2tBsT8fk2SYzIh6TleYjQtMvSWd9TILkUWIBj8pG4crHaXNweISBFB4nrZACBYX3Y3De OlxUjcWCIiJv0tvJkXQAmzKIzOg6n52Au8q65Jlla2UbMYRBAVMXUp2VY1u0V/0b2tVr 2/6umb/9avr0edjHVFdiQITekiN5y0DYh9r++y+GyMSXdq0AZS2ie3EdwJ4ETS9iFCl4 HIslJXbCqji8AZUh7vdxPuOWAk/fWtQ26eYcy0qa+JdhY03Tsf/xirCx1K11QGzVKYhN vtLg== X-Gm-Message-State: APjAAAUb6cxRbdOpT6o9N3UkfjrRKNtseKID0QywAmREd/DxxyR0qMWV SskDWiaOypSS7ujIls4/mr8l36FV X-Google-Smtp-Source: APXvYqxAcYRD8fxHd1Io/fenevWHoPYBwqkKOuoPHg/MGGyHxt3l+E+eyDCuLyqn0N5rmy40jdfMZQ== X-Received: by 2002:a5d:4a8c:: with SMTP id o12mr46427736wrq.43.1582280181990; Fri, 21 Feb 2020 02:16:21 -0800 (PST) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id m21sm3049109wmi.27.2020.02.21.02.16.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Feb 2020 02:16:21 -0800 (PST) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Eli Zaretskii , Wolfgang Scherer References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> <83imk8nvl4.fsf@gnu.org> <6aaa5f28-13da-e998-a2b5-3a52a97b9dde@gmx.de> <83eeuojnhk.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Fri, 21 Feb 2020 12:16:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83eeuojnhk.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 21.02.2020 11:31, Eli Zaretskii wrote: > Also, I'd mention that FILE can be a pattern, otherwise the reference > to patterns might come as a surprise to the reader. And, if we accept the patch from a neighboring bug report, it will never be an absolute file name. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 15:32:16 2020 Received: (at 37215) by debbugs.gnu.org; 21 Feb 2020 20:32:16 +0000 Received: from localhost ([127.0.0.1]:48202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5Ey7-0004Dc-D1 for submit@debbugs.gnu.org; Fri, 21 Feb 2020 15:32:16 -0500 Received: from mout.gmx.net ([212.227.15.19]:47561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5Ey5-00048E-3H for 37215@debbugs.gnu.org; Fri, 21 Feb 2020 15:32:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1582317126; bh=u/BuKjR/FHrkjpq43m4zcsMmcS6UPO4SQ1Yiwr1nsWI=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=A43i/vPuX2ANQVm+JmvekB06+b/pdYbOb+JkieY0tCer38K9UpNPQVTJpBtUgGVmS 26U7ZuXbiP9sTkRv1DevvqEp56o1oFuPVry8bITijJulq9pODcEuyeOPjD56ORuQw6 mJcLxz32a/92ynYYRSAmdJ+a9wKx5bsAHhfC/KT0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M2f5Z-1j9Lpp25vz-004Axb; Fri, 21 Feb 2020 21:32:06 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id 2329919431F0; Fri, 21 Feb 2020 21:32:04 +0100 (CET) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Eli Zaretskii References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> <83imk8nvl4.fsf@gnu.org> <6aaa5f28-13da-e998-a2b5-3a52a97b9dde@gmx.de> <83eeuojnhk.fsf@gnu.org> From: Wolfgang Scherer Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: <686a6419-308c-6536-3996-7f534ca19346@gmx.de> Date: Fri, 21 Feb 2020 21:32:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <83eeuojnhk.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------C42801B66F07C163885B0A0B" Content-Language: de-DE X-Provags-ID: V03:K1:b0cA1VQm6XsOve+5IbntPkMKhnNS/OartfmRtArI2ppAxp/qyUX GX4luYVYEYuZoPj+1RHVu+JOFPMQc+0y5FIdIgRK3WI2SAS1PBr/nh2T+dF62KOEr1c+mf5 NYtKy8h63u6lls04+LNe4GyrPGYcYWqOCzA59P0V6lDj18MiAqMvskze5vz0E/HVeW+FLUC pEZO3b/V5av+ufk0uLtVg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:x9aZqyGkOTI=:BnF2ZaVMNOfo0kF3l3o6NS d1QpzPgQUDLDG91g2M+olH94R2+IABvT2SUNSqz38uglFl03lHNBoAsh6JBweY3Y28i87vt1r mq47DaMDe+QwHWs45D6yi2xHrV+3NSOsCKrWc6ckoCpsD3ZCZ9kNO3vU4qLCr7vFxMHHx+PJE 4D6AXhcOGSrwyAztEq4QWC9EepLknp3ZQBvLJXr205AiDUr7PHtyImKi6c32SEaX1NAONLKf0 /Er8+yGSy7tNpzBEivn/CpOYzTdID0f75g7Zia15ZODpR36XlFMiIEU5IXCxnvUJR33LN1V0i k+rSEe1sNoDZ1ijIb1WBYgvdSKrd6L8QD0eE8QPjp0N4mJ3TsXM/BbJVJud5YGobbR/B2ViSd FPKW/KF16nq2Nlb0HQ/KULSMPi2n6iZfyiWnffovz/X8yTf54f1cn52fqPmiGxxtG5H44RhtM 9eODoddJnUu6ej5FfgIqd9Ep8Zk2CrQU5nSSzS5CiPds1YmAMwCWhOJjCjKBzSQu+8SOobNRy u6feLVvVQ0Cx4Cd1I/7Kq4+FBI21vhXy1lp2I1Ywwle1ju+B/gnMeicrv3h7EhJXjOxOu4vDo DQwB5hZPdsx1A6QjzGU0EUn+cmMwO124tJ+oH2TlHZ7CmHH4iuXpSdyMeEiTGzFtzQJSXoGNx z/srmgfkY9DdYTpT3/NnMku7/P9Rac+0U84F0BWmwt2mBsWlYv4koMGs28ppAVsH9jFCHg7KD D9RQnKmzU3+A7QOyouiJEx53lxF0qURw7uDX99Cl2xT4o0gS+kNQr7w9K0d4etjFJ/0vmG8V2 hxNlIAPeMSdhXbC8L0nBKhZZE7Y752U5B/ufkyx8j4vBaLWUi5h5x5efe4ZDMGLLRu9WZ9v0d LirDIpBn8DIgnCnIXvTSpnRGEL3ZTmFS85odzgJEN6XxxNtRUa/UQQ7UVUsEyuTxi0wsa5LXP Yhe4On/CW0uMHKI5RLORI13qfsBzb2FTVXQggrPikchHBPQABdipsf3IIhVY13jIuZuThh1tw /H+5sYJlcFtrJck+F3xBKzLR4tn+dnVRRNSIu4ejHip/C+/4TX70X44GCkSpWpcMjBvtBGwnV eqfoehDjhDfhXIHRQK1yNj3cCMbRff4RuuI7LtPSgwX22WL+xzCN3MyO65bgR+mEeB6dMgxSh r0pYjkes8VxsPIyfEi9GrRnjcRuxqSw0UFOTkNAIX8EI5jIby4ZdjrYDEcOb7XkLT1NNL+fg8 HfYKjdfN00xv0hr0j X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------C42801B66F07C163885B0A0B Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 21.02.20 um 10:31 schrieb Eli Zaretskii: >> Cc: larsi@gnus.org, 37215@debbugs.gnu.org, dgutov@yandex.ru >> From: Wolfgang Scherer >> Date: Thu, 20 Feb 2020 00:06:11 +0100 >> (lisp/vc/pcvs.el) Call =E2=80=98vc-cvs-append-to-ignore=E2=80=99 with S= ORT argument. > Please quote 'like this' in log messages, and try to avoid non-ASCII > characters there (they are generally only necessary in people's > names). OK >> +Patterns follow glob(7) syntax. Special characters \"?*[\\\" are >> +escaped with a backslash." > I'd say "should be escaped" here, since this is a requirement for the > argument passed to this function. Here is that amgbuity again ;-). It is only required, if the user wants a special character to match literally. It's perfectly fine to specify=C2=A0 *.pyc=C2=A0 as a pattern. I have phrased it like that. > Also, I'd mention that FILE can be a pattern, otherwise the reference > to patterns might come as a surprise to the reader. I emphasized more, that the basename of the FILE argument (not the entire FILE) is in fact a CVS ignore pattern.=15=04 >> +to hear about anymore. If SORT is non-nil, sort the ines of the >> +ignore file." ^^^^ > Typo: should be "lines". Right. >> + (goto-char (point-min)) >> + (save-match-data >> + (unless (re-search-forward (concat "^" (regexp-quote str) "$") n= il t) >> + (goto-char (point-max)) > You could use non-nil, non-t 3rd argument of re-search-forward, in > which case the following goto-char would be redundant, right? Right, I just left the=C2=A0 goto-char=C2=A0 in there, because it makes it obvious what is going on. Switching to the side-effect optimization ... --------------C42801B66F07C163885B0A0B Content-Type: text/x-patch; name="0001-Do-not-write-absolute-filenames-and-duplicate-string.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-Do-not-write-absolute-filenames-and-duplicate-string.pa"; filename*1="tch" =46rom edea70777b81f745b86f812c7ca2e0021a9ecb83 Mon Sep 17 00:00:00 2001 From: Wolfgang Scherer Date: Fri, 21 Feb 2020 21:28:11 +0100 Subject: [PATCH] Do not write absolute filenames and duplicate strings int= o CVS ignore files * lisp/vc/vc-cvs.el: (vc-cvs-ignore) Expand filename correctly and pass on basename as pattern only. (vc-cvs-append-to-ignore) Do not write duplicate strings to .cvsignore. Addtional optional parameter SORT. (lisp/vc/pcvs.el) Call 'vc-cvs-append-to-ignore' with SORT argument. =2D-- lisp/vc/pcvs.el | 4 ++-- lisp/vc/vc-cvs.el | 45 ++++++++++++++++++++++++++++++++------------- 2 files changed, 34 insertions(+), 15 deletions(-) diff --git a/lisp/vc/pcvs.el b/lisp/vc/pcvs.el index dcba504..cb0494e 100644 =2D-- a/lisp/vc/pcvs.el +++ b/lisp/vc/pcvs.el @@ -106,7 +106,6 @@ ;; right now, it's killed without further ado. ;; - make `cvs-mode-ignore' allow manually entering a pattern. ;; to which dir should it apply ? -;; - cvs-mode-ignore should try to remove duplicate entries. ;; - maybe poll/check CVS/Entries files to react to external `cvs' comman= ds ? ;; - some kind of `cvs annotate' support ? ;; but vc-annotate can be used instead. @@ -1972,7 +1971,8 @@ This command ignores files that are not flagged as `= Unknown'." (interactive) (dolist (fi (cvs-mode-marked 'ignore)) (vc-cvs-append-to-ignore (cvs-fileinfo->dir fi) (cvs-fileinfo->file f= i) - (eq (cvs-fileinfo->subtype fi) 'NEW-DIR)) + (eq (cvs-fileinfo->subtype fi) 'NEW-DIR) + cvs-sort-ignore-file) (setf (cvs-fileinfo->type fi) 'DEAD)) (cvs-cleanup-collection cvs-cookies nil nil nil)) diff --git a/lisp/vc/vc-cvs.el b/lisp/vc/vc-cvs.el index 16566a8..b6afda6 100644 =2D-- a/lisp/vc/vc-cvs.el +++ b/lisp/vc/vc-cvs.el @@ -1220,14 +1220,33 @@ is non-nil." "Return the administrative directory of FILE." (vc-find-root file "CVS")) -(defun vc-cvs-ignore (file &optional _directory _remove) - "Ignore FILE under CVS." - (vc-cvs-append-to-ignore (file-name-directory file) file)) - -(defun vc-cvs-append-to-ignore (dir str &optional old-dir) +(defun vc-cvs-ignore (file &optional directory _remove) + "Ignore FILE under CVS. +FILE is either absolute or relative to DIRECTORY. The basename +of FILE is written unmodified into the ignore file and is +therefore evaluated by CVS as an ignore pattern which follows +glob(7) syntax. If the pattern should match any of the special +characters =E2=80=98?*[\\\=E2=80=99 literally, they must be escaped with = a +backslash. + +CVS processes one ignore file for each subdirectory. Patterns +are separated by whitespace and only match files in the same +directory. Since FILE can be a relative filename with leading +diretories, FILE is expanded against DIRECTORY to determine the +correct absolute filename. The directory name of this path is +then used to determine the location of the ignore file. The base +name of this path is used as pattern for the ignore file. + +Since patterns are whitespace sparated, it is usually better to +replace spaces in filenames with question marks =E2=80=98?=E2=80=99." + (setq file (directory-file-name (expand-file-name file directory))) + (vc-cvs-append-to-ignore (file-name-directory file) (file-name-nondirec= tory file))) + +(defun vc-cvs-append-to-ignore (dir str &optional old-dir sort) "In DIR, add STR to the .cvsignore file. If OLD-DIR is non-nil, then this is a directory that we don't want -to hear about anymore." +to hear about anymore. If SORT is non-nil, sort the lines of the +ignore file." (with-current-buffer (find-file-noselect (expand-file-name ".cvsignore" dir)) (when (ignore-errors @@ -1236,13 +1255,13 @@ to hear about anymore." (not (vc-editable-p buffer-file-name)))) ;; CVSREAD=3Don special case (vc-checkout buffer-file-name t)) - (goto-char (point-max)) - (unless (bolp) (insert "\n")) - (insert str (if old-dir "/\n" "\n")) - ;; FIXME this is a pcvs variable. - (if (bound-and-true-p cvs-sort-ignore-file) - (sort-lines nil (point-min) (point-max))) - (save-buffer))) + (goto-char (point-min)) + (save-match-data + (unless (re-search-forward (concat "^" (regexp-quote str) "$") nil = 'move) + (unless (bolp) (insert "\n")) + (insert str (if old-dir "/\n" "\n")) + (if sort (sort-lines nil (point-min) (point-max))) + (save-buffer))))) (provide 'vc-cvs) =2D- 2.7.4 --------------C42801B66F07C163885B0A0B-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 15:45:05 2020 Received: (at 37215) by debbugs.gnu.org; 21 Feb 2020 20:45:05 +0000 Received: from localhost ([127.0.0.1]:48225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5FAX-0004rZ-8g for submit@debbugs.gnu.org; Fri, 21 Feb 2020 15:45:05 -0500 Received: from mout.gmx.net ([212.227.15.19]:53275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5FAV-0004qo-GP for 37215@debbugs.gnu.org; Fri, 21 Feb 2020 15:45:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1582317897; bh=apmMwf7OQYPdh+CaxqfD6vmR9bIQsQTzwp7dZmBOgqg=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=IPS3BKUCQksZHNxUvuGXkwmKS/n+47W0+y0qukGgNtNcXY717UJa09Vyi//2Jw58/ 8NP8tfQIFPXyj1MJk04MhqZbHmbM/Ilk1EALINZ4lnmfbjQgxmJZmwANNGrvmz/d+m M6aZ4pCoKGYXkWLfxEGH2SVZb4CXBUaly2scQuaY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MRTN9-1ikZUT3xxt-00NUHH; Fri, 21 Feb 2020 21:44:56 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id 4825B19431F0; Fri, 21 Feb 2020 21:44:56 +0100 (CET) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Dmitry Gutov , Eli Zaretskii References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> <83imk8nvl4.fsf@gnu.org> <6aaa5f28-13da-e998-a2b5-3a52a97b9dde@gmx.de> <83eeuojnhk.fsf@gnu.org> From: Wolfgang Scherer Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: <0092bc25-f2aa-a6e1-e45b-dc08d5068a64@gmx.de> Date: Fri, 21 Feb 2020 21:44:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: de-DE X-Provags-ID: V03:K1:OBPcts0AUyrzm77I93HdenI0WYyFOGQ7mXeftXonrtmnivqGKVc K8y914J4YFZA2R/iC9fautYO7DAblFQEgxJI4MevwGG8VDzqMGooEZeDQohiC4Z++vnDH/i tM3RRJj854+jVyTVQtJddh90moBzREmF4gRIl+L1vF7u/XSsFNkx0E+gO/nlGPstcVVtDME iNC9PwG9YMXo9OgIYxRfg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:6PDYMp+phQk=:2idRT5VI7B5a4zLEAEI9pt oefic1//3hi4K9mRgAlPvV/lra3JSuXi/3rOODnTZ49iKpjcFLFJa/FyXQsj7edADezUNe9CP tDg9ESPVR0Sw8istSsbyTk53Mp74MXO/wVOnEmBXRo7tdWEplsfSXUkd9a6MC4XdSdOhFY0UB tNeJS0KrQ1K/JVwp6wYVAZBVjwtlfNzGh4UIa9AHI1IvyCJTe8INHJMeTHHqv3W/dyCSSfHqe 1tXulebQ7mQewnSU6/iM8WTH1pQRf1rTCmA0/G7eSv6vr1RyjJ1IJRFxNRCRGraG5sTyzgbOF CQ8lmKRX+mAzIWDSbou9y2Lu7EgNk6hLmtCKypGYjVM1On234aY3E5OKy5X8QCHJ+2RpBQVp4 6uLddbSqBKSq9U9DIDOUFvDGSLgd2tRefxHYKXT4SxXluZLKDG2U06gEpBbDwLuN46PnBnHq8 FMHZ2xQNfclef9fEZGVoFffP77R4dYD60Clz9G9LkpzezMcl7bYF9wktoyf9LXUmhsA6Kk2Mf XN6qXO7/wa4ZGWKESUiKSO50uKJZ5viGb4MC+j5WEriwBkgEB1jmev88WSVnpo0HNkowQDlb1 pP9M0PTyLzf2CejspvrvaFletd1ghqZcef25O/S/tLl5vyfFVVsYk6ZrryVigcjQCJ3h3v1/p fDgUxUpWA6tkhskhEiNzG313bdr3THSjgK5OOzmSjB7FYVacfF42ftX2tTlkDJv7EFSzzWa4u dO/8qwCO9l//VNBSV+M4yxrc+VnQEuKeQpWPnF6B5RbSkBVwZXqSZR+Vjqjt3sgOV1Gwt/B9s YhmHsRi1K1DISLyFi/w6lK8YIiiEJetOIyvWg85IXTH3/A7oSTWdwOBWa6CSGd1lyO2BlxlCW h9ZU3kuy9KhJk4wUkOliutzT3CC9e+hzqdbulju9JEem8Sl5uWmdUkuDTqd1q9EvyITfxmYut RcstLr1OaZh1P8Lh46bo31F4XxVj3m7IY3vB//j4o07bsA1ZAnQtxJyAGcdOYq4r62cz1kK6f jQRKbQ0N0Kyf/H9NEjxm1Qk6Lkz8WdSKf/Al8ycam6H7BRHEWurM3LIBLgsxguMsmgo0yv5oz WMdYXeBVWKhSgquKgnVJIOQxIoUqJSrpGnQeNv6RrvwMz6gzzB/VGt8e9+svmzAlO7PWv8FMm 0kEs5UbGXhZ2I9/epCU7zRQK4DLILQJ+FCWivq2JNCNeD2be4oWO5bfrTBS9dCulZWtebhBeQ cx9mkPXipJZHPnAA7 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Am 21.02.20 um 11:16 schrieb Dmitry Gutov: > On 21.02.2020 11:31, Eli Zaretskii wrote: >> Also, I'd mention that FILE can be a pattern, otherwise the reference >> to patterns might come as a surprise to the reader. > > And, if we accept the patch from a neighboring bug report, it will never= be an absolute file name. I am not aware of that bug report. Currently absolute file names still come in via=C2=A0 vc-dir-ignore . I'd rather not document a possible future, since it seems hard enough to document the current state ;-) =7F From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 16:30:36 2020 Received: (at 37215) by debbugs.gnu.org; 21 Feb 2020 21:30:37 +0000 Received: from localhost ([127.0.0.1]:48246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5Fsa-00060R-N3 for submit@debbugs.gnu.org; Fri, 21 Feb 2020 16:30:36 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:39632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5FsY-000603-AV for 37215@debbugs.gnu.org; Fri, 21 Feb 2020 16:30:34 -0500 Received: by mail-wm1-f65.google.com with SMTP id c84so3371756wme.4 for <37215@debbugs.gnu.org>; Fri, 21 Feb 2020 13:30:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Hb5QuMukpQWpGgKN+6/2MJ37Ce+ZPs3Z+oxZHhYRibc=; b=KrnX4TSv3KYokOUsT0BkArwdhZ7xGoKGwBKfvJsWRkdw5GJ31IIGADkDSWQwdVJBfX jl/WEzHpubdI8FbHIygWdLF5w9I6sHpovL+T8jQtwae2dZ+jxOO85yw2dvVqSkZflTZy cS5t/hgtMzLEipWgPRwfF0bdDhO5HG8ag8wcGxDdF0muG+offYS5GBTyCiTs0EEN9FOn Cu03Cmt7bzpyUI5FqJxCqaH3Dvzdda0eswKkNAY2+tCZTxGJYbt7ZIr6DlAzRQJct35B K9R4/XvrGSlW3P61WBviDHjl2szReUYdgq0eRgoCQPAMe5YWK62ePQZngTx4+3Pd4nXw vuCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Hb5QuMukpQWpGgKN+6/2MJ37Ce+ZPs3Z+oxZHhYRibc=; b=RFTl3XwB0gb+2sLu8NLEMlhq+fWInX9CNV5/oJVvsrA3igPqMZ9C290HbSTylUd7lT ho8fXYcSLHcXNcNHcJXHJv1LrbrRfgoHetF+K7JC4HCeZ/GbsXq3t8xUSqVQQtU4gQs5 eN8wAADXy0Ppfm8+PklPxjpwYWF7tCI7E/6TvAMVPW4d+fH8YeINrt+o53HJSbNkquSx i70ZVYCXg0a/x1rmZR6AkENzqRzPg2Bl8ozQiq0G5o60ip9O8QKT5kjSR2gtP0JKmI/l n1z1BRQ+g3i2Ag46qxX9QfdZ4ol8jWKJFzUHql2fqwRau2Sj/oeGfQQyHeKSvaK2od3O v3PA== X-Gm-Message-State: APjAAAXtsai9HLFYoBPYl9i+2Uirj57IdNZHCdQOQlTgiYmGCv6lGVMO DfNXJ0FYvpIoSdUNvKXkLqFcRAeY X-Google-Smtp-Source: APXvYqxxuBpyb+wCfjTaLU4OErhkVgupPFkD9B2fM43a7lGKDnpFuA73RqDiw4sa2KZD9gB0jGnf3A== X-Received: by 2002:a1c:960c:: with SMTP id y12mr5743366wmd.9.1582320628153; Fri, 21 Feb 2020 13:30:28 -0800 (PST) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id h13sm5725254wrw.54.2020.02.21.13.30.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Feb 2020 13:30:27 -0800 (PST) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Wolfgang Scherer References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> <83imk8nvl4.fsf@gnu.org> <6aaa5f28-13da-e998-a2b5-3a52a97b9dde@gmx.de> <83eeuojnhk.fsf@gnu.org> <0092bc25-f2aa-a6e1-e45b-dc08d5068a64@gmx.de> From: Dmitry Gutov Message-ID: <6b6982fc-f285-baf3-5210-9cc4820798d6@yandex.ru> Date: Fri, 21 Feb 2020 23:30:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <0092bc25-f2aa-a6e1-e45b-dc08d5068a64@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 21.02.2020 22:44, Wolfgang Scherer wrote: > I am not aware of that bug report. Here's a recent message with a patch waiting for feedback from you as well: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37189#143 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 17:23:48 2020 Received: (at 37215) by debbugs.gnu.org; 21 Feb 2020 22:23:48 +0000 Received: from localhost ([127.0.0.1]:48317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5Gi4-0007NJ-Bc for submit@debbugs.gnu.org; Fri, 21 Feb 2020 17:23:48 -0500 Received: from mout.gmx.net ([212.227.15.19]:59173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5Gi2-0007N6-Cz for 37215@debbugs.gnu.org; Fri, 21 Feb 2020 17:23:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1582323820; bh=DaSgN0q/YNqD+oD4YlRchPWDevwjtBdZeKD+9yfprpM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=MwZPu92L0slzki+UVYAQolVJ2B4Dcz+4SSPwRAUXxM0+nhn8M0XtKpOwPzRtp/iEq cu+S/17xSmpBl+nvAKVvHN1B9OvGmbVR/pnJPSeAqBY7dHYj5/yT4hwmVUcICJB3a+ DmTHGDX7J0uBhaie64/8/GhzMWdwVis5fy0R+8xY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MmDIo-1jnRDI1qSG-00iAIV; Fri, 21 Feb 2020 23:23:40 +0100 Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id 2216219431F0; Fri, 21 Feb 2020 23:23:40 +0100 (CET) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings To: Dmitry Gutov References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> <83imk8nvl4.fsf@gnu.org> <6aaa5f28-13da-e998-a2b5-3a52a97b9dde@gmx.de> <83eeuojnhk.fsf@gnu.org> <0092bc25-f2aa-a6e1-e45b-dc08d5068a64@gmx.de> <6b6982fc-f285-baf3-5210-9cc4820798d6@yandex.ru> From: Wolfgang Scherer Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KYqLGtYMuu3/KYq9yBd53OYc7LWTLMxsGOIATSOQRhdCKYW1AanupYrC/bKNW/ 8i2QEXc7LIeYiaII0TkVdQTVZxrg9kKLQ+Vf6z04Lbfv91sVCkHKI9jxgVMAAwUD/0mkDeN0 tllPH+NOjbkkqlOj6UOwzwIYgXmALhuAEFGXVLM2HfRV9TtJa2OoGZiuhyGXat3Jl9QK9NNv d/J4HSal93ZHWstPU4YIRc5uhJ1eeWwKsfTmPvbZXMKMkh+hBBJ39SZnmxfoeUzkK0EQNE2p PZDyjAlz03qOx6D0DHnZwkkEGBECAAkFAkb46IgCGwwACgkQhQKvcavXXZU8PwCdGmUH5mbh dsLYyx7qthe4hOWnW54AoJQMfmHP4uUI6ji8VkdlvO8LKtLP Message-ID: Date: Fri, 21 Feb 2020 23:23:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <6b6982fc-f285-baf3-5210-9cc4820798d6@yandex.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: de-DE X-Provags-ID: V03:K1:PaerznzaduwDKKmShBr9y9f4qTmHjb7VBvLNSqAgLy2rEC3KzIf o6PdT5CnSV/Gb+xz1navLWzd+q9uV+X8XPF76KogdMgQkAiSpCRokMd5BkC92c4hdf0Gvk/ ygAgnFEPhFWfPwtgFh9gBEJbsOQ13waEsryxavDSqgQic7E42xA8c9XePYtKEerVI+XzaGE lvmNwpNqAvmwYY47zUSHQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:WH4+H+DVB5s=:2+R3EnYKjn4AnLPNUzhZDV 5BU8LkYQ82rX72gzcaX0Ae4R/Hp+Gcz8Xh3awke5h7s0lBMAE+qI/XisBw6O9Z77gEWx+gjyj eFYoqXY7y1voiUdEUmv3uzKUjRF7z6GJHbkWl+pfs4/yS6pXGLdMX235G/MLJBHqNaatKK8uq rYZOeyXCDikpd4tqhcZSiweBb1aitf4KzMnx4ocGdVhHKFzTGHC0zdJuRc36nGncvJc2Ry0iU GFkSDJ126gJzFqM0wZvnq3hTnxYM9X4nMAnxkNjgSaTVu4dwPrsytqoGb5IUWC0GtSSHARX2L ti+NLHmrVxvQq9hFQX4cCJq+kbth2FejLifoK2YtmFNQz84ePpwJA5o4P4yz8S3xNpXZErTaT GgX3I2uYhGJ0xhusDSYKMwiiNSZAVuAxdeDqxcv254n2uHPogo7EFe0CwzYvAh1+FKEv5CBl7 ADzacgdoL1UMnv/Y6jAjIqRVHnRwwdzQq2ZSM3iFRGobFV/p0Qhs1onvy+sDTt/mSaVw5/qoO zd3xC0H4OSS86EUATIdUBdXQDjyVLsGKFZ+Iym7zeM5tmRl7I2jnYFSHa0IhQnooKYXrzwMBl O0IYqKOk2JMaRPgPF31PW9eIe/WSigeyM+72+ZRzvvkJ9VjVVRGczWLg8H6tdHgnydduemRSY P5aM67Z8RtmOZWoRslljrRAI8LVJpcoftRUD5p7hxjOsCxLGUAjIRp5itlYTzdstblk2/YJpO 4DMNOKGNYzPY+tQFhowUtUhyHhBlYJgllt6SInrsGTiVBlq0Nz6LufDkeyYDMCg6z1XJPnqVJ nj5gS8QqDZ/a1CUp3ojwtiLWSFdS7F5XDVI0te8S3f2O54sW47z77G8AGufXqYLEKXbqc07Pr ImuQnK+oCNpGN32ZooIDgupJCxPa+shjHWbbjXFzpzk/XiakW+iS/GsLLeMtFWgTLqxZ0Fj2x ZnSFBvAMRye2y+4NLL0jQQy3JMVkwCij2zZvpiHGcsj/hnpsG0xcLcEXEP+hjlIkyy9WR372B ridGRum1uU25Od6EnTR/W0iBuRFZPGYFRWtN9rR0AiP1BuqhQmkBkQ2TOFn162vWw4OkHeAMa O6AcefAz7GG7KYe65HSi+xliCEqeYrJdQQ9xEKa4BpvLOIrVdtnCfLYsDHLyjiCi9b1lRd/pp iVu6vQCIv+MWWDQYqU6oe2Ayaa2LtmEC0qND9IGiB7hf4MLcM8iu59RGFIP7PDlHMVR+9aPfc 5T1aia/1SigTaQY8E X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Am 21.02.20 um 22:30 schrieb Dmitry Gutov: > On 21.02.2020 22:44, Wolfgang Scherer wrote: >> I am not aware of that bug report. > > Here's a recent message with a patch waiting for feedback from you as well: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37189#143 I see. I just answered. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 04:00:07 2020 Received: (at 37215-done) by debbugs.gnu.org; 22 Feb 2020 09:00:07 +0000 Received: from localhost ([127.0.0.1]:48548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5Qdq-0000aj-PG for submit@debbugs.gnu.org; Sat, 22 Feb 2020 04:00:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5Qdo-0000Yo-SG for 37215-done@debbugs.gnu.org; Sat, 22 Feb 2020 04:00:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j5Qdj-0006KB-7J; Sat, 22 Feb 2020 03:59:59 -0500 Received: from [176.228.60.248] (port=2166 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j5Qdi-00033l-35; Sat, 22 Feb 2020 03:59:58 -0500 Date: Sat, 22 Feb 2020 10:59:49 +0200 Message-Id: <83tv3jhu9m.fsf@gnu.org> From: Eli Zaretskii To: Wolfgang Scherer In-reply-to: <686a6419-308c-6536-3996-7f534ca19346@gmx.de> (message from Wolfgang Scherer on Fri, 21 Feb 2020 21:32:03 +0100) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> <83imk8nvl4.fsf@gnu.org> <6aaa5f28-13da-e998-a2b5-3a52a97b9dde@gmx.de> <83eeuojnhk.fsf@gnu.org> <686a6419-308c-6536-3996-7f534ca19346@gmx.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 37215-done Cc: larsi@gnus.org, 37215-done@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) > Cc: larsi@gnus.org, 37215@debbugs.gnu.org, dgutov@yandex.ru > From: Wolfgang Scherer > Date: Fri, 21 Feb 2020 21:32:03 +0100 > > > Please quote 'like this' in log messages, and try to avoid non-ASCII > > characters there (they are generally only necessary in people's > > names). > OK > >> +Patterns follow glob(7) syntax. Special characters \"?*[\\\" are > >> +escaped with a backslash." > > I'd say "should be escaped" here, since this is a requirement for the > > argument passed to this function. > Here is that amgbuity again ;-). It is only required, if the user > wants a special character to match literally. It's perfectly fine to > specify  *.pyc  as a pattern. I have phrased it like that. > > Also, I'd mention that FILE can be a pattern, otherwise the reference > > to patterns might come as a surprise to the reader. > I emphasized more, that the basename of the FILE argument (not the > entire FILE) is in fact a CVS ignore pattern. > >> +to hear about anymore. If SORT is non-nil, sort the ines of the > >> +ignore file." ^^^^ > > Typo: should be "lines". > Right. > >> + (goto-char (point-min)) > >> + (save-match-data > >> + (unless (re-search-forward (concat "^" (regexp-quote str) "$") nil t) > >> + (goto-char (point-max)) > > You could use non-nil, non-t 3rd argument of re-search-forward, in > > which case the following goto-char would be redundant, right? > Right, I just left the  goto-char  in there, because it makes it > obvious what is going on. Switching to the side-effect optimization ... Thanks, pushed to the release branch. Please note that I need to make minor copyedits in the log message; please try following this style in the future. With this, I'm closing this bug report. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 28 11:07:22 2020 Received: (at 37215) by debbugs.gnu.org; 28 Feb 2020 16:07:22 +0000 Received: from localhost ([127.0.0.1]:33698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7iAc-0000oO-I6 for submit@debbugs.gnu.org; Fri, 28 Feb 2020 11:07:22 -0500 Received: from mail73c50.megamailservers.eu ([91.136.10.83]:57296 helo=mail92c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7iAZ-0000oB-SZ for 37215@debbugs.gnu.org; Fri, 28 Feb 2020 11:07:20 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1582906038; bh=+SpTEpBw1V08+0OpEXb6/XdgypI0gxSIKRsqOnbxcp0=; h=From:Subject:Date:Cc:To:From; b=mMEYyztvAoz6se87ukZjxx/qbvp1fXhSNKBXY/jWvi/EqJ6rbsaBLwDNRQk7cH9tQ fK/cYbjR/MmFBOASIiNcrpj+ApdMDzEwxt3MxOU5FknFHxbScBR/RztUfKX2xye2hX 8phKPP4t8bFfQB62TY509s1kqyGBXLfSyKZ9OquQ= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 01SG7FYi022349; Fri, 28 Feb 2020 16:07:16 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings Message-Id: <37D4F504-C582-460B-9561-57E02D7EE6BA@acm.org> Date: Fri, 28 Feb 2020 17:07:14 +0100 To: Eli Zaretskii , Wolfgang Scherer , Lars Ingebrigtsen , Dmitry Gutov X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A782F21.5E593AB3.0066, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=RJbN4Lq+ c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=Ulz2WCFscld1ORtgsMgA:9 a=CjuIK1q_8ugA:10 X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Some doc string tweaks committed to emacs-27 (4dec693f70); hope that's all right. Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: megamailservers.eu] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.3 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Some doc string tweaks committed to emacs-27 (4dec693f70); hope that's = all right. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 28 11:25:17 2020 Received: (at 37215) by debbugs.gnu.org; 28 Feb 2020 16:25:17 +0000 Received: from localhost ([127.0.0.1]:33711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7iRw-0001Oa-Lf for submit@debbugs.gnu.org; Fri, 28 Feb 2020 11:25:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7iRu-0001OG-Vx for 37215@debbugs.gnu.org; Fri, 28 Feb 2020 11:25:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j7iRp-00073D-9I; Fri, 28 Feb 2020 11:25:09 -0500 Received: from [176.228.60.248] (port=4682 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j7iRn-0003Mt-L5; Fri, 28 Feb 2020 11:25:09 -0500 Date: Fri, 28 Feb 2020 18:24:54 +0200 Message-Id: <83d09yfzmx.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-reply-to: <37D4F504-C582-460B-9561-57E02D7EE6BA@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Fri, 28 Feb 2020 17:07:14 +0100) Subject: Re: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings References: <37D4F504-C582-460B-9561-57E02D7EE6BA@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 37215 Cc: 37215@debbugs.gnu.org, larsi@gnus.org, dgutov@yandex.ru, Wolfgang.Scherer@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) > From: Mattias Engdegård > Date: Fri, 28 Feb 2020 17:07:14 +0100 > Cc: 37215@debbugs.gnu.org > > Some doc string tweaks committed to emacs-27 (4dec693f70); hope that's all right. Documentation fixes are always OK on the release branch. Thanks. From unknown Thu Aug 14 22:17:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 28 Mar 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator