GNU bug report logs - #37214
[PATCH] vc-svn error messages are used as ignore list

Previous Next

Package: emacs;

Reported by: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>

Date: Wed, 28 Aug 2019 18:55:02 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 37214 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de>
Cc: 37214 <at> debbugs.gnu.org
Subject: Re: bug#37214: [PATCH] vc-svn error messages are used as ignore list
Date: Sun, 15 Sep 2019 15:16:16 +0200
Wolfgang Scherer <Wolfgang.Scherer <at> gmx.de> writes:

> * lisp/vc/vc-svn.el: (vc-svn-ignore-completion-table) Ignore buffer
> contents, if exit status is not 0.  Split buffer by lines.

I don't use svn, but:


[...]

> -    (vc-svn-command t t nil "propget" "svn:ignore" (expand-file-name directory))
> -    (split-string (buffer-string))))
> +    (if (= (vc-svn-command t t nil "propget" "svn:ignore" (expand-file-name directory)) 0)
> +        (split-string (buffer-string) "\n"))))

This looked "obviously correct", so I've applied it without testing
(after a slight stylistic change).  If this leads to errors with actual
svn users, please revert.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 5 years and 311 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.