From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 28 12:27:40 2019 Received: (at submit) by debbugs.gnu.org; 28 Aug 2019 16:27:40 +0000 Received: from localhost ([127.0.0.1]:51145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i30nM-00016e-CO for submit@debbugs.gnu.org; Wed, 28 Aug 2019 12:27:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:41317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i30ls-00014E-35 for submit@debbugs.gnu.org; Wed, 28 Aug 2019 12:26:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33668) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i30lp-0006m7-J2 for bug-grep@gnu.org; Wed, 28 Aug 2019 12:26:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i30lo-0006l3-Lj for bug-grep@gnu.org; Wed, 28 Aug 2019 12:26:05 -0400 Received: from mout.gmx.net ([212.227.17.20]:58739) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i30lo-0006hv-9X for bug-grep@gnu.org; Wed, 28 Aug 2019 12:26:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1567009556; bh=AA45ou0XSL2qdlO+uwZJFIjI6E3P8pa8dUo2xvZRAeI=; h=X-UI-Sender-Class:To:From:Subject:Date; b=PswiKsjtxw8HhtUCY09rp3+lPmNCXSiV52QQo2HanZ/EjO7d3+6xRVh8CZ8aTmFmy ro/syDLouEsItKQqr/AzNREgros0eojkImbRnlUMYVgnLPjSTJvf7yVeGzz8xtj17x +kmlpxAr0DQOeI+gxh3PrZITtY/WwMHHx7O3GyOg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.8] ([82.10.153.74]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MoO6C-1iZqYO213A-00oryp for ; Wed, 28 Aug 2019 18:25:56 +0200 To: bug-grep@gnu.org From: Duncan Moore Subject: Incorrect --exclude description with 'grep --help' Message-ID: Date: Wed, 28 Aug 2019 17:25:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-Provags-ID: V03:K1:+9jhwKMAlLWABRb+tSfOMgadAZHSd3uoxxPXfyVnGbUvGZrIVym 8cRhGho1Mgwd7Gkde4j5GiSfPEKWpkTvkCPk5fm/w5yqdusZssKGLN/z34ZQxOzA4XW2vD0 9BazuxlWVprA85Jgl2nip2USiroGby17+C+utY0kEjFfCMdCT54pMrAFl/MHHpFMaqQP/fV 9fgbDmYmVRBIJoI3YLTBw== X-UI-Out-Filterresults: notjunk:1;V03:K0:9IH+ELdBxIA=:rfgSmblaUQ7sCN8RvqzOxP wfhWozzukQi/cZjW10ZQ+bnI2m+gQkC2j1biAkISSfeEx9FGp+g25kaIjinpvp3KBbcsrqmwb 55J79sqySZ91ajKvL1z9bCAYIDy4ItHrVsQtXOgqdTlOTl6EevYUdxYtfJhjk1bmBXOsLOMgr wgdApe4S4UI3XKl7Xu7r70vjGpdUAgMn5uOKuXYD6LqKgDDPbapRqSYtlLFS3Ryx7UhwwjsUD 9Wh61A4LzBnP4rbRp4pzISMrczb2FNqX7UEiBpGarXInesC9Jm+WmCbsa/HIX98QUdDuJZO1C 5gsre0tUBPsE6XoLYeImYHDR2ZoaYuKE0Xr3j3ahuBqi7YQPLcQksK7pvIT7MpQL4cnWXQwx3 CxMaJtL3lRQo4SgfFwme48aS3nViWR/5va1pw8haOdcdwJzTdtQNMaatQIIupXfDSBcoTm7Ry h6QzmflY/RWsvoW0jilw+4lBWtncidk0uyJh+S8jbL5ubwF1IECRdcL++eV50JKarg2C87bjH sQUrCnlq0p8D8GZu1pNqfJfWfJiyJuDmhIt0ORyka3zN9nR3DLyKiqMOhAqC8c4OihHyyjDRy CCnfE/tNHP3lJfVAxQ2yxG0Q5xsJ3gEF5lCJux4m82gtUdXP44rlcIxilPwM8NAeikvGO98on S3eYrfvXVDTqVjq1kqbWZyQ0AYe1f/7x6oTN9XQttfM0kK5NMWQmgSc0UM6NA8UJ37uEL7l4w rWYm8+Wu7xxBvdQC3E0TlRzgbuGC6BGw/iaTVXGBVPUmRv0ssu15K3H9NDZc7Dc6xjUTlpvIA Oz4DzwIAc47TQ0KhlNQPsdBEY9rAqqMpGLzc2fplSGkCp+T/nwWblaSM9DZsK7jbYX8Hq02Mz UV/Fvv4gh/ET5toxVklKSFnl/ZxqnFTmshP9yRE9/B1F/e4Ytz8/cpl0YcBa5LTXWwV/dTjdo TjSzfvfK8vjeeEmzn78gwHNvHJmx6F8p/yTYV6FqZtIDDcjhXxctYArQhquLZ7NaCxr2UQy0i ZUoWJE3YobUGnPiZi3Hm5TNLQ4agvfyXRqTxI9iZ/mlmvjmUXgigdg6XOsgSdig9CWPVCrT8k 27kistsRFi5PtLIULmHZbD9bmZ9hV4+XlppwvYRmuOFYSZjlTpsqlqrzMKNKE84HKLfE2UY7d TdYnPqdUWfCpNmFDAUfdUoIstG5W6WsfMURN8DJSJ+Gn77vg== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.20 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 28 Aug 2019 12:27:39 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) 'grep --help' incorrectly states that the --exclude option operates on directories. Here's the suggested change to the help text: -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 --exclude=3DGLOB=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 skip files and directories matching GLOB +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 --exclude=3DGLOB=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 skip files matching GLOB It might also be worthwhile changing 'that match' to 'matching' in these 2 options to give consistent phrasing across the 4 include/exclude options, to make it a bit easier for the user to compare them: -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 --include=3DGLOB=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 search only files that match GLOB (a file pattern) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 --include=3DGLOB=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 search only files matching GLOB (a file pattern) -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 --exclude-dir=3DGLOB=C2=A0=C2=A0=C2=A0 ski= p directories that match GLOB +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 --exclude-dir=3DGLOB=C2=A0=C2=A0=C2=A0 ski= p directories matching GLOB From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 04:57:26 2020 Received: (at 37212-done) by debbugs.gnu.org; 2 Jan 2020 09:57:26 +0000 Received: from localhost ([127.0.0.1]:38234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imxEL-000498-RA for submit@debbugs.gnu.org; Thu, 02 Jan 2020 04:57:26 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imxEJ-00048t-Eb for 37212-done@debbugs.gnu.org; Thu, 02 Jan 2020 04:57:23 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 65273160054; Thu, 2 Jan 2020 01:57:17 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id EpuzX7sID30Z; Thu, 2 Jan 2020 01:57:15 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 83781160058; Thu, 2 Jan 2020 01:57:15 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id fhXZCSYJ80Fq; Thu, 2 Jan 2020 01:57:15 -0800 (PST) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4DF8E160054; Thu, 2 Jan 2020 01:57:15 -0800 (PST) Subject: Re: bug#37212: Incorrect --exclude description with 'grep --help' To: Duncan Moore References: From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Thu, 2 Jan 2020 01:57:15 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------9EA679853AA666C7D8E0EA69" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37212-done Cc: 37212-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------9EA679853AA666C7D8E0EA69 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Thanks for the bug report. I installed the attached (slightly different) patch to fix the bug and inconsistency. --------------9EA679853AA666C7D8E0EA69 Content-Type: text/x-patch; charset=UTF-8; name="0001-doc-fix-exclude-description-in-man-page.patch" Content-Disposition: attachment; filename="0001-doc-fix-exclude-description-in-man-page.patch" Content-Transfer-Encoding: quoted-printable >From 61bbb574dcf350830b526bea61250e30d95057d0 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 2 Jan 2020 01:54:47 -0800 Subject: [PATCH] doc: fix --exclude description in man page MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Problem reported by Duncan Moore (Bug#37212). * src/grep.c (usage): Fix incorrect statement about --exclude and directories. Standardize on =E2=80=9Cthat match GLOB=E2=80=9D instea= d of =E2=80=9Cmatching GLOB=E2=80=9D. --- src/grep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/grep.c b/src/grep.c index 35d563d..7ba602d 100644 --- a/src/grep.c +++ b/src/grep.c @@ -1970,8 +1970,8 @@ Output control:\n\ printf (_("\ --include=3DGLOB search only files that match GLOB (a file = pattern)" "\n\ - --exclude=3DGLOB skip files and directories matching GLOB\n= \ - --exclude-from=3DFILE skip files matching any file pattern from = FILE\n\ + --exclude=3DGLOB skip files that match GLOB\n\ + --exclude-from=3DFILE skip files that match any file pattern fro= m FILE\n\ --exclude-dir=3DGLOB skip directories that match GLOB\n\ ")); printf (_("\ --=20 2.17.1 --------------9EA679853AA666C7D8E0EA69-- From unknown Tue Aug 19 10:05:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 30 Jan 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator