From unknown Tue Jun 24 17:27:09 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3719: [PATCH] Fix eshell so that the builtin kill command works Reply-To: "Jason A. Spiro" , 3719@debbugs.gnu.org Resent-From: "Jason A. Spiro" Original-Sender: jasonspiro@gmail.com Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: bojohan+mail@dd.chalmers.se;johnw@gnu.org, Emacs Bugs Resent-Date: Tue, 30 Jun 2009 00:25:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 3719 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12463211724277 (code B ref -1); Tue, 30 Jun 2009 00:25:07 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 30 Jun 2009 00:19:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.8 required=4.0 tests=AWL,FOURLA,HAS_PACKAGE, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5U0JOM6004270 for ; Mon, 29 Jun 2009 17:19:25 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLR4G-00041v-4s for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2009 20:19:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLR4B-0003wh-3O for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2009 20:19:23 -0400 Received: from [199.232.76.173] (port=44759 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLR4A-0003wd-S4 for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2009 20:19:18 -0400 Received: from mail-gx0-f211.google.com ([209.85.217.211]:41950) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MLR4A-00077Z-L2 for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2009 20:19:18 -0400 Received: by gxk7 with SMTP id 7so7167534gxk.18 for ; Mon, 29 Jun 2009 17:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:from:date :x-google-sender-auth:message-id:subject:to:content-type :content-transfer-encoding; bh=XcFDarCmJ5PYANUUXWIiWvZlv8HFLWAlPTmphD8PDJ4=; b=wGHdTGlHkOQj2Mh/F70h6pTsae7dZHe2pMi/dTZqpA7YfocVXf/UJlYRMMmW2SuMhG GS7IHrcTEadHaUzGYRTyDyMI66QE9Yw+vTM8IgPquvgEXKAm83WNs/rPSkfUiDFkkmGX yWzD79sWcj+Jgr3jgXJ/YJ/pdF91yV4DSHqgU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:from:date:x-google-sender-auth:message-id :subject:to:content-type:content-transfer-encoding; b=WMHN997FfeMpNzr6yr7G/LOGdDeSpAfne3wWo87IvR1ENnGMxJMecFJRXrF3jDCvNl F7KLDr4IstXkfagJLtBNhG3gT+KBcU3mT9gjM78M2N+N9fKvfmwLBAM1310wmmQ/Rywr KbDaALdVQChE/e3aDYcn8ZjEWNW7uMTv8aNQ4= MIME-Version: 1.0 Sender: jasonspiro@gmail.com Received: by 10.231.34.3 with SMTP id j3mr768552ibd.43.1246321156078; Mon, 29 Jun 2009 17:19:16 -0700 (PDT) From: "Jason A. Spiro" Date: Tue, 30 Jun 2009 00:18:56 +0000 X-Google-Sender-Auth: 2a86d882d19b82b8 Message-ID: To: bug-gnu-emacs Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Package: emacs Version: 22.3.1 X-Debbugs-CC: bojohan+mail@dd.chalmers.se;johnw@gnu.org Tags: patch Hi Johan, We were on IRC today. I mentioned that eshell's built-in kill command doesn't seem to be able to kill any processes -- not even xeyes. But /bin/kill works fine. Example: kill 4946 didn't kill xeyes on my PC, but /bin/kill 4946 did. I asked if anyone could confirm this. You and Phil Hagelberg both confirmed the bug. Plus, you wrote a little patch to esh-arg.el and told me it would fix the problem: < (add-text-properties 0 1 '(number t) str)) > (add-text-properties 0 (length str) '(number t) str)) Yes. It fixes the problem. Could you please commit it? :) Thanks in advance, -Jason In GNU Emacs 22.3.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2009-03-31 on raven, modified by Debian -- Jason Spiro: software/web developer, packager, trainer, IT consultant. I support Linux, UNIX, Windows, and more. Contact me to discuss your needs. +1 (416) 992-3445 / www.jspiro.com From rgm@gnu.org Sun Jul 5 18:01:46 2009 Received: (at control) by emacsbugs.donarmstrong.com; 6 Jul 2009 01:01:46 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,ONEWORD,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6611hwj024220 for ; Sun, 5 Jul 2009 18:01:44 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MNcaU-0005FQ-Jn; Sun, 05 Jul 2009 21:01:42 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19025.19702.519808.676830@fencepost.gnu.org> Date: Sun, 5 Jul 2009 21:01:42 -0400 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: white X-Ran: eDWwb[$r^:sLyB2.bpKn"E(P9UO.^!ji^hE8$Mvpg=Iaxxo2>YR,OaUVyT=Kxy(9'*c0mY X-Debbugs-No-Ack: yes close 3719 close 3757 merge 3754 3755 severity 3754 wishlist