GNU bug report logs - #3719
[PATCH] Fix eshell so that the builtin kill command works

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3719 in the body.
You can then email your comments to 3719 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Jason A. Spiro" <jasonspiro4 <at> gmail.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Fix eshell so that the builtin kill command works
Date: Tue, 30 Jun 2009 00:18:56 +0000

Package: emacs
Version: 22.3.1
X-Debbugs-CC: bojohan+mail <at> dd.chalmers.se;johnw <at> gnu.org
Tags: patch

Hi Johan,

We were on IRC today.  I mentioned that eshell's built-in kill command
doesn't seem to be able to kill any processes -- not even xeyes.  But
/bin/kill works fine.  Example:  kill 4946 didn't kill xeyes on my PC,
but /bin/kill 4946 did.  I asked if anyone could confirm this.

You <bojohan> and Phil Hagelberg <technomancy> both confirmed the bug.
 Plus, you wrote a little patch to esh-arg.el and told me it would fix
the problem:

<  (add-text-properties 0 1 '(number t) str))
>  (add-text-properties 0 (length str) '(number t) str))

Yes.  It fixes the problem.  Could you please commit it?  :)

Thanks in advance,
-Jason

In GNU Emacs 22.3.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
of 2009-03-31 on raven, modified by Debian

-- 
Jason Spiro: software/web developer, packager, trainer, IT consultant.
I support Linux, UNIX, Windows, and more. Contact me to discuss your needs.
+1 (416) 992-3445 / www.jspiro.com

Message #8 received at 3719-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: "Jason A. Spiro" <jasonspiro4 <at> gmail.com>
Cc: 3719-done <at> debbugs.gnu.org
Subject: Re: [PATCH] Fix eshell so that the builtin kill command works
Date: Sun, 05 Jul 2009 00:59:37 -0400

> We were on IRC today.  I mentioned that eshell's built-in kill command
> doesn't seem to be able to kill any processes -- not even xeyes.  But
> /bin/kill works fine.  Example:  kill 4946 didn't kill xeyes on my PC,
> but /bin/kill 4946 did.  I asked if anyone could confirm this.
>
> You <bojohan> and Phil Hagelberg <technomancy> both confirmed the bug.
>  Plus, you wrote a little patch to esh-arg.el and told me it would fix
> the problem:
>
> <  (add-text-properties 0 1 '(number t) str))
> >  (add-text-properties 0 (length str) '(number t) str))
>
> Yes.  It fixes the problem.  Could you please commit it?  :)

bjohan has committed the patch to the trunk.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.