GNU bug report logs - #37165
lookup-family-specification test fails

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37165 in the body.
You can then email your comments to 37165 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: lookup-family-specification test fails
Date: Fri, 23 Aug 2019 15:29:18 -0400

Package: emacs
Severity: minor
Version: 27.0.50

The test lookup-family-specification fails on hydra.nixos.org:

    google.com/0 Name or service not known
    Test lookup-family-specification condition:
        (ert-test-failed
         ((should
           (network-lookup-address-info "google.com" 'ipv4))
          :form
          (network-lookup-address-info "google.com" ipv4)
          :value nil))
       FAILED   1/18  lookup-family-specification (0.002023 sec)

Perhaps the system doesn't having working DNS, in which case you
probably just want to add

(skip-unless (not (getenv "EMACS_HYDRA_CI")))

I suppose this could be true of other systems too, but don't know how
you check that.


Note that test lookup-google passes, but based on the above it should not.
(should (length X)) seems like a buggy test condition (it passes when X
is nil).

Message #6 received at 37165 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 37165 <at> debbugs.gnu.org
Subject: Re: bug#37165: lookup-family-specification test fails
Date: Sat, 24 Aug 2019 15:00:26 +0200

>>>>> On Fri, 23 Aug 2019 15:29:18 -0400, Glenn Morris <rgm <at> gnu.org> said:

    GM> Package: emacs
    GM> Severity: minor
    GM> Version: 27.0.50

    GM> The test lookup-family-specification fails on hydra.nixos.org:

    GM>     google.com/0 Name or service not known
    GM>     Test lookup-family-specification condition:
    GM>         (ert-test-failed
    GM>          ((should
    GM>            (network-lookup-address-info "google.com" 'ipv4))
    GM>           :form
    GM>           (network-lookup-address-info "google.com" ipv4)
    GM>           :value nil))
    GM>        FAILED   1/18  lookup-family-specification (0.002023 sec)

    GM> Perhaps the system doesn't having working DNS, in which case you
    GM> probably just want to add

    GM> (skip-unless (not (getenv "EMACS_HYDRA_CI")))

OK, Iʼve added that where appropriate.

    GM> I suppose this could be true of other systems too, but don't know how
    GM> you check that.

By doing a DNS lookup :-)

    GM> Note that test lookup-google passes, but based on the above it should not.
    GM> (should (length X)) seems like a buggy test condition (it passes when X
    GM> is nil).

Yes, plus some others pass that shouldn't. Should be fixed now.

Robert

Message #9 received at 37165 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 37165 <at> debbugs.gnu.org
Subject: Re: bug#37165: lookup-family-specification test fails
Date: Mon, 02 Sep 2019 17:32:34 +0200

tags 37165 fixed
close 37165 27.1
quit

The build on hydra passes now.

Closing.
Committed as 649fb17443

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.