From unknown Fri Sep 05 11:00:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37122: [PATCH] Remove support for upgrading from old bookmark file format Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2019 19:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37122 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 37122@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15663288629900 (code B ref -1); Tue, 20 Aug 2019 19:21:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Aug 2019 19:21:02 +0000 Received: from localhost ([127.0.0.1]:33958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i09gj-0002ZF-9P for submit@debbugs.gnu.org; Tue, 20 Aug 2019 15:21:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:43261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i09gh-0002Z6-6t for submit@debbugs.gnu.org; Tue, 20 Aug 2019 15:20:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38448) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i09gb-0001bg-2h for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 15:20:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i09gZ-0004ZO-Dr for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 15:20:52 -0400 Received: from mail-pl1-f170.google.com ([209.85.214.170]:44628) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i09gZ-0004Yo-0S for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 15:20:51 -0400 Received: by mail-pl1-f170.google.com with SMTP id t14so3223270plr.11 for ; Tue, 20 Aug 2019 12:20:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=sJsbCuH52m9MZBeXzbooq9YN/U2riuYrFAj2/8bD3uQ=; b=etaYV8x0dq4AU4YJUHfpyhwIG2X2SuBmFtCyuN0raaKFFas958oc3ZnfUTxxHgsus/ 3nFmDzjGbFGBt8F2afGSmWVy/I2kefZHcnl88vWcLhDf/HQdmfjPpkGT8xVEYH1ed8K6 9x/54HnNyHeT2Ra7zKSkJ/qFr5AGsiPESMgOPv3mQQehzbMoFvFwPVzOnh8ZZ8ZMKOSL 0uxhZyEheWBRnM3XI8Naq4IBriZtMVtBYGBrv/DyDFaOsCGEf1sFI8ybGfJz2bEXUkFO iqCQb6mzAu15mpInITdVdGuvDh/mLYpx0saOBZP0yf8t5wOyfjSftzWJCDnAbK3Gp7ul TTIQ== X-Gm-Message-State: APjAAAWkRkuwYDfCus8jBPPeQJpm2SOjp3YBo5MT/R92dm6KkWN7G2Jd vywXVRBi/yrKFoRKv5cIZRxtgayI6G+WgKF5yKcYLTzk X-Google-Smtp-Source: APXvYqyoP5v5yV5baYWOAWt8woc1ZdkxmR3StzYuxd3h23VStNGjz56+wV0E0oJJ3HGQTZTw72G4ygIS5xokNFaja8M= X-Received: by 2002:a17:902:b702:: with SMTP id d2mr30845034pls.259.1566328848995; Tue, 20 Aug 2019 12:20:48 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Tue, 20 Aug 2019 21:20:37 +0200 Message-ID: Content-Type: multipart/mixed; boundary="000000000000a5894e0590915a68" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.214.170 X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --000000000000a5894e0590915a68 Content-Type: text/plain; charset="UTF-8" The old bookmark file format has not been used in Emacs since at least version 19.34, released in 1996. And that's a conservative estimate -- it's probably even older. I suggest that we remove the support for converting it to the new bookmark file format completely in order to not have to maintain this ancient code. Please see the attached patch. Thanks, Stefan Kangas --000000000000a5894e0590915a68 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Remove-support-for-upgrading-from-old-bookmark-file-.patch" Content-Disposition: attachment; filename="0001-Remove-support-for-upgrading-from-old-bookmark-file-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jzk7nvm30 RnJvbSBlMzU3MDYxN2U5YWI0ZGE1MGJlODU0NTYzZTYzZDg5ZGNkZDI4NjZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBNb24sIDEgSnVsIDIwMTkgMTY6MTY6MDYgKzAyMDAKU3ViamVjdDogW1BBVENIXSBS ZW1vdmUgc3VwcG9ydCBmb3IgdXBncmFkaW5nIGZyb20gb2xkIGJvb2ttYXJrIGZpbGUgZm9ybWF0 CgoqIGxpc3AvYm9va21hcmsuZWwgKGJvb2ttYXJrLWFsaXN0LWZyb20tYnVmZmVyKTogUmVtb3Zl IHN1cHBvcnQgZm9yCm9sZCBib29rbWFyayBmaWxlIGZvcm1hdC4KKGJvb2ttYXJrLXVwZ3JhZGUt dmVyc2lvbi0wLWFsaXN0KQooYm9va21hcmstdXBncmFkZS1maWxlLWZvcm1hdC1mcm9tLTApCihi b29rbWFyay1ncm9rLWZpbGUtZm9ybWF0LXZlcnNpb24pCihib29rbWFyay1tYXliZS11cGdyYWRl LWZpbGUtZm9ybWF0KTogRGVjbGFyZSBvYnNvbGV0ZS4KKGJvb2ttYXJrLWxvYWQpOiBEb24ndCBj YWxsICdib29rbWFyay1tYXliZS11cGdyYWRlLWZpbGUtZm9ybWF0Jy4KKiBldGMvTkVXUzogQW5u b3VuY2UgaXQuCi0tLQogZXRjL05FV1MgICAgICAgICB8IDEwICsrKysrKysrKysKIGxpc3AvYm9v a21hcmsuZWwgfCAzOSArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KIDIg ZmlsZXMgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCA1NmU1ZmQyZjgzLi5lMmJhN2VlMzNhIDEw MDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMTc5Miw2ICsxNzkyLDE2IEBA IGFsaWFzZXMgb2YgJ2Jvb2ttYXJrLWRlZmF1bHQtZmlsZScuCiAqKiogTmV3IHVzZXIgb3B0aW9u ICdib29rbWFyay13YXRjaC1ib29rbWFyay1maWxlJy4KIFdoZW4gbm9uLW5pbCwgd2F0Y2ggd2hl dGhlciB0aGUgYm9va21hcmsgZmlsZSBoYXMgY2hhbmdlZCBvbiBkaXNrLgogCistLS0KKyoqKiBU aGUgb2xkIGJvb2ttYXJrIGZpbGUgZm9ybWF0IGlzIG5vIGxvbmdlciBzdXBwb3J0ZWQuCitUaGlz IGJvb2ttYXJrIGZpbGUgZm9ybWF0IGhhcyBub3QgYmVlbiB1c2VkIGluIEVtYWNzIHNpbmNlIGF0 IGxlYXN0Cit2ZXJzaW9uIDE5LjM0LCByZWxlYXNlZCBpbiAxOTk2LCBhbmQgd2lsbCBubyBsb25n ZXIgYmUgYXV0b21hdGljYWxseQorY29udmVydGVkIHRvIHRoZSBuZXcgYm9va21hcmsgZmlsZSBm b3JtYXQuCisKK1RoZSBmb2xsb3dpbmcgZnVuY3Rpb25zIGFyZSBub3cgZGVjbGFyZWQgb2Jzb2xl dGU6Citib29rbWFyay1ncm9rLWZpbGUtZm9ybWF0LXZlcnNpb24sIGJvb2ttYXJrLW1heWJlLXVw Z3JhZGUtZmlsZS1mb3JtYXQsCitib29rbWFyay11cGdyYWRlLWZpbGUtZm9ybWF0LWZyb20tMCwg Ym9va21hcmstdXBncmFkZS12ZXJzaW9uLTAtYWxpc3QKKwogLS0tCiAqKiBUaGUgbWFudGVtcC5l bCBsaWJyYXJ5IGlzIG5vdyBtYXJrZWQgb2Jzb2xldGUuCiBUaGlzIGxpYnJhcnkgZ2VuZXJhdGVz IG1hbnVhbCBDKysgdGVtcGxhdGUgaW5zdGFudGlhdGlvbnMuICBJdCBzaG91bGQKZGlmZiAtLWdp dCBhL2xpc3AvYm9va21hcmsuZWwgYi9saXNwL2Jvb2ttYXJrLmVsCmluZGV4IGY1NjRjZDZiNDMu LmU1OGUwNTFhMzkgMTAwNjQ0Ci0tLSBhL2xpc3AvYm9va21hcmsuZWwKKysrIGIvbGlzcC9ib29r bWFyay5lbApAQCAtNjE5LDggKzYxOSw4IEBAIGJvb2ttYXJrLW1ha2UtcmVjb3JkLWRlZmF1bHQK IDs7IHdhcyBpbmNvcnJlY3QgaW4gRW1hY3MgMjIgYW5kIEVtYWNzIDIzLjEuKQogOzsKIDs7IFRv IGRlYWwgd2l0aCB0aGUgY2hhbmdlIGZyb20gRklSU1QgZm9ybWF0IHRvIFNFQ09ORCwgY29udmVy c2lvbgotOzsgY29kZSB3YXMgYWRkZWQsIGFuZCBpdCBpcyBzdGlsbCBpbiB1c2UuICBTZWUKLTs7 IGBib29rbWFyay1tYXliZS11cGdyYWRlLWZpbGUtZm9ybWF0Jy4KKzs7IGNvZGUgd2FzIGFkZGVk LCB3aGljaCBpcyBubyBsb25nZXIgdXNlZCBhbmQgaGFzIGJlZW4gZGVjbGFyZWQKKzs7IG9ic29s ZXRlLiAgU2VlIGBib29rbWFyay1tYXliZS11cGdyYWRlLWZpbGUtZm9ybWF0Jy4KIDs7CiA7OyBO byBjb252ZXJzaW9uIGZyb20gU0VDT05EIHRvIENVUlJFTlQgaXMgZG9uZS4gIEluc3RlYWQsIHRo ZSBjb2RlCiA7OyBoYW5kbGVzIGJvdGggZm9ybWF0cyBPSy4gIEl0IG11c3QgY29udGludWUgdG8g ZG8gc28uCkBAIC02NDAsNyArNjQwLDcgQEAgYm9va21hcmstZW5kLW9mLXZlcnNpb24tc3RhbXAt bWFya2VyCiAKIAogKGRlZnVuIGJvb2ttYXJrLWFsaXN0LWZyb20tYnVmZmVyICgpCi0gICJSZXR1 cm4gYSBgYm9va21hcmstYWxpc3QnIChpbiBhbnkgZm9ybWF0KSBmcm9tIHRoZSBjdXJyZW50IGJ1 ZmZlci4KKyAgIlJldHVybiBhIGBib29rbWFyay1hbGlzdCcgZnJvbSB0aGUgY3VycmVudCBidWZm ZXIuCiBUaGUgYnVmZmVyIG11c3Qgb2YgY291cnNlIGNvbnRhaW4gYm9va21hcmsgZm9ybWF0IGlu Zm9ybWF0aW9uLgogRG9lcyBub3QgY2FyZSBmcm9tIHdoZXJlIGluIHRoZSBidWZmZXIgaXQgaXMg Y2FsbGVkLCBhbmQgZG9lcyBub3QKIGFmZmVjdCBwb2ludC4iCkBAIC02NDgsMTkgKzY0OCwxMyBA QCBib29rbWFyay1hbGlzdC1mcm9tLWJ1ZmZlcgogICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikp CiAgICAgKGlmIChzZWFyY2gtZm9yd2FyZCBib29rbWFyay1lbmQtb2YtdmVyc2lvbi1zdGFtcC1t YXJrZXIgbmlsIHQpCiAgICAgICAgIChyZWFkIChjdXJyZW50LWJ1ZmZlcikpCi0gICAgICA7OyBF bHNlIHdlJ3JlIGRlYWxpbmcgd2l0aCBmb3JtYXQgdmVyc2lvbiAwCi0gICAgICAoaWYgKHNlYXJj aC1mb3J3YXJkICIoIiBuaWwgdCkKLSAgICAgICAgICAocHJvZ24KLSAgICAgICAgICAgIChmb3J3 YXJkLWNoYXIgLTEpCi0gICAgICAgICAgICAocmVhZCAoY3VycmVudC1idWZmZXIpKSkKLSAgICAg ICAgOzsgRWxzZSBubyBob3BlIG9mIGdldHRpbmcgaW5mb3JtYXRpb24gaGVyZS4KLSAgICAgICAg KGlmIGJ1ZmZlci1maWxlLW5hbWUKLSAgICAgICAgICAgIChlcnJvciAiRmlsZSBub3QgaW4gYm9v a21hcmsgZm9ybWF0OiAlcyIgYnVmZmVyLWZpbGUtbmFtZSkKLSAgICAgICAgICAoZXJyb3IgIkJ1 ZmZlciBub3QgaW4gYm9va21hcmsgZm9ybWF0OiAlcyIgKGJ1ZmZlci1uYW1lKSkpKSkpKQotCisg ICAgICAoaWYgYnVmZmVyLWZpbGUtbmFtZQorICAgICAgICAgIChlcnJvciAiRmlsZSBub3QgaW4g Ym9va21hcmsgZm9ybWF0OiAlcyIgYnVmZmVyLWZpbGUtbmFtZSkKKyAgICAgICAgKGVycm9yICJC dWZmZXIgbm90IGluIGJvb2ttYXJrIGZvcm1hdDogJXMiIChidWZmZXItbmFtZSkpKSkpKQogCiAo ZGVmdW4gYm9va21hcmstdXBncmFkZS12ZXJzaW9uLTAtYWxpc3QgKG9sZC1saXN0KQogICAiVXBn cmFkZSBhIHZlcnNpb24gMCBhbGlzdCBPTEQtTElTVCB0byB0aGUgY3VycmVudCB2ZXJzaW9uLiIK KyAgKGRlY2xhcmUgKG9ic29sZXRlIG5pbCAiMjcuMSIpKQogICAobWFwY2FyCiAgICAobGFtYmRh IChib29rbWFyaykKICAgICAgKGxldCogKChuYW1lICAgICAgKGNhciBib29rbWFyaykpCkBAIC02 ODMsMTEgKzY3NywxNCBAQCBib29rbWFyay11cGdyYWRlLXZlcnNpb24tMC1hbGlzdAogKGRlZnVu IGJvb2ttYXJrLXVwZ3JhZGUtZmlsZS1mb3JtYXQtZnJvbS0wICgpCiAgICJVcGdyYWRlIGEgYm9v a21hcmsgZmlsZSBvZiBmb3JtYXQgMCAodGhlIG9yaWdpbmFsIGZvcm1hdCkgdG8gZm9ybWF0IDEu CiBUaGlzIGV4cGVjdHMgdG8gYmUgY2FsbGVkIGZyb20gYHBvaW50LW1pbicgaW4gYSBib29rbWFy ayBmaWxlLiIKKyAgKGRlY2xhcmUgKG9ic29sZXRlIG5pbCAiMjcuMSIpKQogICAobGV0KiAoKHJl cG9ydGVyIChtYWtlLXByb2dyZXNzLXJlcG9ydGVyCiAgICAgICAgICAgICAgICAgICAgIChmb3Jt YXQgIlVwZ3JhZGluZyBib29rbWFyayBmb3JtYXQgZnJvbSAwIHRvICVkLi4uIgotICAgICAgICAg ICAgICAgICAgICAgYm9va21hcmstZmlsZS1mb3JtYXQtdmVyc2lvbikpKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGJvb2ttYXJrLWZpbGUtZm9ybWF0LXZlcnNpb24pKSkKICAgICAgICAg IChvbGQtbGlzdCAoYm9va21hcmstYWxpc3QtZnJvbS1idWZmZXIpKQotICAgICAgICAgKG5ldy1s aXN0IChib29rbWFyay11cGdyYWRlLXZlcnNpb24tMC1hbGlzdCBvbGQtbGlzdCkpKQorICAgICAg ICAgKG5ldy1saXN0ICh3aXRoLXN1cHByZXNzZWQtd2FybmluZ3MKKyAgICAgICAgICAgICAgICAg ICAgICAgKChvYnNvbGV0ZSBib29rbWFyay11cGdyYWRlLXZlcnNpb24tMC1hbGlzdCkpCisgICAg ICAgICAgICAgICAgICAgICAoYm9va21hcmstdXBncmFkZS12ZXJzaW9uLTAtYWxpc3Qgb2xkLWxp c3QpKSkpCiAgICAgKGRlbGV0ZS1yZWdpb24gKHBvaW50LW1pbikgKHBvaW50LW1heCkpCiAgICAg KGJvb2ttYXJrLWluc2VydC1maWxlLWZvcm1hdC12ZXJzaW9uLXN0YW1wIGJ1ZmZlci1maWxlLWNv ZGluZy1zeXN0ZW0pCiAgICAgKHBwIG5ldy1saXN0IChjdXJyZW50LWJ1ZmZlcikpCkBAIC02OTks NiArNjk2LDcgQEAgYm9va21hcmstdXBncmFkZS1maWxlLWZvcm1hdC1mcm9tLTAKIChkZWZ1biBi b29rbWFyay1ncm9rLWZpbGUtZm9ybWF0LXZlcnNpb24gKCkKICAgIlJldHVybiBhbiBpbnRlZ2Vy IHdoaWNoIGlzIHRoZSBmaWxlLWZvcm1hdCB2ZXJzaW9uIG9mIHRoaXMgYm9va21hcmsgZmlsZS4K IFRoaXMgZXhwZWN0cyB0byBiZSBjYWxsZWQgZnJvbSBgcG9pbnQtbWluJyBpbiBhIGJvb2ttYXJr IGZpbGUuIgorICAoZGVjbGFyZSAob2Jzb2xldGUgbmlsICIyNy4xIikpCiAgIChpZiAobG9va2lu Zy1hdCAiXjs7OzsiKQogICAgICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgICAgIChzYXZlLW1hdGNo LWRhdGEKQEAgLTcxNCwxMiArNzEyLDE4IEBAIGJvb2ttYXJrLW1heWJlLXVwZ3JhZGUtZmlsZS1m b3JtYXQKICAgIkNoZWNrIHRoZSBmaWxlLWZvcm1hdCB2ZXJzaW9uIG9mIHRoaXMgYm9va21hcmsg ZmlsZS4KIElmIHRoZSB2ZXJzaW9uIGlzIG5vdCB1cC10by1kYXRlLCB1cGdyYWRlIGl0IGF1dG9t YXRpY2FsbHkuCiBUaGlzIGV4cGVjdHMgdG8gYmUgY2FsbGVkIGZyb20gYHBvaW50LW1pbicgaW4g YSBib29rbWFyayBmaWxlLiIKLSAgKGxldCAoKHZlcnNpb24gKGJvb2ttYXJrLWdyb2stZmlsZS1m b3JtYXQtdmVyc2lvbikpKQorICAoZGVjbGFyZSAob2Jzb2xldGUgbmlsICIyNy4xIikpCisgIChs ZXQgKCh2ZXJzaW9uCisgICAgICAgICAod2l0aC1zdXBwcmVzc2VkLXdhcm5pbmdzCisgICAgICAg ICAgICAgKChvYnNvbGV0ZSBib29rbWFyay1ncm9rLWZpbGUtZm9ybWF0LXZlcnNpb24pKQorICAg ICAgICAgICAoYm9va21hcmstZ3Jvay1maWxlLWZvcm1hdC12ZXJzaW9uKSkpKQogICAgIChjb25k CiAgICAgICgoPSB2ZXJzaW9uIGJvb2ttYXJrLWZpbGUtZm9ybWF0LXZlcnNpb24pCiAgICAgICAp IDsgaG9tZSBmcmVlIC0tIHZlcnNpb24gaXMgY3VycmVudAogICAgICAoKD0gdmVyc2lvbiAwKQot ICAgICAgKGJvb2ttYXJrLXVwZ3JhZGUtZmlsZS1mb3JtYXQtZnJvbS0wKSkKKyAgICAgICh3aXRo LXN1cHByZXNzZWQtd2FybmluZ3MKKyAgICAgICAgICAoKG9ic29sZXRlIGJvb2ttYXJrLXVwZ3Jh ZGUtZmlsZS1mb3JtYXQtZnJvbS0wKSkKKyAgICAgICAgKGJvb2ttYXJrLXVwZ3JhZGUtZmlsZS1m b3JtYXQtZnJvbS0wKSkpCiAgICAgICh0CiAgICAgICAoZXJyb3IgIkJvb2ttYXJrIGZpbGUgZm9y bWF0IHZlcnNpb24gc3RyYW5nZW5lc3MiKSkpKSkKIApAQCAtMTU0MSw3ICsxNTQ1LDYgQEAgYm9v a21hcmstbG9hZAogICAgICAgKHdpdGgtY3VycmVudC1idWZmZXIgKGxldCAoZW5hYmxlLWxvY2Fs LXZhcmlhYmxlcykKIAkJCSAgICAgKGZpbmQtZmlsZS1ub3NlbGVjdCBmaWxlKSkKIAkoZ290by1j aGFyIChwb2ludC1taW4pKQotCShib29rbWFyay1tYXliZS11cGdyYWRlLWZpbGUtZm9ybWF0KQog CShsZXQgKChibGlzdCAoYm9va21hcmstYWxpc3QtZnJvbS1idWZmZXIpKSkKIAkgICh1bmxlc3Mg KGxpc3RwIGJsaXN0KQogCSAgICAoZXJyb3IgIkludmFsaWQgYm9va21hcmsgbGlzdCBpbiAlcyIg ZmlsZSkpCi0tIAoyLjIwLjEKCg== --000000000000a5894e0590915a68-- From unknown Fri Sep 05 11:00:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37122: [PATCH] Remove support for upgrading from old bookmark file format Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 03:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37122 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 37122@debbugs.gnu.org Received: via spool by 37122-submit@debbugs.gnu.org id=B37122.156653206619645 (code B ref 37122); Fri, 23 Aug 2019 03:48:02 +0000 Received: (at 37122) by debbugs.gnu.org; 23 Aug 2019 03:47:46 +0000 Received: from localhost ([127.0.0.1]:38731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i10YD-00056n-RN for submit@debbugs.gnu.org; Thu, 22 Aug 2019 23:47:46 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i10YC-00056f-0s for 37122@debbugs.gnu.org; Thu, 22 Aug 2019 23:47:44 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i10Y8-0003Pu-OI; Fri, 23 Aug 2019 05:47:43 +0200 From: Lars Ingebrigtsen References: Date: Fri, 23 Aug 2019 05:47:40 +0200 In-Reply-To: (Stefan Kangas's message of "Tue, 20 Aug 2019 21:20:37 +0200") Message-ID: <87o90gsftv.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > The old bookmark file format has not been used in Emacs since at least > version 19.34, released in 1996. And that's a conservative estimate > -- it's probably even older. I suggest that we remove t [...] Content analysis details: (-2.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 NO_DNS_FOR_FROM DNS: Envelope sender has no MX or A DNS records -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.9 DKIM_ADSP_NXDOMAIN No valid author signature and domain not in DNS -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Stefan Kangas writes: > The old bookmark file format has not been used in Emacs since at least > version 19.34, released in 1996. And that's a conservative estimate > -- it's probably even older. I suggest that we remove the support for > converting it to the new bookmark file format completely in order to > not have to maintain this ancient code. I think that makes sense -- surely there can't be many people making the jump from 19.34 to Emacs 27 these days. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Sep 05 11:00:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37122: [PATCH] Remove support for upgrading from old bookmark file format Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Sep 2019 20:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37122 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 37122@debbugs.gnu.org Received: via spool by 37122-submit@debbugs.gnu.org id=B37122.156797589616983 (code B ref 37122); Sun, 08 Sep 2019 20:52:02 +0000 Received: (at 37122) by debbugs.gnu.org; 8 Sep 2019 20:51:36 +0000 Received: from localhost ([127.0.0.1]:39210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i749o-0004Pq-D0 for submit@debbugs.gnu.org; Sun, 08 Sep 2019 16:51:36 -0400 Received: from mail-pg1-f179.google.com ([209.85.215.179]:44372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i749k-0004PP-Ud for 37122@debbugs.gnu.org; Sun, 08 Sep 2019 16:51:33 -0400 Received: by mail-pg1-f179.google.com with SMTP id i18so6566199pgl.11 for <37122@debbugs.gnu.org>; Sun, 08 Sep 2019 13:51:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aRriG26PeaEQFTqbjkgay8ByLz9bcnm0mo/6nUZAhTA=; b=h8DlcYK29+ZItu+aLdBl+rWibkJdvqvMz/MXBujGTW3etlXBDVXsm/GAKXqTQBS0H8 chqOgpInFePSjAGi3l5EjhXIVHElESGREfhWTtxAauuEMqhSa0uI9JhZLi09yOjP3ESv 28vtpcAABn76DHnJZ1zIF4fgUpk1oi42y8U10IDhzRQS3EWH8c2HlO3LdtTMVhkKyyQb nJ/mfwpiJ+1WjOVTvlgHn/pmfDqbkhAfXv+HukL38JnrPaflMftOz9scLUP1w+atS2k4 wcfBCUCquADo0th+7oRTuCP7qVxBp/xchpXggN1fMVlI+s7R8XocB+42+8ztHtSFCl4S H0Vw== X-Gm-Message-State: APjAAAURGzcUKq9Kob2PbHreIXjEeMdZIYag2dtu/BRUYC2F+sG00LGU Nlq9SZknOF3Ftz5ksuzM3KYlCweBKrfRlmgUbgzoN5Mj87A= X-Google-Smtp-Source: APXvYqyNSSnndD+Fbt1zyjkmlzDKbmhI8PDsohEf6TjAl+vkddUZg2qkV+FH5PZdsxlRk+vctFY6GJc2QycfG1eleGc= X-Received: by 2002:aa7:8005:: with SMTP id j5mr23652574pfi.50.1567975887292; Sun, 08 Sep 2019 13:51:27 -0700 (PDT) MIME-Version: 1.0 References: <87o90gsftv.fsf@mouse.gnus.org> In-Reply-To: <87o90gsftv.fsf@mouse.gnus.org> From: Stefan Kangas Date: Sun, 8 Sep 2019 22:51:15 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 37122 27.1 quit Lars Ingebrigtsen writes: > > The old bookmark file format has not been used in Emacs since at least > > version 19.34, released in 1996. And that's a conservative estimate > > -- it's probably even older. I suggest that we remove the support for > > converting it to the new bookmark file format completely in order to > > not have to maintain this ancient code. > > I think that makes sense -- surely there can't be many people making the > jump from 19.34 to Emacs 27 these days. Thanks. Since there has been no other comments nor objections in the last two weeks, I've now installed this as commit e94d01f1ac. Best regards, Stefan Kangas