Subject: Re: bug#37120: [PATCH] Prefer display-line-numbers over linum in docs and custom

From: Stefan Kangas <[email-masked]>
Date: Tue, 20 Aug 2019 20:18:49 +0200

Eli Zaretskii <[email-masked]> writes:

> Thanks, but see the comments below.

Thanks for reviewing this patch.

> > --- a/doc/misc/efaq.texi
> > +++ b/doc/misc/efaq.texi
> > @@ -1687,7 +1687,7 @@ Displaying the current line or column
> >  this variable.
> >
> >  @cindex Set number capability in @code{vi} emulators
> > -The @samp{linum} package (distributed with Emacs since version 23.1)
> > +@samp{display-line-numbers-mode} (added to Emacs in version 26.1)
> >  displays line numbers in the left margin, like the ``set number''
> >  capability of @code{vi}.  The packages @samp{setnu} and
>
> This is incorrect: display-line-numbers-mode doesn't use the display
> margin (linum.el did).

Would "displays line numbers on the left side of the current window"
be more precise?

> > diff --git a/lisp/progmodes/prog-mode.el b/lisp/progmodes/prog-mode.el
> > index cb39e62265..8d3513bad3 100644
> > --- a/lisp/progmodes/prog-mode.el
> > +++ b/lisp/progmodes/prog-mode.el
> > @@ -39,7 +39,8 @@ prog-mode
> >  (defcustom prog-mode-hook nil
> >    "Normal hook run when entering programming modes."
> >    :type 'hook
> > -  :options '(flyspell-prog-mode abbrev-mode flymake-mode linum-mode
> > +  :options '(flyspell-prog-mode abbrev-mode flymake-mode
> > +                                display-line-numbers-mode
> >                                  prettify-symbols-mode)
>
> Hmm... is it reasonable to run prog-mode-hook just because someone
> turns on line numbers?  It sounds too drastic to me.

I'm not sure I understand what you mean.  I thought that this just
means that when running M-x customize-option RET prog-mode-hook RET we
show display-line-numbers-mode instead of linum-mode as an option.  Is
there something I'm missing here?

Best regards,
Stefan Kangas