GNU bug report logs - #37087
indent-for-tab-command not ready for GNUmakefile mode

Previous Next

Package: emacs;

Reported by: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>

Date: Mon, 19 Aug 2019 20:44:02 UTC

Severity: minor

Tags: confirmed

To reply to this bug, email your comments to 37087 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#37087; Package emacs. (Mon, 19 Aug 2019 20:44:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 19 Aug 2019 20:44:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: indent-for-tab-command not ready for GNUmakefile mode
Date: Tue, 20 Aug 2019 02:02:33 +0800

TAB (translated from <tab>) runs the command indent-for-tab-command

However it ruins Makefiles.

C-x h TAB wipes out all indentation.

I don't know what it should do. All I know is it shouldn't wipe out all
indentation.

emacs-version "26.1"
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37087; Package emacs. (Wed, 30 Oct 2019 11:15:02 GMT) Full text and rfc822 format available.

Message #8 received at 37087 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 37087 <at> debbugs.gnu.org
Subject: Re: indent-for-tab-command not ready for GNUmakefile mode
Date: Wed, 30 Oct 2019 12:14:13 +0100

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> TAB (translated from <tab>) runs the command indent-for-tab-command
>
> However it ruins Makefiles.
>
> C-x h TAB wipes out all indentation.
>
> I don't know what it should do. All I know is it shouldn't wipe out all
> indentation.

If I try `C-x h TAB' in Emacs 27, it just inserts a TAB character.  Is
there something else needed to reproduce the bug?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37087; Package emacs. (Tue, 05 Nov 2019 23:33:03 GMT) Full text and rfc822 format available.

Message #11 received at 37087 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 37087 <at> debbugs.gnu.org
Subject: Re: indent-for-tab-command not ready for GNUmakefile mode
Date: Wed, 06 Nov 2019 07:27:24 +0800

>>>>> "LI" == Lars Ingebrigtsen <larsi <at> gnus.org> writes:
LI> 積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

>> TAB (translated from <tab>) runs the command indent-for-tab-command
>> 
>> However it ruins Makefiles.
>> 
>> C-x h TAB wipes out all indentation.
>> 
>> I don't know what it should do. All I know is it shouldn't wipe out all
>> indentation.

LI> If I try `C-x h TAB' in Emacs 27, it just inserts a TAB character.  Is
LI> there something else needed to reproduce the bug?

Yes.
Somebody else's makefile. The bigger the better.
Not an empty makefile.
You are testing on an empty makefile. Don't.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37087; Package emacs. (Thu, 06 Aug 2020 16:31:01 GMT) Full text and rfc822 format available.

Message #14 received at 37087 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 37087 <at> debbugs.gnu.org
Subject: Re: bug#37087: indent-for-tab-command not ready for GNUmakefile mode
Date: Thu, 06 Aug 2020 18:30:18 +0200

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> LI> If I try `C-x h TAB' in Emacs 27, it just inserts a TAB character.  Is
> LI> there something else needed to reproduce the bug?
>
> Yes.
> Somebody else's makefile. The bigger the better.
> Not an empty makefile.
> You are testing on an empty makefile. Don't.

No, I was testing without transient mark mode -- it has to be on to
reproduce the bug.

So the bug is (with transient-mark-mode): Mark a region (that contains
tabs), and then hit TAB.  It'll remove all the (leading) tabs in the
region, oddly enough.

The bug is still present in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) confirmed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 06 Aug 2020 16:31:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37087; Package emacs. (Tue, 03 May 2022 14:04:01 GMT) Full text and rfc822 format available.

Message #19 received at 37087 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 37087 <at> debbugs.gnu.org
Subject: Re: bug#37087: indent-for-tab-command not ready for GNUmakefile mode
Date: Tue, 03 May 2022 16:03:41 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> So the bug is (with transient-mark-mode): Mark a region (that contains
> tabs), and then hit TAB.  It'll remove all the (leading) tabs in the
> region, oddly enough.
>
> The bug is still present in Emacs 28.

I've now fixed this in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
bug marked as fixed in version 29.1, send any further explanations to 37087 <at> debbugs.gnu.org and 積丹尼 Dan Jacobson <jidanni <at> jidanni.org> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 03 May 2022 14:04:02 GMT) Full text and rfc822 format available.
bug No longer marked as fixed in versions 29.1 and reopened. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 16 May 2022 12:27:03 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#37087; Package emacs. (Mon, 16 May 2022 12:28:02 GMT) Full text and rfc822 format available.

Message #26 received at 37087 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 37087 <at> debbugs.gnu.org
Subject: Re: bug#37087: indent-for-tab-command not ready for GNUmakefile mode
Date: Mon, 16 May 2022 14:26:56 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I've now fixed this in Emacs 29.

The change led to bug#55446, so I've reverted the change and reopened
this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 3 years and 31 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.