GNU bug report logs - #37052
[PATCH] (wip-haskell-updates) Add stylish-haskell.

Previous Next

Package: guix-patches;

Reported by: John Soo <jsoo1 <at> asu.edu>

Date: Fri, 16 Aug 2019 14:26:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: John Soo <jsoo1 <at> asu.edu>
To: 37052 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [bug#37052] [PATCH] (wip-haskell-updates) Add stylish-haskell.
Date: Thu, 29 Aug 2019 14:50:24 +0000
[Message part 1 (text/plain, inline)]
HI Ludo and Timothy,

Thanks for the review.

> Please address the ‘guix lint’ warning.

I fixed all the lint errors (and the offending commit message, woops!).

> Better to keep each on a single line.  :-)

I put them each on a single line, I like that better!

> +and turn them into (path, bytestring) pairs embedded in your Haskell
code.")

I used @code{(path, bytestring)} for this tuple. Is that desired?

> It’s too new.  Right now we are following LTS 12, which has file-embed
> at 0.0.10.1.

I changed it to version 0.0.10.1.

Thanks again!

- John
[Message part 2 (text/html, inline)]
[0001-gnu-Add-ghc-file-embed.patch (text/x-patch, attachment)]
[0002-gnu-Add-stylish-haskell.patch (text/x-patch, attachment)]

This bug report was last modified 5 years and 347 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.