Subject: Re: [bug#37052] [PATCH] (wip-haskell-updates) Add stylish-haskell.

From: Ludovic Courtès <[email-masked]>
Date: Wed, 28 Aug 2019 18:08:54 +0200

Hi John,

John Soo <[email-masked]> skribis:

> From 512eed6f9d3cc788c381378557d576e470600ca0 Mon Sep 17 00:00:00 2001
> From: John Soo <[email-masked]>
> Date: Fri, 16 Aug 2019 07:18:30 -0700
> Subject: [PATCH 1/2] gnu: Add ghc-file-embed.
>
> * gnu/packages/haskell-xyz (ghc-file-embed): new file.

Please address the ‘guix lint’ warning.

> +  (package
> +    (name "ghc-file-embed")
> +    (version "0.0.11")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri
> +        (string-append
> +         "https://hackage.haskell.org/package/file-embed/"
> +         "file-embed-" version ".tar.gz"))

I think Robert (Cc’d) aims make sure all the GHC packages come from the
same Stackage “snapshot”.  Robert, could you tell whether this is the
case?

Also, please use mirror://hackage here.

> +    (home-page
> +     "https://github.com/snoyberg/file-embed")
> +    (synopsis
> +     "Use Template Haskell to embed file contents directly.")

Better to keep each on a single line.  :-)

> +    (description
> +     "Use Template Haskell to read a file or all the files in a directory,
> +and turn them into (path, bytestring) pairs embedded in your Haskell code.")

Please see
<https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html>.

> From fe5cbaeb2364d5d5debd629090d4a1fdd6f5939a Mon Sep 17 00:00:00 2001
> From: John Soo <[email-masked]>
> Date: Fri, 16 Aug 2019 07:20:28 -0700
> Subject: [PATCH 2/2] gnu: Add stylish-haskell.
>
> * gnu/packages/haskell-apps (stylish-haskell): new variable.

Same comments.  :-)

Thanks,
Ludo’.