GNU bug report logs - #37043
[PATCH] gnu: font-ibm-plex: Update to 2.0.0.

Previous Next

Package: guix-patches;

Reported by: Alva <alva <at> skogen.is>

Date: Thu, 15 Aug 2019 23:12:01 UTC

Severity: normal

Tags: patch

Done: Tobias Geerinckx-Rice <me <at> tobias.gr>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37043: closed ([PATCH] gnu: font-ibm-plex: Update to 2.0.0.)
Date: Fri, 16 Aug 2019 20:01:03 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 16 Aug 2019 22:00:08 +0200
with message-id <875zmw98zb.fsf <at> nckx>
and subject line Re: [bug#37043] [PATCH] gnu: font-ibm-plex: Update to 2.0.0.
has caused the debbugs.gnu.org bug report #37043,
regarding [PATCH] gnu: font-ibm-plex: Update to 2.0.0.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37043: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37043
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Alva <alva <at> skogen.is>
To: guix-patches <at> gnu.org
Cc: Alva <alva <at> skogen.is>
Subject: [PATCH] gnu: font-ibm-plex: Update to 2.0.0.
Date: Fri, 16 Aug 2019 00:52:08 +0200
The 1.0.1 release did not work, due to macOS junk files in the release zip.

* gnu/packages/fonts.scm (font-ibm-plex): Update to 2.0.0.
---
 gnu/packages/fonts.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 2dc1df45c8..1e28191ae1 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -26,6 +26,7 @@
 ;;; Copyright © 2019 Jens Mølgaard <jens <at> zete.tk>
 ;;; Copyright © 2019 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;; Copyright © 2019 Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
+;;; Copyright © 2019 Alva <alva <at> skogen.is>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -63,7 +64,7 @@
 (define-public font-ibm-plex
   (package
     (name "font-ibm-plex")
-    (version "1.0.1")
+    (version "2.0.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -71,7 +72,7 @@
                     "v" version "/OpenType.zip"))
               (sha256
                (base32
-                "0nzxw9z6waixslam248yr26ci3fbk83c7jf6m90hncnaj6zxx795"))))
+                "1lv65z3qnqgh2w36daf5wyz0ma9rg1qj9s9lzlnva8l7q3h8c9b8"))))
     (build-system font-build-system)
     (home-page "https://github.com/IBM/plex")
     (synopsis "IBM Plex typeface")
-- 
2.22.1



[Message part 3 (message/rfc822, inline)]
From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: guix-patches <at> gnu.org
Cc: 37043-done <at> debbugs.gnu.org
Subject: Re: [bug#37043] [PATCH] gnu: font-ibm-plex: Update to 2.0.0.
Date: Fri, 16 Aug 2019 22:00:08 +0200
[Message part 4 (text/plain, inline)]
Alva,

Alva 写道:
>> I wonder whether making 
>> %license-file-regexp in (guix build gnu-build-system) would 
>> have 
>> any unintended consequences. 
>
> My brain added "case-insensitive"; I don't know if that's what 
> you meant. :)

Your brain is absolutely right; mine's still in holiday mode.  :-)

> Anyway, I checked the regexp, and `[Ll]icen[cs]e.*` already 
> matches license.txt,
> so I don't know where it goes wrong.

Not sure what's going on then.

> Yes, my output is different; it contains a number of files that 
> have the
> same names as yours, except prefixed with "._", which file(1) 
> identifies as
> AppleDouble encoded Macintosh files, and LICENSE.txt is missing.
> These files come from the aforementioned __MACOSX directory in 
> the 1.0.1 zip.
> I'm using btrfs, FWIW.

S'oh boy.  My previous ‘good’ output was built on ext4.  Here's 
what building 1.0.1 on btrfs (and 4 cores) gave me.  Safe to say 
this package isn't exactly deterministic there.

 $ guix describe
   Generation 28   Aug 16 2019 15:11:34    (current)
   …
     guix 4cc5e52
       repository URL: https://git.savannah.gnu.org/git/guix.git
       branch: master
       commit: 4cc5e5204b503afb4536a1e93e2fd7a9f57f12bf

 $ tree `guix build font-ibm-plex`
 /gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1
 └── share
     └── fonts
         └── opentype

 3 directories, 0 files

 $

That's 3 very different possible outcomes so far.  My emptiness is 
reproducible on this machine, though.

I've pushed your patch (without the note about it not working 
since It's Complicated and there's no need to justify a bump 
anyway) as 93b3ef1966f9860ae88b87263f8c7f6052565c3f.  It's now 
reproducible on all my file systems, but feel free to try more. 
Thanks!

Kind regards,

T G-R
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 5 years and 277 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.