From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 15 03:38:29 2019 Received: (at submit) by debbugs.gnu.org; 15 Aug 2019 07:38:29 +0000 Received: from localhost ([127.0.0.1]:50551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyAL7-0001TB-Ag for submit@debbugs.gnu.org; Thu, 15 Aug 2019 03:38:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:60179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyAL5-0001T4-9f for submit@debbugs.gnu.org; Thu, 15 Aug 2019 03:38:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58799) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyAL3-0007Fp-Fi for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 03:38:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyAL1-0004wE-Hq for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 03:38:25 -0400 Received: from mail.choca.pics ([62.210.108.126]:40906) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hyAL0-0004o5-UG for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 03:38:23 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 30AE2F19845 for ; Thu, 15 Aug 2019 09:38:13 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id OBk9XIe1Z2MW for ; Thu, 15 Aug 2019 09:38:12 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 7A3F2F19A03 for ; Thu, 15 Aug 2019 09:38:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id fAjipt8wrLWt for ; Thu, 15 Aug 2019 09:38:12 +0200 (CEST) Received: from luz4 (199.138.120.78.rev.sfr.net [78.120.138.199]) by mail.choca.pics (Postfix) with ESMTPSA id 3FE06F19845 for ; Thu, 15 Aug 2019 09:38:12 +0200 (CEST) From: Damien Cassou To: bug-gnu-emacs@gnu.org Subject: 26.2.90; checkdoc doesn't support cl-defgeneric, cl-defmethod and cl-defun Date: Thu, 15 Aug 2019 09:38:10 +0200 Message-ID: <877e7e280t.fsf@cassou.me> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 62.210.108.126 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi, I rely on checkdoc to write clean docstrings. I rely on CL when writing libraries to facilitate writing extensions through specialization. Nevertheless, checkdoc won't check the docstrings of cl-defgeneric, cl-defmethod and cl-defun. Best, -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 15 10:54:59 2019 Received: (at 37034) by debbugs.gnu.org; 15 Aug 2019 14:54:59 +0000 Received: from localhost ([127.0.0.1]:52188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyH9W-0004Vs-PR for submit@debbugs.gnu.org; Thu, 15 Aug 2019 10:54:59 -0400 Received: from mail-oi1-f177.google.com ([209.85.167.177]:46658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyH9U-0004VW-4j; Thu, 15 Aug 2019 10:54:56 -0400 Received: by mail-oi1-f177.google.com with SMTP id t24so2276843oij.13; Thu, 15 Aug 2019 07:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=y4KB3IisrTbYQj+uHG6AFSZ68V1VjcnJLn4WKeDDqCs=; b=m7Da903L0dvadyvZ9lughbTd0WapxAyqezsIcVyxNrx3gwouR1aCpDBEGxa6Cliwxu n21UA10Pn43si9qwz1eo7cMHhpH6shccq7vcR0h4YqX2j1SxqkEmgJdYeqROOayT22Ds Fz2gip2dbMYokHUyt4BsyMojAJ5qsbtfr67TTDyeg1fvuVBGirtg5D35V3qmexlAkB+d eabyV5N1ahkY999VoIueZx5r3CQFBDt5Ki3+14kharLrZcSmj3uueUX+EX+s3VGxWkfm l+b+hlNSUbxJ7RmfOPs7qW/8maYRDAU0Y9Q76l2IjJtTvTHmsWQbwjVreOdG0qpmrr4S wcbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=y4KB3IisrTbYQj+uHG6AFSZ68V1VjcnJLn4WKeDDqCs=; b=fiGjSDinX521OrqfgU4X8AITgl/v58xXfiFf7+eYLMY0WYr5JhLuqBRAuwqiU3TD1R tfcN8mt2GY3vLCnHQzpYq52XGy9aItxQKDE5B1VJtWKoDyEIjF6b8azHfF23ZCi4VrKe pNUPUZyrRUePKMEU171/oCUJu+d7ShzvIGW3nRXASwfQvuTWx4EdHB0E0Ok1ctM24pH1 aEy3mnz8r/QBk5pG6Y0hVw9s0jucV4Av06kqh3rSjoIKW2t3vbe9LjTd+TJV2+coEHWv 6NPaH7FMWGqdZ9LX0iUOa+CmA0vV3iOhTHraMQffiIxq9P1Z566aY+5eYwGGH9HEQogi +6qw== X-Gm-Message-State: APjAAAXb9YXMeVCPHKhnhbHaOeCMFpJ9YpfDF3WS8QnFmDjTNsiz/CVK tVvMPyLeLozQGRgZe4QrYeemw1FHZuM= X-Google-Smtp-Source: APXvYqwtSBLJcr75BXyutseMCZf991+G0swCU6iSH1aLow2YWeJzu9CCV8RpwV6OT6/jnu81IMUpug== X-Received: by 2002:aca:5941:: with SMTP id n62mr1726928oib.76.1565880889681; Thu, 15 Aug 2019 07:54:49 -0700 (PDT) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id s5sm1040955otk.11.2019.08.15.07.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2019 07:54:48 -0700 (PDT) From: Alex Branham To: Damien Cassou Subject: Re: bug#37034: 26.2.90; checkdoc doesn't support cl-defgeneric, cl-defmethod and cl-defun References: <877e7e280t.fsf@cassou.me> Date: Thu, 15 Aug 2019 09:54:47 -0500 In-Reply-To: <877e7e280t.fsf@cassou.me> (Damien Cassou's message of "Thu, 15 Aug 2019 09:38:10 +0200") Message-ID: <871rxmxyvc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37034 Cc: 37034@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 37034 + patch quit On Thu 15 Aug 2019 at 09:38, Damien Cassou wrote: > I rely on checkdoc to write clean docstrings. I rely on CL when writing > libraries to facilitate writing extensions through > specialization. Nevertheless, checkdoc won't check the docstrings of > cl-defgeneric, cl-defmethod and cl-defun. Patch attached should fix the issue. Thanks, Alex --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Make-checkdoc-check-cl-lib-function-docstrings.patch Content-Description: patch >From d52d04d62c14c0c228a5d430188db5c76cac767d Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Thu, 15 Aug 2019 09:51:23 -0500 Subject: [PATCH] Make checkdoc check cl-lib function docstrings * lisp/emacs-lisp/checkdoc.el (checkdoc--next-docstring) (checkdoc-defun-info): Include cl-defun, cl-defgeneric, cl-defmethod. bug#37034 --- lisp/emacs-lisp/checkdoc.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index 830743f5f8..ce36596423 100644 --- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -933,7 +933,7 @@ don't move point." ;; Don't bug out if the file is empty (or a ;; definition ends prematurely. (end-of-file))) - (`(,(or 'defun 'defvar 'defcustom 'defmacro 'defconst 'defsubst 'defadvice) + (`(,(or 'defun 'defvar 'defcustom 'defmacro 'defconst 'defsubst 'defadvice 'cl-defun 'cl-defgeneric 'cl-defmethod) ,(pred symbolp) ;; Require an initializer, i.e. ignore single-argument `defvar' ;; forms, which never have a doc string. @@ -1885,7 +1885,8 @@ the token checkdoc-order: exists, and TOKEN is a symbol read from the comment." (save-excursion (beginning-of-defun) - (let ((defun (looking-at "(def\\(un\\|macro\\|subst\\|advice\\)")) + (let ((defun (looking-at + "(\\(?:cl-\\)?def\\(un\\|macro\\|subst\\|advice\\|generic\\|method\\)")) (is-advice (looking-at "(defadvice")) (lst nil) (ret nil) -- 2.22.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 08:28:38 2019 Received: (at 37034) by debbugs.gnu.org; 16 Aug 2019 12:28:38 +0000 Received: from localhost ([127.0.0.1]:53253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hybLS-0008KO-0O for submit@debbugs.gnu.org; Fri, 16 Aug 2019 08:28:38 -0400 Received: from mail.choca.pics ([62.210.108.126]:49664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hybLO-0008KF-7g for 37034@debbugs.gnu.org; Fri, 16 Aug 2019 08:28:36 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 9AABCF05329; Fri, 16 Aug 2019 14:28:32 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id jEfd9zyEN8Za; Fri, 16 Aug 2019 14:28:32 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 068B8F0532F; Fri, 16 Aug 2019 14:28:32 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id uY8dimWcOaPT; Fri, 16 Aug 2019 14:28:31 +0200 (CEST) Received: from luz4 (199.138.120.78.rev.sfr.net [78.120.138.199]) by mail.choca.pics (Postfix) with ESMTPSA id BB484F05329; Fri, 16 Aug 2019 14:28:31 +0200 (CEST) From: Damien Cassou To: Alex Branham Subject: Re: bug#37034: 26.2.90; checkdoc doesn't support cl-defgeneric, cl-defmethod and cl-defun In-Reply-To: <871rxmxyvc.fsf@gmail.com> References: <877e7e280t.fsf@cassou.me> <871rxmxyvc.fsf@gmail.com> Date: Fri, 16 Aug 2019 14:28:30 +0200 Message-ID: <87r25l1ehd.fsf@cassou.me> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37034 Cc: 37034@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Alex, Alex Branham writes: > tags 37034 + patch thank you for your patch. Nevertheless, it's not going to be enough. For example, CL methods can have this signature: (cl-defmethod navigel-children ((entities list) callback) "Execute CALLBACK with the children of ENTITIES as argument." (navigel-async-mapcar entities #'navigel-children callback)) But this crashes checkdoc+patch because it expects each element of the parameter list to be a symbol which (entities list) is not. Also, CL methods accept &key and &context to specify parameters. Those should be taken care of by checkdoc in one way or another. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 13:26:21 2019 Received: (at 37034) by debbugs.gnu.org; 16 Aug 2019 17:26:22 +0000 Received: from localhost ([127.0.0.1]:54853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyfzY-0003Rm-0s for submit@debbugs.gnu.org; Fri, 16 Aug 2019 13:26:21 -0400 Received: from mail-ot1-f43.google.com ([209.85.210.43]:40860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyfzV-0003RY-En for 37034@debbugs.gnu.org; Fri, 16 Aug 2019 13:26:18 -0400 Received: by mail-ot1-f43.google.com with SMTP id c34so10281959otb.7 for <37034@debbugs.gnu.org>; Fri, 16 Aug 2019 10:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/a8wPRG6XbKG2z3iYWfEHEh7Uw3t1vilHMTznflYP4w=; b=OtXk6CJK28O4+tvBSLGP43NBWfRSqvOS4Yd9GXiQIkaWU/8b7gwDt/JfX0jGaSo3RG h1MueSeXHOBJDGd/EdPsvlAT6RYIi4fZOx75d34O7Z+Fo0aYDgvByeJ4i7zobiWb1ZYv zme2dmguPa5/3+UXnTYp8UREYIONWkuoomSlpgh2D86APFBDgn0433JuUmyARQQCQ8eo SoZI+nK8YENFqXoB7x0E2O7Eo62YjWcON+4iwRLTxk80w5iE5xzxpK6l+O3NqDcHvuWd 2C9aBkGh+q+7hd+DncC4tUS+ibHYcHX2/1qfFl8+l6p92AQJ+CDSAIfSe/SoCc5mZj8P fY2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/a8wPRG6XbKG2z3iYWfEHEh7Uw3t1vilHMTznflYP4w=; b=FaXO5VEXun/5GZjFKoVfIkwwRaoP9QmdxEj3clMXAZ/SLF5zXY2VkbYFUbhpkeHXUn 23R0qvuSf6fTXEoDRI0mVa225UcGXlMagMMxFL9Ig0mOhbFf+wNWtgCA7hAHQ1ZAwpX4 ABh0ZqtzD3ZJjjPk63h3BTg8rSSo6Uwyj0mqCgiML5KNJcT6SdpqDJpTqtoO/vBOHztm YL4hkNaMePv/8IPMgR3LzRmba4HlNo/k0xuxmEl9kdBYLiLD3dxJa0Z5EqxuEFDXf//M dqujdD6sxjF8A+wI8nJLfJQ8lao8pw+uIhGSrksFHrO7I1B1c0pbsgegO2T8Fac+Fj0V 2bIg== X-Gm-Message-State: APjAAAWIO5JyHxZhLfSx40fKaeTRAOtQIWXWhe9P4N5AF6WEH2To1Y+p ul78rJ5q0L8OEnxzcYQixMyO8VBc X-Google-Smtp-Source: APXvYqyoHzlElB+l2GAbarX6hxBUOV5PMC9zfJHO+AEijB4GSDnd15vZCq7LAdpckj/K3/iWOa55Cw== X-Received: by 2002:a9d:3f4b:: with SMTP id m69mr7029488otc.301.1565976371518; Fri, 16 Aug 2019 10:26:11 -0700 (PDT) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id t18sm2274510otk.73.2019.08.16.10.26.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 10:26:10 -0700 (PDT) From: Alex Branham To: Damien Cassou Subject: Re: bug#37034: 26.2.90; checkdoc doesn't support cl-defgeneric, cl-defmethod and cl-defun References: <877e7e280t.fsf@cassou.me> <871rxmxyvc.fsf@gmail.com> <87r25l1ehd.fsf@cassou.me> Date: Fri, 16 Aug 2019 12:26:08 -0500 In-Reply-To: <87r25l1ehd.fsf@cassou.me> (Damien Cassou's message of "Fri, 16 Aug 2019 14:28:30 +0200") Message-ID: <874l2hm37z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 37034 Cc: 37034@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) --=-=-= Content-Type: text/plain On Fri 16 Aug 2019 at 14:28, Damien Cassou wrote: > But this crashes checkdoc+patch because it expects each element of the > parameter list to be a symbol which (entities list) is not. > > Also, CL methods accept &key and &context to specify parameters. Those > should be taken care of by checkdoc in one way or another. True, thanks for reminding me. The attached patch should take care of these two scenarios. Alex --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Make-checkdoc-check-cl-lib-function-docstrings.patch >From 9c0b32423dc95a2d66134132e21a0b59457cdb25 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Thu, 15 Aug 2019 09:51:23 -0500 Subject: [PATCH] Make checkdoc check cl-lib function docstrings * lisp/emacs-lisp/checkdoc.el (checkdoc--next-docstring) (checkdoc-defun-info): Include cl-defun, cl-defgeneric, cl-defmethod. (checkdoc-this-string-valid-engine): Add cl-lib supported keywords. (checkdoc-defun-info): Ensure function parameters are a "flat" list. bug#37034 --- lisp/emacs-lisp/checkdoc.el | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index 830743f5f8..8c3276efb8 100644 --- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -933,7 +933,8 @@ don't move point." ;; Don't bug out if the file is empty (or a ;; definition ends prematurely. (end-of-file))) - (`(,(or 'defun 'defvar 'defcustom 'defmacro 'defconst 'defsubst 'defadvice) + (`(,(or 'defun 'defvar 'defcustom 'defmacro 'defconst 'defsubst 'defadvice + 'cl-defun 'cl-defgeneric 'cl-defmethod 'cl-defmacro) ,(pred symbolp) ;; Require an initializer, i.e. ignore single-argument `defvar' ;; forms, which never have a doc string. @@ -1680,7 +1681,10 @@ function,command,variable,option or symbol." ms1)))))) (last-pos 0) (found 1) (order (and (nth 3 fp) (car (nth 3 fp)))) - (nocheck (append '("&optional" "&rest") (nth 3 fp))) + (nocheck (append '("&optional" "&rest" "&key" "&aux" + "&context" "&environment" "&whole" + "&body" "&allow-other-keys") + (nth 3 fp))) (inopts nil)) (while (and args found (> found last-pos)) (if (or (member (car args) nocheck) @@ -1885,7 +1889,8 @@ the token checkdoc-order: exists, and TOKEN is a symbol read from the comment." (save-excursion (beginning-of-defun) - (let ((defun (looking-at "(def\\(un\\|macro\\|subst\\|advice\\)")) + (let ((defun (looking-at + "(\\(?:cl-\\)?def\\(un\\|macro\\|subst\\|advice\\|generic\\|method\\)")) (is-advice (looking-at "(defadvice")) (lst nil) (ret nil) @@ -1951,7 +1956,10 @@ from the comment." ;; This is because read will intern nil if it doesn't into the ;; new obarray. (if (not (listp lst)) (setq lst nil)) - (if is-advice nil + (unless is-advice + ;; lst here can be something like ((foo bar) baz) from + ;; cl-lib methods; flatten it: + (setq lst (flatten-tree lst)) (while lst (setq ret (cons (symbol-name (car lst)) ret) lst (cdr lst))))) -- 2.22.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 17:00:09 2019 Received: (at 37034) by debbugs.gnu.org; 16 Aug 2019 21:00:10 +0000 Received: from localhost ([127.0.0.1]:55004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjKT-0002jQ-HV for submit@debbugs.gnu.org; Fri, 16 Aug 2019 17:00:09 -0400 Received: from quimby.gnus.org ([80.91.231.51]:37850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjKS-0002i2-J9 for 37034@debbugs.gnu.org; Fri, 16 Aug 2019 17:00:08 -0400 Received: from [50.225.213.182] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyjKO-0000kQ-JG; Fri, 16 Aug 2019 23:00:07 +0200 From: Lars Ingebrigtsen To: Alex Branham Subject: Re: bug#37034: 26.2.90; checkdoc doesn't support cl-defgeneric, cl-defmethod and cl-defun References: <877e7e280t.fsf@cassou.me> <871rxmxyvc.fsf@gmail.com> <87r25l1ehd.fsf@cassou.me> <874l2hm37z.fsf@gmail.com> Date: Fri, 16 Aug 2019 14:00:00 -0700 In-Reply-To: <874l2hm37z.fsf@gmail.com> (Alex Branham's message of "Fri, 16 Aug 2019 12:26:08 -0500") Message-ID: <875zmwq10v.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alex Branham writes: > * lisp/emacs-lisp/checkdoc.el (checkdoc--next-docstring) > (checkdoc-defun-info): Include cl-defun, cl-defgeneric, > cl-defmethod. > (checkdoc-this-string-valid-engine): Add cl-lib supported > keywo [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37034 Cc: Damien Cassou , 37034@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Branham writes: > * lisp/emacs-lisp/checkdoc.el (checkdoc--next-docstring) > (checkdoc-defun-info): Include cl-defun, cl-defgeneric, > cl-defmethod. > (checkdoc-this-string-valid-engine): Add cl-lib supported > keywords. > (checkdoc-defun-info): Ensure function parameters are a > "flat" list. bug#37034 After doing some light testing, this seems to work for me too, and I'm applying the patch. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 17:00:47 2019 Received: (at control) by debbugs.gnu.org; 16 Aug 2019 21:00:47 +0000 Received: from localhost ([127.0.0.1]:55007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjL4-0003M6-RW for submit@debbugs.gnu.org; Fri, 16 Aug 2019 17:00:47 -0400 Received: from quimby.gnus.org ([80.91.231.51]:37922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjL3-0003Jf-0J for control@debbugs.gnu.org; Fri, 16 Aug 2019 17:00:45 -0400 Received: from [50.225.213.182] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyjKz-0000kr-S5 for control@debbugs.gnu.org; Fri, 16 Aug 2019 23:00:44 +0200 Date: Fri, 16 Aug 2019 14:00:38 -0700 Message-Id: <874l2gq0zt.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #37034 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 37034 fixed close 37034 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 37034 fixed close 37034 27.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 17 07:45:11 2019 Received: (at 37034) by debbugs.gnu.org; 17 Aug 2019 11:45:11 +0000 Received: from localhost ([127.0.0.1]:55385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyx8w-0007VS-3Y for submit@debbugs.gnu.org; Sat, 17 Aug 2019 07:45:11 -0400 Received: from mail.choca.pics ([62.210.108.126]:39370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyx8u-0007VJ-7Z for 37034@debbugs.gnu.org; Sat, 17 Aug 2019 07:45:09 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id DFE58F1BB48; Sat, 17 Aug 2019 13:45:06 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id NTn7ccROTkFi; Sat, 17 Aug 2019 13:45:06 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 49208F1BB4A; Sat, 17 Aug 2019 13:45:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id IMuhwmLWXKt0; Sat, 17 Aug 2019 13:45:06 +0200 (CEST) Received: from luz4 (199.138.120.78.rev.sfr.net [78.120.138.199]) by mail.choca.pics (Postfix) with ESMTPSA id F0428F1BB48; Sat, 17 Aug 2019 13:45:05 +0200 (CEST) From: Damien Cassou To: Lars Ingebrigtsen , Alex Branham Subject: Re: bug#37034: 26.2.90; checkdoc doesn't support cl-defgeneric, cl-defmethod and cl-defun In-Reply-To: <875zmwq10v.fsf@mouse.gnus.org> References: <877e7e280t.fsf@cassou.me> <871rxmxyvc.fsf@gmail.com> <87r25l1ehd.fsf@cassou.me> <874l2hm37z.fsf@gmail.com> <875zmwq10v.fsf@mouse.gnus.org> Date: Sat, 17 Aug 2019 13:45:05 +0200 Message-ID: <87ftm010e6.fsf@cassou.me> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37034 Cc: 37034@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Alex Branham writes: > >> * lisp/emacs-lisp/checkdoc.el (checkdoc--next-docstring) >> (checkdoc-defun-info): Include cl-defun, cl-defgeneric, >> cl-defmethod. >> (checkdoc-this-string-valid-engine): Add cl-lib supported >> keywords. >> (checkdoc-defun-info): Ensure function parameters are a >> "flat" list. bug#37034 > > After doing some light testing, this seems to work for me too, and I'm > applying the patch. I think there are problems with this patch. I opened a new bug report: bug#37063. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill From unknown Fri Jun 13 10:11:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 15 Sep 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator