GNU bug report logs - #37026
[PATCH] packages: Apply target triplet in bag-transitive-host-inputs.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Thompson, David" <dthompson2 <at> worcester.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37026: closed ([PATCH] packages: Apply target triplet in
 bag-transitive-host-inputs.)
Date: Mon, 26 Aug 2019 13:39:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 26 Aug 2019 09:38:27 -0400
with message-id <CAJ=RwfbSiu3Lb=msH4iKe_gSGVux56Yj+Uq+4x1gvS=1bF7QYA <at> mail.gmail.com>
and subject line Re: [bug#37026] [PATCH] packages: Apply target triplet in bag-transitive-host-inputs.
has caused the debbugs.gnu.org bug report #37026,
regarding [PATCH] packages: Apply target triplet in bag-transitive-host-inputs.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37026: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37026
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: David Thompson <dthompson2 <at> worcester.edu>
To: guix-patches <at> gnu.org
Cc: David Thompson <dthompson2 <at> worcester.edu>
Subject: [PATCH] packages: Apply target triplet in bag-transitive-host-inputs.
Date: Wed, 14 Aug 2019 08:57:55 -0400

Fixes a bug where propagated inputs that should be cross-compiled are instead
compiled for the host system.

* guix/packages.scm (bag-transitive-host-inputs): Call transitive-inputs in
  the context of the bag's target system triplet.
---
 guix/packages.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/packages.scm b/guix/packages.scm
index c94a651f27..143417b861 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -796,7 +796,8 @@ dependencies are known to build on SYSTEM."
 
 (define (bag-transitive-host-inputs bag)
   "Same as 'package-transitive-target-inputs', but applied to a bag."
-  (transitive-inputs (bag-host-inputs bag)))
+  (parameterize ((%current-target-system (bag-target bag)))
+    (transitive-inputs (bag-host-inputs bag))))
 
 (define (bag-transitive-target-inputs bag)
   "Return the \"target inputs\" of BAG, recursively."
-- 
2.17.1

[Message part 3 (message/rfc822, inline)]

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37026-done <at> debbugs.gnu.org
Subject: Re: [bug#37026] [PATCH] packages: Apply target triplet in
 bag-transitive-host-inputs.
Date: Mon, 26 Aug 2019 09:38:27 -0400

On Fri, Aug 23, 2019 at 5:31 PM Ludovic Courtès <ludo <at> gnu.org> wrote:
>
> Good catch, please push!

Thanks. Done!

- Dave

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.