From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 13 00:14:00 2019 Received: (at submit) by debbugs.gnu.org; 13 Aug 2019 04:14:00 +0000 Received: from localhost ([127.0.0.1]:47577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hxOC8-0005W6-Fu for submit@debbugs.gnu.org; Tue, 13 Aug 2019 00:14:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:37670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hxOC6-0005Vz-Uc for submit@debbugs.gnu.org; Tue, 13 Aug 2019 00:13:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37085) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxOC5-0005ZO-Pk for bug-gnu-emacs@gnu.org; Tue, 13 Aug 2019 00:13:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxOC2-000425-8J for bug-gnu-emacs@gnu.org; Tue, 13 Aug 2019 00:13:57 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:55154) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxOC1-00041N-SK for bug-gnu-emacs@gnu.org; Tue, 13 Aug 2019 00:13:54 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7D49LsU138663 for ; Tue, 13 Aug 2019 04:13:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=P5Z4yjtvnkDzRA0wt+AvnTIdlvCJpgQODMlaLdetuZA=; b=mlNmJL708VvsxmUGrMUWqmn7ZxFOPV8/73aUzGzPk38RpHRxU2AzUxnXUChWBUkJb/MG MGy7MxaaeEGnJxTO+NwGpC3VW7bt+Ga8bs41dv53jdG86BeqjJcdvHYvDk+GeR0U5gkK 4PM3pBLqAI3pzpj97q7oByJPs17SurDUnMZE8Qm6u9cgBZcYdYK5LY8mtSwB5Gs+8W+y Voy08GLS8gUmG78itPf+TvKka4NbVBaVxNzlupZVIg0BKikdesgOAM7RWvsYnAiMFoPF 6N/9wyFjU2gvU1o9Au2AQIg2lggOsnLGOgMOi+u6LZa5bGiB5h83UnwHDhsuYmDXDSga 1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=P5Z4yjtvnkDzRA0wt+AvnTIdlvCJpgQODMlaLdetuZA=; b=G4ZdGmcW/F3un/I1GYN6Y7+xo0UIIZnafaHMH2lwILjaQDCdT6/4xpJhMin9i9qpD5NZ OVeuNPsUCk1xN/6E9FAGE1xZIi4Z4dacHkiEJKWY1qwuVM7aQYc/D5nFP4zDQu5bRaYU CAsuWJSphUljZZLHAI4988ZMWN+S3KpDtDj66cNiOqHG8JWFyVkSHsaja5inx9i5jw7m kY4T4rW9kNjE6Un2IP0+L7B6gpkADw1FemV8DruYHCDxrPMTDtTb6m//elnEk4GoiCYV t99MrFAkb3A26c3eHHK5Ew7EW2KT34epBJcghj06s95gAR6ySpBgtHvvuAV568GmwiZt 1w== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2u9nvp3had-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 13 Aug 2019 04:13:50 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7D4DM6b034474 for ; Tue, 13 Aug 2019 04:13:49 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2u9m0av6f2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 13 Aug 2019 04:13:49 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x7D4D8P5022604 for ; Tue, 13 Aug 2019 04:13:09 GMT MIME-Version: 1.0 Message-ID: <83aaa401-8dc8-4733-a9e1-f959ceea47c0@default> Date: Mon, 12 Aug 2019 21:13:08 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 26.2; `pushnew' doc string (minor) X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9347 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908130044 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9347 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908130043 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 141.146.126.78 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) 1. Why does the first line of the doc string start with the calling sequence (it's on the same line as the start of the doc string). 2. The first "sentence" is a bit misleading. It actually says that X is inserted at the head of the list if it is not already at the head of the list, which is not right. It should say something like "if not already in the list", or "if not already a member of the list". 3. The doc string doesn't say what PLACE is, except that you can guess from the description that it must be a list. To really understand you need to consult the doc of `push'. The doc of `pushnew' could say what is said in the doc of `push', without being longer than it is now. 4. Even the doc string of `push' should say that a _list_ is stored in PLACE. http://clhs.lisp.se/Body/m_push.htm In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32) of 2019-04-13 Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749 Windowing system distributor `Microsoft Corp.', version 10.0.17763 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 23 00:13:13 2019 Received: (at 37016) by debbugs.gnu.org; 23 Aug 2019 04:13:13 +0000 Received: from localhost ([127.0.0.1]:38779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i10wq-0007rs-RP for submit@debbugs.gnu.org; Fri, 23 Aug 2019 00:13:13 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i10wp-0007rl-Tx for 37016@debbugs.gnu.org; Fri, 23 Aug 2019 00:13:12 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i10wm-0003bY-Fr; Fri, 23 Aug 2019 06:13:10 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#37016: 26.2; `pushnew' doc string (minor) References: <83aaa401-8dc8-4733-a9e1-f959ceea47c0@default> Date: Fri, 23 Aug 2019 06:13:08 +0200 In-Reply-To: <83aaa401-8dc8-4733-a9e1-f959ceea47c0@default> (Drew Adams's message of "Mon, 12 Aug 2019 21:13:08 -0700 (PDT)") Message-ID: <87wof4r02z.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Drew Adams writes: > 1. Why does the first line of the doc string start with the calling > sequence (it's on the same line as the start of the doc string). > > 2. The first "sentence" is a bit misleading. It actually sa [...] Content analysis details: (-2.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 NO_DNS_FOR_FROM DNS: Envelope sender has no MX or A DNS records -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.9 DKIM_ADSP_NXDOMAIN No valid author signature and domain not in DNS -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 37016 Cc: 37016@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Drew Adams writes: > 1. Why does the first line of the doc string start with the calling > sequence (it's on the same line as the start of the doc string). > > 2. The first "sentence" is a bit misleading. It actually says that X is > inserted at the head of the list if it is not already at the head of > the list, which is not right. It should say something like "if not > already in the list", or "if not already a member of the list". > > 3. The doc string doesn't say what PLACE is, except that you can guess > from the description that it must be a list. To really understand > you need to consult the doc of `push'. The doc of `pushnew' could > say what is said in the doc of `push', without being longer than it > is now. > > 4. Even the doc string of `push' should say that a _list_ is stored in > PLACE. I've now clarified the doc string as you suggest on the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 23 00:13:20 2019 Received: (at control) by debbugs.gnu.org; 23 Aug 2019 04:13:20 +0000 Received: from localhost ([127.0.0.1]:38782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i10wy-0007sG-3t for submit@debbugs.gnu.org; Fri, 23 Aug 2019 00:13:20 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i10wv-0007s6-5T for control@debbugs.gnu.org; Fri, 23 Aug 2019 00:13:18 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i10ws-0003bh-NW for control@debbugs.gnu.org; Fri, 23 Aug 2019 06:13:16 +0200 Date: Fri, 23 Aug 2019 06:13:14 +0200 Message-Id: <87v9uor02t.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #37016 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 37016 fixed close 37016 27.1 quit Content analysis details: (-2.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 NO_DNS_FOR_FROM DNS: Envelope sender has no MX or A DNS records -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.9 DKIM_ADSP_NXDOMAIN No valid author signature and domain not in DNS -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) tags 37016 fixed close 37016 27.1 quit From unknown Wed Sep 10 01:09:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 20 Sep 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator