GNU bug report logs - #36999
[PATCH] gnu: Add emacs-forge.

Previous Next

Full log

Message #41 received at 36999 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: 36999 <at> debbugs.gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: Re: [bug#36999] [PATCH 1/4] gnu: emacs-magit: Update to
 2.90.1-1.c761d28.
Date: Sun, 06 Oct 2019 21:03:45 -0400

Hi Oleg,

Oleg Pykhalov <go.wigust <at> gmail.com> writes:

>           #:phases
>           (modify-phases %standard-phases
> +           (add-after 'unpack 'patch
> +             (lambda _
> +               (chmod "lisp/magit-extras.el" #o644)
> +               (emacs-batch-edit-file "lisp/magit-extras.el"
> +                 `(progn (progn
> +                          (goto-char (point-min))
> +                          (re-search-forward "(defun magit-copy-buffer-revision ()")
> +                          (forward-sexp 2)
> +                          (kill-sexp)
> +                          (insert ,(format #f "~S"
> +                                           '(if (use-region-p)
> +                                                (copy-region-as-kill nil nil 'region)
> +                                                (when-let ((rev (cl-case major-mode
> +                                                                         ((magit-cherry-mode
> +                                                                           magit-log-select-mode
> +                                                                           magit-reflog-mode
> +                                                                           magit-refs-mode
> +                                                                           magit-revision-mode
> +                                                                           magit-stash-mode
> +                                                                           magit-stashes-mode)
> +                                                                          (car magit-refresh-args))
> +                                                                         ((magit-diff-mode magit-log-mode)
> +                                                                          (let ((r (caar magit-refresh-args)))
> +                                                                            (if (string-match "\\.\\.\\.?\\(.+\\)" r)
> +                                                                                (match-string 1 r)
> +                                                                                r)))
> +                                                                         (magit-status-mode "HEAD"))))
> +                                                          (when (magit-commit-p rev)
> +                                                            (setq rev (magit-rev-parse rev))
> +                                                            (push (list rev default-directory) magit-revision-stack)
> +                                                            (kill-new (message "%s" rev))))))))
> +                         (basic-save-buffer)))
> +               #t))

I didn't spot an explanation in either the commit message or comments
about what problem this patch phase is addressing.  If it's still an
issue with Magit's current master, would you please submit an issue
upstream?  If it's not, why not just go with a newer Magit revision?

-- 
Kyle

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.