From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 08 07:53:22 2019 Received: (at submit) by debbugs.gnu.org; 8 Aug 2019 11:53:22 +0000 Received: from localhost ([127.0.0.1]:40015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvgyw-0000Ly-7B for submit@debbugs.gnu.org; Thu, 08 Aug 2019 07:53:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:54176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvgyu-0000Lo-PZ for submit@debbugs.gnu.org; Thu, 08 Aug 2019 07:53:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48760) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvgys-0007Yv-VQ for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2019 07:53:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvgyq-0006YF-U6 for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2019 07:53:18 -0400 Received: from mail.choca.pics ([2001:bc8:20ab::1]:52772) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hvgyq-0006Uf-B1 for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2019 07:53:16 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id DAA80F1B807 for ; Thu, 8 Aug 2019 13:53:06 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id 2u-WPTmeM3eW for ; Thu, 8 Aug 2019 13:53:05 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id DA8CBF1B808 for ; Thu, 8 Aug 2019 13:53:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id Vm1-I5NS4zME for ; Thu, 8 Aug 2019 13:53:05 +0200 (CEST) Received: from luz4 (arennes-659-1-13-31.w86-215.abo.wanadoo.fr [86.215.172.31]) by mail.choca.pics (Postfix) with ESMTPSA id 9E934F1B807 for ; Thu, 8 Aug 2019 13:53:05 +0200 (CEST) From: Damien Cassou To: bug-gnu-emacs@gnu.org Subject: 26.2.90; [PATCH] Add imenu support to xref Date: Thu, 08 Aug 2019 13:53:03 +0200 Message-ID: <87h86rlvq8.fsf@cassou.me> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:bc8:20ab::1 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable * lisp/progmodes/xref.el (xref--imenu-prev-index-position) (xref--imenu-extract-index-name): Add functions to get imenu support. (xref--xref-buffer-mode): Set imenu variables to the new functions. * etc/NEWS: Add corresponding entry. --=20 Damien Cassou F=C3=B6retagsplatsen AB Phone/Fax: +46 (0)8 774 63 00 Mobile: +33 (0)6 80 50 18 91 Address: Skeppsbron 26, 4tr, SE-111 30 Stockholm Web: www.foretagsplatsen.se --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-imenu-support-to-xref.patch >From e7def47af8c5d8dfedadc5079d1f791c709b2be8 Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Thu, 8 Aug 2019 13:42:20 +0200 Subject: [PATCH] Add imenu support to xref * lisp/progmodes/xref.el (xref--imenu-prev-index-position) (xref--imenu-extract-index-name): Add functions to get imenu support. (xref--xref-buffer-mode): Set imenu variables to the new functions. * etc/NEWS: Add corresponding entry. --- etc/NEWS | 5 +++++ lisp/progmodes/xref.el | 23 +++++++++++++++++++++-- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 818875f7a0..50b2a0f76d 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1810,6 +1810,11 @@ This results in the use of Gravatar's default size of 80 pixels. This is possible using the new user options 'gravatar-default-image' and 'gravatar-force-default'. +** xref + +--- +*** Imenu support has been added to 'xref--xref-buffer-mode'. + * New Modes and Packages in Emacs 27.1 diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 57d803894c..c00622f747 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -728,7 +728,11 @@ xref--xref-buffer-mode "Mode for displaying cross-references." (setq buffer-read-only t) (setq next-error-function #'xref--next-error-function) - (setq next-error-last-buffer (current-buffer))) + (setq next-error-last-buffer (current-buffer)) + (setq imenu-prev-index-position-function + #'xref--imenu-prev-index-position) + (setq imenu-extract-index-name-function + #'xref--imenu-extract-index-name)) (defvar xref--transient-buffer-mode-map (let ((map (make-sparse-keymap))) @@ -740,6 +744,21 @@ xref--transient-buffer-mode xref--xref-buffer-mode "XREF Transient") +(defun xref--imenu-prev-index-position () + "Move point to previous line in `xref' buffer. +This function is used as a value for +`imenu-prev-index-position-function'." + (if (bobp) + nil + (xref--search-property 'xref-group t))) + +(defun xref--imenu-extract-index-name () + "Return imenu name for line at point. +This function is used as a value for +`imenu-extract-index-name-function'. Point should be at the +beginning of the line." + (buffer-substring-no-properties (line-beginning-position) (line-end-position))) + (defun xref--next-error-function (n reset?) (when reset? (goto-char (point-min))) @@ -789,7 +808,7 @@ xref--insert-xrefs for line-format = (and max-line-width (format "%%%dd: " max-line-width)) do - (xref--insert-propertized '(face xref-file-header) group "\n") + (xref--insert-propertized '(face xref-file-header 'xref-group t) group "\n") (cl-loop for (xref . more2) on xrefs do (with-slots (summary location) xref (let* ((line (xref-location-line location)) -- 2.21.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 23 00:32:29 2019 Received: (at 36974) by debbugs.gnu.org; 23 Aug 2019 04:32:29 +0000 Received: from localhost ([127.0.0.1]:38809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i11FU-00047w-T6 for submit@debbugs.gnu.org; Fri, 23 Aug 2019 00:32:29 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i11FS-00047o-VY for 36974@debbugs.gnu.org; Fri, 23 Aug 2019 00:32:27 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i11FO-0003l2-VW; Fri, 23 Aug 2019 06:32:25 +0200 From: Lars Ingebrigtsen To: Damien Cassou Subject: Re: bug#36974: 26.2.90; [PATCH] Add imenu support to xref References: <87h86rlvq8.fsf@cassou.me> Date: Fri, 23 Aug 2019 06:32:22 +0200 In-Reply-To: <87h86rlvq8.fsf@cassou.me> (Damien Cassou's message of "Thu, 08 Aug 2019 13:53:03 +0200") Message-ID: <87imqoh57t.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Damien Cassou writes: > * lisp/progmodes/xref.el (xref--imenu-prev-index-position) > (xref--imenu-extract-index-name): Add functions to get imenu support. > (xref--xref-buffer-mode): Set imenu variables to the new function [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36974 Cc: 36974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Damien Cassou writes: > * lisp/progmodes/xref.el (xref--imenu-prev-index-position) > (xref--imenu-extract-index-name): Add functions to get imenu support. > (xref--xref-buffer-mode): Set imenu variables to the new functions. > * etc/NEWS: Add corresponding entry. I'm not a big imenu user, so I'm probably not the best to judge the applicability of this patch, but it looked logical to me, and I've applied the patch (after folding a couple of too-long lines). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 23 00:32:32 2019 Received: (at control) by debbugs.gnu.org; 23 Aug 2019 04:32:32 +0000 Received: from localhost ([127.0.0.1]:38812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i11FY-00048D-4e for submit@debbugs.gnu.org; Fri, 23 Aug 2019 00:32:32 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i11FW-000484-Jw for control@debbugs.gnu.org; Fri, 23 Aug 2019 00:32:30 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i11FU-0003l9-2Y for control@debbugs.gnu.org; Fri, 23 Aug 2019 06:32:30 +0200 Date: Fri, 23 Aug 2019 06:32:27 +0200 Message-Id: <87h868h57o.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #36974 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 36974 fixed close 36974 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 36974 fixed close 36974 27.1 quit From unknown Sat Jun 14 02:02:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 20 Sep 2019 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 24 15:32:54 2019 Received: (at control) by debbugs.gnu.org; 24 Dec 2019 20:32:54 +0000 Received: from localhost ([127.0.0.1]:53104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijqrO-0001xN-8a for submit@debbugs.gnu.org; Tue, 24 Dec 2019 15:32:54 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:41581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijqrM-0001xB-72 for control@debbugs.gnu.org; Tue, 24 Dec 2019 15:32:52 -0500 Received: by mail-wr1-f41.google.com with SMTP id c9so20609532wrw.8 for ; Tue, 24 Dec 2019 12:32:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=KDuMXldHVtsvd4+2jvvtahT4GN0DAGHqagpY/jJy9a8=; b=NoQWKArFOxC5wkTCVoWgTrg5XscZLzSg0s1s5eXzWmWtKZlNqAIZG+JiEF2ewGBZFt 5k/jaeatGC9GJpn9LGtyGQf36xWEK9mF+2PsqECjsa354poG1QzF3JrbFwj+LjDuAWlw Fi6X/Xzb57CWvDK22wTDvo6oRzOeNzlKNfmQwkogDSbMdTqtbnOOCJ3sNlziw4v2Z7tU JoQariLSn1IZpU8ab+Kqa4BHoxC/051VO33pk2vgtSvltLHxUfeTgrHAy8mbQLmwLExg YMe9xrYn3g5rENfsonLKINgohQxVMPi/+0ZqY8VbjVHy08eherXV0i3LR21CnyMwHk7/ cZ5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=KDuMXldHVtsvd4+2jvvtahT4GN0DAGHqagpY/jJy9a8=; b=eHodC8KO9C5cVIqaIkHIAKDJ1hjQrPbdvRvtW+rbQWVU/ZASd//5ukOty+kXQVQR06 J3cHwS+z8XSDLd0qPe93j4yu+WD2gwhtYDcvA9upqLkowO+wwE+xXuxczdbz8Z7GHcR6 +77O/pgBWXdhv3o3HQJYr1KAP7TxdvYO+TES6DyQEtKvm8xqR8Nq/Ggpo2IEk8dXH4lt c/i2OejiSRSrwhCHX3K0XDzd4ZkRpGvHFuKPrC6gH0B6r8zpX78r3CH6DR1qoEuzEFJ2 QfHI9WAtoO5UFW43VkvVaDaWM+Irp9AgP7lfwiJZs/W+XiXD7FqV6tw3Ig+0RQSV6Mi8 Sivw== X-Gm-Message-State: APjAAAVs8Zm4wzOmFlvFvY5umfOGbBgfcLcF8YHcyFxVUEUeB5Iy6t4i kbwWxdoKkNfGCPNp8ZC8EreFdRjfnxo= X-Google-Smtp-Source: APXvYqwmv5or6QPwn1mtiWmDERPKT3S0JI8TJrNoO0HdmVEGusJid1nJUvUFBYMPEsbOvAN8cc4kvA== X-Received: by 2002:adf:e8ca:: with SMTP id k10mr37294772wrn.50.1577219566072; Tue, 24 Dec 2019 12:32:46 -0800 (PST) Received: from [192.168.0.2] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id b67sm3695326wmc.38.2019.12.24.12.32.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Dec 2019 12:32:45 -0800 (PST) To: control@debbugs.gnu.org From: Dmitry Gutov Subject: asdasdasd Message-ID: <90c84c01-3b53-1bb4-8a9b-bb059a8748f4@yandex.ru> Date: Tue, 24 Dec 2019 22:32:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) unarchive 36974 thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 24 15:41:28 2019 Received: (at 36974) by debbugs.gnu.org; 24 Dec 2019 20:41:28 +0000 Received: from localhost ([127.0.0.1]:53110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijqzg-00029Y-4J for submit@debbugs.gnu.org; Tue, 24 Dec 2019 15:41:28 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:47011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijqze-00029K-3i for 36974@debbugs.gnu.org; Tue, 24 Dec 2019 15:41:26 -0500 Received: by mail-wr1-f66.google.com with SMTP id z7so20552997wrl.13 for <36974@debbugs.gnu.org>; Tue, 24 Dec 2019 12:41:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=S+eVvK+5UOEcIS12TeU87DMIs3QfH45VzkLJ7nco6+M=; b=fCC1e6wSRXPhOlrmeyd5yW5x/vRueoulLaC9EPyb5CR5jpXRvoCyhXSXXOUKZ23aWO 6W0NDDgO0SX6PdqgjtL56QzHlpcfZyL02R72C80UhR5veiQSqFQOkLTlC8PWn3LzcKVZ TwO/wX65ipDDtuKxsfyIsFcg1NzuE5zR/irmpVyoZPznXhAg3SwcaGkvmuj1DzeXnTsY LLFkCbokVNWHmOq2xsPUA1p6IXASAQILm/2V1maZ2uTQkukGGeKvTgRwzkfM+mGO0O/Z vfrob4A5i3SGenAiO6cHXJV4sFMW8TSfq0NxWTxqD4wHtTr/cHjPEiTC4ejbHscJe4RN RMFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=S+eVvK+5UOEcIS12TeU87DMIs3QfH45VzkLJ7nco6+M=; b=TAwhCNC+FI1B2BFKfxMWWJt6AyFW0RPJgPTBmBxWub+u/BDuQ8e+sVYIzwfYLTbMuV aw8Gl2VubRhBE+HJaZg1j5EZ44PghN0rC+49hS+vqo1WMSYo4+laUcvFMYQGZTuyByRh oG3gx9IIzXprBfSwPFnbi4p1oAoRhNknyvxSbdsOGfJ6nIFrWc174Zi8yOmZKXvjJXiC tpst+Vw8I1sKoGOIrJ4XckDAT/8plgcNRFJ9DNMxJlcOBpAvpUBAqnbRzi4mpFeyCEEr wyZF/CdVdssjiYomBa9WQdVDa5uIiCby0lnTFD+DB7Kf3SrudnoDKtX66V5HzWvQ7ZV6 Ld/A== X-Gm-Message-State: APjAAAWtYbH6r1YX9/Brb8v3CvRxXZ3nAV0UrN8+Y20G+5P8Oiia3DUP s/uYARSGN/RQoZlZXU8Yhp39uGkfaGA= X-Google-Smtp-Source: APXvYqw+Y/8rZJaTB0j7uOlN1JRf4eLeDRUPSd9kPwhzJbXBuvLYMvqiYQmYNwqXL8GhOGnWMw0G/A== X-Received: by 2002:adf:dcc2:: with SMTP id x2mr16750642wrm.24.1577220079957; Tue, 24 Dec 2019 12:41:19 -0800 (PST) Received: from [192.168.0.2] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id w13sm25666166wru.38.2019.12.24.12.41.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Dec 2019 12:41:19 -0800 (PST) Subject: Re: bug#36974: 26.2.90; [PATCH] Add imenu support to xref To: Lars Ingebrigtsen , Damien Cassou References: <87h86rlvq8.fsf@cassou.me> <87imqoh57t.fsf@gnus.org> From: Dmitry Gutov Message-ID: Date: Tue, 24 Dec 2019 22:41:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87imqoh57t.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 36974 Cc: 36974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 23.08.2019 7:32, Lars Ingebrigtsen wrote: > Damien Cassou writes: > >> * lisp/progmodes/xref.el (xref--imenu-prev-index-position) >> (xref--imenu-extract-index-name): Add functions to get imenu support. >> (xref--xref-buffer-mode): Set imenu variables to the new functions. >> * etc/NEWS: Add corresponding entry. > I'm not a big imenu user, so I'm probably not the best to judge the > applicability of this patch, but it looked logical to me, and I've > applied the patch (after folding a couple of too-long lines). This patch had a typo which made it not work at all (which is easy to see by calling 'M-x imenu' in any of the Xref buffers). Considering it's been applied 4 months ago and nobody noticed the problem, maybe it's not that useful after all? From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 11:17:41 2019 Received: (at 36974) by debbugs.gnu.org; 25 Dec 2019 16:17:41 +0000 Received: from localhost ([127.0.0.1]:54610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik9Lx-0003fT-Bx for submit@debbugs.gnu.org; Wed, 25 Dec 2019 11:17:41 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik9Lv-0003fF-Eo for 36974@debbugs.gnu.org; Wed, 25 Dec 2019 11:17:39 -0500 Received: from 77.16.52.139.tmi.telenormobil.no ([77.16.52.139] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ik9Lm-0000PH-HH; Wed, 25 Dec 2019 17:17:32 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#36974: 26.2.90; [PATCH] Add imenu support to xref References: <87h86rlvq8.fsf@cassou.me> <87imqoh57t.fsf@gnus.org> Date: Wed, 25 Dec 2019 17:17:29 +0100 In-Reply-To: (Dmitry Gutov's message of "Tue, 24 Dec 2019 22:41:17 +0200") Message-ID: <87h81o4bxi.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > This patch had a typo which made it not work at all (which is easy to > see by calling 'M-x imenu' in any of the Xref buffers). I get Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: yandex.ru] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36974 Cc: Damien Cassou , 36974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > This patch had a typo which made it not work at all (which is easy to > see by calling 'M-x imenu' in any of the Xref buffers). I get imenu-unavailable-error: imenu unavailable: "No items suitable for an index found in this buffer" when I say `M-x imenu' in an xref buffer, but I assumed that was expected. > Considering it's been applied 4 months ago and nobody noticed the > problem, maybe it's not that useful after all? Possibly? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 11:30:11 2019 Received: (at 36974) by debbugs.gnu.org; 25 Dec 2019 16:30:11 +0000 Received: from localhost ([127.0.0.1]:54616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik9Y3-0003yH-JD for submit@debbugs.gnu.org; Wed, 25 Dec 2019 11:30:11 -0500 Received: from mail-lf1-f52.google.com ([209.85.167.52]:44818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik9Y1-0003ww-Qn for 36974@debbugs.gnu.org; Wed, 25 Dec 2019 11:30:10 -0500 Received: by mail-lf1-f52.google.com with SMTP id v201so17027327lfa.11 for <36974@debbugs.gnu.org>; Wed, 25 Dec 2019 08:30:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NewUp1b/hsFH9/T6R7vLC921Lf2Un2Zt1pfy2I2MyVg=; b=nYOI2fQ398G1pvgC75ZhFh9qE6SnbvakeX9tf2JOb5yhIDwXrSMrndS/HpHU6raC2d 20fgGeORpl17EfwX/ZpvqdwFn8c4C6eRa0KvzFFrB6O9pro5+zDC5awvpwpk8cGD6Hbb rdAXSg6u+O9IrkmfDdCZLTJu8aBUE3KTAIrsFTlnyMVkXGtoPClNCym4AUh26dSbIBW0 vWxbk3YQwzmqQgW/5FDYQPDVsWJpmAXKa3UQRV8Ku7sB7NGupjDay3LnpGfM5tgTxB65 wR+JiFiqjXchC1PCDupGdT9csVs/o/c2RaDRMsMHzPk/0ji1XlbH3qathpbJiudtOKdg a44w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NewUp1b/hsFH9/T6R7vLC921Lf2Un2Zt1pfy2I2MyVg=; b=pAi7TlkHt5CM/t20U8CLmxrOA+kr64tIppGj2eOHr0Vru9xmdQ8ZAra3ls+An8tAgJ jfBI42Dr33I9BG/H8lCnRjwgDlUwYzGyAYlwj6c0zxZja36+5jzRHMbBvMgxICrOC8bg NTVaPHk1HgQt9fhOk8WmDaWrkToyNT8aaQa3RiJY/YveaP+xxp6OfDRmZcPRmViF3OAD 9jjLKObBVPijYYRxqLRMh3llsnEatB2omVH6DCWXZFVqIMVbVncCHafZC3SKSh6DzMU6 qsqWmIiyOxqCFhWu9CY0WzSI4VZb0PoJVBYJ5MRMhtXej+wGX9M9hQ7A01XdJHSQ5sTq gQZA== X-Gm-Message-State: APjAAAVj1IVY3iRKT0+3SfmWOiQv3SXRbSsJo3HyMSdsApeEXhO1XzNe BwgrN3t5eK734Oqei6G9oMxIyKQcKDrkZQ== X-Google-Smtp-Source: APXvYqyzw4Mg70eN5Ib1fMIu39EMgf/kBWcKOq27qjgLozixPOOYPaHL21JaX1hVfEZCXIDZYSTbtw== X-Received: by 2002:ac2:498e:: with SMTP id f14mr23069387lfl.172.1577291403551; Wed, 25 Dec 2019 08:30:03 -0800 (PST) Received: from [172.18.118.211] ([79.104.7.197]) by smtp.googlemail.com with ESMTPSA id q26sm11697990lfb.26.2019.12.25.08.30.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Dec 2019 08:30:02 -0800 (PST) Subject: Re: bug#36974: 26.2.90; [PATCH] Add imenu support to xref To: Lars Ingebrigtsen References: <87h86rlvq8.fsf@cassou.me> <87imqoh57t.fsf@gnus.org> <87h81o4bxi.fsf@gnus.org> From: Dmitry Gutov Message-ID: <956519ab-7498-9421-b117-c1ecadfdf43a@yandex.ru> Date: Wed, 25 Dec 2019 18:29:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87h81o4bxi.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 36974 Cc: Damien Cassou , 36974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 25.12.2019 18:17, Lars Ingebrigtsen wrote: > I get > > imenu-unavailable-error: imenu unavailable: "No items suitable for an > index found in this buffer" > > when I say `M-x imenu' in an xref buffer, but I assumed that was > expected. Do you get it still? It should error out because the implementation in this patch offers all file names as imenu entries. And there must be at least one. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 11:43:19 2019 Received: (at 36974) by debbugs.gnu.org; 25 Dec 2019 16:43:19 +0000 Received: from localhost ([127.0.0.1]:54631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik9kl-0004Gf-7W for submit@debbugs.gnu.org; Wed, 25 Dec 2019 11:43:19 -0500 Received: from mail-lj1-f171.google.com ([209.85.208.171]:33684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik9kk-0004GK-3c for 36974@debbugs.gnu.org; Wed, 25 Dec 2019 11:43:18 -0500 Received: by mail-lj1-f171.google.com with SMTP id y6so15078027lji.0 for <36974@debbugs.gnu.org>; Wed, 25 Dec 2019 08:43:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=a7/D9EPEke4N+KIp3wrzT2WEzCpoeA0bKucbqbsT7Ks=; b=A6tLCtV2KxG6OFH3pGJyb+Dt1Pi4oAK7Wwaf8/TS+k4DPQD20iW1HgJ9aV4GCLNXcw zqQ7vpQqJcWxh9RoH73fpCm3/7BV1+lfYh83iQ98HKXzkrAkjWoSJ22F66yn6JzlYhnl UljWrtDkUSqZu94wN6AyYuoOLtYHfcGbroi8yPmqsHnxT0F1HlIguE5aSOk8O0pfPrd6 VgKegDx7QosbyKxLAkWJg8AggDCmEaRZlXXasebstFVm7h4BN/bKeeMeP77PBY5h8D+/ 8SwDnv4+d0SiVjKpkQb9ke0NphPKsfgM9oAC8CjpyDXJ+7DtDbYNclT71Jy4DOYOjAlp H48w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=a7/D9EPEke4N+KIp3wrzT2WEzCpoeA0bKucbqbsT7Ks=; b=HJNPQ6CkQi0+nUyPeSQIeSUPD0aQFoquZWBrn5Sdjl3VV108w2hoQzHYU4y5kG9ZOY mmWb+fso1v6Mx3hFZHVYE3N1P2cDw6vVqo2pIfkZKWi0nc544VYmedj6a0ZxbBHZUOln R6QB2etT2xE7NTZhvOkHUbfMSXq83XxbpbscJVtqSBsmvlrKZdAh/c94q+PxrZK66sLD rU6+GFuzg2drVK3jj1TIv0n3AFqkJUQNsrA6RoStxpoRCeqUxnMIT3PCKg8EXR03WDx2 Dd8bAKmdCMsTYe2nSyuTVg4lA6pnC2yOgw7unaxKD+BVFIQ3Y+109SM0awCbNok719m2 xG4Q== X-Gm-Message-State: APjAAAWT2dzB0ZzZnj8AkGw/ZjXy+HPR+rqtwV22UMnEoDAYhOsKjhOv NnBvq6/ffUAybNzlgfnGxL6mPVqqPjh69g== X-Google-Smtp-Source: APXvYqyU5a4a6V7uEpMAjStIU3bLqiZ+TCyS8zfikwgjWORI6Y/hnXo3nocgZBQIbTdWW0FplpSJZg== X-Received: by 2002:a2e:8804:: with SMTP id x4mr19949949ljh.187.1577292191836; Wed, 25 Dec 2019 08:43:11 -0800 (PST) Received: from [172.18.118.211] ([79.104.7.197]) by smtp.googlemail.com with ESMTPSA id k5sm11721949lfd.86.2019.12.25.08.43.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Dec 2019 08:43:11 -0800 (PST) Subject: Re: bug#36974: 26.2.90; [PATCH] Add imenu support to xref From: Dmitry Gutov To: Lars Ingebrigtsen References: <87h86rlvq8.fsf@cassou.me> <87imqoh57t.fsf@gnus.org> <87h81o4bxi.fsf@gnus.org> <956519ab-7498-9421-b117-c1ecadfdf43a@yandex.ru> Message-ID: <90f554a9-7545-258f-30c8-18664d427352@yandex.ru> Date: Wed, 25 Dec 2019 18:43:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <956519ab-7498-9421-b117-c1ecadfdf43a@yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 36974 Cc: Damien Cassou , 36974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Sorry, On 25.12.2019 18:29, Dmitry Gutov wrote: > On 25.12.2019 18:17, Lars Ingebrigtsen wrote: >> I get >> >> imenu-unavailable-error: imenu unavailable: "No items suitable for an >> index found in this buffer" >> >> when I say `M-x imenu' in an xref buffer, but I assumed that was >> expected. > > Do you get it still? > > It should error out ... ^ shouldn't From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 12:10:14 2019 Received: (at 36974) by debbugs.gnu.org; 25 Dec 2019 17:10:14 +0000 Received: from localhost ([127.0.0.1]:54670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikAAn-0004vO-6x for submit@debbugs.gnu.org; Wed, 25 Dec 2019 12:10:14 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikAAl-0004v5-6Y for 36974@debbugs.gnu.org; Wed, 25 Dec 2019 12:10:11 -0500 Received: from 77.16.52.139.tmi.telenormobil.no ([77.16.52.139] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ikAAc-0000qB-DG; Wed, 25 Dec 2019 18:10:04 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#36974: 26.2.90; [PATCH] Add imenu support to xref References: <87h86rlvq8.fsf@cassou.me> <87imqoh57t.fsf@gnus.org> <87h81o4bxi.fsf@gnus.org> <956519ab-7498-9421-b117-c1ecadfdf43a@yandex.ru> <90f554a9-7545-258f-30c8-18664d427352@yandex.ru> Date: Wed, 25 Dec 2019 18:10:01 +0100 In-Reply-To: <90f554a9-7545-258f-30c8-18664d427352@yandex.ru> (Dmitry Gutov's message of "Wed, 25 Dec 2019 18:43:08 +0200") Message-ID: <87d0cc49hy.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: >>> when I say `M-x imenu' in an xref buffer, but I assumed that was >>> expected. >> Do you get it still? >> It should error out ... > > ^ shouldn't Ah; no, it seems to work now. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: yandex.ru] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36974 Cc: Damien Cassou , 36974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: >>> when I say `M-x imenu' in an xref buffer, but I assumed that was >>> expected. >> Do you get it still? >> It should error out ... > > ^ shouldn't Ah; no, it seems to work now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 27 05:11:17 2019 Received: (at 36974) by debbugs.gnu.org; 27 Dec 2019 10:11:17 +0000 Received: from localhost ([127.0.0.1]:56558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikmaS-000108-RD for submit@debbugs.gnu.org; Fri, 27 Dec 2019 05:11:16 -0500 Received: from mail.choca.pics ([80.67.172.235]:60004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikmaQ-0000zv-Ci for 36974@debbugs.gnu.org; Fri, 27 Dec 2019 05:11:15 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.choca.pics (Postfix) with ESMTP id 7111618192DF2; Fri, 27 Dec 2019 11:11:12 +0100 (CET) Received: from mail.choca.pics ([127.0.0.1]) by localhost (mail.choca.pics [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id B6d1mymeZjEd; Fri, 27 Dec 2019 11:11:12 +0100 (CET) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.choca.pics (Postfix) with ESMTP id 1570118192B29; Fri, 27 Dec 2019 11:11:12 +0100 (CET) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([127.0.0.1]) by localhost (mail.choca.pics [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8KPCPVC7ZZzO; Fri, 27 Dec 2019 11:11:11 +0100 (CET) Received: from luz4 (87-231-56-147.rev.numericable.fr [87.231.56.147]) by mail.choca.pics (Postfix) with ESMTPSA id C99F518192DF2; Fri, 27 Dec 2019 11:11:11 +0100 (CET) From: Damien Cassou To: Dmitry Gutov , Lars Ingebrigtsen Subject: Re: bug#36974: 26.2.90; [PATCH] Add imenu support to xref In-Reply-To: References: <87h86rlvq8.fsf@cassou.me> <87imqoh57t.fsf@gnus.org> Date: Fri, 27 Dec 2019 11:11:11 +0100 Message-ID: <878smyyt6o.fsf@cassou.me> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36974 Cc: 36974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > This patch had a typo which made it not work at all (which is easy to > see by calling 'M-x imenu' in any of the Xref buffers). can you please tell what typo you are referring to? Also, when you say "had" a typo, do you mean someone fixed it somewhere? Can you please give a little more details? I can't find any fix. > Considering it's been applied 4 months ago and nobody noticed the > problem, maybe it's not that useful after all? I haven't switched to Emacs 27 yet. -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 27 08:50:42 2019 Received: (at 36974) by debbugs.gnu.org; 27 Dec 2019 13:50:42 +0000 Received: from localhost ([127.0.0.1]:56636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikq0n-0001r3-S1 for submit@debbugs.gnu.org; Fri, 27 Dec 2019 08:50:42 -0500 Received: from mail-lf1-f51.google.com ([209.85.167.51]:45019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikq0l-0001qo-PW for 36974@debbugs.gnu.org; Fri, 27 Dec 2019 08:50:40 -0500 Received: by mail-lf1-f51.google.com with SMTP id v201so20671336lfa.11 for <36974@debbugs.gnu.org>; Fri, 27 Dec 2019 05:50:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+h6MhbSolnHHx9GiU3D3X6e3O25DasiQNXZkmZr3xn4=; b=Mh6iL9bv6YbJBxzOa6KRm/s3dSEZjx4qTfOrIqkwISA6AMFH0MugTe82KU542Mh1Jp eUg/M0xVcrSzgA/jEgViukf2g/FlGa7E80Qe0pEhbodyaHNF7oCoOFXJoeZ7lV0DwoAV bNcJDitJTea+5GX8NqL6eiocSVxCYlQb74h3bEZRKks4SZIBLJtiJPmBrADyjwnmaBtR QFfmrn3kb6PfHhWjY2jRl4RAx7P8GhSa2JeAf7BUjSX38JisqFktK8DXKPDB92mequWZ N6LgX/109lYLH+10XOeuHPry9YoH7qVaSp0DD4jwUtoHKmSRQX2ELfR2fHcCsE3Bot9F RWug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+h6MhbSolnHHx9GiU3D3X6e3O25DasiQNXZkmZr3xn4=; b=ofE/f1J6QRpyo+y0P3S0IRzf6SmK8306QXE5PYWXmcJkASxFRA48UwrluT9bk39MGe kd3E4c/scogqYWGOmCgp3s7REtpWGA5ri4WQ5cevqntiafyGRX0nQLvH0u+lWVwn6AnW kPZPDqLIPhAsW6uRliIpbfHUPFYBd5yto0PMDEFH8Mn5JLqCv4Ufgfz7L2Mp0lJl9eM1 nuV9amVFCklF2a9xg0JXbQ443OSDRnJengTxm+khVtOx2QcY4PxfW1fGKGuqdazQD/aI K1L00uLiGDeNnwZminKrA/AQCXUuH6dCccU/4EfSRebvlgFBpyvG5Ybn0nbeb+KSU1gq KgXg== X-Gm-Message-State: APjAAAWZHDjl8zAqAuB1+f1ZgPT2xPTILKJP6iGQJDUS2gPbgcwXNEQY zs52O8lDLn5Ltg9qIlTkIDQzru/l+mE= X-Google-Smtp-Source: APXvYqy15oasgGL2ZUB4nRlMct+Cw1zwi2gfBNfpKcgS7n92PqPwvzAeFhcfoeMnDuTR7wdwh1ZNJg== X-Received: by 2002:ac2:5287:: with SMTP id q7mr30305944lfm.66.1577454633365; Fri, 27 Dec 2019 05:50:33 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id r21sm13623328ljn.64.2019.12.27.05.50.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Dec 2019 05:50:32 -0800 (PST) Subject: Re: bug#36974: 26.2.90; [PATCH] Add imenu support to xref To: Damien Cassou , Lars Ingebrigtsen References: <87h86rlvq8.fsf@cassou.me> <87imqoh57t.fsf@gnus.org> <878smyyt6o.fsf@cassou.me> From: Dmitry Gutov Message-ID: Date: Fri, 27 Dec 2019 16:50:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <878smyyt6o.fsf@cassou.me> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 27.12.2019 12:11, Damien Cassou wrote: > can you please tell what typo you are referring to? Also, when you say > "had" a typo, do you mean someone fixed it somewhere? Can you please > give a littl [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.51 listed in list.dnswl.org] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: yandex.ru] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 36974 Cc: 36974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 27.12.2019 12:11, Damien Cassou wrote: > can you please tell what typo you are referring to? Also, when you say > "had" a typo, do you mean someone fixed it somewhere? Can you please > give a little more details? I can't find any fix. It's this one: commit 9ea9ac9a61067995a3f7a38f62766f32a8c38bb2 Author: Dmitry Gutov Date: Tue Dec 24 22:30:02 2019 +0200 Apply the 'xref-group' property properly * lisp/progmodes/xref.el (xref--insert-xrefs): Apply the 'xref-group' property properly (bug#36974). diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 8d8e7ab208..13a1600594 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -814,7 +814,7 @@ xref--insert-xrefs for line-format = (and max-line-width (format "%%%dd: " max-line-width)) do - (xref--insert-propertized '(face xref-file-header 'xref-group t) + (xref--insert-propertized '(face xref-file-header xref-group t) group "\n") (cl-loop for (xref . more2) on xrefs do (with-slots (summary location) xref >> Considering it's been applied 4 months ago and nobody noticed the >> problem, maybe it's not that useful after all? > > > I haven't switched to Emacs 27 yet. I hope you were going to do that before the release. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 27 09:24:56 2019 Received: (at 36974) by debbugs.gnu.org; 27 Dec 2019 14:24:56 +0000 Received: from localhost ([127.0.0.1]:56660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikqXw-0002fm-Hv for submit@debbugs.gnu.org; Fri, 27 Dec 2019 09:24:56 -0500 Received: from mail.choca.pics ([80.67.172.235]:36378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikqXu-0002fc-As for 36974@debbugs.gnu.org; Fri, 27 Dec 2019 09:24:55 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.choca.pics (Postfix) with ESMTP id EAF6818192DF2; Fri, 27 Dec 2019 15:24:50 +0100 (CET) Received: from mail.choca.pics ([127.0.0.1]) by localhost (mail.choca.pics [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id gM9tsvYNiTNB; Fri, 27 Dec 2019 15:24:50 +0100 (CET) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.choca.pics (Postfix) with ESMTP id 909B318192B2A; Fri, 27 Dec 2019 15:24:50 +0100 (CET) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([127.0.0.1]) by localhost (mail.choca.pics [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ve49rv75wUFH; Fri, 27 Dec 2019 15:24:50 +0100 (CET) Received: from luz4 (87-231-56-147.rev.numericable.fr [87.231.56.147]) by mail.choca.pics (Postfix) with ESMTPSA id 55E1318192DF2; Fri, 27 Dec 2019 15:24:50 +0100 (CET) From: Damien Cassou To: Dmitry Gutov , Lars Ingebrigtsen Subject: Re: bug#36974: 26.2.90; [PATCH] Add imenu support to xref In-Reply-To: References: <87h86rlvq8.fsf@cassou.me> <87imqoh57t.fsf@gnus.org> <878smyyt6o.fsf@cassou.me> Date: Fri, 27 Dec 2019 15:24:49 +0100 Message-ID: <87eewp7sni.fsf@cassou.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36974 Cc: 36974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 27.12.2019 12:11, Damien Cassou wrote: >> can you please tell what typo you are referring to? Also, when you say >> "had" a typo, do you mean someone fixed it somewhere? Can you please >> give a little more details? I can't find any fix. > > It's this one: [=E2=80=A6] ok. I guess I only checked my patch in Emacs 26 and not in Emacs 27. Sorry about that. >> I haven't switched to Emacs 27 yet. > > I hope you were going to do that before the release. I have done that some hours ago. --=20 Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 27 09:32:52 2019 Received: (at 36974) by debbugs.gnu.org; 27 Dec 2019 14:32:52 +0000 Received: from localhost ([127.0.0.1]:56669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikqfc-0002s2-9r for submit@debbugs.gnu.org; Fri, 27 Dec 2019 09:32:52 -0500 Received: from mail-lj1-f171.google.com ([209.85.208.171]:46137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikqfa-0002rq-ML for 36974@debbugs.gnu.org; Fri, 27 Dec 2019 09:32:51 -0500 Received: by mail-lj1-f171.google.com with SMTP id m26so24824373ljc.13 for <36974@debbugs.gnu.org>; Fri, 27 Dec 2019 06:32:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yM/nTIztsGL39JMDVoRTele1dA6lNDBaAaSoDZpVtJs=; b=fiBKWqQbf67o6YbWSfgU/7xcZsNn3GkXzLJWZcHkskXyvg64VsWFAN6jk5SK9e2C/b eh5PWqhj8puOmesoeAxRYnpC8L1gGKpJTg3a8KbhvlRLuy0WJuWED+OV6dYzeGoiTVlu hb6JXPEh8ENPLUcqeagbfGxI0v5u0oUBWD3MY6OsPXq6otwv0I/hTzxUPVQvjDhfBDF+ 9hdaQO35wLfSBSrAlBSGaWiqTUMbIhlY3KBGwnfX+L19d2r1Oujo0Ih4BbsDdC9lQk8e Uwq2/rki/MLMIShUgEezLYO0hoWAD8RUb8U2vlfXF04TNdwAfKszeeGpPiF+V2n6052N HRbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yM/nTIztsGL39JMDVoRTele1dA6lNDBaAaSoDZpVtJs=; b=ngLsUz9Ne3mGny9KWfl1a0wB94mI4QVKoaROCth1zIO54gHR2Wu0XTuLluXsaviXEF itV8sM4l92WRwcyF0rluvGwIUjVUglFplnqtBIZnSl7/1sfdsKlQO07praZt9lk5xFNQ 3cpA3ZsDGHgN93mCMqk/2oIPWibixNZ/7UCMXfflWTcZubzLHzulqM3tyq8BW4VTu8Y1 GB46e+k0F3qIrDKUwsNtdvXc4ijXGEkYcklY6gtSSdcF8qPYz5C8sI/z2uK8xEbC4s// U5fjLPnNPQ3vXJN3YNq7PoxvWYgHtVPOvNpdmMzv3uWgvkIUcpoArkRJGCEse5GXtMAx 7+mw== X-Gm-Message-State: APjAAAUiRttojsXlXKg2fSxvSrjzrs9hfSZnmUIvLNhscN4Y7PQB8VqP xPPmp0B0AWVK/xvVIH2knB53viwaoeY= X-Google-Smtp-Source: APXvYqxXy3IvFJ+eTBu6GAqhUI4Ih1Ic5JReV92Xh/zphfAAFrLS2rb5TiGNucMoLBBqj58aJEgAxg== X-Received: by 2002:a2e:b1c3:: with SMTP id e3mr28425894lja.137.1577457164393; Fri, 27 Dec 2019 06:32:44 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id z3sm13693226ljh.83.2019.12.27.06.32.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Dec 2019 06:32:43 -0800 (PST) Subject: Re: bug#36974: 26.2.90; [PATCH] Add imenu support to xref To: Damien Cassou , Lars Ingebrigtsen References: <87h86rlvq8.fsf@cassou.me> <87imqoh57t.fsf@gnus.org> <878smyyt6o.fsf@cassou.me> <87eewp7sni.fsf@cassou.me> From: Dmitry Gutov Message-ID: Date: Fri, 27 Dec 2019 17:32:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87eewp7sni.fsf@cassou.me> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 27.12.2019 16:24, Damien Cassou wrote: > ok. I guess I only checked my patch in Emacs 26 and not in Emacs > 27. Sorry about that. Um. I don't think it should have worked in either version. Could be mistaken, though. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.171 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 36974 Cc: 36974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 27.12.2019 16:24, Damien Cassou wrote: > ok. I guess I only checked my patch in Emacs 26 and not in Emacs > 27. Sorry about that. Um. I don't think it should have worked in either version. Could be mistaken, though. > I have done that some hours ago. Cool. From unknown Sat Jun 14 02:02:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 25 Jan 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator