GNU bug report logs - #36967
27.0.50; Duplicate lines in xref output

Previous Next

Package: emacs;

Reported by: Juri Linkov <juri <at> linkov.net>

Date: Wed, 7 Aug 2019 22:04:01 UTC

Severity: normal

Merged with 43715

Found in versions 27.0.50, 28.0.50

Fixed in version 28.1

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#36967: closed (27.0.50; Duplicate lines in xref output)
Date: Mon, 21 Dec 2020 01:43:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 21 Dec 2020 03:42:41 +0200
with message-id <53aad279-912c-9b47-e5c3-d4373b1556a2 <at> yandex.ru>
and subject line Re: bug#36967: 27.0.50; Duplicate lines in xref output
has caused the debbugs.gnu.org bug report #36967,
regarding 27.0.50; Duplicate lines in xref output
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
36967: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36967
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Duplicate lines in xref output
Date: Thu, 08 Aug 2019 00:52:13 +0300
I tried to use project-find-regexp more often than rgrep,
but unfortunately xref still has a fundamental flaw:

0. emacs -Q
1. M-x project-find-regexp RET regexp RET
2. The output buffer *xref* contains duplicate lines
   when regexp is found on the same line several times,
   each duplicate output line has separate highlighting
   for every regexp occurrence.


[Message part 3 (message/rfc822, inline)]
From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>
Cc: Pankaj Jangid <pankaj <at> codeisgreat.org>, 36967-done <at> debbugs.gnu.org
Subject: Re: bug#36967: 27.0.50; Duplicate lines in xref output
Date: Mon, 21 Dec 2020 03:42:41 +0200
Version: 28.1

On 09.12.2020 15:57, Dmitry Gutov wrote:
> On 09.12.2020 05:53, Dmitry Gutov wrote:
>> Using xref-file-location-column there kind of breaks the abstraction. 
>> I was thinking more along the lines of text-prop search for the column 
>> inside the summary string:
> 
> Although we'll probably make it an optional method, just like 
> xref-location-line is already.

And now done.

I've pushed the slightly tweaked Juri's patch and the change described 
above.

With that, the bug should be fixed now. Please let me know if something 
is still amiss.

Thanks all!


This bug report was last modified 4 years and 154 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.