Subject: Re: [bug#36962] [PATCH] gnu: Add network-manager-openconnect.

From: Ricardo Wurmus <[email-masked]>
Date: Wed, 07 Aug 2019 20:37:19 +0200

Hi Efraim,

> * gnu/packages/gnome.scm (network-manager-openconnect): New variable.

This looks good to me.

Why is this in gnome.scm and not in, say, networking?

> +               (substitute* "src/nm-openconnect-service.c"
> +                    (("\"/usr/local/sbin/openconnect\"") pretty-ovpn)
> +                    (("\"/usr/sbin/openconnect\"") pretty-ovpn)
> +                    (("/sbin/modprobe") modprobe)))

The indentation looks wrong.

-- 
Ricardo