GNU bug report logs - #3695
23.0.94; kill-whole-line has no effect

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3695 in the body.
You can then email your comments to 3695 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: pent <pent <at> aparamon.msk.ru>
To: emacs-pretest-bug <at> gnu.org
Cc: rfrancoise <at> debian.org
Subject: 23.0.94; kill-whole-line has no effect
Date: Sat, 27 Jun 2009 11:15:44 +0400

Hello!

In recent snapshots, setting kill-whole-line to t has no effect for
Visual Line mode.

I'm ready to provide additional info,
Andrey Paramonov

In GNU Emacs 23.0.94.1 (i486-pc-linux-gnu, GTK+ Version 2.16.2)
 of 2009-06-18 on elegiac, modified by Debian
 (emacs-snapshot package, version 1:20090618-1)
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.94/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.94/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ru_RU.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Custom

Minor modes in effect:
  TeX-PDF-mode: t
  diff-auto-refine-mode: t
  delete-selection-mode: t
  show-paren-mode: t
  pc-selection-mode: t
  pretty-control-l-mode: t
  shell-dirtrack-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  global-visual-line-mode: t
  visual-line-mode: t
  transient-mark-mode: t

Message #10 received at 3695 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Teemu Likonen <tlikonen <at> iki.fi>
To: pent <pent <at> aparamon.msk.ru>
Cc: 3695 <at> debbugs.gnu.org
Subject: Re: bug#3695: 23.0.94; kill-whole-line has no effect
Date: Sat, 27 Jun 2009 10:42:38 +0300

On 2009-06-27 11:15 (+0400), pent <at> aparamon.msk.ru wrote:

> In recent snapshots, setting kill-whole-line to t has no effect for
> Visual Line mode.

I think this is intentional:

    commit 9608255daf00ca5cd4030515ea74f0b41105d469
    Author: Chong Yidong <cyd <at> stupidchicken.com>
    Date:   2009-06-13 18:56:07 +0000

        * simple.el (kill-visual-line): Rewrite (Bug#3437).  Don't try to
        handle kill-whole-line, as it doesn't make sense in this context.

Message #15 received at 3695 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Андрей Парамонов <cmr.pent <at> gmail.com>
To: 3695 <at> debbugs.gnu.org
Subject: Re: bug#3695: 23.0.94; kill-whole-line has no effect
Date: Sat, 27 Jun 2009 13:07:55 +0400

Hello!

I've looked through the change by Chong Yidong, and it seems to be
different from your patch. Your patch does respect the kill-whole-line
option. Does it have some problems compared to the committed change?

I think kill-visual-line must behave exactly as kill-line, if the text
line consists of just one visual line. Otherwise it's a regression.

Thanks for a quick reply,
Andrey Paramonov

Message #20 received at 3695 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Teemu Likonen <tlikonen <at> iki.fi>
To: Андрей Парамонов
 <cmr.pent <at> gmail.com>
Cc: 3695 <at> debbugs.gnu.org
Subject: Re: bug#3695: 23.0.94; kill-whole-line has no effect
Date: Sat, 27 Jun 2009 12:42:57 +0300

On 2009-06-27 13:07 (+0400), Андрей Парамонов wrote:

> I've looked through the change by Chong Yidong, and it seems to be
> different from your patch. Your patch does respect the kill-whole-line
> option. Does it have some problems compared to the committed change?

As far as I know my patch doesn't have other problems, and indeed it
preserves the kill-whole-line functionality.

> I think kill-visual-line must behave exactly as kill-line, if the text
> line consists of just one visual line. Otherwise it's a regression.

Probably I'd expect that too but I have no strong opinion for this.

Message #25 received at 3695 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Teemu Likonen <tlikonen <at> iki.fi>
To: 3695 <at> debbugs.gnu.org
Subject: Re: bug#3695: 23.0.94; kill-whole-line has no effect
Date: Sat, 27 Jun 2009 19:57:35 +0300

On 2009-06-27 12:42 (+0300), Teemu Likonen wrote:

> On 2009-06-27 13:07 (+0400), Андрей Парамонов wrote:
>
>> I've looked through the change by Chong Yidong, and it seems to be
>> different from your patch. Your patch does respect the kill-whole-line
>> option. Does it have some problems compared to the committed change?
>
> As far as I know my patch doesn't have other problems, and indeed it
> preserves the kill-whole-line functionality.

To make following this discussion easier I'll add link the bug report in
which the said patch is attached and where this change originated from:

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3437

Message #30 received at 3695 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: pent <pent <at> aparamon.msk.ru>
Cc: Teemu Likonen <tlikonen <at> iki.fi>, 3695 <at> debbugs.gnu.org
Subject: Re: 23.0.94; kill-whole-line has no effect
Date: Sun, 28 Jun 2009 16:37:22 -0400

> I think kill-visual-line must behave exactly as kill-line, if the text
> line consists of just one visual line. Otherwise it's a regression.

The docstring of kill-whole-line does not mention kill-visual-line:

  If non-nil, `kill-line' with no arg at beg of line kills the whole
  line.

You could argue that this can be extended to kill-visual-line, as
follows:

  `kill-visual-line' with no arg at beg of visual line kills the whole
  visual line.

but that doesn't make much sense, because kill-visual-line *already*
consumes the entire visual line.  In the normal case, kill-line consumes
the additional newline character at the end of the line, but
word-wrapped lines have no additional newline character to consume.

Message #35 received at 3695 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Андрей Парамонов <cmr.pent <at> gmail.com>
To: 3695 <at> debbugs.gnu.org
Subject: Re: bug#3695: 23.0.94; kill-whole-line has no effect
Date: Mon, 29 Jun 2009 22:00:01 +0400

If a line consists of a single visual line, C-k should behave the same
way as it used to work in Emacs 22 (kill the whole line). Do you
agree?

Is it possible to implement the following behavior?

`kill-visual-line' with no arg at beg of line kills the whole line, if
a line consists of a single visual line.

Thanks for your effort,
Andrey

Message #40 received at 3695-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: pent <pent <at> aparamon.msk.ru>
Cc: Teemu Likonen <tlikonen <at> iki.fi>, 3695-done <at> debbugs.gnu.org
Subject: Re: bug#3695: 23.0.94; kill-whole-line has no effect
Date: Tue, 14 Jul 2009 22:06:31 -0400

> Is it possible to implement the following behavior?
>
> `kill-visual-line' with no arg at beg of line kills the whole line, if
> a line consists of a single visual line.

I've checked a patch into the trunk that does this.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.