Subject: bug#36940: tests slowness and failure after recent Tramp changes

From: Michael Albinus <[email-masked]>
Date: Mon, 26 Aug 2019 18:43:35 +0200

Stefan Kangas <[email-masked]> writes:

Hi Stefan,

> Please find attached the log of running that with your patch.

So let's try the following patch.

diff --git a/test/lisp/net/tramp-tests.el b/test/lisp/net/tramp-tests.el
index 9930a2c9e1..8afd9f4ba4 100644
--- a/test/lisp/net/tramp-tests.el
+++ b/test/lisp/net/tramp-tests.el
@@ -5288,18 +5288,28 @@ tramp--test-check-files
 		  (setenv "PS1")
 		  (with-temp-buffer
 		    (should (zerop (process-file "env" nil t nil)))
-		    (goto-char (point-min))
-		    (should
-		     (re-search-forward
-                      ;; We must use proper encoding on macOS.  See
-                      ;; Bug#36940.
-                      (funcall
-	               (if (eq coding-system-for-read 'utf-8-hfs)
-                           'ucs-normalize-HFS-NFD-string 'identity)
-		       (format
-		        "^%s=%s$"
-		        (regexp-quote envvar)
-		        (regexp-quote (getenv envvar)))))))))))
+                    (tramp--test-message
+                     "coding-sytem: `%s' `%s'"
+                     coding-system-for-read coding-system-for-write )
+                    (tramp--test-message "search: `%s'" (getenv envvar))
+                    (let ((coding-system-for-read 'no-conversion)
+                          (coding-system-for-write 'no-conversion))
+                      (tramp--test-message
+                       "search: `%s'"
+                       (ucs-normalize-HFS-NFD-string (getenv envvar)))
+                      (tramp--test-message "buffer: `%s'" (buffer-string))
+		      (goto-char (point-min))
+		      (should
+		       (re-search-forward
+                        ;; We must use proper encoding on macOS.  See
+                        ;; Bug#36940.
+                        (funcall
+	                 (if (eq system-type 'darwin)
+                             'ucs-normalize-HFS-NFD-string 'identity)
+		         (format
+		          "^%s=%s$"
+		          (regexp-quote envvar)
+		          (regexp-quote (getenv envvar))))))))))))

 	;; Cleanup.
 	(ignore-errors (delete-directory tmp-name1 'recursive))

> Best regards,
> Stefan Kangas

Best regards, Michael.