GNU bug report logs - #36922
[PATCH] Add defalias toolbar-mode for tool-bar-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36922 in the body.
You can then email your comments to 36922 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add defalias toolbar-mode for tool-bar-mode
Date: Sun, 4 Aug 2019 19:41:52 +0200

[Message part 1 (text/plain, inline)]

OK, so this is very minor, but:

I can never remember that it's called tool-bar-mode, and not toolbar-mode.  This
is not often an annoyance, but it hits me every time I'm on "emacs -Q" or
similar.  (I type "M-x toolb TAB TAB TAB", have a revelation and then, "DEL -bar
TAB".)

Both "toolbar" and "tool bar" are valid spellings AFAICT.

I suggest to introduce a new (defalias 'toolbar-mode 'tool-bar-mode) to
accommodate users who are used to either spelling.

Thanks,
Stefan Kangas

[0001-lisp-tool-bar.el-toolbar-mode-New-alias-for-tool-bar.patch (application/x-patch, attachment)]

Message #8 received at 36922 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Kangas <stefan <at> marxist.se>, 36922 <at> debbugs.gnu.org
Subject: RE: bug#36922: [PATCH] Add defalias toolbar-mode for tool-bar-mode
Date: Sun, 4 Aug 2019 19:23:36 -0700 (PDT)

> OK, so this is very minor, but:
> 
> I can never remember that it's called tool-bar-mode, and not toolbar-
> mode.  This
> is not often an annoyance, but it hits me every time I'm on "emacs -Q"
> or
> similar.  (I type "M-x toolb TAB TAB TAB", have a revelation and then,
> "DEL -bar TAB".)
> 
> Both "toolbar" and "tool bar" are valid spellings AFAICT.
> 
> I suggest to introduce a new (defalias 'toolbar-mode 'tool-bar-mode) to
> accommodate users who are used to either spelling.

FWIW, I disagree that we should do this.

We should pick one name and try to stick with it.

We've picked one, I think (`tool-bar').  A quick
count with stuff I've loaded shows ~4 times as many
functions with `tool-bar' in the name as with `toolbar'
in the name.  So yeah, we have both.

For `filename' vs `file-name' in function names, we
have about twice as many of the latter, but, again,
we have both.

That's bad enough.  Now imagine if we started aliasing
all of those.  And toolbar and filename are just the
tip of the iceberg.

Better to be pretty consistent in our names, and IF
(big if) we end up with some inconsistency then
either (1) fix it (renaming, deprecating old names,
creating aliases for backward-compatibility) or (2)
maybe build some tolerance of different forms into
UI functions (e.g. reading function/variable names,
apropos, help commands).

Just one opinion.

Message #11 received at 36922 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 36922 <at> debbugs.gnu.org
Subject: Re: bug#36922: [PATCH] Add defalias toolbar-mode for tool-bar-mode
Date: Tue, 6 Aug 2019 13:38:54 +0200

Drew Adams <drew.adams <at> oracle.com> writes:
> > I suggest to introduce a new (defalias 'toolbar-mode 'tool-bar-mode) to
> > accommodate users who are used to either spelling.
>
> FWIW, I disagree that we should do this.
>
> We should pick one name and try to stick with it.

I agree that we should try to be consistent.

> That's bad enough.  Now imagine if we started aliasing
> all of those.  And toolbar and filename are just the
> tip of the iceberg.

Right.  But I'm not suggesting to alias all of them.  I suggest to
make an alias only for one common command.  There already exists
several such convenience aliases in Emacs.

I guess one could argue that it's a slippery slope, and I think there
is some merit to that.  In my opinion, the solution is to be selective
about where to add such aliases.

> Just one opinion.

Thanks for that.

Best regards,
Stefan Kangas

Message #14 received at 36922 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 36922 <at> debbugs.gnu.org
Subject: Re: bug#36922: [PATCH] Add defalias toolbar-mode for tool-bar-mode
Date: Sun, 8 Sep 2019 21:40:41 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> Drew Adams <drew.adams <at> oracle.com> writes:
> > > I suggest to introduce a new (defalias 'toolbar-mode 'tool-bar-mode) to
> > > accommodate users who are used to either spelling.
> >
> > FWIW, I disagree that we should do this.
> >
> > We should pick one name and try to stick with it.
>
> I agree that we should try to be consistent.
>
> > That's bad enough.  Now imagine if we started aliasing
> > all of those.  And toolbar and filename are just the
> > tip of the iceberg.
>
> Right.  But I'm not suggesting to alias all of them.  I suggest to
> make an alias only for one common command.  There already exists
> several such convenience aliases in Emacs.
>
> I guess one could argue that it's a slippery slope, and I think there
> is some merit to that.  In my opinion, the solution is to be selective
> about where to add such aliases.

That was one month ago.  It would be good if we could clarify what to
do here: apply my patch or close this as wontfix?

It would be a nice addition for my usage, but I'm not married to the
idea if no one else likes it.

Best regards,
Stefan Kangas

Message #17 received at 36922 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Drew Adams <drew.adams <at> oracle.com>, 36922 <at> debbugs.gnu.org
Subject: Re: bug#36922: [PATCH] Add defalias toolbar-mode for tool-bar-mode
Date: Sun, 08 Sep 2019 23:43:15 +0300

>> > > I suggest to introduce a new (defalias 'toolbar-mode 'tool-bar-mode) to
>> > > accommodate users who are used to either spelling.
>> >
>> > FWIW, I disagree that we should do this.
>> >
>> > We should pick one name and try to stick with it.
>>
>> I agree that we should try to be consistent.
>>
>> > That's bad enough.  Now imagine if we started aliasing
>> > all of those.  And toolbar and filename are just the
>> > tip of the iceberg.
>>
>> Right.  But I'm not suggesting to alias all of them.  I suggest to
>> make an alias only for one common command.  There already exists
>> several such convenience aliases in Emacs.
>>
>> I guess one could argue that it's a slippery slope, and I think there
>> is some merit to that.  In my opinion, the solution is to be selective
>> about where to add such aliases.
>
> That was one month ago.  It would be good if we could clarify what to
> do here: apply my patch or close this as wontfix?
>
> It would be a nice addition for my usage, but I'm not married to the
> idea if no one else likes it.

Oh, the name of the new feature tab-bar was modeled after tool-bar,
so now it should be renamed to tabbar, this doesn't look too nice.

OTOH, there is a tooltip as one word, but in dictionaries it's one word
as well, this is too confusing.

Message #20 received at 36922 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Juri Linkov <juri <at> linkov.net>
Cc: Drew Adams <drew.adams <at> oracle.com>, 36922 <at> debbugs.gnu.org
Subject: Re: bug#36922: [PATCH] Add defalias toolbar-mode for tool-bar-mode
Date: Sun, 8 Sep 2019 22:57:30 +0200

Juri Linkov <juri <at> linkov.net> writes:

> Oh, the name of the new feature tab-bar was modeled after tool-bar,
> so now it should be renamed to tabbar, this doesn't look too nice.

I think that should be "tab-bar", since that seems to be the most
common spelling.

I'm not suggesting a rename of "tool-bar" by the way, only a convenience alias.

Best regards,
Stefan Kangas

Message #23 received at 36922 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Drew Adams <drew.adams <at> oracle.com>, 36922 <at> debbugs.gnu.org
Subject: Re: bug#36922: [PATCH] Add defalias toolbar-mode for tool-bar-mode
Date: Mon, 09 Sep 2019 00:58:46 +0300

>> Oh, the name of the new feature tab-bar was modeled after tool-bar,
>> so now it should be renamed to tabbar, this doesn't look too nice.
>
> I think that should be "tab-bar", since that seems to be the most
> common spelling.

Indeed preparing good names for completion makes them easier to type.
For example, recently after adding the "tab-bar-mouse" command made harder to
enable "tab-bar-mode" by typing just "tab-b-mo", it doesn't complete anymore.
Also better would be to group all related commands under one prefix,
such as "tab-next", "tab-previous" for easier completion.

> I'm not suggesting a rename of "tool-bar" by the way, only a convenience alias.

Please try to find evidence that more people have the same problem
with completion.  For example, I have in my init file such aliases
that I often mistype, e.g.:

  (defalias 'comapre-windows 'compare-windows)

because "comapre" is easier to type than "compare" on a qwerty keyboard :)

Another solution is to make completion smarter, like when in bash
mistyping a shell command still find it by correcting its name.

Message #26 received at 36922 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Juri Linkov <juri <at> linkov.net>
Cc: Drew Adams <drew.adams <at> oracle.com>, 36922 <at> debbugs.gnu.org
Subject: Re: bug#36922: [PATCH] Add defalias toolbar-mode for tool-bar-mode
Date: Mon, 9 Sep 2019 00:16:42 +0200

Juri Linkov <juri <at> linkov.net> writes:

> Please try to find evidence that more people have the same problem
> with completion.

I'd love to, but I'm not sure how to find such evidence.  :-)

> For example, I have in my init file such aliases
> that I often mistype, e.g.:
>
>   (defalias 'comapre-windows 'compare-windows)
>
> because "comapre" is easier to type than "compare" on a qwerty keyboard :)

Indeed, I already have the alias in my init file.

Best regards,
Stefan Kangas

Message #29 received at 36922 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: drew.adams <at> oracle.com, 36922 <at> debbugs.gnu.org
Subject: Re: bug#36922: [PATCH] Add defalias toolbar-mode for tool-bar-mode
Date: Mon, 09 Sep 2019 19:11:21 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Sun, 8 Sep 2019 21:40:41 +0200
> Cc: 36922 <at> debbugs.gnu.org
> 
> > Right.  But I'm not suggesting to alias all of them.  I suggest to
> > make an alias only for one common command.  There already exists
> > several such convenience aliases in Emacs.
> >
> > I guess one could argue that it's a slippery slope, and I think there
> > is some merit to that.  In my opinion, the solution is to be selective
> > about where to add such aliases.
> 
> That was one month ago.  It would be good if we could clarify what to
> do here: apply my patch or close this as wontfix?

FWIW, I don't think it's terribly important to have such an alias.  So
if there are people who object, perhaps we shouldn't.  After all,
those who make this mistake frequently can write their private alias,
right?

Message #32 received at 36922 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Drew Adams <drew.adams <at> oracle.com>, 36922 <at> debbugs.gnu.org
Subject: Re: bug#36922: [PATCH] Add defalias toolbar-mode for tool-bar-mode
Date: Mon, 9 Sep 2019 19:19:37 +0200

tags 36922 + wontfix
close 36922
quit

Eli Zaretskii <eliz <at> gnu.org> writes:

> FWIW, I don't think it's terribly important to have such an alias.  So
> if there are people who object, perhaps we shouldn't.  After all,
> those who make this mistake frequently can write their private alias,
> right?

Thanks for taking a decision about this suggestion.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.