GNU bug report logs - #36907
27.0.50; make versionclean leaves stale .pdmp files around

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36907 in the body.
You can then email your comments to 36907 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sven Joachim <svenjoac <at> gmx.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; make versionclean leaves stale .pdmp files around
Date: Sat, 03 Aug 2019 16:35:06 +0200

To get rid of old versions, I run "make -C src versionclean all".  The
result on the master branch is somewhat disappointing:

,----
| $ LC_ALL=C ls -l src/emacs-27*
| -rw-r--r-- 1 sven src 10353360 Aug  3 13:55 src/emacs-27.0.50.1.pdmp
| -rw-r--r-- 1 sven src 10355384 Aug  3 15:49 src/emacs-27.0.50.2.pdmp
| -rwxr-xr-x 2 sven src 33630968 Aug  3 16:18 src/emacs-27.0.50.3
| -rw-r--r-- 2 sven src 10355376 Aug  3 16:18 src/emacs-27.0.50.3.pdmp
`----

Two stale files left behind, and the version increased once more instead
of being reset to .1.

Message #8 received at 36907 <at> debbugs.gnu.org (full text, mbox):

From: Sven Joachim <svenjoac <at> gmx.de>
To: 36907 <at> debbugs.gnu.org
Subject: Re: bug#36907: 27.0.50;
 make versionclean leaves stale .pdmp files around
Date: Sat, 03 Aug 2019 17:30:02 +0200

[Message part 1 (text/plain, inline)]

tags 36907 + patch
thanks

On 2019-08-03 16:35 +0200, Sven Joachim wrote:

> To get rid of old versions, I run "make -C src versionclean all".  The
> result on the master branch is somewhat disappointing:
>
> ,----
> | $ LC_ALL=C ls -l src/emacs-27*
> | -rw-r--r-- 1 sven src 10353360 Aug  3 13:55 src/emacs-27.0.50.1.pdmp
> | -rw-r--r-- 1 sven src 10355384 Aug  3 15:49 src/emacs-27.0.50.2.pdmp
> | -rwxr-xr-x 2 sven src 33630968 Aug  3 16:18 src/emacs-27.0.50.3
> | -rw-r--r-- 2 sven src 10355376 Aug  3 16:18 src/emacs-27.0.50.3.pdmp
> `----
>
> Two stale files left behind, and the version increased once more instead
> of being reset to .1.

Attached patch takes care of that.  Does anybody know why 'rm' is
allowed to fail in the versionclean and extraclean targets?  I don't see
a good reason, other than "it has been that way forever".

Cheers,
       Sven

[0001-src-Makefile.in-versionclean-Delete-versioned-pdmp-f.patch (text/x-diff, inline)]

From 94e72ffb0816ce6d49e72e5e59a517b45727f4e1 Mon Sep 17 00:00:00 2001
From: Sven Joachim <svenjoac <at> gmx.de>
Date: Sat, 3 Aug 2019 16:31:40 +0200
Subject: [PATCH] src/Makefile.in (versionclean): Delete versioned pdmp files
 (Bug#36907)

---
 src/Makefile.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/Makefile.in b/src/Makefile.in
index fd05a45df5..eb9708e66f 100644
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -721,7 +721,8 @@ distclean:
 maintainer-clean: distclean
 	rm -f TAGS
 versionclean:
-	-rm -f emacs$(EXEEXT) emacs-*.*.*[0-9]$(EXEEXT) ../etc/DOC*
+	-rm -f emacs$(EXEEXT) emacs-*.*.*[0-9]$(EXEEXT) emacs-*.*.*[0-9].pdmp
+	-rm -f ../etc/DOC*
 extraclean: distclean
 	-rm -f ./*~ \#* TAGS config.in

--
2.23.0.rc1

Message #15 received at 36907-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Sven Joachim <svenjoac <at> gmx.de>
Cc: 36907-done <at> debbugs.gnu.org
Subject: 27.0.50; make versionclean leaves stale .pdmp files around
Date: Sat, 3 Aug 2019 14:16:11 -0700

[Message part 1 (text/plain, inline)]

Thanks for reporting that. I installed the attached patch, which is slightly 
more ambitious.

[0001-Remove-stale-.pdmp-files-with-make-clean.txt (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.