GNU bug report logs - #36896
Evolution needs gsettings-desktop-schemas

Previous Next

Full log

Message #64 received at 36896-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Martin Becze <mjbecze <at> riseup.net>
Cc: 36896-done <at> debbugs.gnu.org
Subject: Re: bug#36896: [PATCH] added gsettings-desktop-schema to progragated
 inputs
Date: Mon, 16 Sep 2019 12:26:46 +0200

[Message part 1 (text/plain, inline)]

Martin,

Martin Becze 写道：
> ping :P

Absolutely.

The diff you sent here[0] is incomplete (it relies on your 
previous patch and doesn't have a header); please always send 
git-formatted patches that apply directly to current master.  They 
are easier to merge and will be merged sooner.

> Yeah I don't know. I just used prefix in the latest patch. Let 
> me know
> if the other method is preferred.

¯\_(ツ)_/¯

I've pushed this to master as 
ad6e168b3f29576d92b00725dedbb38cd5f05e46 with the following 
changes:

- Moved widowed ‘#:phases’ to the previous line (in well-formatted 
 Scheme, ‘(’ can never end a line and ‘)’ should never start 
 one), same for 'phase 'names
- then decided to move ’#:phases’ below ‘#:configure-flags’.  This 
 is subjective, but since *flags ‘affect’ phases (never the other 
 way 'round) it felt right  :-)
- dropped the unused ‘inputs’ phase argument
- added the missing ":" separator to the prefix wrapping — if it 
 does work without one (I didn't test), that's undocumented & 
 shouldn't be relied upon
- removed unnecessary trailing / in ‘schemas/’
- and wrote a commit message as mostly documented in ‘info 
 (standards)Change Logs’.

Thanks!

T G-R

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36896#53

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.