GNU bug report logs - #36895
Patch in dired-guess-shell-alist-default

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> linkov.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#36895: closed (Patch in dired-guess-shell-alist-default)
Date: Mon, 05 Aug 2019 21:19:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 06 Aug 2019 00:04:40 +0300
with message-id <87wofrwcgn.fsf <at> mail.linkov.net>
and subject line Re: bug#36895: Patch in dired-guess-shell-alist-default
has caused the debbugs.gnu.org bug report #36895,
regarding Patch in dired-guess-shell-alist-default
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
36895: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36895
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Patch in dired-guess-shell-alist-default
Date: Fri, 02 Aug 2019 00:42:32 +0300

[Message part 3 (text/plain, inline)]

Tags: patch

Isn't "git apply" used more often nowadays than "patch"?
If yes, then I propose this patch:

[dired-guess-shell-alist-default.patch (text/x-diff, inline)]

diff --git a/lisp/dired-x.el b/lisp/dired-x.el
index 462fa4ee15..3b3c0aeaf3 100644
--- a/lisp/dired-x.el
+++ b/lisp/dired-x.el
@@ -909,11 +909,11 @@ dired-guess-shell-alist-default
 	 '(concat "znew" (if dired-guess-shell-gzip-quiet " -q")
 		  " " dired-guess-shell-znew-switches))
 
-   '("\\.patch\\'" "cat * | patch")
-   (list "\\.patch\\.g?z\\'" "gunzip -qc * | patch"
+   '("\\.patch\\'" "cat * | patch" "cat * | git apply")
+   (list "\\.patch\\.g?z\\'" "gunzip -qc * | patch" "gunzip -qc * | git apply"
 	 ;; Optional decompression.
 	 '(concat "gunzip" (if dired-guess-shell-gzip-quiet " -q")))
-   (list "\\.patch\\.Z\\'" "zcat * | patch"
+   (list "\\.patch\\.Z\\'" "zcat * | patch" "zcat * | git apply"
 	 ;; Optional conversion to gzip format.
 	 '(concat "znew" (if dired-guess-shell-gzip-quiet " -q")
 		  " " dired-guess-shell-znew-switches))

[Message part 5 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 36895-done <at> debbugs.gnu.org
Subject: Re: bug#36895: Patch in dired-guess-shell-alist-default
Date: Tue, 06 Aug 2019 00:04:40 +0300

>> >> Isn't "git apply" used more often nowadays than "patch"?
>> >
>> > No, not here.  "git apply" is only relevant for when working in a Git
>> > repository.
>> >
>> > We could perhaps make this customizable, or maybe even make Emacs
>> > intuit the right command looking at the current buffer, though.
>> 
>> Yes, this would be more appropriate:
>
> Thanks, LGTM.

Pushed to master and closed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.