GNU bug report logs - #36880
[PATCH] reconfigure: Reload all shepherd files when upgrading services.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
Subject: bug#36880: closed (Re: [bug#36880] [PATCH] reconfigure: Reload
 all shepherd files when upgrading services.)
Date: Fri, 02 Aug 2019 09:23:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#36880: [PATCH] reconfigure: Reload all shepherd files when upgrading services.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 36880 <at> debbugs.gnu.org.

-- 
36880: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36880
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
Cc: 36880-done <at> debbugs.gnu.org
Subject: Re: [bug#36880] [PATCH] reconfigure: Reload all shepherd files when
 upgrading services.
Date: Fri, 2 Aug 2019 11:21:56 +0200

[Message part 3 (text/plain, inline)]

I've pushed that patch to guix master as commit 1db6f137d93b59409fedb3deb24c876649e1b8f2 now.

Thanks!

[Message part 4 (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: guix-patches <at> gnu.org
Subject: [PATCH] reconfigure: Reload all shepherd files when upgrading
 services.
Date: Wed, 31 Jul 2019 14:13:01 -0400

[Message part 6 (text/plain, inline)]

Fixes <https://bugs.gnu.org/36878>.
Reported by Robert Vollmert <rob <at> vllmrt.net>.

* guix/scripts/system/reconfigure.scm (upgrade-shepherd-services): Load
all service files, rather than just those of services to be started.
---
 guix/scripts/system/reconfigure.scm | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/guix/scripts/system/reconfigure.scm b/guix/scripts/system/reconfigure.scm
index 8c7d461585..dee0c24bd2 100644
--- a/guix/scripts/system/reconfigure.scm
+++ b/guix/scripts/system/reconfigure.scm
@@ -161,12 +161,7 @@ services as defined by OS."
                                              target-services)
                                         (map live-service-canonical-name
                                              live-services)))
-             (service-files
-              (map shepherd-service-file
-                   (filter (lambda (service)
-                             (memq (shepherd-service-canonical-name service)
-                                   to-start))
-                           target-services))))
+             (service-files (map shepherd-service-file target-services)))
         (eval #~(primitive-load #$(upgrade-services-program service-files
                                                             to-start
                                                             to-unload
-- 
2.22.0

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.