GNU bug report logs - #36878
'guix system reconfigure' does not reload Shepherd services

Previous Next

Package: guix;

Reported by: Robert Vollmert <rob <at> vllmrt.net>

Date: Wed, 31 Jul 2019 16:19:02 UTC

Severity: important

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#36878: closed ('guix system reconfigure' does not reload
 Shepherd services)
Date: Fri, 23 Aug 2019 12:56:05 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 23 Aug 2019 14:55:45 +0200
with message-id <877e746nxq.fsf <at> gnu.org>
and subject line Re: bug#36878: guix system reconfigure broken
has caused the debbugs.gnu.org bug report #36878,
regarding 'guix system reconfigure' does not reload Shepherd services
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
36878: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36878
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Robert Vollmert <rob <at> vllmrt.net>
To: bug-guix <at> gnu.org
Cc: guix-devel <at> gnu.org
Subject: guix system reconfigure broken
Date: Wed, 31 Jul 2019 18:18:47 +0200
Hi,

it appears that commit 5c8c8c455420af27189d6045b3599fe6e27ad012

  guix system: Reimplement 'reconfigure’.

breaks guix system reconfigure. In particular, after reconfiguring,
shepherd doesn’t know about the updated versions of services.

The usual output below is missing; after reverting the commit it’s
fine again.

guix system: loading new services: …
To complete the upgrade, run 'herd restart SERVICE' to stop,
upgrade, and restart each service that was not automatically restarted.
shepherd: Evaluating user expression (let* ((services (map primitive-load (?))) # ?) ?).
shepherd: Service user-homes has been started.
shepherd: Service term-auto could not be started.
bootloader successfully installed on '/dev/sda’

I see that some system tests for “guix system reconfigure” were added
after this change. Might I suggest adding them before the change next
time around, and making sure they pass both before and after?

Cheers
Robert




[Message part 3 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
Cc: guix-devel <at> gnu.org, 36878-done <at> debbugs.gnu.org,
 Robert Vollmert <rob <at> vllmrt.net>
Subject: Re: bug#36878: guix system reconfigure broken
Date: Fri, 23 Aug 2019 14:55:45 +0200
Hello,

zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze) skribis:

> zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze) writes:
>
>> Great :)
>>
>> CC'ing Chris and Dave since I don't have write access -- can we
>> fast-track #36880 into master? I'd consider this to be a high-priority
>> bug fix.
>>
>> Regards,
>> Jakob
>
> The patch made it into master as 1db6f137d; thanks to Danny for signing
> off on it. Should we close this?

I gather that this particular issue is fixed, so closing the bug now!

Ludo’.


This bug report was last modified 5 years and 277 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.