Subject: Re: [bug#36866] [PATCH] added trezord package

From: Julien Lepiller <[email-masked]>
Date: Thu, 01 Aug 2019 08:48:18 +0200

Le 1 août 2019 08:12:25 GMT+02:00, Julien Lepiller <[email-masked]> a écrit :
>Le 1 août 2019 03:38:53 GMT+02:00, Martin Becze <[email-masked]> a
>écrit :
>>heyyy does anyone know if this is the correct way to open a PR to
>guix?
>>kinda missing easy github mode here... lol
>
>Hey Martin,
>
>You're on the right track. Now, you just have to send your patches to
>this bug ([email-masked]) with git send-email. If there's only
>one patch, you may send it as an attachment instead, but send-email is
>the prefered way.

Hi again,

For some reason I didn't see your previous email with the patch, but I do now. Can you make sure the copyright line at the beginning is correct? It should only mentionned people who worked on that file, including you.

Github tarballs are autogenerated, but get regenerated from time to time and they are not stable. We prefer to use tge git-fetch method for github, since it is more stable. There thould be plenty of examples in the repo, but we can take care of that. Otherwise, nice patch! Could you send an updated one to this bug number? Thank you!