GNU bug report logs - #36858
27.0.50; display bugs with display-fill-column-indicator-mode

Previous Next

Full log

Message #32 received at 36858 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ergus <spacibba <at> aol.com>
Cc: 36858 <at> debbugs.gnu.org, rotim.davor <at> gmail.com
Subject: Re: bug#36858: 27.0.50; display bugs with
 display-fill-column-indicator-mode
Date: Wed, 07 Aug 2019 19:37:04 +0300

> Date: Wed, 7 Aug 2019 18:20:33 +0200
> From: Ergus <spacibba <at> aol.com>
> Cc: 36858 <at> debbugs.gnu.org, rotim.davor <at> gmail.com
> 
> in this code (in xdisp.c):
> 
> if (it->current_x < indicator_column_x)
>   {
>     it->face_id = merge_faces (it->w, Qextend_to_end_of_line,
>                                0, extend_face_merged_id);
> 
>     it->char_to_display = XFIXNAT (Vdisplay_fill_column_indicator_character);
>     PRODUCE_GLYPHS (it);
> 
>     it->face_id = extend_face_merged_id;
> }
> 
> I changed char_to_display:
> 
> it->char_to_display = (it->glyph_row->ends_at_zv_p) ? '1' : '0';

(There's no need to make any changes for that, you can simply invoke
dump-glyph-row or dump-glyph-matrix.)

> And then I obtained the attached image.

Right, I forgot where in the code we set that flag, and display of an
after-string at EOB indeed happens before that.

But since Dmitry says the case of Company mode doesn't need to be
fixed, I think this is a moot point now.  We should only solve the
issue with attributes being extended all the way towards the indicator
column.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.