GNU bug report logs - #36857
27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#36857: closed (27.0.50; Reduce calls to xref-collect-matches
 in dired-do-find-regexp)
Date: Thu, 26 Dec 2019 16:01:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 26 Dec 2019 18:00:02 +0200
with message-id <2f948de5-7be0-25b3-ce57-b37bc594570f <at> yandex.ru>
and subject line Re: bug#36857: 27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp
has caused the debbugs.gnu.org bug report #36857,
regarding 27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
36857: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36857
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp
Date: Tue, 30 Jul 2019 10:20:42 -0700

This is a proper bug report for an issue I raised on emacs.devel:

When marking multiple files in Dired, then running a search with
`dired-do-find-regexp', `xref-collect-matches' is called once per marked
file, when it could just be called once for the whole search. This can
slow things down quite a bit.

[Message part 3 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 36857-done <at> debbugs.gnu.org
Subject: Re: bug#36857: 27.0.50; Reduce calls to xref-collect-matches in
 dired-do-find-regexp
Date: Thu, 26 Dec 2019 18:00:02 +0200

On 25.12.2019 23:46, Eric Abrahamsen wrote:

>> Please try the attached patch. It should cut down on the number of
>> process calls.
> 
> That's great! The searches that once took "longer than I was willing to
> wait" now return nearly instantly. Thanks a lot. The compiler complains
> that `project--files-in-directory' and `project--find-regexp-in-files'
> are unknown, but presumably that's easily addressed.

Thanks for testing!

Pushed as ccd7cd2c51.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.