From unknown Wed Jun 18 23:16:34 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36857 <36857@debbugs.gnu.org> To: bug#36857 <36857@debbugs.gnu.org> Subject: Status: 27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp Reply-To: bug#36857 <36857@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:16:34 +0000 retitle 36857 27.0.50; Reduce calls to xref-collect-matches in dired-do-fin= d-regexp reassign 36857 emacs submitter 36857 Eric Abrahamsen severity 36857 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 13:20:54 2019 Received: (at submit) by debbugs.gnu.org; 30 Jul 2019 17:20:54 +0000 Received: from localhost ([127.0.0.1]:51102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsVnx-0005WG-Tm for submit@debbugs.gnu.org; Tue, 30 Jul 2019 13:20:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:44947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsVnw-0005W9-Fw for submit@debbugs.gnu.org; Tue, 30 Jul 2019 13:20:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60475) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsVnv-0006OB-Ib for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 13:20:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsVnu-0007xd-PU for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 13:20:51 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:54388 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hsVnu-0007uK-M0 for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 13:20:50 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id BC960FA080 for ; Tue, 30 Jul 2019 17:20:43 +0000 (UTC) From: Eric Abrahamsen To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp Date: Tue, 30 Jul 2019 10:20:42 -0700 Message-ID: <87wofzv3px.fsf@ericabrahamsen.net> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 52.70.2.18 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This is a proper bug report for an issue I raised on emacs.devel: When marking multiple files in Dired, then running a search with `dired-do-find-regexp', `xref-collect-matches' is called once per marked file, when it could just be called once for the whole search. This can slow things down quite a bit. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 14:44:49 2019 Received: (at 36857) by debbugs.gnu.org; 30 Jul 2019 18:44:49 +0000 Received: from localhost ([127.0.0.1]:51167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsX7B-0007ip-Hi for submit@debbugs.gnu.org; Tue, 30 Jul 2019 14:44:49 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:38546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsX7A-0007iY-04 for 36857@debbugs.gnu.org; Tue, 30 Jul 2019 14:44:48 -0400 Received: by mail-wm1-f43.google.com with SMTP id s15so36203611wmj.3 for <36857@debbugs.gnu.org>; Tue, 30 Jul 2019 11:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dm3GIkAVcy5bMWdiLz3UqZK3HZWok1xQ5HA6OLzG/jw=; b=rhXqmhruyUdVU96TIlh5HUOA41FOD3+OjKnHiYnPXLlx3TAjHJsZveDLYDLQTa5AeY B9gYxObMKSNXB+rm6bhM4tDvqgpAoV3NXMaA74Y1gOs0oe+LCZUBZ9JKSeKhU1nTDR0Y if/MSGF65MxAbvjSCHAtVo8e26ZhRljyKkNcBlPnPf06CeFDY7AtWsb8BaTcc4epUPRU PpgfZe3deqm/55irEbaBZomt2pWFpucmb7DN2q5hgog35vJmRM6f5v2Ly3JQ5dnXo76a hyr8Eq1B4nfOTVpZGQV+VRITIEe/kEOhIt3681gSo+M8/xTBuqlpj5N+qn6pN+wxxHQX apaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dm3GIkAVcy5bMWdiLz3UqZK3HZWok1xQ5HA6OLzG/jw=; b=r+gTNF2TIOyYGmJ7HM6tyfyMJ/7i451ejuHjwZUQs8dK3hsmlmWSCZm3pBp91CYuO6 pvqRDTefqWhIXsmV+8lz9/LPiL8L21hX/3gdlKny5PqaSa44SgB81rCxoVva2GzRBeLt y1oEQ/orE20aJLxVqTktWayLacJDalz8ZgRbe9AdKOmxhOrpPUaJPUwY5SbKFu3n7VqD 2tZhJ3E4Ql5qrUv4+N/Fc4laNlZIlZ7hsOh98omvpXoaEm0IJni9Lzs4gB7bdpdPdYUO 4zEb1yo2/mOrWt3TqZh8Eseyv4eq2V7JjJjB2woZCAeKxHGEPerNdz87GRSMm/a3iFiE COBA== X-Gm-Message-State: APjAAAUqyAfo5CroK9gpEY/HuyYIlCCZSn2zvYRnps7L57JF9M8AnghC ZaoQCB4/7Ayc8tcNhIZ/SEXWDiPizhE= X-Google-Smtp-Source: APXvYqw75f16WJ97InLLlslpYE8N6l+GLawvLX0bMhkl8hqbDPLjsYMflBuen+9JW3EnFWX1GoaXfw== X-Received: by 2002:a1c:c545:: with SMTP id v66mr108836393wmf.51.1564512281856; Tue, 30 Jul 2019 11:44:41 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id x20sm51453030wmc.1.2019.07.30.11.44.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2019 11:44:40 -0700 (PDT) Subject: Re: bug#36857: 27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp To: Eric Abrahamsen , 36857@debbugs.gnu.org References: <87wofzv3px.fsf@ericabrahamsen.net> From: Dmitry Gutov Message-ID: <43928735-8d95-de13-74e6-96f4b1b3e1bd@yandex.ru> Date: Tue, 30 Jul 2019 21:44:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <87wofzv3px.fsf@ericabrahamsen.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 36857 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 30.07.2019 20:20, Eric Abrahamsen wrote: > When marking multiple files in Dired Could you estimate how many files you need to mark for this to become a problem? I'm really curious. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 14:46:00 2019 Received: (at 36857) by debbugs.gnu.org; 30 Jul 2019 18:46:00 +0000 Received: from localhost ([127.0.0.1]:51171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsX8J-0007lF-SQ for submit@debbugs.gnu.org; Tue, 30 Jul 2019 14:46:00 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:45561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsX8H-0007l2-Du for 36857@debbugs.gnu.org; Tue, 30 Jul 2019 14:45:57 -0400 Received: by mail-wr1-f48.google.com with SMTP id f9so66858328wre.12 for <36857@debbugs.gnu.org>; Tue, 30 Jul 2019 11:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QnF5hyvaO9WOwIFtMzFZm0ErcJPtYzrz7XrAx8cnM/U=; b=E4JPK2ATNQLpgNofcQHBJZ7vH5iHX0sql/LZhkOhxwcFiGwKxeOSAOOtvmKM1oWpfz KPgVLltgkLuxPKxuCjsLQAzuY3+sRW8XiJld96UYI8Y/fkIdGqiChx6yBjpjHA0f5eQO 8jN9X3yQAT3+E7ZtKyn8VPTrrUQWmsBahJCLFBg7bgNICMdffgpS41UVMSp0Ot4QLKBh w7CJXnXIp/F+K1t0Xu819rYIk4vcYXdyQOXWSHvAslKervBBUJpxZTNibNi0NfcZmgC5 NElPWBUwrcFhuHyN4EEY4RD6ZvLbyl4GFEonRTuu9neUq+O+Hh9sgBq33bBOjT9lXjwG Y3Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QnF5hyvaO9WOwIFtMzFZm0ErcJPtYzrz7XrAx8cnM/U=; b=c3qLtDUbNk1TgTM2+vWQp6OBk99llhKYn/31JdLOVB9oojpzspFtFyDOutHdgdWpqR leezLplbEUya6Awk8KHUeAkVsbgelnNayxaP1JwvNUHUKa+J1uUxyW+EewHdCT/xT/t1 ldkkyEqkMnjRzvLkwgI3YEhlID7/evqYfa1f0w9kcCoeNyaG5qatAhV5uwCYssGAM2tR kiMl9bqppZg/O7L38vV7MgxdUIl0nBI5Qn4BuWU6hW6HQqx3hB358SzfU3dP31F0l5zN HOLq3m+K8sAJ5fXX9M8Lz1c+WZHlpk0bA+XB2Kk9cOgKO+MMqg6vbZLhkXvOKLoRO6vg sqfg== X-Gm-Message-State: APjAAAUwY+AIteF6mfUOYK7OmS3zf+r/n1sENWRnvu4lk+1XoX4u9340 RBmQFHubQxgB+RkwJWjwkKjylXy4Jpk= X-Google-Smtp-Source: APXvYqxK8cgVNtsM5zdZ1Jv00+oIXXJJcgYB6biOu42caJapTtadpWrb9x8lTKkpuvbggClH2zeRwQ== X-Received: by 2002:adf:fc52:: with SMTP id e18mr7875332wrs.14.1564512351269; Tue, 30 Jul 2019 11:45:51 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id p3sm53857254wmg.15.2019.07.30.11.45.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2019 11:45:50 -0700 (PDT) Subject: Re: bug#36857: 27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp From: Dmitry Gutov To: Eric Abrahamsen , 36857@debbugs.gnu.org References: <87wofzv3px.fsf@ericabrahamsen.net> <43928735-8d95-de13-74e6-96f4b1b3e1bd@yandex.ru> Message-ID: <26938345-f9bb-1c92-fedf-e59fdb536f77@yandex.ru> Date: Tue, 30 Jul 2019 21:45:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <43928735-8d95-de13-74e6-96f4b1b3e1bd@yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 36857 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 30.07.2019 21:44, Dmitry Gutov wrote: > On 30.07.2019 20:20, Eric Abrahamsen wrote: >> When marking multiple files in Dired > > Could you estimate how many files you need to mark for this to become a > problem? I'm really curious. Never mind, saw your reply on emacs-devel. 200-300 is a respectable amount. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 14:56:11 2019 Received: (at 36857) by debbugs.gnu.org; 30 Jul 2019 18:56:11 +0000 Received: from localhost ([127.0.0.1]:51180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsXIB-000823-36 for submit@debbugs.gnu.org; Tue, 30 Jul 2019 14:56:11 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:56322 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsXI8-00081j-Jv for 36857@debbugs.gnu.org; Tue, 30 Jul 2019 14:56:09 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id BB167FA0A3; Tue, 30 Jul 2019 18:56:02 +0000 (UTC) From: Eric Abrahamsen To: Dmitry Gutov Subject: Re: bug#36857: 27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp References: <87wofzv3px.fsf@ericabrahamsen.net> <43928735-8d95-de13-74e6-96f4b1b3e1bd@yandex.ru> <26938345-f9bb-1c92-fedf-e59fdb536f77@yandex.ru> Date: Tue, 30 Jul 2019 11:56:00 -0700 In-Reply-To: <26938345-f9bb-1c92-fedf-e59fdb536f77@yandex.ru> (Dmitry Gutov's message of "Tue, 30 Jul 2019 21:45:48 +0300") Message-ID: <8736inuzb3.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36857 Cc: 36857@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dmitry Gutov writes: > On 30.07.2019 21:44, Dmitry Gutov wrote: >> On 30.07.2019 20:20, Eric Abrahamsen wrote: >>> When marking multiple files in Dired >> >> Could you estimate how many files you need to mark for this to >> become a problem? I'm really curious. > > Never mind, saw your reply on emacs-devel. 200-300 is a respectable amount. Does "respectable" mean "quite a few" or "a number we should be able to handle without significant slowdowns"? :) From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 31 10:06:13 2019 Received: (at 36857) by debbugs.gnu.org; 31 Jul 2019 14:06:13 +0000 Received: from localhost ([127.0.0.1]:52812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hspF6-0004j1-Rv for submit@debbugs.gnu.org; Wed, 31 Jul 2019 10:06:13 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:35949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hspF5-0004ip-Pp for 36857@debbugs.gnu.org; Wed, 31 Jul 2019 10:06:12 -0400 Received: by mail-wr1-f47.google.com with SMTP id n4so69914988wrs.3 for <36857@debbugs.gnu.org>; Wed, 31 Jul 2019 07:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sVF0mSO9GfDLp/j/xrg/wn2wF39PRwE7qWkUJCO0yH8=; b=K+SPir6REGk598Jgi3pWJhPg5DYlHgCN+GX+Cv1tSZyiZ5Gwfk1VwsNp7kKkqWYv5J wt0nTV4mGRyoMxrIX2ghx7uHMwbg2eJgwEYhNW61hsTW5t91r4T84biUXspF4LGUG49a mJQQPJd21MQOesGYWoemAdYWyjcELOgR2sq4vDoS04CCfO3qAGgrWXNjE27JEtiBcEzU ubnIzj9apv789wuFSgcaQ4gcJjNxwclphU7yHhDc5dANQ2hufo7Vyeq1NcXm/JDJBlVK Oe017fgWvtqoDou57n9e+7ji4oHTzBILei6SjF2V4O6kUb5KoX2VekI1sZP3aOOeJ3fV tdIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sVF0mSO9GfDLp/j/xrg/wn2wF39PRwE7qWkUJCO0yH8=; b=BU1D9Rvtd8PAZi3gX/6ixfbSTVASB7sMfnCRfMlp0BHlksb4VZqvdWqybCOMBDeeI5 8960TmKAGE+xu1pdORAT6eo99SzEDU71NtMXTMb9vpFlPJLAsvbr3NCfJ44cHu5nHouw czF7ReIZtEyZgR8h03f6rvUox2sa2fir9eT+bpFCOIZbuxK58HjPLLAlS9MJ/9ygMpyY PfUkEzEUzHf54BZukrW51UelESuPgJyRx8fzUKcNLepgDK26VARGeUhYaa/SPtieqsmj r6hOqhHPBDTh8V0BjHsKh1rj2h/JjBz0HBP917BGtWbC8ndg1cK1S5fikEhTQLqaR7ro oNCw== X-Gm-Message-State: APjAAAWrkRZDg5oSH499Hrb38KHd4ltDJNxSVMdkSm+bd4e9Hdj+XiJA ZkLMfJDAjE1r+5Hl9KhZxKL5O35eiFU= X-Google-Smtp-Source: APXvYqxt9UqTYwCQIhn/d2FO/lwNNYeQtp/I6PucNwmDzcqTxKn3VNQElrsCYnTsqUH6j1FpEiiPag== X-Received: by 2002:a5d:42c5:: with SMTP id t5mr93449086wrr.5.1564581965369; Wed, 31 Jul 2019 07:06:05 -0700 (PDT) Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id q18sm82878653wrw.36.2019.07.31.07.06.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jul 2019 07:06:04 -0700 (PDT) Subject: Re: bug#36857: 27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp To: Eric Abrahamsen References: <87wofzv3px.fsf@ericabrahamsen.net> <43928735-8d95-de13-74e6-96f4b1b3e1bd@yandex.ru> <26938345-f9bb-1c92-fedf-e59fdb536f77@yandex.ru> <8736inuzb3.fsf@ericabrahamsen.net> From: Dmitry Gutov Message-ID: Date: Wed, 31 Jul 2019 17:06:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <8736inuzb3.fsf@ericabrahamsen.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 36857 Cc: 36857@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 30.07.2019 21:56, Eric Abrahamsen wrote: >> Never mind, saw your reply on emacs-devel. 200-300 is a respectable amount. > > Does "respectable" mean "quite a few" or "a number we should be able to > handle without significant slowdowns"? :) Hopefully both. :-) I have an improvement in mind that would fix it, but there are a couple change I'll need to make in a related area (project.el) first, so please stay tuned. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 31 11:56:39 2019 Received: (at 36857) by debbugs.gnu.org; 31 Jul 2019 15:56:39 +0000 Received: from localhost ([127.0.0.1]:52946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsqxz-0003Pk-Cv for submit@debbugs.gnu.org; Wed, 31 Jul 2019 11:56:39 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:52172 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsqxx-0003PP-Ma for 36857@debbugs.gnu.org; Wed, 31 Jul 2019 11:56:38 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 318CEFA0A3; Wed, 31 Jul 2019 15:56:31 +0000 (UTC) From: Eric Abrahamsen To: Dmitry Gutov Subject: Re: bug#36857: 27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp References: <87wofzv3px.fsf@ericabrahamsen.net> <43928735-8d95-de13-74e6-96f4b1b3e1bd@yandex.ru> <26938345-f9bb-1c92-fedf-e59fdb536f77@yandex.ru> <8736inuzb3.fsf@ericabrahamsen.net> Date: Wed, 31 Jul 2019 08:56:29 -0700 In-Reply-To: (Dmitry Gutov's message of "Wed, 31 Jul 2019 17:06:01 +0300") Message-ID: <87wofykxjm.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36857 Cc: 36857@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dmitry Gutov writes: > On 30.07.2019 21:56, Eric Abrahamsen wrote: > >>> Never mind, saw your reply on emacs-devel. 200-300 is a respectable amount. >> >> Does "respectable" mean "quite a few" or "a number we should be able to >> handle without significant slowdowns"? :) > > Hopefully both. :-) > > I have an improvement in mind that would fix it, but there are a > couple change I'll need to make in a related area (project.el) first, > so please stay tuned. Cool, thanks! From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 11:31:17 2019 Received: (at 36857) by debbugs.gnu.org; 25 Dec 2019 16:31:17 +0000 Received: from localhost ([127.0.0.1]:54626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik9Z7-00040J-3j for submit@debbugs.gnu.org; Wed, 25 Dec 2019 11:31:17 -0500 Received: from mail-lf1-f49.google.com ([209.85.167.49]:33046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik9Z6-000408-AD for 36857@debbugs.gnu.org; Wed, 25 Dec 2019 11:31:16 -0500 Received: by mail-lf1-f49.google.com with SMTP id n25so17096590lfl.0 for <36857@debbugs.gnu.org>; Wed, 25 Dec 2019 08:31:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=L4YznNs7yNaKl/fVYr/0zthpLH+8KBh15FX1OGdBonM=; b=sa+ktAz4csiU03/bBYeuanYER2mZWUO90jMZgr/aparMF+8rYesi8U8o2DbvHqIx2f /KfZKy3XU0gHGDrZ4+ZJSuRvcsUrfkp0Ou35SOKDpHGrZCA6NiTpJ5JkebcC/TVjpBMV qvHK/o3qWN796Catny+VJDr/L1HqFISEpChRBb8sKUKMWHwAdejGpJH+boBPLAYI2ObM uhC1/ym/SFIQqUGQUdjZq7bznTB0bSzGn97rlxZEp+oE4kdD4SXdarRoBhfUrsZQUceO WJ7Pk8tnslM4TpXiPX4orsfyipOm9/k0jOZE+MmizayFSpaGx7cDGNwqyDh2T6pSjsnG 4gHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:subject:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=L4YznNs7yNaKl/fVYr/0zthpLH+8KBh15FX1OGdBonM=; b=nKFolO9i0/BneCwkr+7gslmjz/gWeioLCfZSKt8oAFe5wD0M61yOfwfyUsDlnsY2S0 gxJsW/lYkb5W2BnPeubei5susp5aKyrNNiZIpQWLrQhTIvWOwFZ+qY5vfsOfl4XuaYw4 jVYltb9nwedcQvuHKc4MJ9ADpWzv0NDvr1KwlJRTB5EuqKA+74Ff8Jlwy/+k9eyDBsk4 dUGBe24fMCEVD5gv8syOwOnXSpP0b8EQNZAl8bG2z8vBduj2wi2yI05gWr3V915y9/wh XGfXE7tP7YhEEjtaFRva5+9+xcVXqOLlt0Q6MSr/YOEMVe6CYa4eIus7ru6BqqlyS1Xr /wxA== X-Gm-Message-State: APjAAAUgE93v4tCKZtY4csFDqcSKz/IWvwWwfvG09yAhhvLtaKagzGaA iK/vTgu0hC49F3Ql9xCiGDCPShZFEogUKw== X-Google-Smtp-Source: APXvYqz9HWPJz/qWzslkhGs7yR+jw/Jum4bUe9cDDQuay2vyuYRzmFCQgMNmqd25ex2DZBsFkHgvgg== X-Received: by 2002:a19:6d13:: with SMTP id i19mr23766183lfc.6.1577291470404; Wed, 25 Dec 2019 08:31:10 -0800 (PST) Received: from [172.18.118.211] ([79.104.7.197]) by smtp.googlemail.com with ESMTPSA id 138sm11925300lfa.76.2019.12.25.08.31.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Dec 2019 08:31:09 -0800 (PST) From: Dmitry Gutov Subject: Re: bug#36857: 27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp To: Eric Abrahamsen References: <87wofzv3px.fsf@ericabrahamsen.net> <43928735-8d95-de13-74e6-96f4b1b3e1bd@yandex.ru> <26938345-f9bb-1c92-fedf-e59fdb536f77@yandex.ru> <8736inuzb3.fsf@ericabrahamsen.net> Message-ID: <0f42bb71-b460-1ec7-f24f-e2df50cb5f70@yandex.ru> Date: Wed, 25 Dec 2019 18:31:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <8736inuzb3.fsf@ericabrahamsen.net> Content-Type: multipart/mixed; boundary="------------9206BD6875C43B8C55FFF47D" Content-Language: en-US X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 36857 Cc: 36857@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) This is a multi-part message in MIME format. --------------9206BD6875C43B8C55FFF47D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Eric, Please try the attached patch. It should cut down on the number of process calls. --------------9206BD6875C43B8C55FFF47D Content-Type: text/x-patch; name="dired-do-find-regexp-speedup.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="dired-do-find-regexp-speedup.diff" diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index fb1ad6266d..0fb8839a3f 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -2975,19 +2975,24 @@ dired-do-find-regexp (require 'xref) (defvar grep-find-ignored-files) (declare-function rgrep-find-ignored-directories "grep" (dir)) - (let* ((files (dired-get-marked-files nil nil nil nil t)) + (let* ((marks (dired-get-marked-files nil nil nil nil t)) (ignores (nconc (mapcar #'file-name-as-directory (rgrep-find-ignored-directories default-directory)) grep-find-ignored-files)) (fetcher (lambda () - (let ((xrefs (mapcan - (lambda (file) - (xref-collect-matches regexp "*" file - (and (file-directory-p file) - ignores))) - files))) + (let (files xrefs) + (mapc + (lambda (mark) + (if (file-directory-p mark) + (setq files (nconc + (project--files-in-directory mark ignores "*") + files)) + (push mark files))) + (nreverse marks)) + (setq xrefs + (project--find-regexp-in-files regexp files)) (unless xrefs (user-error "No matches for: %s" regexp)) xrefs)))) --------------9206BD6875C43B8C55FFF47D-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 16:46:49 2019 Received: (at 36857) by debbugs.gnu.org; 25 Dec 2019 21:46:49 +0000 Received: from localhost ([127.0.0.1]:54731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikEUT-0003Tv-0r for submit@debbugs.gnu.org; Wed, 25 Dec 2019 16:46:49 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:47594 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikEUR-0003Tb-3H for 36857@debbugs.gnu.org; Wed, 25 Dec 2019 16:46:47 -0500 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id C52BFFA0E5; Wed, 25 Dec 2019 21:46:40 +0000 (UTC) From: Eric Abrahamsen To: Dmitry Gutov Subject: Re: bug#36857: 27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp References: <87wofzv3px.fsf@ericabrahamsen.net> <43928735-8d95-de13-74e6-96f4b1b3e1bd@yandex.ru> <26938345-f9bb-1c92-fedf-e59fdb536f77@yandex.ru> <8736inuzb3.fsf@ericabrahamsen.net> <0f42bb71-b460-1ec7-f24f-e2df50cb5f70@yandex.ru> Date: Wed, 25 Dec 2019 13:46:39 -0800 In-Reply-To: <0f42bb71-b460-1ec7-f24f-e2df50cb5f70@yandex.ru> (Dmitry Gutov's message of "Wed, 25 Dec 2019 18:31:07 +0200") Message-ID: <87k16khydc.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36857 Cc: 36857@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12/25/19 18:31 PM, Dmitry Gutov wrote: > Hi Eric, > > Please try the attached patch. It should cut down on the number of > process calls. That's great! The searches that once took "longer than I was willing to wait" now return nearly instantly. Thanks a lot. The compiler complains that `project--files-in-directory' and `project--find-regexp-in-files' are unknown, but presumably that's easily addressed. Thanks, Eric From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 26 11:00:12 2019 Received: (at 36857-done) by debbugs.gnu.org; 26 Dec 2019 16:00:12 +0000 Received: from localhost ([127.0.0.1]:56128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikVYa-0004Hf-B8 for submit@debbugs.gnu.org; Thu, 26 Dec 2019 11:00:12 -0500 Received: from mail-lf1-f44.google.com ([209.85.167.44]:41402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikVYY-0004GL-PV for 36857-done@debbugs.gnu.org; Thu, 26 Dec 2019 11:00:11 -0500 Received: by mail-lf1-f44.google.com with SMTP id m30so18781811lfp.8 for <36857-done@debbugs.gnu.org>; Thu, 26 Dec 2019 08:00:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dogutqqeT7/JpmvTyP9Icnk3+preFMNMxdNuEZQo7KQ=; b=pUXxnN81NMkEZ+BrXANdkizSVHe1t163DGGMmBbd7Bg3xhljp3K+iNCDYlJO+dZnTl yd/P28JHKSzvE+b+wDzjE6Era3wme4KsSEnS6FwongQqjycTXlfFVvlSSYvfZcZnAqEG lIygOyKeju9MykwKfVD/SGRuPW7OGeI/wnAXKy6uIObQuKlfzp2Fc4SuvcCVFcbniS4a quySj+l8w7rCjEKTG9K0NL4H8xJg/tO+5h/z3aoWtTrxPxfTdITc/6+JGj6Y98hy2q/8 DAkyCV+LRAwJEYe+tH5YN+S80tGw9NBIlQ3NtqRTaZNyGMpvopaXHdqEhd4GgDByYSI6 04Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dogutqqeT7/JpmvTyP9Icnk3+preFMNMxdNuEZQo7KQ=; b=o6BNxXNQujlqgP6DYoa8/0NjYfu68FMBjZTvONFRvMx0VTG4rPXNYoomsTQldxVg2P P8FMIj/1eN6cX0GATD21uGO8WcvkCE+ySgyMh2OJNe1LBGXB2maZK0x1oa5PvYbmhTWO lysbE/n+HZqHJHo5+im4XREY+ENvbht5DOuY5hjWLACS6O+w28HHMjTYrS29M6CzxQkf uMKT3USK957BgxULd0SHh3QmGphNQVp2WD1jZjcV42m9FkaIb66gvXMcSsSxBcxCa1Hj /UNICmuoLRpMBvtwf8TzpGP/IHGqE9giq3goCJDHYZin7gUKoiy8BAw/pOxLZX+wozUw 6Gyw== X-Gm-Message-State: APjAAAVRgYHJXIygrmEexsjPdJxZCOP5Y2YNYCKbu58E7qJ25vpDh9pi bt4m+eyyfRgxAyhUZoeslwmsu6H6cTk= X-Google-Smtp-Source: APXvYqy3k+EEKuei6Sd6KhRThYg82A+FYDaUAwW9Jxmdk4ZPwVZZMzWU3dz5tN2b1n33y4XdDeGXGA== X-Received: by 2002:ac2:5592:: with SMTP id v18mr24591877lfg.17.1577376004391; Thu, 26 Dec 2019 08:00:04 -0800 (PST) Received: from [192.168.0.100] ([94.229.108.16]) by smtp.googlemail.com with ESMTPSA id i1sm12662241lji.71.2019.12.26.08.00.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Dec 2019 08:00:03 -0800 (PST) Subject: Re: bug#36857: 27.0.50; Reduce calls to xref-collect-matches in dired-do-find-regexp To: Eric Abrahamsen References: <87wofzv3px.fsf@ericabrahamsen.net> <43928735-8d95-de13-74e6-96f4b1b3e1bd@yandex.ru> <26938345-f9bb-1c92-fedf-e59fdb536f77@yandex.ru> <8736inuzb3.fsf@ericabrahamsen.net> <0f42bb71-b460-1ec7-f24f-e2df50cb5f70@yandex.ru> <87k16khydc.fsf@ericabrahamsen.net> From: Dmitry Gutov Message-ID: <2f948de5-7be0-25b3-ce57-b37bc594570f@yandex.ru> Date: Thu, 26 Dec 2019 18:00:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87k16khydc.fsf@ericabrahamsen.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 36857-done Cc: 36857-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 25.12.2019 23:46, Eric Abrahamsen wrote: >> Please try the attached patch. It should cut down on the number of >> process calls. > > That's great! The searches that once took "longer than I was willing to > wait" now return nearly instantly. Thanks a lot. The compiler complains > that `project--files-in-directory' and `project--find-regexp-in-files' > are unknown, but presumably that's easily addressed. Thanks for testing! Pushed as ccd7cd2c51. From unknown Wed Jun 18 23:16:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 24 Jan 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator