GNU bug report logs - #36843
26.2; ERC lurker feature broken

Previous Next

Package: emacs;

Reported by: Thibault Polge <thibault <at> thb.lt>

Date: Mon, 29 Jul 2019 22:06:02 UTC

Severity: normal

Tags: fixed, patch

Found in versions 24.4, 26.2

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #30 received at 36843 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Amin Bandali <bandali <at> gnu.org>
Cc: Thibault Polge <thibault <at> thb.lt>, 36843 <at> debbugs.gnu.org
Subject: Re: bug#36843: 26.2; ERC lurker feature broken
Date: Thu, 05 Sep 2019 19:57:45 -0400

tags 36843 fixed
close 36843 27.1
quit

Amin Bandali <bandali <at> gnu.org> writes:

> Subject: [PATCH] Fix erc-lurker-update-status (bug#36843)
>
> Broken since 2013-08-22 "* lisp/erc/erc.el: Use lexical-binding".
>
> * lisp/erc/erc.el (erc-message-parsed): New variable.
> (erc-display-message): Dynamically bind it.
> (erc-lurker-update-status): Check it instead of using `parsed'
> directly.  This results in `erc-lurker-state' being properly updated
> to keep track of non-lurkers, and thus `erc-lurker-p' returning
> correct results rather than return t for everyone.

Pushed to master.

ff0f4c7312 2019-09-05T19:56:14-04:00 "Fix erc-lurker-update-status (bug#36843)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ff0f4c731231b03d73cc35de9e042d1fc1b75f4e
This bug report was last modified 5 years and 264 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.