From unknown Mon Jun 23 18:33:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36843: 26.2; ERC lurker feature broken Resent-From: Thibault Polge Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jul 2019 22:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 36843@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156443793621372 (code B ref -1); Mon, 29 Jul 2019 22:06:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jul 2019 22:05:36 +0000 Received: from localhost ([127.0.0.1]:49229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsDlu-0005Yd-St for submit@debbugs.gnu.org; Mon, 29 Jul 2019 18:05:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:35979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsDlq-0005YU-Vn for submit@debbugs.gnu.org; Mon, 29 Jul 2019 18:05:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36941) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsDlo-0006EG-3N for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2019 18:05:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsDli-0003lE-BX for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2019 18:05:26 -0400 Received: from 4.mo173.mail-out.ovh.net ([46.105.34.219]:60106) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hsDld-0003aO-Je for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2019 18:05:18 -0400 Received: from player715.ha.ovh.net (unknown [10.108.57.18]) by mo173.mail-out.ovh.net (Postfix) with ESMTP id 552C61135E1 for ; Tue, 30 Jul 2019 00:05:08 +0200 (CEST) Received: from thb.lt (85-170-54-226.rev.numericable.fr [85.170.54.226]) (Authenticated sender: thibault@thb.lt) by player715.ha.ovh.net (Postfix) with ESMTPSA id B756483FBE42 for ; Mon, 29 Jul 2019 22:05:06 +0000 (UTC) User-agent: mu4e 1.3.2; emacs 26.2 From: Thibault Polge Date: Tue, 30 Jul 2019 00:05:04 +0200 Message-ID: <877e80o5tb.fsf@thb.lt> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 7895654573764233483 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrledvgddtiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecu X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 46.105.34.219 X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Message-ID: <878ssgo5ve.fsf@thb.lt> Hello, ERC lurkers feature is broken on Emacs 26.2: (erc-lurker-p) returns t for all inputs and messages of types in 'erc-lurker-hide-list' are always hidden. I think this is because 'erc-lurker-update-status' relies on dynamic binding, as stated in its docstring: > This function depends on the fact that `erc-display-message' > dynamically binds `parsed', which is used to check if the current > message is a PRIVMSG and to determine its sender. See also > `erc-lurker-trim-nicks' and `erc-lurker-ignore-chars'. But erc.el uses lexical binding. All the best, Thibault In GNU Emacs 26.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.8) Windowing system distributor 'The X.Org Foundation', version 11.0.12005000 Recent messages: Saving file /home/thblt/*message*-20190729-235431... Wrote /home/thblt/*message*-20190729-235431 Mark set [2 times] Sending... message-send: No methods specified to send by previous-line: Beginning of buffer Auto-saving... Mark set Quit Buffer *unsent mail to bug-gnu-emacs@gnu.org* modified; kill anyway? (y or n) y Configured using: 'configure --prefix=/nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2 --disable-build-details --with-modules --with-x-toolkit=gtk3 --with-xft CFLAGS=-DMAC_OS_X_VERSION_MAX_ALLOWED=101200' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GSETTINGS GLIB NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD Important settings: value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-netsplit-mode: t erc-hl-nicks-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t diff-auto-refine-mode: t aggressive-indent-mode: t color-identifiers-mode: t outshine-mode: t pdf-occur-global-minor-mode: t magit-auto-revert-mode: t async-bytecomp-package-mode: t company-posframe-mode: t company-mode: t shell-dirtrack-mode: t outline-minor-mode: t super-save-mode: t yas-global-mode: t yas-minor-mode: t global-undo-tree-mode: t undo-tree-mode: t show-smartparens-global-mode: t show-smartparens-mode: t smartparens-global-mode: t smartparens-mode: t recentf-mode: t beginend-global-mode: t beginend-prog-mode: t winner-mode: t which-key-mode: t popwin-mode: t ivy-posframe-mode: t eyebrowse-mode: t counsel-projectile-mode: t ivy-mode: t projectile-mode: t auto-compile-on-load-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/thblt/.emacs.d/lib/password-store/password-store hides /home/thblt/.nix-profile/share/emacs/site-lisp/password-store /home/thblt/.nix-profile/share/emacs/site-lisp/site-start hides /run/current-system/sw/share/emacs/site-lisp/site-start /home/thblt/.nix-profile/share/emacs/site-lisp/site-start hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/site-lisp/site-start /home/thblt/.emacs.d/lib/auth-password-store/auth-source-pass hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/auth-source-pass /home/thblt/.emacs.d/lib/org/lisp/ob-emacs-lisp hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-emacs-lisp /home/thblt/.emacs.d/lib/org/lisp/ob-picolisp hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-picolisp /home/thblt/.emacs.d/lib/org/lisp/org-attach hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-attach /home/thblt/.emacs.d/lib/org/lisp/org-id hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-id /home/thblt/.emacs.d/lib/org/lisp/ox-publish hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ox-publish /home/thblt/.emacs.d/lib/org/lisp/org-indent hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-indent /home/thblt/.emacs.d/lib/org/lisp/ob-core hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-core /home/thblt/.emacs.d/lib/org/lisp/ob-hledger hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-hledger /home/thblt/.emacs.d/lib/org/lisp/org-protocol hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-protocol /home/thblt/.emacs.d/lib/org/lisp/ob-sqlite hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-sqlite /home/thblt/.emacs.d/lib/org/lisp/ob-python hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-python /home/thblt/.emacs.d/lib/org/lisp/org hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org /home/thblt/.emacs.d/lib/org/lisp/org-pcomplete hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-pcomplete /home/thblt/.emacs.d/lib/org/lisp/ob-java hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-java /home/thblt/.emacs.d/lib/org/lisp/ob-lua hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-lua /home/thblt/.emacs.d/lib/org/lisp/ob-mscgen hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-mscgen /home/thblt/.emacs.d/lib/org/lisp/org-timer hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-timer /home/thblt/.emacs.d/lib/org/lisp/org-lint hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-lint /home/thblt/.emacs.d/lib/org/lisp/org-plot hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-plot /home/thblt/.emacs.d/lib/org/lisp/ob-processing hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-processing /home/thblt/.emacs.d/lib/org/lisp/ob-scheme hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-scheme /home/thblt/.emacs.d/lib/org/lisp/ob-exp hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-exp /home/thblt/.emacs.d/lib/org/lisp/ob-sql hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-sql /home/thblt/.emacs.d/lib/org/lisp/org-faces hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-faces /home/thblt/.emacs.d/lib/org/lisp/org-crypt hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-crypt /home/thblt/.emacs.d/lib/org/lisp/org-table hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-table /home/thblt/.emacs.d/lib/org/lisp/ox-md hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ox-md /home/thblt/.emacs.d/lib/org/lisp/ox-ascii hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ox-ascii /home/thblt/.emacs.d/lib/org/lisp/org-loaddefs hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-loaddefs /home/thblt/.emacs.d/lib/org/lisp/org-colview hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-colview /home/thblt/.emacs.d/lib/org/lisp/ob-C hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-C /home/thblt/.emacs.d/lib/org/lisp/org-footnote hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-footnote /home/thblt/.emacs.d/lib/org/lisp/org-feed hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-feed /home/thblt/.emacs.d/lib/org/lisp/org-duration hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-duration /home/thblt/.emacs.d/lib/org/lisp/ob-calc hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-calc /home/thblt/.emacs.d/lib/org/lisp/ob-ebnf hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-ebnf /home/thblt/.emacs.d/lib/org/lisp/ob-ocaml hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-ocaml /home/thblt/.emacs.d/lib/org/lisp/ob-ditaa hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-ditaa /home/thblt/.emacs.d/lib/org/lisp/org-mobile hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-mobile /home/thblt/.emacs.d/lib/org/lisp/ob-gnuplot hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-gnuplot /home/thblt/.emacs.d/lib/org/lisp/ox-texinfo hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ox-texinfo /home/thblt/.emacs.d/lib/org/lisp/org-datetree hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-datetree /home/thblt/.emacs.d/lib/org/lisp/ob-J hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-J /home/thblt/.emacs.d/lib/org/lisp/ob-ruby hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-ruby /home/thblt/.emacs.d/lib/org/lisp/ob-eval hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-eval /home/thblt/.emacs.d/lib/org/lisp/ob-abc hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-abc /home/thblt/.emacs.d/lib/org/lisp/ox-html hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ox-html /home/thblt/.emacs.d/lib/org/lisp/ob-io hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-io /home/thblt/.emacs.d/lib/org/lisp/org-compat hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-compat /home/thblt/.emacs.d/lib/org/lisp/ob-perl hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-perl /home/thblt/.emacs.d/lib/org/lisp/org-archive hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-archive /home/thblt/.emacs.d/lib/org/lisp/ob-dot hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-dot /home/thblt/.emacs.d/lib/org/lisp/ob-ref hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-ref /home/thblt/.emacs.d/lib/org/lisp/org-habit hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-habit /home/thblt/.emacs.d/lib/org/lisp/org-capture hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-capture /home/thblt/.emacs.d/lib/org/lisp/ob-shell hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-shell /home/thblt/.emacs.d/lib/org/lisp/ob-js hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-js /home/thblt/.emacs.d/lib/org/lisp/ob-stan hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-stan /home/thblt/.emacs.d/lib/org/lisp/ob-css hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-css /home/thblt/.emacs.d/lib/org/lisp/ob-clojure hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-clojure /home/thblt/.emacs.d/lib/org/lisp/ob-tangle hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-tangle /home/thblt/.emacs.d/lib/org/lisp/org-element hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-element /home/thblt/.emacs.d/lib/org/lisp/org-version hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-version /home/thblt/.emacs.d/lib/org/lisp/ob-haskell hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-haskell /home/thblt/.emacs.d/lib/org/lisp/org-src hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-src /home/thblt/.emacs.d/lib/org/lisp/ob-lilypond hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-lilypond /home/thblt/.emacs.d/lib/org/lisp/ob-groovy hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-groovy /home/thblt/.emacs.d/lib/org/lisp/org-install hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-install /home/thblt/.emacs.d/lib/org/lisp/ob-table hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-table /home/thblt/.emacs.d/lib/org/lisp/ob-ledger hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-ledger /home/thblt/.emacs.d/lib/org/lisp/ob-plantuml hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-plantuml /home/thblt/.emacs.d/lib/org/lisp/ob-coq hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-coq /home/thblt/.emacs.d/lib/org/lisp/org-inlinetask hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-inlinetask /home/thblt/.emacs.d/lib/org/lisp/ox-beamer hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ox-beamer /home/thblt/.emacs.d/lib/org/lisp/org-macs hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-macs /home/thblt/.emacs.d/lib/org/lisp/org-entities hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-entities /home/thblt/.emacs.d/lib/org/lisp/ox-odt hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ox-odt /home/thblt/.emacs.d/lib/org/lisp/ob-lisp hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-lisp /home/thblt/.emacs.d/lib/org/lisp/ob-fortran hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-fortran /home/thblt/.emacs.d/lib/org/lisp/ob-forth hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-forth /home/thblt/.emacs.d/lib/org/lisp/ox-icalendar hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ox-icalendar /home/thblt/.emacs.d/lib/org/lisp/ob-comint hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-comint /home/thblt/.emacs.d/lib/org/lisp/ob-screen hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-screen /home/thblt/.emacs.d/lib/org/lisp/org-list hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-list /home/thblt/.emacs.d/lib/org/lisp/ob-shen hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-shen /home/thblt/.emacs.d/lib/org/lisp/org-mouse hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-mouse /home/thblt/.emacs.d/lib/org/lisp/ob-vala hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-vala /home/thblt/.emacs.d/lib/org/lisp/ob hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob /home/thblt/.emacs.d/lib/org/lisp/ob-sed hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-sed /home/thblt/.emacs.d/lib/org/lisp/ob-octave hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-octave /home/thblt/.emacs.d/lib/org/lisp/ox-org hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ox-org /home/thblt/.emacs.d/lib/org/lisp/org-ctags hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-ctags /home/thblt/.emacs.d/lib/org/lisp/org-macro hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-macro /home/thblt/.emacs.d/lib/org/lisp/ob-asymptote hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-asymptote /home/thblt/.emacs.d/lib/org/lisp/ob-latex hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-latex /home/thblt/.emacs.d/lib/org/lisp/ob-awk hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-awk /home/thblt/.emacs.d/lib/org/lisp/ox hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ox /home/thblt/.emacs.d/lib/org/lisp/ob-maxima hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-maxima /home/thblt/.emacs.d/lib/org/lisp/ob-makefile hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-makefile /home/thblt/.emacs.d/lib/org/lisp/org-agenda hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-agenda /home/thblt/.emacs.d/lib/org/lisp/org-clock hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/org-clock /home/thblt/.emacs.d/lib/org/lisp/ox-latex hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ox-latex /home/thblt/.emacs.d/lib/org/lisp/ob-sass hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-sass /home/thblt/.emacs.d/lib/org/lisp/ob-org hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-org /home/thblt/.emacs.d/lib/org/lisp/ob-R hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-R /home/thblt/.emacs.d/lib/org/lisp/ob-matlab hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-matlab /home/thblt/.emacs.d/lib/org/lisp/ox-man hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ox-man /home/thblt/.emacs.d/lib/org/lisp/ob-lob hides /nix/store/hb9lqgyxn4h731fp8xk0n99vv5b8kibn-emacs-26.2/share/emacs/26.2/lisp/org/ob-lob Features: (dabbrev windmove shadow sort ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnir ol-docview ol-bibtex bibtex ol-bbdb ol-w3m orgalist mail-extr emacsbug misearch multi-isearch two-column iso-transl cl-print eieio-opt help-fns mwim eziam-dark-theme network-stream nsm starttls erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete erc-track erc-match erc-netsplit znc warnings erc-hl-nicks erc-button erc-fill erc-stamp erc-goodies erc erc-backend erc-compat vc-git diff-mode aggressive-indent color-identifiers-mode smartparens-python python tramp-sh tramp tramp-compat tramp-loaddefs trampver ucs-normalize json map company-oddmuse company-keywords company-etags etags company-gtags company-dabbrev-code company-dabbrev company-files company-capf company-cmake company-xcode company-clang company-semantic company-eclim company-bbdb company-irony company-template irony-completion irony-snippet irony irony-iotask outshine outshine-org-cmds outorg rx pdf-occur tablist tablist-filter semantic/wisent/comp semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet pdf-isearch let-alist pdf-misc imenu pdf-tools package url-handlers cus-edit cus-start cus-load pdf-view bookmark pp pdf-cache pdf-info tq pdf-util auth-source-pass mu4e-contrib mu4e desktop frameset mu4e-speedbar speedbar sb-image ezimage dframe mu4e-main mu4e-view browse-url gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source tls gnutls utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus nnheader mu4e-headers mu4e-compose mu4e-context mu4e-draft mu4e-actions ido rfc2368 smtpmail sendmail mu4e-mark mu4e-message flow-fill mu4e-proc mu4e-utils doc-view image-mode mu4e-lists mu4e-vars message rmc puny rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader hl-line mu4e-meta magit-repos magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor async-bytecomp async magit-mode transient magit-git magit-section magit-utils crm rainbow-mode evil-nerd-commenter evil-nerd-commenter-sdk smartparens-html sgml-mode dom subr-x company-posframe company pcase ob-shell shell ob-dot ox-extra ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar ox-html table ox-ascii ox-publish ox org-element avl-tree generator smartparens-org org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs find-func cal-menu calendar cal-loaddefs tex-site auto-loads visual-fill-column super-save yasnippet-snippets yasnippet elec-pair undo-tree diff smartparens-config smartparens-text smartparens recentf tree-widget wid-edit nav-flash pulse beginend flyspell-correct-ivy flyspell-correct flyspell ispell hydra lv winner time-date which-key popwin ivy-posframe easy-mmode posframe eyebrowse format-spec dash general diminish counsel-projectile counsel xdg xref project dired dired-loaddefs swiper ivy delsel colir ivy-overlay ffap url-parse auth-source eieio eieio-core eieio-loaddefs password-cache url-vars projectile grep compile comint ansi-color ring ibuf-ext ibuffer ibuffer-loaddefs thingatpt server powerline powerline-separators color powerline-themes kurecolor cl-macs s cl eziam-light-theme eziam-common advice edmacro kmacro jka-compr no-littering auto-compile packed org-loaddefs cl-extra help-mode cl-seq borg info easymenu autoload radix-tree lisp-mnt seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 742385 50609) (symbols 48 60828 45) (miscs 40 1271 1467) (strings 32 238679 4144) (string-bytes 1 6957697) (vectors 16 102684) (vector-slots 8 2239185 213522) (floats 8 742 1110) (intervals 56 9385 3740) (buffers 992 31)) From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 16 12:31:38 2019 Received: (at control) by debbugs.gnu.org; 16 Aug 2019 16:31:38 +0000 Received: from localhost ([127.0.0.1]:54797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyf8c-0007n5-15 for submit@debbugs.gnu.org; Fri, 16 Aug 2019 12:31:38 -0400 Received: from mail-io1-f52.google.com ([209.85.166.52]:42678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyf8b-0007hj-2t for control@debbugs.gnu.org; Fri, 16 Aug 2019 12:31:37 -0400 Received: by mail-io1-f52.google.com with SMTP id e20so7351217iob.9 for ; Fri, 16 Aug 2019 09:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=R8VrKmKez6y36hrC4yvtYkK+3eOg6a5/U4jdrSyvNTs=; b=gz/tJ35NfFhSSirt1+AevR92YRxo5ulc/AfDCgLGjFJqWsbGao0wTAIHomitWDQ88q DZJnTKqVIB7kkKSbNnUeP7qyj0Tps9lERxiABnPHlD4ecD2im2quvGSlIa4JHEpuBUkE L7TLWUCN+4NbBvAgxBa3kLnmNb3NUYbRTyhRlf+SPX4cLbAnnUoPP5zfdPLqMu9ppwMX XGutcxFehW1cgluEpooNXWcGGqvezC5E4vKDLGAnvtZPpIVCn8RGqHtYBKzeEUAx0hJU wbJ/7dlmKv1BCa7SDMB++1kl1VWJnSCoyBcaMkqVFbfG1Xt1TSJJJ15kRZRGY89vlhXJ ZKgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=R8VrKmKez6y36hrC4yvtYkK+3eOg6a5/U4jdrSyvNTs=; b=n21G4VjPguv8YWStOuT6jzF8xsYRJ/YOyq0XS0OtiqGlHpX+qphEdPeXDq33rGWCdt wfrREweMIhW7/yCnYAfSuFEqNl9+ctGyWuV8aKHzq1vZUk9oQ+Px64q/IMZ6lxGY8EZ+ Yvlmm7eC9Bu2VvFZMUtQUNPWps/VlHHTLDoF5f4Y9caPsAXK1hzCrfhep1FES8NXAEC4 1R541hyQHM6YAeWUTA3KrxZEswINULNFL1+mXmQkmPvchcrEdjb2rf2DiBvfJtYerJ/b pOpKH0bjzyaPoOKtXIux/VZgQrnR6/C/pQVcGnS82lFH3ipx6pqRVfRaS20SKtauyOCA WXyg== X-Gm-Message-State: APjAAAUhMTbC34O9J3hgMmSLboDd039fqRdPzmvRTvILyfkXq7+uHfjI M+qD9Oeojyg8zaALt1XZE3U4VwvB X-Google-Smtp-Source: APXvYqwnKCiAuKpJhsR/GNcDNFHcsZOFYlTdc6LFRLeJZHvreb4kD60OAWLIvg6Put2I2vpzZ9tzKQ== X-Received: by 2002:a02:ba91:: with SMTP id g17mr11608986jao.11.1565973091313; Fri, 16 Aug 2019 09:31:31 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id v10sm7569948iob.43.2019.08.16.09.31.30 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Aug 2019 09:31:30 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #36843 Date: Fri, 16 Aug 2019 12:31:29 -0400 Message-ID: <851rxlkr6m.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) found 36843 24.4 quit Introduced in: [1: d0fcaff]: 2013-08-22 00:06:45 -0400 * lisp/erc/erc.el: Use lexical-binding. https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0fcaff514d2be16ccf73817f658318cf85221e3 From unknown Mon Jun 23 18:33:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36843: 26.2; ERC lurker feature broken In-Reply-To: <877e80o5tb.fsf@thb.lt> Resent-From: Amin Bandali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Aug 2019 18:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Thibault Polge Cc: 36843@debbugs.gnu.org Received: via spool by 36843-submit@debbugs.gnu.org id=B36843.156606690213690 (code B ref 36843); Sat, 17 Aug 2019 18:35:02 +0000 Received: (at 36843) by debbugs.gnu.org; 17 Aug 2019 18:35:02 +0000 Received: from localhost ([127.0.0.1]:56857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hz3XZ-0003Yd-In for submit@debbugs.gnu.org; Sat, 17 Aug 2019 14:35:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hz3XY-0003YM-6z for 36843@debbugs.gnu.org; Sat, 17 Aug 2019 14:35:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hz3XS-0002MX-FX; Sat, 17 Aug 2019 14:34:54 -0400 Received: from [2607:fea8:3b80:184:757c:ddb:c40:3329] (port=39682 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hz3XS-0005CX-5p; Sat, 17 Aug 2019 14:34:54 -0400 From: Amin Bandali References: <877e80o5tb.fsf@thb.lt> Date: Sat, 17 Aug 2019 14:34:52 -0400 Message-ID: <87v9uvmyib.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Below is a patch that seems to fix this. I haven=E2=80=99t tested the actu= al patch but I=E2=80=99ve added its changed to my init file (adding the new de= fvar, and redefining erc-display-message and erc-lurker-update-status) for the last couple of days, and it seems to work as intended. Thanks to Noam for helping me with this over on #emacs. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-erc-lurker-update-status.patch >From 389654f5c7a9ad0975bff84a163ed6234cdb3cb8 Mon Sep 17 00:00:00 2001 From: Amin Bandali Date: Sat, 17 Aug 2019 14:09:11 -0400 Subject: [PATCH] Fix erc-lurker-update-status Fix erc-lurker-update-status (bug#36843), broken since d0fcaff514d2be16ccf73817f658318cf85221e3. * lisp/erc/erc.el: define `erc-message-parsed', lexically bind it in `erc-display-message', and change `erc-lurker-update-status' to use that instead of using `parsed' directly. This results in `erc-lurker-state' being properly updated to keep track of non-lurkers, and thus `erc-lurker-p' returning correct results rather than return t for everyone. --- lisp/erc/erc.el | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index f5c9decc3a..9ea9e608ac 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -2594,6 +2594,8 @@ erc-lurker-cleanup-interval consumption of lurker state during long Emacs sessions and/or ERC sessions with large numbers of incoming PRIVMSGs.") +(defvar erc-message-parsed) + (defun erc-lurker-update-status (_message) "Update `erc-lurker-state' if necessary. @@ -2603,18 +2605,20 @@ erc-lurker-update-status current time. Otherwise, take no action. This function depends on the fact that `erc-display-message' -dynamically binds `parsed', which is used to check if the current -message is a PRIVMSG and to determine its sender. See also -`erc-lurker-trim-nicks' and `erc-lurker-ignore-chars'. +dynamically binds `erc-message-parsed', which is used to check if +the current message is a PRIVMSG and to determine its sender. +See also `erc-lurker-trim-nicks' and `erc-lurker-ignore-chars'. In order to limit memory consumption, this function also calls `erc-lurker-cleanup' once every `erc-lurker-cleanup-interval' updates of `erc-lurker-state'." - (when (and (boundp 'parsed) (erc-response-p parsed)) - (let* ((command (erc-response.command parsed)) + (when (and (boundp 'erc-message-parsed) + (erc-response-p erc-message-parsed)) + (let* ((command (erc-response.command erc-message-parsed)) (sender (erc-lurker-maybe-trim - (car (erc-parse-user (erc-response.sender parsed))))) + (car (erc-parse-user + (erc-response.sender erc-message-parsed))))) (server (erc-canonicalize-server-name erc-server-announced-name))) (when (equal command "PRIVMSG") @@ -2704,7 +2708,8 @@ erc-display-message See also `erc-format-message' and `erc-display-line'." (let ((string (if (symbolp msg) (apply #'erc-format-message msg args) - msg))) + msg)) + (erc-message-parsed parsed)) (setq string (cond ((null type) -- 2.22.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 10:22:14 2019 Received: (at control) by debbugs.gnu.org; 18 Aug 2019 14:22:14 +0000 Received: from localhost ([127.0.0.1]:58328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzM4T-0003EX-L7 for submit@debbugs.gnu.org; Sun, 18 Aug 2019 10:22:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzM4S-0003EJ-VG for control@debbugs.gnu.org; Sun, 18 Aug 2019 10:22:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hzM4N-0002bf-S9 for control@debbugs.gnu.org; Sun, 18 Aug 2019 10:22:07 -0400 Received: from [2607:fea8:3b80:184:1d66:abc7:302f:21d6] (port=55470 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hzM4N-0001CH-IE for control@debbugs.gnu.org; Sun, 18 Aug 2019 10:22:07 -0400 From: Amin Bandali To: control@debbugs.gnu.org Subject: add patch tag for bug#36843 Date: Sun, 18 Aug 2019 10:22:05 -0400 Message-ID: <87zhk6wo36.fsf@fencepost.gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 36843 patch thanks From unknown Mon Jun 23 18:33:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36843: 26.2; ERC lurker feature broken Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Aug 2019 19:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Amin Bandali Cc: Thibault Polge , 36843@debbugs.gnu.org Received: via spool by 36843-submit@debbugs.gnu.org id=B36843.15661562002691 (code B ref 36843); Sun, 18 Aug 2019 19:24:01 +0000 Received: (at 36843) by debbugs.gnu.org; 18 Aug 2019 19:23:20 +0000 Received: from localhost ([127.0.0.1]:58677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzQlp-0000hJ-BQ for submit@debbugs.gnu.org; Sun, 18 Aug 2019 15:23:20 -0400 Received: from mail-oi1-f181.google.com ([209.85.167.181]:37348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzQln-0000h7-OA for 36843@debbugs.gnu.org; Sun, 18 Aug 2019 15:23:16 -0400 Received: by mail-oi1-f181.google.com with SMTP id b25so4257429oib.4 for <36843@debbugs.gnu.org>; Sun, 18 Aug 2019 12:23:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=1wowHjMlaOg5WvSNfPxV6GDYydI/vBNzFgY/COwjPBI=; b=DLp5gjAFFEwgl8juRUHk+wd4IB7REdNERZZIrKY0q4mTczO4IQu9lbkOD1sQgmDmMF CrcWaF3xh6PC9kmwYimhuGCFlsVICSKaxviFuWbgLHNVdotB0p1F67s33BDOzxDz2TSS YtSBdnbRQvPagPEGTTG2ZqEjs6UW66vs+23fthjycIovYlAwakKix1o6xmwNruoW5tcl gUz97uGdvpt+CExk2AcB+nFY5VFo3O0xfjFEfZQdCF8r8yWny1zNCGnL/ygVQR94BgZ5 I0I+GZVohsM8bWiNW+wduUcjdphV5kAdGUNXXyqKG4csbbCw9LDBGbA7vcevW81E0+qB qQbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=1wowHjMlaOg5WvSNfPxV6GDYydI/vBNzFgY/COwjPBI=; b=p6am6BZsD/PJ4NvZ1+U6VhI9ap7PngcBkImOu9qHUQkuVwWDHndSjKqCkpE0bSvFGI gQfflJO39Mz8xuQHHJi86nm5UAR6neVi09g/4yNJbVUa/Pkj/tlKVOkfpCoEni0XjsYt RVDSCRQ63zmIIUecPkAIfAf+/sLqR7Uba+bsWhNfBISpYcO19q/rMsqMNDwX/VM3dLnS N8vvfNJNvNIbLjZWWSDff/AQefbz0c8QTh6Reg1aF4HhA3OzNY6DTlRM2TzymAFKjiqb Ll0/Xee6OlY8kS+tkkDtZYS0KqKmsKVv7D4IcFTm2otVCucC1dtnjQyueeidXyn9Wb/5 tdMA== X-Gm-Message-State: APjAAAWCyC7tFgCQ2ZeuyETRo+lSGS4EmzyzKP+q51GsCnN3N9KdRHGy ack6jF9QUYhXrYdF6ybyCTRbGMlm X-Google-Smtp-Source: APXvYqxC+zOEcMm3BZx7EvFZYtQcyKmBsIfnQ7K9LsJmx/OKPHA1RAtMc85QLzicNLocPrt8J7WDbQ== X-Received: by 2002:aca:5e06:: with SMTP id s6mr11503241oib.171.1566156189782; Sun, 18 Aug 2019 12:23:09 -0700 (PDT) Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id q5sm3512320oih.2.2019.08.18.12.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Aug 2019 12:23:08 -0700 (PDT) From: Alex Branham References: <877e80o5tb.fsf@thb.lt> <87v9uvmyib.fsf@gnu.org> Date: Sun, 18 Aug 2019 14:23:07 -0500 In-Reply-To: <87v9uvmyib.fsf@gnu.org> (Amin Bandali's message of "Sat, 17 Aug 2019 14:34:52 -0400") Message-ID: <87zhk6nuqs.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat 17 Aug 2019 at 14:34, Amin Bandali wrote: > Below is a patch that seems to fix this. I haven=E2=80=99t tested the ac= tual > patch but I=E2=80=99ve added its changed to my init file (adding the new = defvar, > and redefining erc-display-message and erc-lurker-update-status) for the > last couple of days, and it seems to work as intended. > > Thanks to Noam for helping me with this over on #emacs. I've tested this locally lightly. It fixes the issue and seems to work well. Thanks, Alex From unknown Mon Jun 23 18:33:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36843: 26.2; ERC lurker feature broken Resent-From: Thibault Polge Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Aug 2019 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 36843@debbugs.gnu.org Received: via spool by 36843-submit@debbugs.gnu.org id=B36843.15664928746776 (code B ref 36843); Thu, 22 Aug 2019 16:55:01 +0000 Received: (at 36843) by debbugs.gnu.org; 22 Aug 2019 16:54:34 +0000 Received: from localhost ([127.0.0.1]:38279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0qM6-0001lD-3Z for submit@debbugs.gnu.org; Thu, 22 Aug 2019 12:54:34 -0400 Received: from 8.mo177.mail-out.ovh.net ([46.105.61.98]:33886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0qM4-0001l3-9j for 36843@debbugs.gnu.org; Thu, 22 Aug 2019 12:54:33 -0400 Received: from player762.ha.ovh.net (unknown [10.109.146.82]) by mo177.mail-out.ovh.net (Postfix) with ESMTP id A3D76108E70 for <36843@debbugs.gnu.org>; Thu, 22 Aug 2019 18:54:30 +0200 (CEST) Received: from thb.lt (85-170-54-226.rev.numericable.fr [85.170.54.226]) (Authenticated sender: thibault@thb.lt) by player762.ha.ovh.net (Postfix) with ESMTPSA id E9D7690C6C7A for <36843@debbugs.gnu.org>; Thu, 22 Aug 2019 16:54:29 +0000 (UTC) References: <877e80o5tb.fsf@thb.lt> <87v9uvmyib.fsf@gnu.org> <87zhk6nuqs.fsf@gmail.com> User-agent: mu4e 1.3.2; emacs 27.0.50 From: Thibault Polge Message-ID: <87mug1nnzi.fsf@thb.lt> In-reply-to: <87zhk6nuqs.fsf@gmail.com> Date: Thu, 22 Aug 2019 18:54:28 +0200 MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 14467250854245681490 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrudegiedgieefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenuc X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I'm running emacs-26.1-7008-ge5defc3e0f compiled with Amin's patch applied, and everything seems to work well. Thanks! Thibault From unknown Mon Jun 23 18:33:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36843: 26.2; ERC lurker feature broken Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Aug 2019 16:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Amin Bandali Cc: Thibault Polge , 36843@debbugs.gnu.org Received: via spool by 36843-submit@debbugs.gnu.org id=B36843.156666512831019 (code B ref 36843); Sat, 24 Aug 2019 16:46:01 +0000 Received: (at 36843) by debbugs.gnu.org; 24 Aug 2019 16:45:28 +0000 Received: from localhost ([127.0.0.1]:43244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1ZAO-00084F-BG for submit@debbugs.gnu.org; Sat, 24 Aug 2019 12:45:28 -0400 Received: from mail-io1-f41.google.com ([209.85.166.41]:40646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1ZAM-00083t-3k for 36843@debbugs.gnu.org; Sat, 24 Aug 2019 12:45:26 -0400 Received: by mail-io1-f41.google.com with SMTP id t6so27444410ios.7 for <36843@debbugs.gnu.org>; Sat, 24 Aug 2019 09:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2JmCrnr5rbMcUq+X46K/L1wqEtmUkAA15wjuZzqznm4=; b=hYsQL6i3vvO4jO7JzFDCUVu7Knrbq1/mSSzIis5hXae8iT6aSus3gSpm9C9/0DEY4k za+oI2jCNMzA+saE7B89DJt24oGAWTB97NdJqAUmB1OnvqUWhwHmPYmtXpZe/n7eiYzL 2Q2W0+AWRD9rPiKU/5jHxYkDnytQFLf63vQ+11AaGgqBOe76CRSogp7vi+8zUDG9cybX W0vL4zDb2XaCZRm+rOBOMiSZ3EkOkneLhzx+cuS4WqmNHJdS/2N4xB/p86rt8jJ3joLY RdScqtVOSOu3SsVxYJQJ5IsyHI5cXzb1F/b+15rhfLjEq9w8FLmLrX6shSUWJd+P6itF 9OFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=2JmCrnr5rbMcUq+X46K/L1wqEtmUkAA15wjuZzqznm4=; b=V9SIBH6K/r0Kt5pAcjk1Qs3XyY+2ziNhLsKBTih6pqybdG54+TE6venNbBOstESwAd Vu2goeFdm903xXUavAimx+ETu+VUyreduFVgK7PmE0rHU5Rk4UtFu4Ex+2ONbd3De9pC 472+ccsaH45GxN3v0TX3AJHH5tYTiJRgGPztR1kmwiIuQFnuNkpoX27Qld3SiMTE8FvY 5/dintTnARaE8YcEMKwfAu9aOl5JVO78Whex8hs8MLQrAPDXHrXITGqMAveBF2SUfooD hS5mzUvTRd80MmVTunu+zx8FjkSOPKX2/IHVJJdZpKWJrdXycP8es0dcw2os3w/sh8AP ms8g== X-Gm-Message-State: APjAAAUCMvJm3tnDNZxl1DchgClN4lENb85iSNrR8Ix2DPcEPMQ8KumG cZO4/W3Zpe02eNb2pey0xV7Z/1cL X-Google-Smtp-Source: APXvYqzn/kgb9XSBRAE7LbW4U0yhieKWU9tCygf+CGLDgpOkH/PgInIk4MaOWzxVepxU42fHeQVtxQ== X-Received: by 2002:a02:810:: with SMTP id 16mr10492526jac.121.1566665120139; Sat, 24 Aug 2019 09:45:20 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id c3sm10684997iot.42.2019.08.24.09.45.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 24 Aug 2019 09:45:19 -0700 (PDT) From: Noam Postavsky References: <877e80o5tb.fsf@thb.lt> <87v9uvmyib.fsf@gnu.org> Date: Sat, 24 Aug 2019 12:45:19 -0400 In-Reply-To: <87v9uvmyib.fsf@gnu.org> (Amin Bandali's message of "Sat, 17 Aug 2019 14:34:52 -0400") Message-ID: <871rxao6lc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Amin Bandali writes: > From: Amin Bandali This address seems to be different than what's in the copyright list. Could you use that one, since otherwise it's a bit confusing as to whether I'm actually looking at the entry of the right person. > Date: Sat, 17 Aug 2019 14:09:11 -0400 > Subject: [PATCH] Fix erc-lurker-update-status > > Fix erc-lurker-update-status (bug#36843), broken since > d0fcaff514d2be16ccf73817f658318cf85221e3. > > * lisp/erc/erc.el: define `erc-message-parsed', lexically bind it in Instead of "lexically" I believe you actually mean "dynamically" (binding lexically is the cause of the bug). And I would reformat like this: Fix erc-lurker-update-status (bug#36843) Broken since 2013-08-22 "* lisp/erc/erc.el: Use lexical-binding". * lisp/erc/erc.el (erc-message-parsed): New variable. (erc-display-message): Dynamically bind it. (erc-lurker-update-status): Check it instead of using `parsed' directly. This results in `erc-lurker-state' being properly updated to keep track of non-lurkers, and thus `erc-lurker-p' returning correct results rather than return t for everyone. From unknown Mon Jun 23 18:33:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36843: 26.2; ERC lurker feature broken Resent-From: Amin Bandali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Aug 2019 14:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: Thibault Polge , 36843@debbugs.gnu.org Received: via spool by 36843-submit@debbugs.gnu.org id=B36843.156691627525389 (code B ref 36843); Tue, 27 Aug 2019 14:32:02 +0000 Received: (at 36843) by debbugs.gnu.org; 27 Aug 2019 14:31:15 +0000 Received: from localhost ([127.0.0.1]:49246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2cV9-0006bR-8E for submit@debbugs.gnu.org; Tue, 27 Aug 2019 10:31:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2cV7-0006bD-CA for 36843@debbugs.gnu.org; Tue, 27 Aug 2019 10:31:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i2cUw-0001bn-Jm; Tue, 27 Aug 2019 10:31:03 -0400 Received: from [2607:fea8:3b80:184:5488:d652:cee4:415c] (port=32988 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i2cUw-0004TT-8N; Tue, 27 Aug 2019 10:31:02 -0400 From: Amin Bandali References: <877e80o5tb.fsf@thb.lt> <87v9uvmyib.fsf@gnu.org> <871rxao6lc.fsf@gmail.com> Date: Tue, 27 Aug 2019 10:31:00 -0400 In-Reply-To: <871rxao6lc.fsf@gmail.com> Message-ID: <877e6y7k9n.fsf@fencepost.gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Noam Postavsky writes: > Amin Bandali writes: > >> From: Amin Bandali > > This address seems to be different than what's in the copyright list. > Could you use that one, since otherwise it's a bit confusing as to > whether I'm actually looking at the entry of the right person. > Thanks for bringing this to my attention. I=E2=80=99d changed my email bac= k in December 2018 and had notified the copyright clerk about it, but it seems that their change hadn=E2=80=99t properly propagated to copyright.lis= t. It should be there now. > >> Date: Sat, 17 Aug 2019 14:09:11 -0400 >> Subject: [PATCH] Fix erc-lurker-update-status >> >> Fix erc-lurker-update-status (bug#36843), broken since >> d0fcaff514d2be16ccf73817f658318cf85221e3. >> >> * lisp/erc/erc.el: define `erc-message-parsed', lexically bind it in > > Instead of "lexically" I believe you actually mean "dynamically" > (binding lexically is the cause of the bug). And I would reformat like > this: > Good catch! I rebased on latest master and reformatted per your suggestion. I=E2=80=99ve attached an updated patch below. Thanks for your feedback. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-erc-lurker-update-status-bug-36843.patch >From 2bc8f35e4a0f76e7b59950738fbfdc3c3e48263c Mon Sep 17 00:00:00 2001 From: Amin Bandali Date: Sat, 17 Aug 2019 14:09:11 -0400 Subject: [PATCH] Fix erc-lurker-update-status (bug#36843) Broken since 2013-08-22 "* lisp/erc/erc.el: Use lexical-binding". * lisp/erc/erc.el (erc-message-parsed): New variable. (erc-display-message): Dynamically bind it. (erc-lurker-update-status): Check it instead of using `parsed' directly. This results in `erc-lurker-state' being properly updated to keep track of non-lurkers, and thus `erc-lurker-p' returning correct results rather than return t for everyone. --- lisp/erc/erc.el | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index f5c9decc3a..9ea9e608ac 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -2594,6 +2594,8 @@ erc-lurker-cleanup-interval consumption of lurker state during long Emacs sessions and/or ERC sessions with large numbers of incoming PRIVMSGs.") +(defvar erc-message-parsed) + (defun erc-lurker-update-status (_message) "Update `erc-lurker-state' if necessary. @@ -2603,18 +2605,20 @@ erc-lurker-update-status current time. Otherwise, take no action. This function depends on the fact that `erc-display-message' -dynamically binds `parsed', which is used to check if the current -message is a PRIVMSG and to determine its sender. See also -`erc-lurker-trim-nicks' and `erc-lurker-ignore-chars'. +dynamically binds `erc-message-parsed', which is used to check if +the current message is a PRIVMSG and to determine its sender. +See also `erc-lurker-trim-nicks' and `erc-lurker-ignore-chars'. In order to limit memory consumption, this function also calls `erc-lurker-cleanup' once every `erc-lurker-cleanup-interval' updates of `erc-lurker-state'." - (when (and (boundp 'parsed) (erc-response-p parsed)) - (let* ((command (erc-response.command parsed)) + (when (and (boundp 'erc-message-parsed) + (erc-response-p erc-message-parsed)) + (let* ((command (erc-response.command erc-message-parsed)) (sender (erc-lurker-maybe-trim - (car (erc-parse-user (erc-response.sender parsed))))) + (car (erc-parse-user + (erc-response.sender erc-message-parsed))))) (server (erc-canonicalize-server-name erc-server-announced-name))) (when (equal command "PRIVMSG") @@ -2704,7 +2708,8 @@ erc-display-message See also `erc-format-message' and `erc-display-line'." (let ((string (if (symbolp msg) (apply #'erc-format-message msg args) - msg))) + msg)) + (erc-message-parsed parsed)) (setq string (cond ((null type) -- 2.23.0 --=-=-=-- From unknown Mon Jun 23 18:33:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36843: 26.2; ERC lurker feature broken Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Sep 2019 14:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Amin Bandali Cc: Thibault Polge , Noam Postavsky , 36843@debbugs.gnu.org Received: via spool by 36843-submit@debbugs.gnu.org id=B36843.15676059224013 (code B ref 36843); Wed, 04 Sep 2019 14:06:01 +0000 Received: (at 36843) by debbugs.gnu.org; 4 Sep 2019 14:05:22 +0000 Received: from localhost ([127.0.0.1]:34053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i5VuU-00012e-74 for submit@debbugs.gnu.org; Wed, 04 Sep 2019 10:05:22 -0400 Received: from mail-oi1-f172.google.com ([209.85.167.172]:36731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i5VuS-00012R-4M for 36843@debbugs.gnu.org; Wed, 04 Sep 2019 10:05:20 -0400 Received: by mail-oi1-f172.google.com with SMTP id k20so9482357oih.3 for <36843@debbugs.gnu.org>; Wed, 04 Sep 2019 07:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=v5c8T93UttRd1+PoWvQdATioMOLnhFm/VQ+gDENH58g=; b=QpxiyrGp1vadtzAtOZfAp3j+46MdJ3DaUnwkywDmntRhogd9+qXi+soWSr3iNrFpWO BxCGSYiV6FmS74BgjRQjkBXYZzfH3wTHc35HaNNFdWSRySxfnMQga82VQV0qXdyhDmHE B6c0GeCwtGCNtiwnwqc7K5Kokpn8Ao3MdQRqCjEwc7nUnXCC+FLvCGUaEjljLcKb9w6W ZJK0bKnBgOoy4pFPU2sZ3Y8t0EWqhZLvuTSuWbG/qFqFjC4mIwWQGLuQXIQtUyWd+TUo YwxOf3Ahu4K51LifY1l71dPoZYrTvIls3culjSnRxkGMO7IltF0fySmd3rjzUUpcF9A9 9J9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=v5c8T93UttRd1+PoWvQdATioMOLnhFm/VQ+gDENH58g=; b=el6iWTC4cz/r/ewz+NPx7DfM/WhBr2UGBanbFDlKCtf5cfqvlOUs/4HIStNCvvuHm9 6M5D/r3w+tvcUUvEu1ETG795dfLheDt+D+giyNAIX5M0mx98C/c2u6ni72gBeEs3XyJm nEytqkFryvCcCKGpUSg+MNNhgw7qovAh6Tg9+QQrhv4zDjlWl6pgIAFxyEgEok6aV0lY /807fEJEsPfcEe+UsS88DBVaf0nc+yw6O5oJhxUiaa464G0Pj6EGIHRXtSb0vmAruFjV Phyi4lk/vPkNkWxM7KFEbuM0PkwE4GU8TQ/dmaLOOnO2R5MEAjtDc/7gGnleu+PrvhY3 qfrA== X-Gm-Message-State: APjAAAUqEEHbj1ntLlx2C+scJR2EFI/0uIU0THw1FvhXlakAi0r7TuQ/ wkWZ2qmBKp2gmsf/3xFvUnOYl6sb X-Google-Smtp-Source: APXvYqybafEplhGErniWlAcmc0m7hpFd1i3HEkb9dJ0WrzsPj7A/kTt4ZfNcVvDIG1cDACYAMBE7dQ== X-Received: by 2002:aca:911:: with SMTP id 17mr3164836oij.149.1567605914177; Wed, 04 Sep 2019 07:05:14 -0700 (PDT) Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id f84sm5955515oig.43.2019.09.04.07.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2019 07:05:13 -0700 (PDT) From: Alex Branham References: <877e80o5tb.fsf@thb.lt> <87v9uvmyib.fsf@gnu.org> <871rxao6lc.fsf@gmail.com> <877e6y7k9n.fsf@fencepost.gnu.org> Date: Wed, 04 Sep 2019 09:05:12 -0500 In-Reply-To: <877e6y7k9n.fsf@fencepost.gnu.org> (Amin Bandali's message of "Tue, 27 Aug 2019 10:31:00 -0400") Message-ID: <87ef0wdunb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue 27 Aug 2019 at 10:31, Amin Bandali wrote: Is this OK to apply to master? I've been using it locally and seems to work well. >>> Date: Sat, 17 Aug 2019 14:09:11 -0400 >>> Subject: [PATCH] Fix erc-lurker-update-status >>> >>> Fix erc-lurker-update-status (bug#36843), broken since >>> d0fcaff514d2be16ccf73817f658318cf85221e3. >>> >>> * lisp/erc/erc.el: define `erc-message-parsed', lexically bind it in >> >> Instead of "lexically" I believe you actually mean "dynamically" >> (binding lexically is the cause of the bug). And I would reformat like >> this: >> > > Good catch! I rebased on latest master and reformatted per your > suggestion. I=E2=80=99ve attached an updated patch below. > > Thanks for your feedback. > >>>From 2bc8f35e4a0f76e7b59950738fbfdc3c3e48263c Mon Sep 17 00:00:00 2001 > From: Amin Bandali > Date: Sat, 17 Aug 2019 14:09:11 -0400 > Subject: [PATCH] Fix erc-lurker-update-status (bug#36843) > > Broken since 2013-08-22 "* lisp/erc/erc.el: Use lexical-binding". > > * lisp/erc/erc.el (erc-message-parsed): New variable. > (erc-display-message): Dynamically bind it. > (erc-lurker-update-status): Check it instead of using `parsed' > directly. This results in `erc-lurker-state' being properly updated > to keep track of non-lurkers, and thus `erc-lurker-p' returning > correct results rather than return t for everyone. > --- > lisp/erc/erc.el | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el > index f5c9decc3a..9ea9e608ac 100644 > --- a/lisp/erc/erc.el > +++ b/lisp/erc/erc.el > @@ -2594,6 +2594,8 @@ erc-lurker-cleanup-interval > consumption of lurker state during long Emacs sessions and/or ERC > sessions with large numbers of incoming PRIVMSGs.") >=20=20 > +(defvar erc-message-parsed) > + > (defun erc-lurker-update-status (_message) > "Update `erc-lurker-state' if necessary. >=20=20 > @@ -2603,18 +2605,20 @@ erc-lurker-update-status > current time. Otherwise, take no action. >=20=20 > This function depends on the fact that `erc-display-message' > -dynamically binds `parsed', which is used to check if the current > -message is a PRIVMSG and to determine its sender. See also > -`erc-lurker-trim-nicks' and `erc-lurker-ignore-chars'. > +dynamically binds `erc-message-parsed', which is used to check if > +the current message is a PRIVMSG and to determine its sender. > +See also `erc-lurker-trim-nicks' and `erc-lurker-ignore-chars'. >=20=20 > In order to limit memory consumption, this function also calls > `erc-lurker-cleanup' once every `erc-lurker-cleanup-interval' > updates of `erc-lurker-state'." > - (when (and (boundp 'parsed) (erc-response-p parsed)) > - (let* ((command (erc-response.command parsed)) > + (when (and (boundp 'erc-message-parsed) > + (erc-response-p erc-message-parsed)) > + (let* ((command (erc-response.command erc-message-parsed)) > (sender > (erc-lurker-maybe-trim > - (car (erc-parse-user (erc-response.sender parsed))))) > + (car (erc-parse-user > + (erc-response.sender erc-message-parsed))))) > (server > (erc-canonicalize-server-name erc-server-announced-name))) > (when (equal command "PRIVMSG") > @@ -2704,7 +2708,8 @@ erc-display-message > See also `erc-format-message' and `erc-display-line'." > (let ((string (if (symbolp msg) > (apply #'erc-format-message msg args) > - msg))) > + msg)) > + (erc-message-parsed parsed)) > (setq string > (cond > ((null type) From unknown Mon Jun 23 18:33:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#36843: 26.2; ERC lurker feature broken Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Sep 2019 23:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Amin Bandali Cc: Thibault Polge , 36843@debbugs.gnu.org Received: via spool by 36843-submit@debbugs.gnu.org id=B36843.156772787524476 (code B ref 36843); Thu, 05 Sep 2019 23:58:01 +0000 Received: (at 36843) by debbugs.gnu.org; 5 Sep 2019 23:57:55 +0000 Received: from localhost ([127.0.0.1]:36240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i61dS-0006Md-Rz for submit@debbugs.gnu.org; Thu, 05 Sep 2019 19:57:55 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:36381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i61dQ-0006ME-UE; Thu, 05 Sep 2019 19:57:53 -0400 Received: by mail-io1-f68.google.com with SMTP id b136so8806086iof.3; Thu, 05 Sep 2019 16:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GahStc4EaFYfWkeso47uLq3ZHKIbKSb2Uk4/mwxOeR4=; b=E9jJxsBJ3oImEjutPXVnqQN5zz/FJ8yEPNj8f29nIVzyPJ+kTF+7FY1oRWsLA7a8L+ rrvBU+CcMi4AD7gXOnjanxwHqlY3fUM/Egk96wZ98GKwgmVzeoWOa8RL3XYfrgDKic60 9EcNBOexAFVBcmfxxEahg+0SFZPqLB2yxwrgMTIw6jf6EKcF2GjcpHpnf3sp8IkOAZ89 0oFdJV8Qn65BU8iiIgXNpLyNb8ZGRezcAAInpc4KyXgN50RvQ+fMQdXh2KNbzolPutWk M38GrJvoIUS/UhYo6W1SM3PVMK4jswUwBkG05RIU/DTeGmC9+pkHD+KVW4qV6aDAuwnZ 7WOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=GahStc4EaFYfWkeso47uLq3ZHKIbKSb2Uk4/mwxOeR4=; b=VB0WismxcSc5Pc6Gg+m5puzTfCRFLCIK2cMMH4C1thhTMXp6QAa8KdxX6CQkCSN9jN xFGIpNoLW0/SXCFkBxtYFDhGx8nbDo8ZiHEhUlCAMmvJrM/HVoYev2/NamAwwpaiI1PE p9IwZGftR5zWbdLbFzRm/muNNBqQJChyoNwL8BgHszXcyjQQue6/9utcQCAMOMvSqqGj r4gbFIIwrc6w9PgJSug78VqbQF6igKePUICeyDceJNQiCUXhAWZ+AURdII3+SeI/37YY GZkVg5JWI31LizH1jsiZicBEUWj3QLE2TokLtm9odWghbA5sVgYjLI8ULqVN0PxCjA6i WdxA== X-Gm-Message-State: APjAAAWK/o3laepmCJ7icjsfQt7qZPyYRSxgEzHnjZUuLhxbKsr5TSlC UKyI3sHT4UWYLlQgL2owfo8l7fBr X-Google-Smtp-Source: APXvYqwxYQjlRs0fy4utO9G6eDq/p3iwefINmJfnTK2b6g1vAJikhaQ7efIbBM0CGCGjgT6y4T5NFg== X-Received: by 2002:a5d:9403:: with SMTP id v3mr6927445ion.281.1567727867135; Thu, 05 Sep 2019 16:57:47 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id u6sm1875273iop.18.2019.09.05.16.57.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Sep 2019 16:57:46 -0700 (PDT) From: Noam Postavsky References: <877e80o5tb.fsf@thb.lt> <87v9uvmyib.fsf@gnu.org> <871rxao6lc.fsf@gmail.com> <877e6y7k9n.fsf@fencepost.gnu.org> Date: Thu, 05 Sep 2019 19:57:45 -0400 In-Reply-To: <877e6y7k9n.fsf@fencepost.gnu.org> (Amin Bandali's message of "Tue, 27 Aug 2019 10:31:00 -0400") Message-ID: <87blvymh3a.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 36843 fixed close 36843 27.1 quit Amin Bandali writes: > Subject: [PATCH] Fix erc-lurker-update-status (bug#36843) > > Broken since 2013-08-22 "* lisp/erc/erc.el: Use lexical-binding". > > * lisp/erc/erc.el (erc-message-parsed): New variable. > (erc-display-message): Dynamically bind it. > (erc-lurker-update-status): Check it instead of using `parsed' > directly. This results in `erc-lurker-state' being properly updated > to keep track of non-lurkers, and thus `erc-lurker-p' returning > correct results rather than return t for everyone. Pushed to master. ff0f4c7312 2019-09-05T19:56:14-04:00 "Fix erc-lurker-update-status (bug#36843)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ff0f4c731231b03d73cc35de9e042d1fc1b75f4e