From unknown Sat Sep 20 08:01:31 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36803 <36803@debbugs.gnu.org> To: bug#36803 <36803@debbugs.gnu.org> Subject: Status: 27.0.50; Update mode-line of every window when compilation ends Reply-To: bug#36803 <36803@debbugs.gnu.org> Date: Sat, 20 Sep 2025 15:01:31 +0000 retitle 36803 27.0.50; Update mode-line of every window when compilation en= ds reassign 36803 emacs submitter 36803 K=C3=A9vin Le Gouguec severity 36803 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 24 17:22:25 2019 Received: (at submit) by debbugs.gnu.org; 24 Jul 2019 21:22:25 +0000 Received: from localhost ([127.0.0.1]:38132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqOiP-0006ng-7a for submit@debbugs.gnu.org; Wed, 24 Jul 2019 17:22:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:36747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqOiL-0006nT-77 for submit@debbugs.gnu.org; Wed, 24 Jul 2019 17:22:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60376) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqOiJ-0002GI-Gj for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 17:22:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqOiH-000796-RZ for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 17:22:19 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:42476) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hqOiH-00078x-J2 for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 17:22:17 -0400 Received: by mail-wr1-x431.google.com with SMTP id x1so33470092wrr.9 for ; Wed, 24 Jul 2019 14:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=bxwoIvWuK47Jy+yHiW3HsU1a0+Wp4t8fEIWN9DuAV7c=; b=alNxhrrzL8MKSfhG9V0r1ygTh7kiN21tBahXIvC+kYnrCHOZDXb69wcdvhVTYgIsju 7jM6CEA5fGwU/i1kjzEma7IpCd4IiN+M8tqIM7kK5n/y0kCtmz6Q7DHndFpJE0tqvIDQ oHP7UIi66Kk0e+5ykRIEttUs/3P9ZaeA7vizRH/1K1Ev0rYUKMFcGnjHgg4/bI5wLsvK MwM5hmczva9gd/S/fR7t5MxB1qPgo+rurHzXGo6xYevxn4wWVGkZWatOkUiMR/ek81T7 wPDCCwkJLFmEtTWDsIC3s+mFf9ckwkmDLewZhxVYRI/yQTJZ78I2qvzUAHF1KM9p+Dlg 1TtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=bxwoIvWuK47Jy+yHiW3HsU1a0+Wp4t8fEIWN9DuAV7c=; b=F3hwPTZ0aBAnqLdW8j1NaVKNoAEtwV42Sck4tjCXOdmxu8FuY7teybIdbli/4SsAtU W8fgvdcg8GK0R1yCnvV3UfkNGX0nUcJVnJqWyfDgi2WBEqJs3tIXukLuRUyQx/EsHJ+o c7m465hljlK9AcH9gWz4T/H+ljSWIKI4haDoBJkpeIppY6euuQNg8zSi1J1FmVQI6pob OacDWzpncga+eEoKS+1nSqVeOqhbttDkYDi9kQFVB49jLKznSuRGP+NKVSdTRP5rp6Ya tnopxxLilkNMPfiKWF1FxrMBIEjkA3eGBBM2tV44zIwFC/gsEXr3F0aeoEf+BWUPIAvN LmuA== X-Gm-Message-State: APjAAAWUAboJzrCL8v/XDNLudkdZW9Z0/NdxIzy309QJUXWXqLxInDfj vh99kelmrpx0mfvNqW5PV2dhNsUg X-Google-Smtp-Source: APXvYqyIun98h3kufNDuhWEmzVGLmNaxaNUjg7EQ3AQDMOant3XmYuA5if34x5FdnZITyhO79Ii4kA== X-Received: by 2002:a5d:498f:: with SMTP id r15mr84484122wrq.353.1564003335344; Wed, 24 Jul 2019 14:22:15 -0700 (PDT) Received: from my-little-tumbleweed (71.142.13.109.rev.sfr.net. [109.13.142.71]) by smtp.gmail.com with ESMTPSA id f70sm56968639wme.22.2019.07.24.14.22.13 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 24 Jul 2019 14:22:14 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Update mode-line of every window when compilation ends Date: Wed, 24 Jul 2019 23:22:11 +0200 Message-ID: <877e87i0vw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::431 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Hello, The recent changes on the compilation-in-progress indicator[1] made me realize that the indicator lingers in the mode-lines of some windows. To reproduce from emacs -Q: C-x 2 C-x 2 M-x compile RET C-a C-k true RET "[Compiling]" correctly disappears from the current window and the compilation window, but it lingers on the mode-line of the third window. The attached patch trivially fixes the issue; I do not know whether it's appropriate, or maybe too heavyweight. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Update-every-mode-line-when-compilation-ends.patch >From 25bc31d85ffd7e27e00ba73bac47856def9e97ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Le=20Gouguec?= Date: Wed, 24 Jul 2019 22:50:59 +0200 Subject: [PATCH] Update every mode-line when compilation ends Otherwise the "[Compiling]" indicator lingers in some of them. * lisp/progmodes/compile.el (compilation-handle-exit): Refresh every mode-line. --- lisp/progmodes/compile.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index f4750c0059..657650b488 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -2214,7 +2214,7 @@ compilation-handle-exit 'compilation-mode-line-exit))) compilation-mode-line-errors)) ;; Force mode line redisplay soon. - (force-mode-line-update) + (force-mode-line-update t) (if (and opoint (< opoint omax)) (goto-char opoint)) (run-hook-with-args 'compilation-finish-functions cur-buffer msg))) -- 2.22.0 --=-=-= Content-Type: text/plain WDYT? [1] Make "Compiling" in the mode line a clickable command http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3479ec7332a474b3400cbc6b681c2a1f5637db94 In GNU Emacs 27.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.24.9, cairo version 1.16.0) of 2019-07-03 built on my-little-tumbleweed Repository revision: 22760ab357dd8124c856b76a545e562917872d78 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12005000 System Description: openSUSE Tumbleweed Configured using: 'configure --with-xwidgets --with-cairo' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS XWIDGETS JSON PDUMPER LCMS2 GMP Important settings: value of $LC_CTYPE: en_US.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=local locale-coding-system: utf-8-unix Major mode: Magit Minor modes in effect: global-magit-file-mode: t magit-auto-revert-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t shell-dirtrack-mode: t show-paren-mode: t minibuffer-depth-indicate-mode: t icomplete-mode: t global-page-break-lines-mode: t page-break-lines-mode: t electric-pair-mode: t diff-hl-flydiff-mode: t global-diff-hl-mode: t delete-selection-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr magit-patch bug-reference gnus-async qp gnus-ml nndraft nnmh nnfolder utf-7 epa-file gnutls network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap nntp gnus-cache gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus nnheader emacsbug sendmail magit-extras flyspell ispell rect thingatpt magit-submodule magit-obsolete magit-popup magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process magit-mode transient git-commit magit-git magit-section magit-utils crm log-edit message rmc puny dired dired-loaddefs format-spec rfc822 mml mml-sec epa derived epg gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp async server dash executable cus-edit wid-edit whitespace eieio-opt speedbar sb-image ezimage dframe shell pcomplete help-fns radix-tree cl-print debug backtrace find-func misearch multi-isearch vc-git files-x pcase rx delight advice eighters-theme cl-extra rg rg-ibuffer rg-result wgrep-rg wgrep s rg-history rg-header rg-compat ibuf-ext ibuffer ibuffer-loaddefs grep compile comint ansi-color ring quail help-mode edmacro kmacro disp-table paren mb-depth icomplete page-break-lines elec-pair diff-hl-flydiff diff diff-hl vc-dir ewoc vc vc-dispatcher diff-mode easy-mmode delsel cus-start cus-load mule-util info package easymenu epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting xwidget-internal cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 285991 35395) (symbols 48 25540 1) (strings 32 82326 4257) (string-bytes 1 2726046) (vectors 16 48859) (vector-slots 8 1366992 49654) (floats 8 259 339) (intervals 56 4124 4946) (buffers 992 32)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 25 05:42:36 2019 Received: (at 36803) by debbugs.gnu.org; 25 Jul 2019 09:42:36 +0000 Received: from localhost ([127.0.0.1]:38374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqaGi-0002kk-0y for submit@debbugs.gnu.org; Thu, 25 Jul 2019 05:42:36 -0400 Received: from quimby.gnus.org ([80.91.231.51]:41700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqaGg-0002kc-3y for 36803@debbugs.gnu.org; Thu, 25 Jul 2019 05:42:34 -0400 Received: from 109.179.27.28.tmi.telenormobil.no ([109.179.27.28] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqaGc-0003Gz-Dz; Thu, 25 Jul 2019 11:42:33 +0200 From: Lars Ingebrigtsen To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> Date: Thu, 25 Jul 2019 11:42:27 +0200 In-Reply-To: <877e87i0vw.fsf@gmail.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Wed, 24 Jul 2019 23:22:11 +0200") Message-ID: <87imrqcuws.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Kévin Le Gouguec writes: > The recent changes on the compilation-in-progress indicator[1] made me > realize that the indicator lingers in the mode-lines of some windows. > To reproduce from emacs -Q: > > C-x 2 > C-x 2 > M-x c [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) K=C3=A9vin Le Gouguec writes: > The recent changes on the compilation-in-progress indicator[1] made me > realize that the indicator lingers in the mode-lines of some windows. > To reproduce from emacs -Q: > > C-x 2 > C-x 2 > M-x compile RET C-a C-k true RET > > "[Compiling]" correctly disappears from the current window and the > compilation window, but it lingers on the mode-line of the third window. Was this the case before, too, when the "Compiling" lighter was displayed from minor-mode-alist, or is that somehow updated... differently?=20 > The attached patch trivially fixes the issue; I do not know whether it's > appropriate, or maybe too heavyweight. > > WDYT? - (force-mode-line-update) + (force-mode-line-update t) >From the doc string, that sounds like the right thing to do -- I mean, the lighter is displayed in all mode lines, so I guess you have to do it that way? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 25 06:34:58 2019 Received: (at submit) by debbugs.gnu.org; 25 Jul 2019 10:34:58 +0000 Received: from localhost ([127.0.0.1]:38419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqb5O-0006Ex-Ao for submit@debbugs.gnu.org; Thu, 25 Jul 2019 06:34:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:56976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqb5M-0006Ep-1B for submit@debbugs.gnu.org; Thu, 25 Jul 2019 06:34:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34529) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqb5L-0004LC-2W for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2019 06:34:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hqb5K-0000Uj-QH; Thu, 25 Jul 2019 06:34:54 -0400 Received: from [176.12.156.40] (port=54658 helo=[10.161.225.215]) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1hqb5J-0002PT-RD; Thu, 25 Jul 2019 06:34:54 -0400 Date: Thu, 25 Jul 2019 13:34:50 +0300 User-Agent: K-9 Mail for Android In-Reply-To: <87imrqcuws.fsf@mouse.gnus.org> References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends To: bug-gnu-emacs@gnu.org, Lars Ingebrigtsen , =?ISO-8859-1?Q?K=E9vin_Le_Gouguec?= From: Eli Zaretskii Message-ID: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: 36803@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On July 25, 2019 12:42:27 PM GMT+03:00, Lars Ingebrigtsen wrote: > K=C3=A9vin Le Gouguec writes: >=20 > > The recent changes on the compilation-in-progress indicator[1] made > me > > realize that the indicator lingers in the mode-lines of some > windows=2E > > To reproduce from emacs -Q: > > > > C-x 2 > > C-x 2 > > M-x compile RET C-a C-k true RET > > > > "[Compiling]" correctly disappears from the current window and the > > compilation window, but it lingers on the mode-line of the third > window=2E >=20 > Was this the case before, too, when the "Compiling" lighter was > displayed from minor-mode-alist, or is that somehow updated=2E=2E=2E > differently?=20 >=20 > > The attached patch trivially fixes the issue; I do not know whether > it's > > appropriate, or maybe too heavyweight=2E > > > > WDYT? >=20 > - (force-mode-line-update) > + (force-mode-line-update t) >=20 > >From the doc string, that sounds like the right thing to do -- I > mean, > the lighter is displayed in all mode lines, so I guess you have to do > it > that way? This seems to be a regression since Emacs 25, as it works for me upto and = including Emacs 24=2E5=2E So I think it would be nice to bisect to see whi= ch change caused this, before we decide how to fix it=2E Thanks=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 25 09:37:56 2019 Received: (at 36803) by debbugs.gnu.org; 25 Jul 2019 13:37:56 +0000 Received: from localhost ([127.0.0.1]:38611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqdwR-0004OI-Vy for submit@debbugs.gnu.org; Thu, 25 Jul 2019 09:37:56 -0400 Received: from mail-oi1-f177.google.com ([209.85.167.177]:36993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqdwQ-0004O6-1A for 36803@debbugs.gnu.org; Thu, 25 Jul 2019 09:37:54 -0400 Received: by mail-oi1-f177.google.com with SMTP id t76so37697170oih.4 for <36803@debbugs.gnu.org>; Thu, 25 Jul 2019 06:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xlCVv5l+jujaJDDiHqJlLa3yqRue8T7GHP/7HVpxgAc=; b=ZZp0bSnkoDKzHnwG2OybS2YEYZ/1g0v/9JE1w/1ZysnDuCsUOTqx+9gXSZW+oOGgZ4 AviaVkoV/CGGpLzRppmVgLUuOVOMqOwdM9DCXOiOH81dWX4mRnOsBy+59tUPCbtcgt9+ wJPg2izBEaq3MmQNnEMg8Upzb/Bd/NUsZN+0AdXx3wOKEAUVKbebMky8jOefz0RIRzcU b+LCOwNZ4DSL1AW1zC6bf5ClrS2VsR5Q6AAfY9HmV7NFVePxDAJj4PvJZKYW/KLpIG9J V0hcv43lrG7rcwGRchYxPySUTBRi4Y+HGBgVtBnTjfBVuJbrfCoGgztJi6lZC1qFrkyG 1anA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xlCVv5l+jujaJDDiHqJlLa3yqRue8T7GHP/7HVpxgAc=; b=iLihFNy6Zy0JiDw1DgfujL1APj7ye0lwd7O+LnotQAUmRehT6nIKOXT6SiNTOFdKAu 6tYzpzEkNORB0hSRvEVILD3CLBx1yHY+wj3sMKcOC/f2hwajAEIPuvLC+YVGSxP+FxFN mipTnFnL4uP7rWqYcZPBXNeCr5VxQprY6t2TzomODWuKiGZypFVEysRvh2KgWpxbYT9o 63pp1s2sPyoGoy8dZmv9hQX30GhnJ1JJGG9YodCTHdnSFChIysWIfc7/UHJfInatr3uQ pdZFq6Pi7MJbk8DI9Rwok2Fn5aa0cSl0//H/evLdExpplXfINIt6BI0LcEf5O940YJUy fYgQ== X-Gm-Message-State: APjAAAUEeyZ6roeIJksubqW5VkNFJaBMN9K53bSoCGLzoCk8nu7D8dp+ slnz7EeTjHI6wuwys9ZXeHFmE96NmJbWEBKbbdA= X-Google-Smtp-Source: APXvYqwxlc8G4e9Zqlv4eTdePYrewezG19mHoOAS4rxqyFYyQTos7ZGnUYE2VOKqRn+ltvoj4HQbs11X1tvgb2brl6k= X-Received: by 2002:aca:cdd3:: with SMTP id d202mr39045706oig.115.1564061868376; Thu, 25 Jul 2019 06:37:48 -0700 (PDT) MIME-Version: 1.0 References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> In-Reply-To: From: =?UTF-8?Q?K=C3=A9vin_Le_Gouguec?= Date: Thu, 25 Jul 2019 15:37:37 +0200 Message-ID: Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Jul 25, 2019 at 12:34 PM Eli Zaretskii wrote: > > This seems to be a regression since Emacs 25, as it works for me upto and including Emacs 24.5. So I think it would be nice to bisect to see which change caused this, before we decide how to fix it. > > Thanks If my bisection is correct, then this regression dates back from 645c8597e7f9fbc90ffe227d2be8ce383b0777ae * src/process.c (status_notify): Avoid global redisplay (bug#11822) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=645c8597e7f9fbc90ffe227d2be8ce383b0777ae I can't take an in-depth look at this commit right now (may do in a few hours); I am sending this in case the issue (and hopefully, the ideal fix) jumps out to you. Thanks for identifying that this is actually a regression! From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 25 10:59:16 2019 Received: (at 36803) by debbugs.gnu.org; 25 Jul 2019 14:59:16 +0000 Received: from localhost ([127.0.0.1]:40248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqfDA-0006kC-DV for submit@debbugs.gnu.org; Thu, 25 Jul 2019 10:59:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqfD7-0006jy-TF for 36803@debbugs.gnu.org; Thu, 25 Jul 2019 10:59:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hqfD2-0001HQ-Bg; Thu, 25 Jul 2019 10:59:08 -0400 Received: from [176.228.60.248] (port=4262 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hqfD1-0002Pn-25; Thu, 25 Jul 2019 10:59:07 -0400 Date: Thu, 25 Jul 2019 17:59:00 +0300 Message-Id: <83ef2enosr.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec In-reply-to: (message from =?utf-8?Q?K=C3=A9vin?= Le Gouguec on Thu, 25 Jul 2019 15:37:37 +0200) Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Kévin Le Gouguec > Date: Thu, 25 Jul 2019 15:37:37 +0200 > Cc: Lars Ingebrigtsen , 36803@debbugs.gnu.org > > > This seems to be a regression since Emacs 25, as it works for me upto and including Emacs 24.5. So I think it would be nice to bisect to see which change caused this, before we decide how to fix it. > > > > Thanks > > If my bisection is correct, then this regression dates back from > > 645c8597e7f9fbc90ffe227d2be8ce383b0777ae > * src/process.c (status_notify): Avoid global redisplay (bug#11822) > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=645c8597e7f9fbc90ffe227d2be8ce383b0777ae Makes sense, I will look into why this change was made. > I can't take an in-depth look at this commit right now (may do in a > few hours); I am sending this in case the issue (and hopefully, the > ideal fix) jumps out to you. The very few first lines of the change are those which caused this, the rest are just comment clarifications. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 04:13:33 2019 Received: (at 36803) by debbugs.gnu.org; 26 Jul 2019 08:13:33 +0000 Received: from localhost ([127.0.0.1]:40783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqvM4-0000sb-TO for submit@debbugs.gnu.org; Fri, 26 Jul 2019 04:13:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqvM2-0000sN-Tv for 36803@debbugs.gnu.org; Fri, 26 Jul 2019 04:13:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hqvLr-0000k9-Ca; Fri, 26 Jul 2019 04:13:19 -0400 Received: from [176.228.60.248] (port=3883 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hqvLq-0002k1-Ql; Fri, 26 Jul 2019 04:13:19 -0400 Date: Fri, 26 Jul 2019 11:13:12 +0300 Message-Id: <83r26dmcx3.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: <83ef2enosr.fsf@gnu.org> (message from Eli Zaretskii on Thu, 25 Jul 2019 17:59:00 +0300) Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 25 Jul 2019 17:59:00 +0300 > From: Eli Zaretskii > Cc: 36803@debbugs.gnu.org, larsi@gnus.org > > > If my bisection is correct, then this regression dates back from > > > > 645c8597e7f9fbc90ffe227d2be8ce383b0777ae > > * src/process.c (status_notify): Avoid global redisplay (bug#11822) > > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=645c8597e7f9fbc90ffe227d2be8ce383b0777ae > > Makes sense, I will look into why this change was made. Stefan, I'm looking and looking, and don't understand why that change made sense. The process-status indication in the mode line is shown in all windows, so status_notify is exactly the place where we should trigger update of all mode lines. Otherwise, we will have to sprinkle force-mode-line-update calls all over the place (and it still won't work well in the cases where the default sentinel is used, and this no Lisp is involved). So I think we should restore the old code, i.e. revert this part of the above-mentioned commit: --- a/src/process.c +++ b/src/process.c @@ -6694,10 +6694,12 @@ status_notify (struct Lisp_Process *deleting_process, p->update_tick = p->tick; /* Now output the message suitably. */ exec_sentinel (proc, msg); + if (BUFFERP (p->buffer)) + /* In case it uses %s in mode-line-format. */ + bset_update_mode_line (XBUFFER (p->buffer)); } } /* end for */ - update_mode_lines = 24; /* In case buffers use %s in mode-line-format. */ return got_some_output; } Am I missing something? From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 09:59:54 2019 Received: (at 36803) by debbugs.gnu.org; 26 Jul 2019 13:59:54 +0000 Received: from localhost ([127.0.0.1]:43062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr0lG-0001hb-GW for submit@debbugs.gnu.org; Fri, 26 Jul 2019 09:59:54 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:55505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr0lD-0001hL-8Z for 36803@debbugs.gnu.org; Fri, 26 Jul 2019 09:59:52 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9D47885ACA; Fri, 26 Jul 2019 09:59:45 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DE5FB8117A; Fri, 26 Jul 2019 09:59:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1564149583; bh=AgEDDuZjsWEWYh1/WyJ3CMP8T5hqleIMNbAxBzFxf3I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=TJZCgvFDW3ASsghxCPkhXHGmtP626xie3nnZs6r61O5ueXuBmhac0FV8aQZmubJMP EodkpB/eA4FyUpGgyx8Qx5TevJQwh7B9nDPg0BQb78FYIFtbVT0e5w+DY75tNBrsly 4PRHbDcZ/zwEE+E493RrH5Z4JCT4QwAKRy/0tRF0tFSLzE9EBOXgvKhASHveSQWpEV R5U1np6RZSqUf9QLuDC6EB9P+plgDG5AnaOpyCu5MOt/Tav4hvwwBqwmT52+Z6Gwmj MMpmSFxzNYAZEPf8jGkFH9wPOS0E87uu5e4QL0hG6EAqqy5V/rJY5pHnDznGCyUSvY 07KiW98r2XRsw== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3F6BD120F1F; Fri, 26 Jul 2019 09:59:43 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends Message-ID: References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> Date: Fri, 26 Jul 2019 09:59:39 -0400 In-Reply-To: <83r26dmcx3.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Jul 2019 11:13:12 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.401 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> > If my bisection is correct, then this regression dates back from >> > >> > 645c8597e7f9fbc90ffe227d2be8ce383b0777ae >> > * src/process.c (status_notify): Avoid global redisplay (bug#11822) >> > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=645c8597e7f9fbc90ffe227d2be8ce383b0777ae >> >> Makes sense, I will look into why this change was made. > > Stefan, I'm looking and looking, and don't understand why that change > made sense. The process-status indication in the mode line is shown > in all windows, so status_notify is exactly the place where we should > trigger update of all mode lines. Hmm... AFAIK the "process status" normally only indicates the status of the process running in the buffer to which this mode line belongs. Which is why I made the change to only bset_update_mode_line rather than set the global update_mode_lines. > Otherwise, we will have to sprinkle force-mode-line-update calls all > over the place (and it still won't work well in the cases where the > default sentinel is used, and this no Lisp is involved). AFAIK it's rather rare to use a global indicator such that all mode lines indicate whether that specific process might be running (and I personally find it a bad idea: why should my hundreds of mode-lines duplicate that information even though most of them are displaying buffers which have nothing to do whatsoever with that process?). So I think it's OK for this particular case to have to explicitly call force-mode-line-update. I don't think it will be needed "all over the place". Additionally, in this particular case, the need to update all mode-lines doesn't come from the fact that a sentinel was run, but from the fact that compilation-in-progress was modified, which can (and does) also happen when no sentinel is run. So I think TRT is something like the patch below. Stefan diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index a7575b5a1a..cbc60f5630 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1806,8 +1806,10 @@ compilation-start ;; The process may have exited already. (error nil))) (run-hook-with-args 'compilation-start-hook proc) - (setq compilation-in-progress - (cons proc compilation-in-progress))) + ;; `compilation-in-progress' affects the mode-line of all + ;; buffers when it changes from nil to non-nil or vice-versa. + (unless compilation-in-progress (force-mode-line-update t)) + (push proc compilation-in-progress)) ;; No asynchronous processes available. (message "Executing `%s'..." command) ;; Fake mode line display as if `start-process' were run. @@ -2240,7 +2242,10 @@ compilation-sentinel ;; process is dead, we can delete it now. Otherwise it ;; will stay around until M-x list-processes. (delete-process proc))) - (setq compilation-in-progress (delq proc compilation-in-progress))))) + (setq compilation-in-progress (delq proc compilation-in-progress)) + ;; `compilation-in-progress' affects the mode-line of all buffers when + ;; it changes from nil to non-nil or vice-versa. + (unless compilation-in-progress (force-mode-line-update t))))) (defun compilation-filter (proc string) "Process filter for compilation buffers. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 11:09:14 2019 Received: (at 36803) by debbugs.gnu.org; 26 Jul 2019 15:09:14 +0000 Received: from localhost ([127.0.0.1]:43170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr1qL-0001QH-GR for submit@debbugs.gnu.org; Fri, 26 Jul 2019 11:09:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr1qJ-0001Q5-Mp for 36803@debbugs.gnu.org; Fri, 26 Jul 2019 11:09:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hr1qC-0007gA-A9; Fri, 26 Jul 2019 11:09:05 -0400 Received: from [176.228.60.248] (port=1593 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hr1qB-0007h7-MI; Fri, 26 Jul 2019 11:09:04 -0400 Date: Fri, 26 Jul 2019 18:08:57 +0300 Message-Id: <83imron88m.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Fri, 26 Jul 2019 09:59:39 -0400) Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: kevin.legouguec@gmail.com, 36803@debbugs.gnu.org, larsi@gnus.org > Date: Fri, 26 Jul 2019 09:59:39 -0400 > > > Stefan, I'm looking and looking, and don't understand why that change > > made sense. The process-status indication in the mode line is shown > > in all windows, so status_notify is exactly the place where we should > > trigger update of all mode lines. > > Hmm... AFAIK the "process status" normally only indicates the status of > the process running in the buffer to which this mode line belongs. > Which is why I made the change to only bset_update_mode_line rather than > set the global update_mode_lines. So you are saying that there's a redisplay bug, whereby some windows that display a buffer don't have their mode line updated in the recipe of this bug report? > Additionally, in this particular case, the need to update all mode-lines > doesn't come from the fact that a sentinel was run, but from the fact > that compilation-in-progress was modified, which can (and does) also > happen when no sentinel is run. So I think TRT is something like the > patch below. force-mode-line-update with a non-nil argument affects all the windows, even those which don't show the process status. So why are you saying it's TRT in this case? Or are you talking about some other issue? From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 12:23:38 2019 Received: (at 36803) by debbugs.gnu.org; 26 Jul 2019 16:23:39 +0000 Received: from localhost ([127.0.0.1]:43259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr30M-0005ow-8E for submit@debbugs.gnu.org; Fri, 26 Jul 2019 12:23:38 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:8917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr30I-0005oE-WF for 36803@debbugs.gnu.org; Fri, 26 Jul 2019 12:23:36 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2F507102D83; Fri, 26 Jul 2019 12:23:29 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C7BD91013C1; Fri, 26 Jul 2019 12:23:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1564158207; bh=DLoQJn4gnQ03Fn3VTacUvsht65K+6Qfn7yU9mSjf0Qk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bHssGljBPHRE+qOCm8p0hzffK6EFDaf07mB77QauyoykC4YkHf9Q8MwEi2TMrn+Ws DOwt/nxTUo3J/D8Z1Se12SgLecz2oYVHfJJzXcZyFwjIfF8pWnZgv5bkXAFHQMd6xU texTuiBg5lInZPBUC9spvXAcZ0t54xWadnNHSMZhOMNE711FgooyNha8yXWregu7ee 04LKm7KLJqvfuRH+nUH2wchguSI0gfHrtm07s/joF3yAfvc85HYuvq7rB6SxLSvGHT 2Apt2/F8efTBfLc3SE4Ojd3ZY0xpYKBjZRu9jOFoGNRKkHETFk/kr4Bcihi1ON9ukU NrjoS+76uoR8A== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6AB3F120C71; Fri, 26 Jul 2019 12:23:27 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends Message-ID: References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> Date: Fri, 26 Jul 2019 12:23:26 -0400 In-Reply-To: <83imron88m.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Jul 2019 18:08:57 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.137 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> > Stefan, I'm looking and looking, and don't understand why that change >> > made sense. The process-status indication in the mode line is shown >> > in all windows, so status_notify is exactly the place where we should >> > trigger update of all mode lines. >> >> Hmm... AFAIK the "process status" normally only indicates the status of >> the process running in the buffer to which this mode line belongs. >> Which is why I made the change to only bset_update_mode_line rather than >> set the global update_mode_lines. > > So you are saying that there's a redisplay bug, whereby some windows > that display a buffer don't have their mode line updated in the recipe > of this bug report? In the recipe of this bug, we have a process in the compilation buffer and the status of this process is reflected in the mode line of *all* windows (via the compilation-in-progress variable). The "process status" I'm referring to above is another kind of "process status" in the mode-line: that of `mode-line-process` which is usually buffer-local and only reflects the status of the process running in that same buffer. >> Additionally, in this particular case, the need to update all mode-lines >> doesn't come from the fact that a sentinel was run, but from the fact >> that compilation-in-progress was modified, which can (and does) also >> happen when no sentinel is run. So I think TRT is something like the >> patch below. > force-mode-line-update with a non-nil argument affects all the > windows, even those which don't show the process status. So why are > you saying it's TRT in this case? Because the status of the compilation process *is* by default reflected in the mode line of all windows (I disable this in my own config because I don't like it). Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 14:17:10 2019 Received: (at 36803) by debbugs.gnu.org; 26 Jul 2019 18:17:10 +0000 Received: from localhost ([127.0.0.1]:43344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr4mE-0001nh-1h for submit@debbugs.gnu.org; Fri, 26 Jul 2019 14:17:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr4mC-0001nT-IX for 36803@debbugs.gnu.org; Fri, 26 Jul 2019 14:17:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hr4m6-0001Mj-96; Fri, 26 Jul 2019 14:17:02 -0400 Received: from [176.228.60.248] (port=1064 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hr4m5-0001pO-Iv; Fri, 26 Jul 2019 14:17:02 -0400 Date: Fri, 26 Jul 2019 21:16:55 +0300 Message-Id: <83h878mzjc.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Fri, 26 Jul 2019 12:23:26 -0400) Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com > Date: Fri, 26 Jul 2019 12:23:26 -0400 > > > So you are saying that there's a redisplay bug, whereby some windows > > that display a buffer don't have their mode line updated in the recipe > > of this bug report? > > In the recipe of this bug, we have a process in the compilation buffer > and the status of this process is reflected in the mode line of > *all* windows (via the compilation-in-progress variable). > > The "process status" I'm referring to above is another kind of "process > status" in the mode-line: that of `mode-line-process` which is usually > buffer-local and only reflects the status of the process running in that > same buffer. But the recipe uses "C-x 2" several times, so all the windows display the same buffer. And yet one of them has its mode line not updated after the process exist. > >> Additionally, in this particular case, the need to update all mode-lines > >> doesn't come from the fact that a sentinel was run, but from the fact > >> that compilation-in-progress was modified, which can (and does) also > >> happen when no sentinel is run. So I think TRT is something like the > >> patch below. > > force-mode-line-update with a non-nil argument affects all the > > windows, even those which don't show the process status. So why are > > you saying it's TRT in this case? > > Because the status of the compilation process *is* by default reflected > in the mode line of all windows Then we should update all mode lines when the status changes, and we should not require any Lisp to force that update. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 14:53:57 2019 Received: (at 36803) by debbugs.gnu.org; 26 Jul 2019 18:53:57 +0000 Received: from localhost ([127.0.0.1]:43379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr5Lp-0002jU-Dg for submit@debbugs.gnu.org; Fri, 26 Jul 2019 14:53:57 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr5Ln-0002jH-Gy for 36803@debbugs.gnu.org; Fri, 26 Jul 2019 14:53:56 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DFE31102D83; Fri, 26 Jul 2019 14:53:49 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0E6F61013C1; Fri, 26 Jul 2019 14:53:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1564167224; bh=NRKZIAlYrAwGglkdc7JulgUb2OK+8QT7J3zKQiGTcTs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Dv8EUw3o9MyzG7aDSzEbKJsrurs61pRcbmeS76JeZxhBp5KqZA8//QeP39fTC8E8W mCv3mzlAcqSXOXxjhMboq3Uvzb7TnyG13qMbGD0yyWFGUCALviI3XVnisoj+fWjIfs 2rt/dRlLucHpaec4UlWwV2eREjzEs6NNG6omXb6wShpNa7WH2EpR1oOBu92sTEiQlK 8UI0mIs3vTiYYNpylWIpTQm5PSvN8o7WRD4OOV8pOCNtJpEnBraiDC6b94HA+Zt9eV +Qh6qiyBY/6xxGb/g8meZx3Z8UtNByn0GzKyFWzJHgnntaHaEAlpjJaIWE33nePTWh 4ivzbGjPvRTTA== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CC4A6120F3E; Fri, 26 Jul 2019 14:53:43 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends Message-ID: References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> <83h878mzjc.fsf@gnu.org> Date: Fri, 26 Jul 2019 14:53:43 -0400 In-Reply-To: <83h878mzjc.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Jul 2019 21:16:55 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.132 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> The "process status" I'm referring to above is another kind of "process >> status" in the mode-line: that of `mode-line-process` which is usually >> buffer-local and only reflects the status of the process running in that >> same buffer. > > But the recipe uses "C-x 2" several times, so all the windows display > the same buffer. And yet one of them has its mode line not updated > after the process exist. Right: there are 2 windows displaying the original buffer, plus a third one displaying the compilation buffer. The C code for process sentinels makes sure that the mode-line of the window showing the compilation buffer get updated (for the benefit of mode-line-process, presumably), but none of the others. As it so happens, one of the others also gets updated because it's the currently selected_window. > Then we should update all mode lines when the status changes, and we > should not require any Lisp to force that update. I don't see why we should do that every time a process sentinel is run, while it's only needed for the sentinel of the compilation processes. Especially since it only saves us one of the (force-mode-line-update t) in my patch (the one that's in the process sentinel) but not the other (the one that's in the code that launches the process). Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 15:21:53 2019 Received: (at 36803) by debbugs.gnu.org; 26 Jul 2019 19:21:53 +0000 Received: from localhost ([127.0.0.1]:43384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr5mq-0003Qg-Mf for submit@debbugs.gnu.org; Fri, 26 Jul 2019 15:21:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr5mo-0003QU-Vz for 36803@debbugs.gnu.org; Fri, 26 Jul 2019 15:21:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hr5mi-0006hl-Sl; Fri, 26 Jul 2019 15:21:44 -0400 Received: from [176.228.60.248] (port=4995 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hr5mg-00083S-4t; Fri, 26 Jul 2019 15:21:42 -0400 Date: Fri, 26 Jul 2019 22:21:37 +0300 Message-Id: <83ef2cmwji.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Fri, 26 Jul 2019 14:53:43 -0400) Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> <83h878mzjc.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com > Date: Fri, 26 Jul 2019 14:53:43 -0400 > > >> The "process status" I'm referring to above is another kind of "process > >> status" in the mode-line: that of `mode-line-process` which is usually > >> buffer-local and only reflects the status of the process running in that > >> same buffer. > > > > But the recipe uses "C-x 2" several times, so all the windows display > > the same buffer. And yet one of them has its mode line not updated > > after the process exist. > > Right: there are 2 windows displaying the original buffer, plus a third > one displaying the compilation buffer. The C code for process sentinels > makes sure that the mode-line of the window showing the compilation > buffer get updated (for the benefit of mode-line-process, presumably), > but none of the others. > As it so happens, one of the others also gets updated because it's the > currently selected_window. That's not what happens. What happens is that one of the windows still shows "Compiling" after the process exits. That's what this bug report is about. If you are saying that that buffer's mode line wasn't supposed to show the process status in the first place, then that's the bug we should solve. But right now the mode line of *scratch* does show "Compiling" in all of its windows, so there's a global setting that is updated when the process starts and ends, and that change isn't triggering the update of mode lines in all the windows showing *scratch*. I still don't understand how you explain that inconsistency. > > Then we should update all mode lines when the status changes, and we > > should not require any Lisp to force that update. > > I don't see why we should do that every time a process sentinel is run, > while it's only needed for the sentinel of the compilation processes. > > Especially since it only saves us one of the (force-mode-line-update t) > in my patch (the one that's in the process sentinel) but not the other > (the one that's in the code that launches the process). If the call to force-mode-line-update is the solution you suggest, then I think it is not a good solution. We cannot rely in a call to force-mode-line-update, because there's the default sentinel, and because it's unreasonable to request each sentinel written in Lisp to make that call. If every sentinel must do that, then the core should do that for them. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 15:35:23 2019 Received: (at 36803) by debbugs.gnu.org; 26 Jul 2019 19:35:23 +0000 Received: from localhost ([127.0.0.1]:43389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr5zv-0003mA-1P for submit@debbugs.gnu.org; Fri, 26 Jul 2019 15:35:23 -0400 Received: from quimby.gnus.org ([80.91.231.51]:52316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr5zs-0003m1-N5 for 36803@debbugs.gnu.org; Fri, 26 Jul 2019 15:35:21 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hr5zm-0006pf-L2; Fri, 26 Jul 2019 21:35:17 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> <83h878mzjc.fsf@gnu.org> <83ef2cmwji.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEXNuNNoRlyjgrqUbqAR BxKbebStjr/hc4CXAAACeElEQVQ4jW2Tz47bIBDGZ9fNnD2F5uylMucQ1j4XJQ+wS4TPFMu8/yN0 BiepVi2Komh++ebPxwBrLRmguOv9zEOptZoRljQDQG1AC8jbktEWjmVAxHeOkQBVDStqgcjxbSgC lIAfiy0Vq4Upw3aum34ofIy1gny2McVpeqaa0lIBsAKmFG/+xrHQwDFa7pIVW0rp5r3+Wzxz2PwD wjRIT8XAmJK9g3YmU7itaiClZbuDIEBxV8byHClVSfUQXC/nGA0fYMGX4pdpvIMSH6BNflxT2sHe lQx41FymPzyAsSV547QA3cCeaql1TOfhd7jSiXQIGe+Ax6ix5k4HGhxpxV7zgC2VsRnz+k5HQKU9 iINMWGEiikL1gEfyzVgBxmT5CxIrXsLlBphFU4DNlx94dj280vENsAUKKySeO+c4xZtz7Z/IJnJv Vq5sYQBr6VptcZdbTrIok6wXrGf+Yt9b8XEsm/dzK9b52dZXK13FOHLDnk4i4I1UM1+HDMiKlLyn 7+rEwOnjOZo2+WiSAK2oFxDmKVquzZOPOyB1zF9BeoD5f0BpotYu1bOxUIcn6Hl6aWvoJjavPAGR 9NTONvDw+Q5unjc38gv66BrEXB6A7459cSfyu+4JtFYzrMEFn8V4fKZyL32Gz15f5sKJcDg8QQ4z aLqqycgYO4jj6Fz/fll5r/208EWMO1hqcY6+yWsOasqFL6IeYGKS8aenTnad/Nxsra87EC/6HfDC pSfgWVf9i19BoBnzQQDyQ+Qi/FDfVPcZKHiwyBfRViVZs0VA6ix5WtEC2ogIGXkx8CPnz8NCpA7s Mm4zDz/WtpIZ3Gt2RAV5rdbTAf4A5IDo2eF7uKAAAAAASUVORK5CYII= Date: Fri, 26 Jul 2019 21:35:14 +0200 In-Reply-To: <83ef2cmwji.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Jul 2019 22:21:37 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > If the call to force-mode-line-update is the solution you suggest, > then I think it is not a good solution. We cannot rely in a call to > force-mode-line-update, because there's the default sentine [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, Stefan Monnier , kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > If the call to force-mode-line-update is the solution you suggest, > then I think it is not a good solution. We cannot rely in a call to > force-mode-line-update, because there's the default sentinel, and > because it's unreasonable to request each sentinel written in Lisp to > make that call. If every sentinel must do that, then the core should > do that for them. Well, when I was looking at where to move the "Compiling" sort-of-lighter (from out of minor-mode-alist where it didn't belong), I was looking for other modes that display things in mode lines in all buffers -- and there doesn't seem to be many. So while I agree that it seems more logical that this "should just work", I think the problem is very limited in practice, and having compile.el (as one of the very few packages that does this) call force-mode-line-update wouldn't be an outrage. (Another issue is whether compile.el should do this, and I kinda think... perhaps not?) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 17:10:59 2019 Received: (at 36803) by debbugs.gnu.org; 26 Jul 2019 21:10:59 +0000 Received: from localhost ([127.0.0.1]:43417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr7UP-00067s-Dj for submit@debbugs.gnu.org; Fri, 26 Jul 2019 17:10:59 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr7UN-00067d-DE for 36803@debbugs.gnu.org; Fri, 26 Jul 2019 17:10:56 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CAAF944567C; Fri, 26 Jul 2019 17:10:49 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5598B445668; Fri, 26 Jul 2019 17:10:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1564175448; bh=XI7AD4Mcp6pG+QGKx81Jtze0tFibV19rpSjSlxXk3jM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Vdvl0QeKZi51Bd/ldP7vKauK2MqiIA7/jePAXDMGrSIwQ3L5RqbiCVJXrp3wvhFp4 lOWD0wABbWTfLoLHvhnwhNbLVKP1g3MUJ2x9Dd6o//5wZVI3OBT1JdXvRI7C7eO5Zv ORe3nfLYzqFdb3StWfwtsn+kwuQA/SNtsk2FPxcKAJXdBpnnE2FPI0ZftIPLQ48xQr ELKUJ4FgTpeTw8IDOlxM9dI7bBqMgK9/Oz0VPEWUFVFjyrpCEUYXM52noEZPCS1uHP OnQpoTus1UIHFInkhqv/kdcmOr5fm4gw+Ljm6VVaZr6rZ09O9V/nH4JEQlRJRRuYGr J5L3Gk8tYxrGQ== Received: from pastel (unknown [216.154.19.233]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1018612081F; Fri, 26 Jul 2019 17:10:48 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends Message-ID: References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> <83h878mzjc.fsf@gnu.org> <83ef2cmwji.fsf@gnu.org> Date: Fri, 26 Jul 2019 17:10:40 -0400 In-Reply-To: <83ef2cmwji.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Jul 2019 22:21:37 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.103 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Right: there are 2 windows displaying the original buffer, plus a third >> one displaying the compilation buffer. The C code for process sentinels >> makes sure that the mode-line of the window showing the compilation >> buffer get updated (for the benefit of mode-line-process, presumably), >> but none of the others. >> As it so happens, one of the others also gets updated because it's the >> currently selected_window. > > That's not what happens. What happens is that one of the windows > still shows "Compiling" after the process exits. AFAIK this is indeed just what I describe in the previous paragraph (i.e. at the end of the compilation, when the sentinel is run, the C part of the sentinel processing causes the refresh of the mode-line of the window showing the compilation buffer, the redisplay itself will on its own accord decide to refresh the selected window's mode-line, but the third window's mode-line is not refreshed because noone tells the C code that all mode-lines indicated the status of this specific process). > If you are saying that that buffer's mode line wasn't supposed to show > the process status in the first place, then that's the bug we should > solve. No, I only indicated as a side-comment that this default of showing the status of the compilation process in all mode lines is a behavior I dislike. > But right now the mode line of *scratch* does show "Compiling" > in all of its windows, so there's a global setting that is updated > when the process starts and ends, Indeed. > and that change isn't triggering the update of mode lines in all the > windows showing *scratch*. I still don't understand how you explain > that inconsistency. Very simple: the change in the mode-line is caused by a change to the `compilation-in-progress` global variable. Yet, the mode-line infrastructure is not setup to track dependencies on variables; instead it's traditionally the responsability of the code which sets this variable to explicitly call force-mode-line-update (as is done, for example in all minor-modes (from within `define-minor-mode`)). > If the call to force-mode-line-update is the solution you suggest, > then I think it is not a good solution. We cannot rely in a call to > force-mode-line-update, because there's the default sentinel, and The default sentinel does not modify `compilation-in-progress` (nor any other global variable for that matter), so there's never any need to update all the mode-lines at the end of a process using the default sentinel. > because it's unreasonable to request each sentinel written in Lisp to > make that call. If every sentinel must do that, then the core should > do that for them. Not all sentinels must so that. Only those which set global variables whose content affects the mode-line of "all" windows (not necessarily all, tho, but at least more than just the mode lines of the current buffer). There might be a few beside compile.el's sentinel, but they are the exception rather than the rule. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 17:27:07 2019 Received: (at 36803) by debbugs.gnu.org; 26 Jul 2019 21:27:07 +0000 Received: from localhost ([127.0.0.1]:43425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr7k3-0006Xu-2y for submit@debbugs.gnu.org; Fri, 26 Jul 2019 17:27:07 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:45174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr7k2-0006XP-B8 for 36803@debbugs.gnu.org; Fri, 26 Jul 2019 17:27:06 -0400 Received: by mail-wr1-f43.google.com with SMTP id f9so55718877wre.12 for <36803@debbugs.gnu.org>; Fri, 26 Jul 2019 14:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=6Dwju1HJiqSDSiuaO9eVK9TY5THKZebxKPp0OiKuey8=; b=nEkTktV4/xwm90v6Gcv5BU1fneJe77+PTrFxBMXOS9ov31Gdi/DgIEiIUqSWNGcmap 7JLeJ0CDtWWMyvs8Sr+jsqj3fVKTguI0KuXumKQBb5iSd3WYhMElrkGr+LkUV6Ftzfgt IhgAXXFK4L8o+5uzZqSa0IQLIsrbc+GSSWoMHeB4N18ghil5hXOLz6BHJwXY9efEpNwJ Vlgo2yyZdbUKBYklZQkMk49wrdWbRfzaEJvZsLuRzrkZaPkJ3FbS5s/ObMeuzo/NOZUP mnWsITlTPwbRTd0ndYCCCFqFIJMX3ChowRSgmiUXOSZ9R2p8znVrStaNHixvfUqhpWdj buDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=6Dwju1HJiqSDSiuaO9eVK9TY5THKZebxKPp0OiKuey8=; b=iHv0igN2jXLtc+r4OVSacVpN9eUfBxoKHPLjs0eFz0Ox5ZULk65r86Fkfi8jNBStHG xJDUTdzhEX7TlOODISdedOBNB6ANZdxxKA7gliZNUQy2kZ5pv1UX4avPNhcu0EMvnhud 0A/XJ5C1s0QkZonwtHohuJIgIRIoyEnek0wflJ8X6hgosBOjpI3D0v39xHn4JJfozvG+ MdyazOpZTKSwO+XhoEQSpI+q+NODer9HYTINGFsReZcY2yszZJ5LInNdhctprvYBVfpy 34g6XXtBhrPnh1YBD53PrlhzdilTIyjGeCWkLurb9aKfC6H5FzocasDucBj724NUkAId hFJw== X-Gm-Message-State: APjAAAXhOLiO9mZ+N5fbvV+m8Vo3qpmdg2gYZHElbF+JPFq5eBNzFXLZ Fsc3Ml8dVMUchLxjNqBFZhNUpkXi1t8= X-Google-Smtp-Source: APXvYqyUMiHrqBfZeYpsl7vKIKV5PL8yjBqne8a4omjWMHjurHmYykaK/y2NT6cOocWcY6JymiutPw== X-Received: by 2002:a5d:6182:: with SMTP id j2mr56990004wru.275.1564176420281; Fri, 26 Jul 2019 14:27:00 -0700 (PDT) Received: from nc10-laptop (2a01cb04010fc8001d26ade98aef9bb2.ipv6.abo.wanadoo.fr. [2a01:cb04:10f:c800:1d26:ade9:8aef:9bb2]) by smtp.gmail.com with ESMTPSA id 17sm46868220wmx.47.2019.07.26.14.26.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jul 2019 14:26:59 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Lars Ingebrigtsen Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> <83h878mzjc.fsf@gnu.org> <83ef2cmwji.fsf@gnu.org> Date: Fri, 26 Jul 2019 23:26:58 +0200 In-Reply-To: (Lars Ingebrigtsen's message of "Fri, 26 Jul 2019 21:35:14 +0200") Message-ID: <878sskqyfx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > (Another issue is whether compile.el should [display things in mode > lines in all buffers], and I kinda think... perhaps not?) Mmm, I guess the rationale is that since 1. the user may bury the compilation buffer if the process takes a long time, 2. the user may miss the "Compilation finished" message (e.g. it can be hidden by any movement command that triggers a "Mark set" message), The only reliable way to inform the user that the compilation process is still running is to spray all mode-lines with an indicator=E2=80=A6 (I have notifications-notify in compilation-finish-functions, so as far as I am concerned, I could live without this indicator; for a stock Emacs configuration though, I can't think of another signaling method=E2=80= =A6) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 02:58:02 2019 Received: (at 36803) by debbugs.gnu.org; 27 Jul 2019 06:58:02 +0000 Received: from localhost ([127.0.0.1]:43556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrGeY-0001Ip-IK for submit@debbugs.gnu.org; Sat, 27 Jul 2019 02:58:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrGeW-0001IJ-NN for 36803@debbugs.gnu.org; Sat, 27 Jul 2019 02:58:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hrGeR-0000ta-An; Sat, 27 Jul 2019 02:57:55 -0400 Received: from [176.228.60.248] (port=3517 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hrGeP-00060Z-QJ; Sat, 27 Jul 2019 02:57:54 -0400 Date: Sat, 27 Jul 2019 09:57:50 +0300 Message-Id: <83blxgm0b5.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: (message from Lars Ingebrigtsen on Fri, 26 Jul 2019 21:35:14 +0200) Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> <83h878mzjc.fsf@gnu.org> <83ef2cmwji.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, monnier@iro.umontreal.ca, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Stefan Monnier , 36803@debbugs.gnu.org, > kevin.legouguec@gmail.com > Date: Fri, 26 Jul 2019 21:35:14 +0200 > > Eli Zaretskii writes: > > > If the call to force-mode-line-update is the solution you suggest, > > then I think it is not a good solution. We cannot rely in a call to > > force-mode-line-update, because there's the default sentinel, and > > because it's unreasonable to request each sentinel written in Lisp to > > make that call. If every sentinel must do that, then the core should > > do that for them. > > Well, when I was looking at where to move the "Compiling" > sort-of-lighter (from out of minor-mode-alist where it didn't belong), I > was looking for other modes that display things in mode lines in all > buffers -- and there doesn't seem to be many. I'm not talking about just any change to the mode line. I'm talking specifically about the process status indicator there. The process status change is detected by the C code, so that's where we should make sure the mode line gets updated regarding the process status. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 03:46:52 2019 Received: (at 36803) by debbugs.gnu.org; 27 Jul 2019 07:46:52 +0000 Received: from localhost ([127.0.0.1]:43567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrHPn-0002Rq-P2 for submit@debbugs.gnu.org; Sat, 27 Jul 2019 03:46:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrHPm-0002Re-5M for 36803@debbugs.gnu.org; Sat, 27 Jul 2019 03:46:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hrHPf-00087r-VK; Sat, 27 Jul 2019 03:46:44 -0400 Received: from [176.228.60.248] (port=2499 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hrHPf-0002GN-E7; Sat, 27 Jul 2019 03:46:43 -0400 Date: Sat, 27 Jul 2019 10:46:38 +0300 Message-Id: <83a7czncm9.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Fri, 26 Jul 2019 17:10:40 -0400) Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> <83h878mzjc.fsf@gnu.org> <83ef2cmwji.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com > Date: Fri, 26 Jul 2019 17:10:40 -0400 > > >> Right: there are 2 windows displaying the original buffer, plus a third > >> one displaying the compilation buffer. The C code for process sentinels > >> makes sure that the mode-line of the window showing the compilation > >> buffer get updated (for the benefit of mode-line-process, presumably), > >> but none of the others. > >> As it so happens, one of the others also gets updated because it's the > >> currently selected_window. > > > > That's not what happens. What happens is that one of the windows > > still shows "Compiling" after the process exits. > > AFAIK this is indeed just what I describe in the previous paragraph > (i.e. at the end of the compilation, when the sentinel is run, the > C part of the sentinel processing causes the refresh of the mode-line > of the window showing the compilation buffer, the redisplay itself will > on its own accord decide to refresh the selected window's mode-line, > but the third window's mode-line is not refreshed because noone tells > the C code that all mode-lines indicated the status of this specific > process). Yes. And if you add to the recipe yet another, unrelated buffer displayed in the 4th window, then its mode line will also show "Compiling" if that buffer is not the current buffer when "M-x compile" is invoked. > > But right now the mode line of *scratch* does show "Compiling" > > in all of its windows, so there's a global setting that is updated > > when the process starts and ends, > > Indeed. > > > and that change isn't triggering the update of mode lines in all the > > windows showing *scratch*. I still don't understand how you explain > > that inconsistency. > > Very simple: the change in the mode-line is caused by a change to the > `compilation-in-progress` global variable. Yet, the mode-line > infrastructure is not setup to track dependencies on variables; instead > it's traditionally the responsability of the code which sets this > variable to explicitly call force-mode-line-update (as is done, for > example in all minor-modes (from within `define-minor-mode`)). The variable compilation-in-progress is specific to compile.el. However, the problem its use exposes is more general, and the general problem cannot IMO be reasonably put under the responsibility of the code which could cause it (and I don't really agree with the "traditional" part above). More about this below. > > If the call to force-mode-line-update is the solution you suggest, > > then I think it is not a good solution. We cannot rely in a call to > > force-mode-line-update, because there's the default sentinel, and > > The default sentinel does not modify `compilation-in-progress` (nor any > other global variable for that matter), so there's never any need to > update all the mode-lines at the end of a process using the default sentinel. > > > because it's unreasonable to request each sentinel written in Lisp to > > make that call. If every sentinel must do that, then the core should > > do that for them. > > Not all sentinels must so that. Only those which set global variables > whose content affects the mode-line of "all" windows (not necessarily > all, tho, but at least more than just the mode lines of the current > buffer). And that brings me right back to the beginning. In response to my original question, you said: > Hmm... AFAIK the "process status" normally only indicates the status of > the process running in the buffer to which this mode line belongs. > Which is why I made the change to only bset_update_mode_line rather than > set the global update_mode_lines. This is true only if the process status is modified via mode-line-process, which is a buffer-local variable. If a Lisp program modifies the mode line directly, the result will be global. That's what compile.el does via compilation-in-progress, but the most basic operation is simply to add %s to mode-line-format (or to header-line-format or even to frame-title-format). When a Lisp program or the user does that, I see no way of keeping that indicator up to date except trigger mode-line updates in all windows in status_notify. Any other method will be simply unreliable. Am I missing something? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 05:54:05 2019 Received: (at 36803) by debbugs.gnu.org; 27 Jul 2019 09:54:05 +0000 Received: from localhost ([127.0.0.1]:43598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrJOv-0005LE-DO for submit@debbugs.gnu.org; Sat, 27 Jul 2019 05:54:05 -0400 Received: from quimby.gnus.org ([80.91.231.51]:35320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrJOt-0005L3-1M for 36803@debbugs.gnu.org; Sat, 27 Jul 2019 05:54:03 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrJOl-0005zX-9W; Sat, 27 Jul 2019 11:53:57 +0200 From: Lars Ingebrigtsen To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> <83h878mzjc.fsf@gnu.org> <83ef2cmwji.fsf@gnu.org> <878sskqyfx.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAADFBMVEWRdqF1WH1RM1JkRmon GwKsAAACOklEQVQokR2OTWsTURiFz2CGrIQUG7qwMSv3FupCRZxgQnQRyNA7DbWJWbnouEgXCf2c zq8ILsSPjWDv2BTED5qQjuhWQTSTa21idmpuaArSNjbpdLzx3T2ccx5exLI1leWnKvbhvAZvxV04 dVMd7zDlwFzreZ7HPN5baCJhuuXygFldu1tF6PwetT02ON3k6zgb/u1VvJTLivoQGqxTYR47yDm4 vUSY5cab2UJpHaGZfH3fjR+bLt+CYQSm3Yy/arjdEywZATVDPhybhvcNM4mkEiQxd8ExD3AtAcgk vnpXyy1isDMa8RfktKaEF5E91lR5NRKKKSPA7Epa1Ygc1ZIBIJytRYhP8gVVAZmbzlQSAoiA68HC lAJh1MTmCjH/Q3BkwocVLav+T6QbSSxfbn2N+gBJGqth2fT+ECIpsiQKfbNT/5SPNGTfpXn02+WX AohQAFyn73fyMSIJCfSMF98dUZMSggRzoXBqZ1xyJEXUZjOcuZMRIitjUWHb7s3kITaj4+DN/s9B Xo5KvnO3QBv60VbbeRSDlETf4KVKJ9OMKf5xDNo6rfCWbb+bEO+0S2+3+cOqkb76GX33F/vR2bVP Exefg78osHouu9WLzn8EX3/GWtp0lTkXNsCtzS/O5Jnik1pwFZxaR/Y9LLUOA1GRWLQ8p/grzv00 6PCs+iuzqDcgAlrOsY07D7o10CHw4t73N/wvdEp5iT9+WqKWImxUX8vVh8s2+pTuh7O9IRygbNHX 8tj0EE7+AUesJ9QiKiRFAAAAAElFTkSuQmCC Date: Sat, 27 Jul 2019 11:53:55 +0200 In-Reply-To: <878sskqyfx.fsf@gmail.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Fri, 26 Jul 2019 23:26:58 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Kévin Le Gouguec writes: > Mmm, I guess the rationale is that since > > 1. the user may bury the compilation buffer if the process takes a long > time, > > 2. the user may miss the "Compilation finished" message (e.g. it can [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) K=C3=A9vin Le Gouguec writes: > Mmm, I guess the rationale is that since > > 1. the user may bury the compilation buffer if the process takes a long > time, > > 2. the user may miss the "Compilation finished" message (e.g. it can be > hidden by any movement command that triggers a "Mark set" message), > > The only reliable way to inform the user that the compilation process is > still running is to spray all mode-lines with an indicator=E2=80=A6 I guess... but it's not like Emacs doesn't have a lot of things that run asynchronously. Very few of them alter the mode-line in all the modes. erc does, and that's very useful (it notifies you that somebody's sent you a message, for instance), but the compilation thing just doesn't seem that... urgent? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 08:46:50 2019 Received: (at 36803) by debbugs.gnu.org; 27 Jul 2019 12:46:50 +0000 Received: from localhost ([127.0.0.1]:43845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrM66-00013H-0j for submit@debbugs.gnu.org; Sat, 27 Jul 2019 08:46:50 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrM62-0000wY-U4 for 36803@debbugs.gnu.org; Sat, 27 Jul 2019 08:46:48 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EA0A2101AF6; Sat, 27 Jul 2019 08:46:40 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4A113100B8F; Sat, 27 Jul 2019 08:46:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1564231599; bh=NVysK5kp1ziSrEI9HKyu4zLIIwVrQWtQTYWkxw/9KxA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=E80UYrxBGQn3H+xGHxGe++i4a0fkhK8HE1m+cKvmEu77xhE+x4tt1tHKR5qCZQ4tw Kh+4J8IcJqgyb30ENnsagaPmbf1bFaWeeL48pR4DSspfuGQIcGxuITP9EEEERXkKg9 SHcKJutf04f8rNkgBL6ZJAwQ8FvJSeb4u5xzaPg351oaoTDcw31Y2FXR3g83YLXM5u 9P+NAH8mGkb01ORzTuptj9TXGuWyIaBSfQXPsfccayuthB55DgeZueU3nYRpqYpGKV jQ1Le5LDjfOYabEJFoeX1DHFCp5+JTiSKW+pldnUkWwZcV5Lm/BIOiN5QI2z/jMj9P M5TjTzo6TG7Gw== Received: from pastel (unknown [216.154.19.233]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F14EB12081F; Sat, 27 Jul 2019 08:46:38 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends Message-ID: References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> <83h878mzjc.fsf@gnu.org> <83ef2cmwji.fsf@gnu.org> <83a7czncm9.fsf@gnu.org> Date: Sat, 27 Jul 2019 08:46:35 -0400 In-Reply-To: <83a7czncm9.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Jul 2019 10:46:38 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Yes. And if you add to the recipe yet another, unrelated buffer > displayed in the 4th window, then its mode line will also show > "Compiling" if that buffer is not the current buffer when "M-x > compile" is invoked. Yes, with 100 windows, 98 of them will stay stale. > And that brings me right back to the beginning. In response to my > original question, you said: > >> Hmm... AFAIK the "process status" normally only indicates the status of >> the process running in the buffer to which this mode line belongs. >> Which is why I made the change to only bset_update_mode_line rather than >> set the global update_mode_lines. > > This is true only if the process status is modified via > mode-line-process, which is a buffer-local variable. If a Lisp > program modifies the mode line directly, the result will be global. > That's what compile.el does via compilation-in-progress, but the most > basic operation is simply to add %s to mode-line-format (or to > header-line-format or even to frame-title-format). That's not a problem: %s only shows the status *of the process in the current buffer*: the status of a process in buffer A is never reflected in the %s part of the mode-line of other buffers, which is why the sentinel code only causes a mode-line update for the process's buffer. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 09:13:18 2019 Received: (at 36803) by debbugs.gnu.org; 27 Jul 2019 13:13:18 +0000 Received: from localhost ([127.0.0.1]:43872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrMVh-0002Ky-Nj for submit@debbugs.gnu.org; Sat, 27 Jul 2019 09:13:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrMVf-0002Kl-Uw for 36803@debbugs.gnu.org; Sat, 27 Jul 2019 09:13:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hrMVa-00051G-Hv; Sat, 27 Jul 2019 09:13:10 -0400 Received: from [176.228.60.248] (port=3227 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hrMVZ-0003hn-L0; Sat, 27 Jul 2019 09:13:10 -0400 Date: Sat, 27 Jul 2019 16:12:59 +0300 Message-Id: <83tvb7lixw.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Sat, 27 Jul 2019 08:46:35 -0400) Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> <83h878mzjc.fsf@gnu.org> <83ef2cmwji.fsf@gnu.org> <83a7czncm9.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com > Date: Sat, 27 Jul 2019 08:46:35 -0400 > > >> Hmm... AFAIK the "process status" normally only indicates the status of > >> the process running in the buffer to which this mode line belongs. > >> Which is why I made the change to only bset_update_mode_line rather than > >> set the global update_mode_lines. > > > > This is true only if the process status is modified via > > mode-line-process, which is a buffer-local variable. If a Lisp > > program modifies the mode line directly, the result will be global. > > That's what compile.el does via compilation-in-progress, but the most > > basic operation is simply to add %s to mode-line-format (or to > > header-line-format or even to frame-title-format). > > That's not a problem: %s only shows the status *of the process in the > current buffer*: the status of a process in buffer A is never > reflected in the %s part of the mode-line of other buffers, which is why > the sentinel code only causes a mode-line update for the process's buffer. If there's no way for a Lisp program to inject a global process-status element into the mode line, then I guess your patch is TRT, indeed. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 10:00:58 2019 Received: (at 36803-done) by debbugs.gnu.org; 27 Jul 2019 14:00:58 +0000 Received: from localhost ([127.0.0.1]:45069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrNFp-0000X9-RB for submit@debbugs.gnu.org; Sat, 27 Jul 2019 10:00:58 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrNFo-0000QL-NK for 36803-done@debbugs.gnu.org; Sat, 27 Jul 2019 10:00:57 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 35B31102D76; Sat, 27 Jul 2019 10:00:51 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 31B621013C1; Sat, 27 Jul 2019 10:00:50 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1564236050; bh=MVK1r7KMNkVeHuOdwbna23IbEPFsmC/QF6ilfrhmNg0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KKk1ihQVYJI1ySHHo2QDKsRO5UDTy5lflAQT2gvwzzMbnI6sgT6zUZ8gxnz7s0lWc DMeTlNzChwqKUWb6knmbhiaCyM6egSWkE2u4nn3R2ef5ffAjOWKL3ke7N9UVhR2krt 70QjRrBPhY/l7boss8t0Lvx0lzV9DVBNZHV8Ik8ceWGfqCl4jNhWDYt4UTOEoN/5a4 UFtSzfQDFdbEaOXG6/7P7TiOVWUYcOgHa2cej/zmVkzIpYqqTOOpJQmpEsnFrt02NC 9d7GKhkAMYGbNHv3SxwUQuhSUuXVi+xOugQvZMesbpPKiqG87uQB+MfbWkJinivTf4 URncJhKH8mvTA== Received: from pastel (unknown [216.154.19.233]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 576E7120F3E; Sat, 27 Jul 2019 10:00:49 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends Message-ID: References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> <83h878mzjc.fsf@gnu.org> <83ef2cmwji.fsf@gnu.org> <83a7czncm9.fsf@gnu.org> <83tvb7lixw.fsf@gnu.org> Date: Sat, 27 Jul 2019 10:00:46 -0400 In-Reply-To: <83tvb7lixw.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Jul 2019 16:12:59 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36803-done Cc: larsi@gnus.org, 36803-done@debbugs.gnu.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > If there's no way for a Lisp program to inject a global process-status > element into the mode line, then I guess your patch is TRT, indeed. Thanks, installed, Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 13:02:05 2019 Received: (at 36803) by debbugs.gnu.org; 27 Jul 2019 17:02:05 +0000 Received: from localhost ([127.0.0.1]:45333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrQ57-0005ok-4A for submit@debbugs.gnu.org; Sat, 27 Jul 2019 13:02:05 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:45016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrQ55-0005o6-1p for 36803@debbugs.gnu.org; Sat, 27 Jul 2019 13:02:03 -0400 Received: by mail-wr1-f47.google.com with SMTP id p17so57456258wrf.11 for <36803@debbugs.gnu.org>; Sat, 27 Jul 2019 10:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=qlNUEqMuwW99AAANEPCJDRx9GjRy9DD1+Pj+SYXAhGY=; b=Pb+uCeKtzozyqrtoaFRbqirYx6MTLuSRetKKo/JErJu/ow/ZnB/DVB/1CMVLsFJgPK UFljCUrTFd1Hm49ZlTfl2Deudl66rEZ2oVwqFHaLOFSwNVRCorAF90S9u9tETRoiThm1 w32hUHSB2keoXIKV+Wh00PqKrqCFUWkCy9TAK+YDOKl0/jijKRgwyLH/Zdu8V6FXB4fE BceOlpMGlKIuZzlgq+vZBtjwElNc5JkRwyHHWzSImBJTv3Dp8IjE1DQVwG1HbPUAyO2C 2myhv2eSDEdvPrWE31PzJ9EL89/KorKJNj+jsm33KN1N81K+J6j9IBZg99Oo8jf1FKh7 Wk4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=qlNUEqMuwW99AAANEPCJDRx9GjRy9DD1+Pj+SYXAhGY=; b=COfd5xc1WYIFsXh7Z8GB3NS6Ur3GKpkuhWtjUTrIFjR1sFZHW0GI5Ngv6T4W5Mx+u5 jSPR0Cx93q7H1ZaI5y8pbS7OdsZeFai0ikky/PcNOlyXeR5fRer666bW2u/Ob/B3CvJN F0H7Hd8eE8DK3Yl01ijYW+3CNGLypOmdga80bHNs4tWTfb9zLDQb5BlxQEfahgH2dR26 kUIhaK6Vi1moMDjrSgnohBKxTaKL4vV2Gfmu3JiONcEv7S2I+6yoV30pI3LTggLal65e K+Ey5Miux1uarHMNKfLJNXcriUY7BL1g7dononbNqh2kFM9rwteOZVNjFgjVB8z1PWeP wORA== X-Gm-Message-State: APjAAAV64O6t8pD0tCgK70cGoIfbHGkzgetHlE52ggETu6Fgyuy2pR/+ X/z/2mz+2GLwqIkkXlS3mz+gaPoFefs= X-Google-Smtp-Source: APXvYqzb9yzu42OZWR55+oTmvuF5bBSwVv91G2BmivVEQk7byIb9SeZl+TH82ypyV2K0GkmpcrPsUw== X-Received: by 2002:adf:f206:: with SMTP id p6mr36852719wro.216.1564246916993; Sat, 27 Jul 2019 10:01:56 -0700 (PDT) Received: from nc10-laptop (2a01cb04010fc800c8771fb97d0446e3.ipv6.abo.wanadoo.fr. [2a01:cb04:10f:c800:c877:1fb9:7d04:46e3]) by smtp.gmail.com with ESMTPSA id k17sm68821943wrq.83.2019.07.27.10.01.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 27 Jul 2019 10:01:56 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Lars Ingebrigtsen Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> <83h878mzjc.fsf@gnu.org> <83ef2cmwji.fsf@gnu.org> <878sskqyfx.fsf@gmail.com> Date: Sat, 27 Jul 2019 19:01:55 +0200 In-Reply-To: (Lars Ingebrigtsen's message of "Sat, 27 Jul 2019 11:53:55 +0200") Message-ID: <874l37qum4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36803 Cc: 36803@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > K=C3=A9vin Le Gouguec writes: > >> The only reliable way to inform the user that the compilation process is >> still running is to spray all mode-lines with an indicator=E2=80=A6 > > I guess... but it's not like Emacs doesn't have a lot of things that > run asynchronously. Very few of them alter the mode-line in all the > modes. > > erc does, and that's very useful (it notifies you that somebody's sent > you a message, for instance), but the compilation thing just doesn't > seem that... urgent? Mmm=E2=80=A6 I was about to say that since I often wait on compilation processes to validate something before committing changes or sending an email, I'd rather be notified immediately, but updating the mode-line to remove the indicator is actually not that informative. I still need to bring up the compilation buffer to know whether the process succeeded=E2=80= =A6 So maybe cluttering every mode-line does not actually help that much, indeed. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 13:37:56 2019 Received: (at 36803-done) by debbugs.gnu.org; 27 Jul 2019 17:37:56 +0000 Received: from localhost ([127.0.0.1]:45385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrQdo-0000g1-3B for submit@debbugs.gnu.org; Sat, 27 Jul 2019 13:37:56 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:40180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrQdm-0000fU-Dm for 36803-done@debbugs.gnu.org; Sat, 27 Jul 2019 13:37:54 -0400 Received: by mail-wm1-f43.google.com with SMTP id v19so50130284wmj.5 for <36803-done@debbugs.gnu.org>; Sat, 27 Jul 2019 10:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=soHTxDJshgeIAk5vQTxeWEHGtZt7O0I7xKgqBgqy/Yk=; b=UcXltWIrj5c/GeSOtQQvdERAfAjg9Zlfxb90B2hRL050NcNvt5kiy/h/LLwyzbZ0lp kkw/mzxZIyAy8hXmI0yJLEZwdAV3BLDzS/Zubs1jaRfW9GkMNUgMMxJHoXsmB4ercdRp NRm20Rx2g/z5dwS9DLvqGjXtIzE6OmSN2Qp3TqvbXHtPrpkXv6/s3QLQ2lV8sH+74rsL ThWomoIJ2hFdy9+yOjaiuh1jsphKdc3RpjdvZq4rriLN/DGQMHxUX9UnhySihSigjBOM laiSuP7EvoK28tVWMI1khicqJjMYMGUTZc0jJq8kbj1OwhoCbaLdC3kWK+hT9AIt8PtI 3ZOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=soHTxDJshgeIAk5vQTxeWEHGtZt7O0I7xKgqBgqy/Yk=; b=dBOvmXZt8oQi5X0kV643kOMeyc3EcHSqCIDkV3M4KOxi3dn1hcj+COfQeQWDjWhdo/ Ptees+7UqcAvV4fiZ06NDrHoLtlFq3zFADWwT52vdBE+oyDtkNEmHF8UB2UmcjHZoSYI cO8QU6VFoLQTdglSkl9/vOmQK7yDZfp3Q9l1xgx1pUYLSRn5BZMjaBuxXZjwIhLreRKL XbTVsEWp2DwyaM3LeIneIOApI9Mf4cr/AyhDwP3HsKwrjqF/rMONd8pmzrlEh/L/sul2 C0W8x+av1TsuFOZ+yRL+mioJVlFCzvCO6AvcQDthHEMzSPhpM0MBxNZdPf4MmICCdacZ SjZA== X-Gm-Message-State: APjAAAWUanPKPGgffdc/MtcC6PyhtuWlWOvkO1qgrLG4Dut+RePTrmCE fXpv0qLHCMIvVnVvuMshdt8= X-Google-Smtp-Source: APXvYqykprJu66TPoaDjOQhNx0EKz1DJY+V2mw0KnDptngiAITKCXzillvVt7RMqSP0+hevStfYDeg== X-Received: by 2002:a1c:f914:: with SMTP id x20mr12596872wmh.142.1564249068579; Sat, 27 Jul 2019 10:37:48 -0700 (PDT) Received: from nc10-laptop (2a01cb04010fc800c8771fb97d0446e3.ipv6.abo.wanadoo.fr. [2a01:cb04:10f:c800:c877:1fb9:7d04:46e3]) by smtp.gmail.com with ESMTPSA id w67sm72805882wma.24.2019.07.27.10.37.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 27 Jul 2019 10:37:47 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Stefan Monnier Subject: Re: bug#36803: 27.0.50; Update mode-line of every window when compilation ends References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> <83h878mzjc.fsf@gnu.org> <83ef2cmwji.fsf@gnu.org> <83a7czncm9.fsf@gnu.org> <83tvb7lixw.fsf@gnu.org> Date: Sat, 27 Jul 2019 19:37:47 +0200 In-Reply-To: (Stefan Monnier's message of "Sat, 27 Jul 2019 10:00:46 -0400") Message-ID: <87pnlvpedw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36803-done Cc: Eli Zaretskii , 36803-done@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > Thanks, installed, > > > Stefan Thank you all for getting to the bottom of this issue! AFAICT the committed patch works fine. From unknown Sat Sep 20 08:01:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 25 Aug 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator