GNU bug report logs - #36780
26.1; request: savehist should also save log-edit-comment-ring by default

Previous Next

Full log

Message #14 received at 36780 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: emacsuser <at> freemail.hu, 36780 <at> debbugs.gnu.org
Subject: RE: bug#36780: 26.1; request:  savehist should also save
 log-edit-comment-ring by default
Date: Fri, 23 Aug 2019 11:04:01 -0700 (PDT)

> > `savehist-additional-variables' is explicitly reserved for users to
> > add stuff to, so I don't think it'd be appropriate for log-edit.el
> > to add anything to it.

+1

> I don't see why the solution of customizing
> savehist-additional-variables by the user is not the right one.
> After all, we are not talking about minibuffer history here.

+1

> The savehist package defines itself as being for "saving the
> minibuffer history".  What you suggest makes it a much more general
> facility, and we then would need to review many other variables and
> decide whether they are candidates for saving (some of them are
> already saved by separate features).  Maybe we should do that, but
> that's a much broader issue than this particular bug report.

YAGNI.  Emacs doesn't need to pre-populate a list
of variables to save.  `savehist-additional-variables'
is the right way (for users) to save variables, IMO.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.