GNU bug report logs - #36763
`guix search` does unexpected logical and

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#36763: closed (`guix search` does unexpected logical and)
Date: Thu, 19 Sep 2019 19:57:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 19 Sep 2019 21:56:05 +0200
with message-id <87ef0cysa2.fsf <at> gnu.org>
and subject line Re: bug#36763: `guix search` does unexpected logical and
has caused the debbugs.gnu.org bug report #36763,
regarding `guix search` does unexpected logical and
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
36763: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36763
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: zimoun <zimon.toutoune <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: `guix search` does unexpected logical and
Date: Mon, 22 Jul 2019 19:11:50 +0200

[Message part 3 (text/plain, inline)]

Dear,

As discussed here [1], the `relevance` in `guix/ui.scm` does not match
"inter-field".

Attached a fix.
Now,  the example from the manual
  $ guix search crypto library | \
        recsel -e '! (name ~ "^(ghc|perl|python|ruby)")' -p name,synopsis
outputs the expected crypto libraries as `libb2`.


Please comment. :-)


Then, please indicate me how the commit has to be filled.
The commit 8874faaaac665100a095ef25e39c9a389f5a397f introducing the
logical AND says:

ui: 'relevance' considers regexps connected with a logical and.

* guix/ui.scm (relevance)[score]: Change to return 0 when one of REGEXPS
doesn't match.
* tests/ui.scm ("package-relevance"): New test.

Should another test be added?


[1] https://lists.gnu.org/archive/html/guix-devel/2019-07/msg00263.html


Thank you in advance,
simon

[search.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 36763-done <at> debbugs.gnu.org
Subject: Re: bug#36763: `guix search` does unexpected logical and
Date: Thu, 19 Sep 2019 21:56:05 +0200

Hello,

zimoun <zimon.toutoune <at> gmail.com> skribis:

> On Mon, 16 Sep 2019 at 10:17, Ludovic Courtès <ludo <at> gnu.org> wrote:
>
>> Bonus points if you send the patch with ‘git format-patch’ and with a
>> commit log:
>
> I did my best here:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37448
>
> Hope I am doing right.

Yup!

We can close it now, thank you.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.