Subject: bug#36752: closed (Re: [bug#36752] [PATCH 0/2] git-annex: Don't patch hook shebangs and update version)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 08 Aug 2019 18:23:02 +0000

Your bug report

#36752: [PATCH 0/2] git-annex: Don't patch hook shebangs and update version

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
36752: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36752
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#36752] [PATCH 0/2] git-annex: Don't patch hook shebangs and update version
From: Marius Bakke <[email-masked]>
To: Kyle Meyer <[email-masked]>, [email-masked]
Date: Thu, 08 Aug 2019 20:22:04 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Kyle Meyer <[email-masked]> writes:

> The git-annex definition patches the snippet that git-annex uses as the
> shebang when creating its Git hooks.  As discussed previously [1], this is
> problematic because the hooks refer to a bash that may later be garbage
> collected.
>
> However, a large number of the tests fail if we simply don't patch the shebang
> because the hooks of course can't find the unpatched "/bin/sh" in the build
> environment [2].  The first patch updates the definition to use a "patch,
> build, test, revert patch, re-build" sequence.  It's not pretty, but it
> certainly seems better than disabling the tests.  Please let me know if you
> have suggestions for a cleaner approach.
>
> The second patch updates git-annex to its latest version.
>
> [1] https://lists.gnu.org/archive/html/guix-devel/2018-08/msg00142.html
> [2] https://lists.gnu.org/archive/html/guix-devel/2019-02/msg00012.html
>
> Kyle Meyer (2):
>   gnu: git-annex: Don't patch shebang used in hooks.
>   gnu: git-annex: Update to 7.20190708.

Thank you for fixing the shebang bug, and for updating the package.

Applied both, thanks!

Subject: [PATCH 0/2] git-annex: Don't patch hook shebangs and update version
From: Kyle Meyer <[email-masked]>
To: [email-masked]
Cc: Timothy Sample <[email-masked]>, Kyle Meyer <[email-masked]>
Date: Sun, 21 Jul 2019 15:46:26 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

The git-annex definition patches the snippet that git-annex uses as the
shebang when creating its Git hooks.  As discussed previously [1], this is
problematic because the hooks refer to a bash that may later be garbage
collected.

However, a large number of the tests fail if we simply don't patch the shebang
because the hooks of course can't find the unpatched "/bin/sh" in the build
environment [2].  The first patch updates the definition to use a "patch,
build, test, revert patch, re-build" sequence.  It's not pretty, but it
certainly seems better than disabling the tests.  Please let me know if you
have suggestions for a cleaner approach.

The second patch updates git-annex to its latest version.

[1] https://lists.gnu.org/archive/html/guix-devel/2018-08/msg00142.html
[2] https://lists.gnu.org/archive/html/guix-devel/2019-02/msg00012.html

Kyle Meyer (2):
  gnu: git-annex: Don't patch shebang used in hooks.
  gnu: git-annex: Update to 7.20190708.

 gnu/packages/haskell-apps.scm | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

-- 
2.22.0