GNU bug report logs - #36751
[PATCH] gnu: Add emacs-hyperbole.

Previous Next

Package: guix-patches;

Reported by: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>

Date: Sun, 21 Jul 2019 19:38:02 UTC

Severity: normal

Tags: patch

Done: Jakub Kądziołka <kuba <at> kadziolka.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: swedebugia <swedebugia <at> riseup.net>
To: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>, 36751 <at> debbugs.gnu.org
Subject: [bug#36751] [PATCH] gnu: Add emacs-hyperbole.
Date: Tue, 6 Aug 2019 13:32:50 +0200
Hi!

Thanks for the patch.

On 2019-08-03 06:16, LaFreniere, Joseph wrote:
> I have squashed the fixup into the original commit and rebased on 
> current master (82ebb785f178d8618d39b658932d23d9f859fc91).  The 
> resulting commit is attached.
>
>
> -- 
> Joseph LaFreniere

Git said this:

$ git apply 0001-gnu-Add-emacs-hyperbole.patch
0001-gnu-Add-emacs-hyperbole.patch:122: space before tab in indent.
         (or (and (boundp 'user-mail-address)
0001-gnu-Add-emacs-hyperbole.patch:123: trailing whitespace.
-- 
0001-gnu-Add-emacs-hyperbole.patch:149: trailing whitespace.

0001-gnu-Add-emacs-hyperbole.patch:155: space before tab in indent.
      (dname (or (and (boundp 'message-user-fqdn) (stringp 
message-user-fqdn)
0001-gnu-Add-emacs-hyperbole.patch:156: space before tab in indent.
              (string-match "\\." message-user-fqdn)
warning: squelched 10 whitespace errors
warning: 15 lines add whitespace errors.

---

Could you take a look at that?

Otherwise LGTM.

(I linted it, inspected the output in the store with 'ls -lR' and opened 
the info file)

-- 
Cheers Swedebugia




This bug report was last modified 4 years and 338 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.