Subject: Re: [bug#36744] [PATCH 1/1] gnu: Add cutter.

From: Marius Bakke <[email-masked]>
Date: Thu, 08 Aug 2019 20:24:32 +0200

"Jovany Leandro G.C" <[email-masked]> writes:

> * gnu/packages/engineering.scm (cutter): New variable.

[...]

> +(define-public cutter
> +  (package
> +    (name "cutter")
> +    (version "1.8.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri  (string-append
> +              "https://github.com/radareorg/cutter/archive/v"
> +              version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1nhzwqavb156bqxk723i6an6iaagm3hs7642ijbma4hgl32lw0bi"))))

I changed this to use a git checkout, because the auto-generated GitHub
tarballs may change hash in the future.

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'configure
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out"))
> +                   (radare2 (assoc-ref inputs "radare2")))
> +               ;; fix pkg-config detection ./src/lib_radare2.pri:PREFIX=/usr/lib
> +               ;; override `qmake PREFIX=`
> +               (substitute* "./src/lib_radare2.pri"
> +                 (("PREFIX") "R2PREFIX")
> +                 (("R2PREFIX=/usr") (string-append "R2PREFIX=" radare2)))
> +               (invoke "qmake"
> +                       (string-append "PREFIX=" out)
> +                       "./src/Cutter.pro")))))))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("qtbase" ,qtbase)
> +       ("qtsvg" ,qtsvg)
> +       ("openssl" ,openssl)
> +       ("radare2" ,radare2)))
> +    (home-page "https://github.com/radareorg/cutter")
> +    (synopsis "Free and open-source GUI for radare2 reverse engineering framework")
> +    (description "Cutter is a free and open-source GUI for radare2 reverse
> +engineering framework.  Its goal is making an advanced, customizable and
> +FOSS reverse-engineering platform while keeping the user experience at mind.
> +Cutter is created by reverse engineers for reverse engineers.")

I removed mentions of "free" and "open source", because everything in
Guix is free software.

> +    (license license:gpl3+)))

I also added the CC-BY-SA 3.0 license used by the icon set.

Pushed in 5cded306f92a8641259909ee986e583168b85b17, thanks!