GNU bug report logs - #36741
26.2.90; view-mode: Update docstring

Previous Next

Package: emacs;

Reported by: Tino Calancha <tino.calancha <at> gmail.com>

Date: Sat, 20 Jul 2019 13:46:01 UTC

Severity: normal

Tags: patch

Found in version 26.2.90

Done: Tino Calancha <tino.calancha <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#36741: closed (26.2.90; view-mode: Update docstring)
Date: Fri, 26 Jul 2019 15:43:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 26 Jul 2019 17:42:26 +0200 (CEST)
with message-id <alpine.DEB.2.21.1907261740170.875 <at> calancha-pc.dy.bbexcite.jp>
and subject line Re: bug#36741: 26.2.90; view-mode: Update docstring
has caused the debbugs.gnu.org bug report #36741,
regarding 26.2.90; view-mode: Update docstring
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
36741: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36741
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Tino Calancha <tino.calancha <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.2.90; view-mode: Update docstring
Date: Sat, 20 Jul 2019 15:45:13 +0200

The mention to kill buffers in this context is likely an original
implementation detail; nowadays, Emacs saves the killed text in variables.

Either way for the purpose to document this mode, the way how the text
is stored is not relevant.

--8<-----------------------------cut here---------------start------------->8---
From 54267d85f3418e0cb4cb1009fcd4e680bfda6825 Mon Sep 17 00:00:00 2001
From: Tino Calancha <tino.calancha <at> gmail.com>
Date: Sat, 20 Jul 2019 15:23:38 +0200
Subject: [PATCH] * lisp/view.el (view-mode): Update docstring.

---
 lisp/view.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/view.el b/lisp/view.el
index 3d423f1748..5e6f3e2caa 100644
--- a/lisp/view.el
+++ b/lisp/view.el
@@ -386,8 +386,8 @@ view-mode
 if ARG is omitted or nil.
 
 When View mode is enabled, commands that do not change the buffer
-contents are available as usual.  Kill commands insert text in
-kill buffers but do not delete.  Most other commands beep and
+contents are available as usual.  Kill commands save text but
+do not delete it from the buffer.  Most other commands beep and
 tell the user that the buffer is read-only.
 
 \\<view-mode-map>
-- 
2.20.1

--8<-----------------------------cut here---------------end--------------->8---

In GNU Emacs 26.2.90 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.5)
Repository revision: 021f32cca1b9082e7219b06aee28c00c4323a72a
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description:	Debian GNU/Linux 10 (buster)


[Message part 3 (message/rfc822, inline)]
From: Tino Calancha <tino.calancha <at> gmail.com>
To: 36741-done <at> debbugs.gnu.org
Subject: Re: bug#36741: 26.2.90; view-mode: Update docstring
Date: Fri, 26 Jul 2019 17:42:26 +0200 (CEST)

On Thu, 25 Jul 2019, Noam Postavsky wrote:

> Tino Calancha <tino.calancha <at> gmail.com> writes:
>> `kill-rectangle' won't save the text in the kill ring by default.
>
> I think your patch is good, you should push to emacs-26 (perhaps also 
> mention the above point in the  commit message though).

Pushed into emacs-26 branch with commit 'Update view-mode docstring'
(d4c49875eaae3078ea3b51cc7b72ae3403cb2c04)




This bug report was last modified 5 years and 302 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.