From unknown Wed Jun 18 22:49:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#36739 <36739@debbugs.gnu.org> To: bug#36739 <36739@debbugs.gnu.org> Subject: Status: [PATCH] maint: fix issues in syntax-check Reply-To: bug#36739 <36739@debbugs.gnu.org> Date: Thu, 19 Jun 2025 05:49:45 +0000 retitle 36739 [PATCH] maint: fix issues in syntax-check reassign 36739 coreutils submitter 36739 Akim Demaille severity 36739 normal tag 36739 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 20 03:28:17 2019 Received: (at submit) by debbugs.gnu.org; 20 Jul 2019 07:28:17 +0000 Received: from localhost ([127.0.0.1]:56779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hojmr-0007Fy-Dm for submit@debbugs.gnu.org; Sat, 20 Jul 2019 03:28:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:35807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hojmk-0007Fh-3q for submit@debbugs.gnu.org; Sat, 20 Jul 2019 03:28:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39167) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hojmi-0000Wi-KY for bug-coreutils@gnu.org; Sat, 20 Jul 2019 03:28:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hojmh-0008OA-2T for bug-coreutils@gnu.org; Sat, 20 Jul 2019 03:28:00 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:38218) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hojmg-0008Na-S2 for bug-coreutils@gnu.org; Sat, 20 Jul 2019 03:27:59 -0400 Received: by mail-wm1-x342.google.com with SMTP id s15so9495102wmj.3 for ; Sat, 20 Jul 2019 00:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=mVjl00t/5PRl7rdzPZTRVIHSfHgvjG9V8ro5Mngvq30=; b=jTrI0FE6vYixqf9JTf9hF8Pe76gmQE3iVUlRF8LDGMR1DARTRNVQfjlteC6MifmK4O p5wDxRbRyQXOgPeAe3bRVSXDhTvIyhbyUAFgLeqNbscVk3W9eIK3LBrRO7xG2fGB4kzt UZi8Gnx36G2zW77TQLDjZWXePzdB4jtMpOEcdFWPQLY2oE8QohNj5Cp1evw+wAwuWznb A5p/hgSkFu9JHkzBiAajJZkC+vvNt6rIrFLHw+cC2gkQHe1BwkM/gePsH2dc3faQ+jF2 Fju/vf8ndRXuizaXH3JILA4TxX3DRUi/JWNBG56waUmAg/VEDWs7G9HsU4+2v72FgMpw 0dow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=mVjl00t/5PRl7rdzPZTRVIHSfHgvjG9V8ro5Mngvq30=; b=qJZZx1yuWB4MEm3HAO4cMaOydFbTznOLoZqGQ+N2Eh6cpk8lHxdxp6gqRGiuaqZttk n8JCOLWz1h8DdHBj9aN38wWQ6h1PzDgvlnJI2fCQZ5LKSbg3taRgNrSqTmyzcH4PVVzx HNVM1OgZussQ2jTyx2+egHvUhlJnv3O666ivrcG9C49/dsywC+dYIMLREQP/Bkbkr74r cFbGO2wjm2BB9oJtDRohzG4tKz5TTqxz4+l2PWaCjXUfeN+Zwes0zCQu31+p9Yd61vkp PHTL7FmJQy9i+xbY7ZCToPNPWeZA4sB7XsEPyhAPq5XqKO2H8Cz++7ra5Tteb3bCB72l UbCA== X-Gm-Message-State: APjAAAUtg64hPVnyChl3kA61SSNmaiJ0qdBedYVU+IDKLIcfpHaBmUok w4tgI/elqER9JVcESDjxVHcx5eXf X-Google-Smtp-Source: APXvYqw/YMpUwkXMmay/SAe7ZQY9gDhbANkE78mPWBA9ktvZwrP59GDGUdNQLob74U69zxVok92IMQ== X-Received: by 2002:a1c:4d01:: with SMTP id o1mr53268286wmh.55.1563607677299; Sat, 20 Jul 2019 00:27:57 -0700 (PDT) Received: from [172.20.10.14] ([37.164.90.204]) by smtp.gmail.com with ESMTPSA id n9sm61690999wrp.54.2019.07.20.00.27.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Jul 2019 00:27:56 -0700 (PDT) From: Akim Demaille Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [PATCH] maint: fix issues in syntax-check Message-Id: <45498A40-5C0F-46D0-9A36-8B33BD3CC3E4@gmail.com> Date: Sat, 20 Jul 2019 09:27:54 +0200 To: bug-coreutils@gnu.org X-Mailer: Apple Mail (2.3445.104.11) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi! I was trying to reproduce some error in gnulib's syntax-check, and faced = a few issues. My builddirs are in a separate tree, with symlinks from the src tree to = them. So running git from builddir will never work. There are other errors, that I was not addressed. error_quotes env.c:337: " error at: %s"), str); ls.c:2780: _("error canonicalizing %s"), name); ls.c:3199: _("error canonicalizing %s"), = full_name); maint.mk: Use quote() for error string arguments Cheers! =46rom dd4e813ab7ee3a8d9d27ca8f5eb874f991fff9b8 Mon Sep 17 00:00:00 2001 From: Akim Demaille Date: Sat, 20 Jul 2019 09:04:00 +0200 Subject: [PATCH] maint: fix issues in syntax-check * cfg.mk (sc_prohibit_colon_redirection): Don't expect `|` to denote the pipe character in git grep. (sc_tests_executable) (sc_case_insensitive_file_names) (sc_some_programs_must_avoid_exit_failure) (sc_prohibit_test_background_without_cleanup_) (sc_prohibit_test_calls_print_ver_with_irrelevant_argument) (sc_prohibit_test_ulimit_without_require_) (sc_prohibit_test_background_without_cleanup_) (sc_THANKS_in_duplicates) *sc_prohibit_test_calls_print_ver_with_irrelevant_argument): Don't expect builddir to be a descendant of srcdir. (sc_strftime_check): Don't check file size against 0 when "N\nq\n" was already put in the file. * THANKS.in: Remove me. --- THANKS.in | 1 - cfg.mk | 39 ++++++++++++++++++++++----------------- 2 files changed, 22 insertions(+), 18 deletions(-) diff --git a/THANKS.in b/THANKS.in index 02b8ada1c..23b089754 100644 --- a/THANKS.in +++ b/THANKS.in @@ -25,7 +25,6 @@ Adam Klein aklein@debian.org Adam Sampson ats@offog.org Adrian Bunk bunk@stusta.de AIDA Shinra shinra@j10n.org -Akim Demaille demaille@inf.enst.fr Alain Magloire alain@qnx.com Alan Iwi iwi@atm.ox.ac.uk Alan Jenkins alan-jenkins@tuffmail.co.uk diff --git a/cfg.mk b/cfg.mk index b0b758dd5..b589b40e3 100644 --- a/cfg.mk +++ b/cfg.mk @@ -121,6 +121,7 @@ sc_tests_list_consistency: # Ensure that all version-controlled test scripts are executable. sc_tests_executable: @set -o noglob 2>/dev/null || set -f; = \ + cd $(srcdir); = \ find_ext=3D"-name '' "`printf -- "-o -name *%s " = $(TEST_EXTENSIONS)`;\ find $(srcdir)/tests/ \( $$find_ext \) \! -perm -u+x -print = \ | { sed "s|^$(srcdir)/||"; git ls-files $(srcdir)/tests/; } = \ @@ -138,8 +139,8 @@ sc_ensure_gl_diffs_apply_cleanly: =20 # Avoid :>file which doesn't propagate errors sc_prohibit_colon_redirection: - @cd $(srcdir)/tests && GIT_PAGER=3D git grep -n ': *>.*||' \ - && { echo '$(ME): '"The leading colon in :> will hide errors" = 1>&2; \ + @cd $(srcdir)/tests && GIT_PAGER=3D git grep -En ': *>.*\|\|' = \ + && { echo '$(ME): '"The leading colon in :> will hide errors" = >&2; \ exit 1; } \ || : =20 @@ -407,7 +408,7 @@ check-programs-vs-x: =20 # Ensure we can check out on case insensitive file systems sc_case_insensitive_file_names: src/uniq - @git ls-files | sort -f | src/uniq -Di | grep . && \ + @git -C $(srcdir) ls-files | sort -f | src/uniq -Di | grep . && = \ { echo "$(ME): the above file(s) conflict on case insensitive" = \ " file systems" 1>&2; exit 1; } || : =20 @@ -445,20 +446,22 @@ sc_prohibit_stat_macro_address: # Ensure that date's --help output stays in sync with the info # documentation for GNU strftime. The only exception is %N and %q, # which date accepts but GNU strftime does not. +# +# "info foo" fails with error, but not "info foo >/dev/null". extract_char =3D sed 's/^[^%][^%]*%\(.\).*/\1/' sc_strftime_check: @if test -f $(srcdir)/src/date.c; then = \ - grep '^ %. ' $(srcdir)/src/date.c | sort = \ - | $(extract_char) > $@-src; = \ - { echo N; echo q; = \ - info libc date calendar format 2>/dev/null = \ - | grep "^ *['\`]%.'$$"| $(extract_char); }| sort = >$@-info;\ - if test $$(stat --format %s $@-info) !=3D 2; then = \ + if info libc date calendar format 2>/dev/null | = \ + grep "^ *['\`]%.'$$" >$@-tmp; then = \ + { echo N; echo q; $(extract_char) $@-tmp; }| sort = \ + >$@-info; = \ + grep '^ %. ' $(srcdir)/src/date.c | sort = \ + | $(extract_char) > $@-src; = \ diff -u $@-src $@-info || exit 1; = \ else = \ echo '$(ME): skipping $@: libc info not installed' 1>&2; = \ fi; = \ - rm -f $@-src $@-info; = \ + rm -f $@-info $@-src $@-tmp; = \ fi =20 # Indent only with spaces. @@ -608,7 +611,8 @@ sc_prohibit_expr_unsigned: # Others, use the EXIT_CANCELED, EXIT_ENOENT, etc. macros defined in = system.h. # In those programs, ensure that EXIT_FAILURE is not used by mistake. sc_some_programs_must_avoid_exit_failure: - @grep -nw EXIT_FAILURE = \ + @cd $(srcdir) = \ + && grep -nw EXIT_FAILURE = \ $$(git grep -El '[^T]_FAILURE|EXIT_CANCELED' $(srcdir)/src) = \ | grep -vE '=3D EXIT_FAILURE|return .* \?' | grep . = \ && { echo '$(ME): do not use EXIT_FAILURE in the above' = \ @@ -616,22 +620,23 @@ sc_some_programs_must_avoid_exit_failure: =20 # Ensure that tests call the get_min_ulimit_v_ function if using ulimit = -v sc_prohibit_test_ulimit_without_require_: - @(git grep -l get_min_ulimit_v_ $(srcdir)/tests; = \ - git grep -l 'ulimit -v' $(srcdir)/tests) = \ + @(git -C $(srcdir) grep -l get_min_ulimit_v_ tests; = \ + git -C $(srcdir) grep -l 'ulimit -v' tests) = \ | sort | uniq -u | grep . && { echo "$(ME): the above = test(s)"\ " should match get_min_ulimit_v_ with ulimit -v" 1>&2; exit 1; = } || : =20 # Ensure that tests call the cleanup_ function if using background = processes sc_prohibit_test_background_without_cleanup_: - @(git grep -El '( &$$|&[^&]*=3D\$$!)' $(srcdir)/tests; = \ - git grep -l 'cleanup_()' $(srcdir)/tests | sed p) = \ + @(git -C $(srcdir) grep -El '( &$$|&[^&]*=3D\$$!)' tests; = \ + git -C $(srcdir) grep -l 'cleanup_()' tests | sed p) = \ | sort | uniq -u | grep . && { echo "$(ME): the above = test(s)"\ " should use cleanup_ for background processes" 1>&2; exit 1; = } || : =20 # Ensure that tests call the print_ver_ function for programs which are # actually used in that test. sc_prohibit_test_calls_print_ver_with_irrelevant_argument: - @git grep -w print_ver_ $(srcdir)/tests = \ + @cd $(srcdir) = \ + && git -C grep -w print_ver_ tests = \ | sed 's#:print_ver_##' = \ | { fail=3D0; = \ while read file name; do = \ @@ -743,7 +748,7 @@ sc_preprocessor_indentation: # someone who was initially listed only in THANKS.in later authors a = commit, # this rule detects that their pair may now be removed from THANKS.in. sc_THANKS_in_duplicates: - @{ git log --pretty=3Dformat:%aN | sort -u; = \ + @{ git -C $(srcdir) log --pretty=3Dformat:%aN | sort -u; = \ cut -b-36 $(srcdir)/THANKS.in = \ | sed '/^$$/,/^$$/!d;/^$$/d;s/ *$$//'; } = \ | sort | uniq -d | grep . = \ --=20 2.22.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 04 03:39:11 2019 Received: (at 36739) by debbugs.gnu.org; 4 Aug 2019 07:39:11 +0000 Received: from localhost ([127.0.0.1]:60372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huB6l-0002IW-Kv for submit@debbugs.gnu.org; Sun, 04 Aug 2019 03:39:11 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:54782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huB6j-0002IJ-Ev for 36739@debbugs.gnu.org; Sun, 04 Aug 2019 03:39:09 -0400 Received: by mail-wm1-f43.google.com with SMTP id p74so71879657wme.4 for <36739@debbugs.gnu.org>; Sun, 04 Aug 2019 00:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=ueC5VTlD9srXw3nIH9njJ76Dcn6bg+Ch492X/b41lbA=; b=b7XLcQKSZ/G5OuaZNJ+/Biri4adLlqsht00y46K95JrlbQg8BfrFSDzgDGHrBOuYNs REGvTwUKYXnsMGbI7S1lA/aVf/nD82LlppeqXqbviLTO/IrZ77TzjWstbS4mA7r5yLiT qhAs4pC1xtU8f+gRBDt/2KpNccuzV6ICtHrp70V0S6lMnwnEQOxsbEVGYqUI7Ai9h5S0 +KEQcVO2rbTebW3lbtqdsRlylXe8vdYUy5Z9IuSSC7VhwCPoCNtHJo7Qq9tfUm0kdSxR uzbFBRlAPgoWMi/BZ/24zlR45AJXgNjJ3mC1uBMiiZpCZx79KPAJSs9DKKwXgGfQ3MlC YHPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=ueC5VTlD9srXw3nIH9njJ76Dcn6bg+Ch492X/b41lbA=; b=TicbHGYI2sC2h7FHbHA5qd+LYnqHznHli5FLBtMDRW8b6WGaK2P5Y9i+EJZduhRD03 ddQ8AMQSOdJaGs5QqSjCoZEFoDxPgkCKcnBqKemh2amfXPZvLN2P0TfRFpdDOB0g/LqH T7yeEqoIxg5Y7BU69LooztO4dZn6J5Gl8xvyXYhSeQolpiq5WCZ0F69fVrVzG/W9kYOF Q2k52qss6P1kc6dt+UKJ3zj4/YUlhRKQstI1P0AJGIsk1v1QuFVuRtcdUABH5WDnJQP/ 4XnGzSx96HXNxXH+3G61TsbEZ0wMhEfXYPwKRdpwBTF6M4anXsM4RdDI9Fu7swXhGZVC zUyw== X-Gm-Message-State: APjAAAW7LuDg57anVvTdHG+Yf0xdPVA3GxWiUOYYxr+bRZ/JyTiOp+/P LfcD7J4AfvcXOv7lBNrE//EvqwAN X-Google-Smtp-Source: APXvYqyL2ZxzfjgBnjZg5BqEbQXTGdKbDWHgotr/OAvhXQ/csNbc5wVZbo9pkDvAjmcG0GceF+AgbQ== X-Received: by 2002:a1c:9c8a:: with SMTP id f132mr12726577wme.29.1564904343001; Sun, 04 Aug 2019 00:39:03 -0700 (PDT) Received: from ?IPv6:2a01:e35:2fd9:96a0:c9aa:b048:ba3d:6362? ([2a01:e35:2fd9:96a0:c9aa:b048:ba3d:6362]) by smtp.gmail.com with ESMTPSA id j33sm181402480wre.42.2019.08.04.00.39.02 for <36739@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Aug 2019 00:39:02 -0700 (PDT) From: Akim Demaille Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: maint: fix issues in syntax-check Message-Id: Date: Sun, 4 Aug 2019 09:38:55 +0200 To: 36739@debbugs.gnu.org X-Mailer: Apple Mail (2.3445.104.11) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36739 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ping? From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 04 14:11:51 2019 Received: (at 36739-done) by debbugs.gnu.org; 4 Aug 2019 18:11:51 +0000 Received: from localhost ([127.0.0.1]:34222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huKz0-0003eO-MB for submit@debbugs.gnu.org; Sun, 04 Aug 2019 14:11:50 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huKyy-0003eB-Eh for 36739-done@debbugs.gnu.org; Sun, 04 Aug 2019 14:11:49 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7F92F162639; Sun, 4 Aug 2019 11:11:42 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0hUb4dfz52Ht; Sun, 4 Aug 2019 11:11:41 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id DB4CA1626A7; Sun, 4 Aug 2019 11:11:41 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id oyAa1elmWqiu; Sun, 4 Aug 2019 11:11:41 -0700 (PDT) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B74BD162639; Sun, 4 Aug 2019 11:11:41 -0700 (PDT) Subject: Re: bug#36739: maint: fix issues in syntax-check To: Akim Demaille , 36739-done@debbugs.gnu.org References: <45498A40-5C0F-46D0-9A36-8B33BD3CC3E4@gmail.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Sun, 4 Aug 2019 11:11:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36739-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thanks, I installed that. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 06 16:28:55 2019 Received: (at 36739) by debbugs.gnu.org; 6 Aug 2019 20:28:55 +0000 Received: from localhost ([127.0.0.1]:37860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hv64l-0005Vy-2I for submit@debbugs.gnu.org; Tue, 06 Aug 2019 16:28:55 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:56391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hv64i-0005Vk-Rd for 36739@debbugs.gnu.org; Tue, 06 Aug 2019 16:28:53 -0400 Received: from [192.168.101.10] ([93.218.111.19]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MTRAS-1hl6gs18cW-00TlXb; Tue, 06 Aug 2019 22:28:46 +0200 Subject: Re: bug#36739: [PATCH] maint: fix issues in syntax-check To: Akim Demaille , 36739@debbugs.gnu.org References: <45498A40-5C0F-46D0-9A36-8B33BD3CC3E4@gmail.com> From: Bernhard Voelker Openpgp: preference=signencrypt Autocrypt: addr=mail@bernhard-voelker.de; prefer-encrypt=mutual; keydata= mQENBFPirzMBCACyzYldTjQ4ufFOkByY5Nn5USb5GFoL48nWBwNHjd9KUbtRRNlQiPNKd6hK Gvd3BGi5aoFKA4ytfRk6jbAbW3jVb3R8wYaV08mOy4KVEKxqN4bxsXlMjNChXVR+rtKDmfI+ oPTL+cPH2X6gW4W02IRbVw0uUhNm6zEedC/gNrY/mTlf1enZ46jxZ7BTUZaG+kx38UMISIMB zSzLRtdkwgmHj4jS3p1fF2cwRqLclIfMjKGpbNFPEXeXKWrCLcqHw78795eAR9q0YvrDkfIn GdDBwfb3VM4NdulwIFzvYZMSXvSbbyPLB5YkHU5aAWQHUse4WlfT5ccDpbzUYldRAvF9ABEB AAG0K0Jlcm5oYXJkIFZvZWxrZXIgPG1haWxAYmVybmhhcmQtdm9lbGtlci5kZT6JATkEEwEC ACMFAlPirzMCGwMHCwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRBGUC73lpFxle5wCACC dbs0QaJ0vR3Sff2cKdTk41rUq3YfWngsR///IOU0C5DdkePmCnJE/lUsUy0LRTxcUDLxQR+x QHU8ssRT0JUO9726dI3miy36UdsgmBYaOtLvQcidGmW1R7o0PYYf04+TFtyqKgngOUBPpMgR 6o4UsQxy/OD4bN1WDqOgIjL+D/qJpkKmgp6L6+hhaBCpiOFKRmmV7YyQ3SqVlfQNiHs5ZtkR nXpIjgZARV+GllKucI17bO0CGmTJZ1tstVy0+W3DQT1lbBkTTc++5LONM99D3jjn23l1ocOp folR53F7I4cb2RNfT23v1I59RH37lB9wMOqrKj0UjYAC2YoPGQ3BuQENBFPirzMBCADXLWWp QihBldY6reca8ZKdc3T9qXEOa3akE3DWKztIBmNJhtYOjmpLYajQTkGa7UoJTnbmZE2Rn6ZE oNnvb0gcFNAIcY95KOI+bjOR8HEgh4cx2REXh6L6olIgyXqt/KFusE4wtVZAFxZl+30HzN6n D+1HvrjXxPJRX6MsIYOYyyX9/6OofwJK6QHODYGp8WL2olHDnmsXg4AT6Wlr7qKpKrQELlcF R4xkvdmgL/Ghw/tK0yJTxMIcewCCZWLPOXRmFRbvAadZWPAgVsJ63siNyUlVnVMSzDgTJl+s l/DMabXpqrJQx3/1Yy6mTaDs3XZT/wmBKaTLXx/LByaPxQQ7ABEBAAGJAR8EGAECAAkFAlPi rzMCGwwACgkQRlAu95aRcZWVPwgAqZT6iTXkoP37wYb41323RzhBcJ8JSk4cyBDBUXX0lMrM 3qhiClKG7phpxVdu817Gwc6Hsecg7FfjQAV8MHQ0ZFeEFdk3b2rKBqfsStc+h49/xF3Fb+if CzR9qeQF82fMSxkg18++7hMcHCMO/hPZ/Q0xRi+lrSr2QKDJQuLzSyVU14TxrCkevZjEhtma VNvcJlJzCbiBXee9Fpc5jITUXPFG8E8dxqo1n+duOyIMgozrAnzP7X5V/Ob/Ozf/aGGX9+Jd inyfCX18nWcHALKMU/36Eua/ylalf/2c2YkBp9KCLVmGgPkUgW52EeRPgroIsiwu+rwCSV6Z UyCJ+OymCg== Message-ID: Date: Tue, 6 Aug 2019 22:28:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <45498A40-5C0F-46D0-9A36-8B33BD3CC3E4@gmail.com> Content-Type: multipart/mixed; boundary="------------54EFD0C6BA263F48823416A3" Content-Language: en-US X-Provags-ID: V03:K1:JhzKiFW/OHvWooJSqMteZXMJcsWhwBl3I3kKzoY05ukwZcFSkf5 NLncsZXseW2qxsSJHOWllkpSntRVgJYNEUjS34+22UT7RFWixLrKf4zxXpml4mRzb2i4dHV 7Y1ymPgpOlejYbdaQp1ZQuvEnRA9EIxQzrawRd2BDmjpTDa4iDkEFgItl2dba93osoEMBq8 oW5zjDQahaAe3bJkZW0YQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:N1pJmsBs72o=:0tuBT0f7q7azJHOmsOh97l +YdhprkJ9cyBvwMrHLGqaOn9u1913yQhbHpshcNnx2560zOZj5BZxgRnpAQ2EGFbEOKzCx0dt wFLp2uIbHoEpxyBzxJY6S+m9FN+k2tsEfLlzuTVjXbFXSTerQWEtkwq0hEmq6wK19eiUUO+Qj FlicNJ3psTbctZCjy8KynAlrtMeRvtbOTkINtMsZmIQf+ufgHwz66o3E9CcmWLMeQI4h7wdVA mnYAvpj/ct7HiJGTBC6XlYLhzM1ac0hyg/rIAGqZjyx1giZHk4iC8tZuT4c26xCkJG4VUZZHg nPq1C+ySKAMNiyiUAZc7BMIta/R7mjZNcTJbdRYbGC1ctkBwky/vmXsnIiU2rKwhslJ0g9EeV BjuFU+UCLmGHHZGL4dd+QkgjdAPl4ozNgQAThT9Bq/W/KFWz8FXfQq5vfEuTqnpspXSvnxyFl CLWXh74JFsUAYJ33BHYG7QSgG5vXfJuY7a4BryFTa61RyXn/xDs9qM/N0L59jn+Q3SZHe3YWC AuRkQ17dXU2mgvAqDJrItuLMi3bjKc5bzCoWrQTD3M6TnxStyyb3nr8Y/zSqBfKNrxpZeU1q9 kckmn6lpyi2GWAo7NdoVmOxLQVpGbIw1DdqfGJQ2hS/RZ6khuw5Yu2P8atnJnQcbQM70lgE05 +4iqKLWZ1pmpo+hekzWgfRKschskcWEARsMRPiKFlgc9BqW+mg1YhSVT+HEqmnC3nOklnp80y VgyNuKtojV+3xgsTzqZouQErIeWzn6jys4GPjlgie4XkFxxWiOarLh82Kds= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 36739 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------54EFD0C6BA263F48823416A3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 7/20/19 9:27 AM, Akim Demaille wrote: > # Ensure that tests call the print_ver_ function for programs which are > # actually used in that test. > sc_prohibit_test_calls_print_ver_with_irrelevant_argument: > - @git grep -w print_ver_ $(srcdir)/tests \ > + @cd $(srcdir) \ > + && git -C grep -w print_ver_ tests \ > | sed 's#:print_ver_##' \ > | { fail=0; \ > while read file name; do \ 'git -C' is lacking the SRCDIR argument. The attached fixes it. Have a nice day, Berny --------------54EFD0C6BA263F48823416A3 Content-Type: text/x-patch; name="0001-maint-fix-error-in-syntax-check-checking.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-maint-fix-error-in-syntax-check-checking.patch" >From 4f4475f2ffad417e021d08fbf4a742bda48b10ee Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Tue, 6 Aug 2019 22:23:36 +0200 Subject: [PATCH] maint: fix error in syntax-check checking The previous commit introduced a bug into the following syntax-check, and thus effectively turned it off: $ make sc_prohibit_test_calls_print_ver_with_irrelevant_argument; \ echo $? prohibit_test_calls_print_ver_with_irrelevant_argument fatal: cannot change to 'grep': No such file or directory 0 * cfg.mk (sc_prohibit_test_calls_print_ver_with_irrelevant_argument): Remove changing directory, and pass $(srcdir) as argument to 'git -C'. --- cfg.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cfg.mk b/cfg.mk index b589b40e3..2bc933c8b 100644 --- a/cfg.mk +++ b/cfg.mk @@ -635,8 +635,7 @@ sc_prohibit_test_background_without_cleanup_: # Ensure that tests call the print_ver_ function for programs which are # actually used in that test. sc_prohibit_test_calls_print_ver_with_irrelevant_argument: - @cd $(srcdir) \ - && git -C grep -w print_ver_ tests \ + @git -C $(srcdir) grep -w print_ver_ tests \ | sed 's#:print_ver_##' \ | { fail=0; \ while read file name; do \ -- 2.22.0 --------------54EFD0C6BA263F48823416A3-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 06 19:11:32 2019 Received: (at 36739) by debbugs.gnu.org; 6 Aug 2019 23:11:32 +0000 Received: from localhost ([127.0.0.1]:37963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hv8c7-0001q6-75 for submit@debbugs.gnu.org; Tue, 06 Aug 2019 19:11:32 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hv8c4-0001pp-E0 for 36739@debbugs.gnu.org; Tue, 06 Aug 2019 19:11:29 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 91D5E16270E; Tue, 6 Aug 2019 16:11:22 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id keTTi_7mGSub; Tue, 6 Aug 2019 16:11:22 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F03EF1626EF; Tue, 6 Aug 2019 16:11:21 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Q86nvYYu9uEf; Tue, 6 Aug 2019 16:11:21 -0700 (PDT) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C54CF16270E; Tue, 6 Aug 2019 16:11:21 -0700 (PDT) Subject: Re: bug#36739: [PATCH] maint: fix issues in syntax-check To: Bernhard Voelker , Akim Demaille , 36739@debbugs.gnu.org References: <45498A40-5C0F-46D0-9A36-8B33BD3CC3E4@gmail.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <0198b11a-aa19-f6d9-e378-9961bc1edb4d@cs.ucla.edu> Date: Tue, 6 Aug 2019 16:11:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36739 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thanks, I installed that. From unknown Wed Jun 18 22:49:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Sep 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator